mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

Fix https://github.com/flutter/flutter/issues/160270 Fix the NavigationRail examples overflow alignment by replacing it with the SegmentedButton widget. ### Before Example 1: <img src="https://github.com/user-attachments/assets/b9f54cd2-b2d1-44ee-a159-f1f04ed011e2" alt="NavigationRail Example 1 - Before" height="450"> Example: 2: <img src="https://github.com/user-attachments/assets/be78bee7-f03d-40ff-ae36-679416c9c3d2" alt="NavigationRail Example 2 - Before" height="450"> ### After Example 1: <img src="https://github.com/user-attachments/assets/c6a3f060-dc9a-44d3-9ab3-3eea5f6183d6" alt="NavigationRail Example 1 - After" height="450"> Example 2: <img src="https://github.com/user-attachments/assets/6b35753b-e2ab-4053-8dd7-d983531b2c74" alt="NavigationRail Example 2 - After" height="450"> ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Taha Tesser <tessertaha@gmail.com>
103 lines
3.8 KiB
Dart
103 lines
3.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_api_samples/material/navigation_rail/navigation_rail.0.dart' as example;
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
testWidgets('NavigationRail updates destination on tap', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const example.NavigationRailExampleApp());
|
|
final NavigationRail navigationRailWidget = tester.firstWidget(find.byType(NavigationRail));
|
|
|
|
/// NavigationRailDestinations must be rendered
|
|
expect(find.text('First'), findsOneWidget);
|
|
expect(find.text('Second'), findsOneWidget);
|
|
expect(find.text('Third'), findsOneWidget);
|
|
|
|
/// initial index must be zero
|
|
expect(navigationRailWidget.selectedIndex, 0);
|
|
|
|
/// switch to second tab
|
|
await tester.tap(find.text('Second'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('selectedIndex: 1'), findsOneWidget);
|
|
|
|
/// switch to third tab
|
|
await tester.tap(find.text('Third'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('selectedIndex: 2'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('NavigationRail updates label type', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const example.NavigationRailExampleApp());
|
|
|
|
// initial label type set to all.
|
|
expect(find.text('Label type: all'), findsOneWidget);
|
|
|
|
// switch to selected label type
|
|
await tester.tap(find.text('Selected'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Label type: selected'), findsOneWidget);
|
|
|
|
// switch to none label type
|
|
await tester.tap(find.text('None'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Label type: none'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('Navigation rail updates group alignment', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const example.NavigationRailExampleApp());
|
|
|
|
// initial group alignment set top top.
|
|
expect(find.text('Group alignment: -1.0'), findsOneWidget);
|
|
|
|
// switch to center alignment
|
|
await tester.tap(find.text('Center'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Group alignment: 0.0'), findsOneWidget);
|
|
|
|
// switch to bottom alignment
|
|
await tester.tap(find.text('Bottom'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Group alignment: 1.0'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('NavigationRail shows leading/trailing widgets', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const example.NavigationRailExampleApp());
|
|
|
|
// Initially leading/trailing widgets are hidden.
|
|
expect(find.byType(FloatingActionButton), findsNothing);
|
|
expect(find.byType(IconButton), findsNothing);
|
|
|
|
// Tap to show leading Widget.
|
|
await tester.tap(find.text('Show Leading'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.byType(FloatingActionButton), findsOneWidget);
|
|
expect(find.byType(IconButton), findsNothing);
|
|
|
|
// Tap to show trailing Widget.
|
|
await tester.tap(find.text('Show Trailing'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.byType(FloatingActionButton), findsOneWidget);
|
|
expect(find.byType(IconButton), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('Destinations have badge', (WidgetTester tester) async {
|
|
await tester.pumpWidget(const example.NavigationRailExampleApp());
|
|
|
|
// Test badge without label.
|
|
final Badge notificationBadge = tester.firstWidget(
|
|
find.ancestor(of: find.byIcon(Icons.bookmark_border), matching: find.byType(Badge)),
|
|
);
|
|
expect(notificationBadge.label, null);
|
|
|
|
// Test badge with label.
|
|
final Badge messagesBadge = tester.firstWidget(
|
|
find.ancestor(of: find.byIcon(Icons.star_border), matching: find.byType(Badge)),
|
|
);
|
|
expect(messagesBadge.label, isNotNull);
|
|
});
|
|
}
|