mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
9d7d36cfba
Fixes [Compact Visual Density is wrongfully applied to Checkboxes with `MaterialTapTargetSize.padded` on desktop platforms according to Material 3 Guidelines](https://github.com/flutter/flutter/issues/156408) ### Description This PR updates default `Checkbox` visual density to not depend on `ThemeData.visualDenSity` as it will return `VisualDensity.compact` on desktop and break Material 3 guidelines for `Checkbox`. > [!NOTE] > This makes a similar fix as https://github.com/flutter/flutter/pull/110722. ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold( body: Center( child: Row( mainAxisAlignment: MainAxisAlignment.center, children: [ ColoredBox( color: Colors.amber, child: Checkbox( materialTapTargetSize: MaterialTapTargetSize.padded, value: true, onChanged: (bool? value) {}, ), ), Container( width: 48, height: 48, color: Colors.red, alignment: Alignment.center, child: const Text( '48x48px', style: TextStyle(fontSize: 10, color: Colors.white), ), ) ], ), ), ), ); } } ``` </details> <img width="577" alt="Screenshot 2024-11-18 at 18 02 01" src="https://github.com/user-attachments/assets/d390c92f-dd62-4c42-b6b7-d4f101078618"> <img width="577" alt="Screenshot 2024-11-18 at 18 01 49" src="https://github.com/user-attachments/assets/632e8d19-11bf-45c7-9be9-5c4fc308f3ea"> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md |
||
|---|---|---|
| .. | ||
| action_chip_template.dart | ||
| app_bar_template.dart | ||
| badge_template.dart | ||
| banner_template.dart | ||
| bottom_app_bar_template.dart | ||
| bottom_sheet_template.dart | ||
| button_template.dart | ||
| card_template.dart | ||
| checkbox_template.dart | ||
| chip_template.dart | ||
| color_scheme_template.dart | ||
| date_picker_template.dart | ||
| dialog_template.dart | ||
| divider_template.dart | ||
| drawer_template.dart | ||
| expansion_tile_template.dart | ||
| fab_template.dart | ||
| filter_chip_template.dart | ||
| icon_button_template.dart | ||
| input_chip_template.dart | ||
| input_decorator_template.dart | ||
| list_tile_template.dart | ||
| menu_template.dart | ||
| motion_template.dart | ||
| navigation_bar_template.dart | ||
| navigation_drawer_template.dart | ||
| navigation_rail_template.dart | ||
| popup_menu_template.dart | ||
| progress_indicator_template.dart | ||
| radio_template.dart | ||
| search_bar_template.dart | ||
| search_view_template.dart | ||
| segmented_button_template.dart | ||
| slider_template.dart | ||
| snackbar_template.dart | ||
| surface_tint.dart | ||
| switch_template.dart | ||
| tabs_template.dart | ||
| template.dart | ||
| text_field_template.dart | ||
| time_picker_template.dart | ||
| token_logger.dart | ||
| typography_template.dart | ||