mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
4372bfbc6c
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169451
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke a number of post-submit tests
(ios_app_extension, packages_autoroller).
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mosuem
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Reland after #169357.
Switch Flutter to use pub workspaces as a preparation to unpin selected
packages.
Assumptions:
1. No packages in this repository are published to pub.dev --> We can
use `any` dependencies in most local pubspecs, as the global constraint
defines the version. An exception are the packages used outside of this
repo with an `sdk` dependency, namely `flutter_localizations`,
`flutter_test`, and `flutter`.
2. The "universes" `{flutter_tools}` and `{flutter,
flutter_localizations, flutter_goldens}` can use different packages
versions, as they are not resolved together. --> We do not need to
upgrade them in sync, we can first do one "universe", then the other.
Based on these assumptions, we use
https://github.com/mosuem/pubspec_merger.dart to merge all packages in
the `flutter` universe into a top-level pub workspace.
The `flutter` and `flutter_tools` workspaces being separate also ensures
that changes to `flutter` will not inadvertently break `flutter_tools`,
with not-so-nice consequences for our users which would be unable to run
`flutter upgrade`.
There is a third "top-level" pubspec besides `./pubspec.yaml` and
`packages/flutter_tools/pubspec.yaml`, namely
`packages/flutter_tools/.../widget_preview_scaffold/pubspec.yaml`. This
is an artifact due to it living under `flutter_tools`, so it can't be
part of the `./pubspec.yaml` workspace. Moving it would be a larger
change, and out of the scope of this PR.
This required a rewrite of the update-packages tool, but the main
functionality stays the same, as well as the argument names, to ensure a
seamless transition.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
|
||
|---|---|---|
| .. | ||
| debug_adapter | ||
| isolated | ||
| test_data | ||
| analyze_all_templates_test.dart | ||
| analyze_once_test.dart | ||
| analyze_size_test.dart | ||
| analyze_suggestions_integration_test.dart | ||
| android_e2e_api_test.dart | ||
| android_gradle_daemon_cache_test.dart | ||
| android_gradle_flutter_source_path_test.dart | ||
| android_gradle_java_version_test.dart | ||
| android_gradle_legacy_flutter_plugins_strings_in_comments_test.dart | ||
| android_gradle_outputs_app_link_settings_test.dart | ||
| android_gradle_print_build_variants_test.dart | ||
| android_plugin_compilesdkversion_mismatch_test.dart | ||
| android_plugin_example_app_build_test.dart | ||
| android_plugin_ndkversion_mismatch_test.dart | ||
| android_plugin_new_output_dir_test.dart | ||
| android_run_flutter_gradle_plugin_tests_test.dart | ||
| asset_transformation_test.dart | ||
| background_isolate_test.dart | ||
| bash_entrypoint_test.dart | ||
| batch_entrypoint_test.dart | ||
| break_on_framework_exceptions_test.dart | ||
| build_ios_config_only_test.dart | ||
| build_macos_config_only_test.dart | ||
| cache_test.dart | ||
| command_output_test.dart | ||
| coverage_collection_test.dart | ||
| daemon_mode_test.dart | ||
| debugger_stepping_test.dart | ||
| deferred_components_test.dart | ||
| devtools_uri_test.dart | ||
| downgrade_upgrade_integration_test.dart | ||
| driver_environment_test.dart | ||
| exit_code_test.dart | ||
| expression_evaluation_test.dart | ||
| flutter_attach_test.dart | ||
| flutter_build_android_app_project_builddir_test.dart | ||
| flutter_build_apk_verbose_test.dart | ||
| flutter_build_config_only_test.dart | ||
| flutter_build_wasm_test.dart | ||
| flutter_build_windows_test.dart | ||
| flutter_build_with_compilation_error_test.dart | ||
| flutter_plugins_dependencies_test.dart | ||
| flutter_run_test.dart | ||
| flutter_run_with_error_test.dart | ||
| forbidden_imports_test.dart | ||
| gen_l10n_test.dart | ||
| gradle_non_android_plugin_test.dart | ||
| hot_reload_errors_test.dart | ||
| hot_reload_test.dart | ||
| hot_reload_with_asset_test.dart | ||
| hot_restart_with_unhandled_exception_test.dart | ||
| lifetime_test.dart | ||
| lldb_init_test.dart | ||
| macos_assemble_test.dart | ||
| observatory_port_test.dart | ||
| overall_experience_test.dart | ||
| plist_parser_test.dart | ||
| README.md | ||
| shader_compiler_test.dart | ||
| stateless_stateful_hot_reload_test.dart | ||
| swift_package_manager_create_app_test.dart | ||
| swift_package_manager_create_plugin_test.dart | ||
| swift_package_manager_test.dart | ||
| swift_package_manager_utils.dart | ||
| template_manifest_test.dart | ||
| test_driver.dart | ||
| test_test.dart | ||
| test_utils.dart | ||
| timeline_test.dart | ||
| tool_backend_test.dart | ||
| transition_test_utils.dart | ||
| unit_coverage_test.dart | ||
| variable_expansion_windows_test.dart | ||
| variable_expansion_windows.dart | ||
| vmservice_integration_test.dart | ||
| web_plugin_registrant_test.dart | ||
| widget_preview_test.dart | ||
| xcode_backend_test.dart | ||
| xcode_dev_dependencies_test.dart | ||
Integration tests
These tests are not hermetic, and use the actual Flutter SDK. While
they don't require actual devices, they run flutter_tester to test
Dart VM and Flutter integration.
Use this command to run (from the flutter_tools directory):
../../bin/cache/dart-sdk/bin/dart run test test/integration.shard
You need to have downloaded the Dart SDK in your Flutter clone for this
to work. Running ../../bin/flutter will automatically download it.
Coverage exclusion
These tests are expensive to run and do not give meaningful coverage
information for the flutter tool (since they are black-box tests that
run the tool as a subprocess, rather than being unit tests). For this
reason, they are in a separate shard when running on continuous
integration and are not run when calculating coverage.
Adding new test files
When adding a new test file make sure that it ends with _test.dart, or else it will not be run.