mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

Enables the `comment_references` and `unintended_html_in_doc_comment` lints in `packages/flutter_tool`, then fixes each of the triggering cases. This PR is test exempt due to only affecting documentation comments. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
98 lines
2.8 KiB
Dart
98 lines
2.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:io';
|
|
|
|
import 'package:file/file.dart';
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/src/base/context.dart';
|
|
import 'package:flutter_tools/src/base/error_handling_io.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/process.dart';
|
|
import 'package:flutter_tools/src/globals.dart' as globals;
|
|
|
|
import '../src/common.dart';
|
|
import '../src/testbed.dart';
|
|
|
|
void main() {
|
|
group('Testbed', () {
|
|
test('Can provide default interfaces', () async {
|
|
final TestBed testbed = TestBed();
|
|
|
|
late FileSystem localFileSystem;
|
|
await testbed.run(() {
|
|
localFileSystem = globals.fs;
|
|
});
|
|
|
|
expect(localFileSystem, isA<ErrorHandlingFileSystem>());
|
|
expect((localFileSystem as ErrorHandlingFileSystem).fileSystem, isA<MemoryFileSystem>());
|
|
});
|
|
|
|
test('Can provide setup interfaces', () async {
|
|
final TestBed testbed = TestBed(overrides: <Type, Generator>{A: () => A()});
|
|
|
|
A? instance;
|
|
await testbed.run(() {
|
|
instance = context.get<A>();
|
|
});
|
|
|
|
expect(instance, isA<A>());
|
|
});
|
|
|
|
test('Can provide local overrides', () async {
|
|
final TestBed testbed = TestBed(overrides: <Type, Generator>{A: () => A()});
|
|
|
|
A? instance;
|
|
await testbed.run(() {
|
|
instance = context.get<A>();
|
|
}, overrides: <Type, Generator>{A: () => B()});
|
|
|
|
expect(instance, isA<B>());
|
|
});
|
|
|
|
test('provides a mocked http client', () async {
|
|
final TestBed testbed = TestBed();
|
|
await testbed.run(() async {
|
|
final HttpClient client = HttpClient();
|
|
final HttpClientRequest request = await client.getUrl(Uri.parse('http://foo.dev'));
|
|
final HttpClientResponse response = await request.close();
|
|
|
|
expect(response.statusCode, HttpStatus.ok);
|
|
expect(response.contentLength, 0);
|
|
});
|
|
});
|
|
|
|
test('Throws StateError if Timer is left pending', () async {
|
|
final TestBed testbed = TestBed();
|
|
|
|
expect(
|
|
testbed.run(() async {
|
|
Timer.periodic(const Duration(seconds: 1), (Timer timer) {});
|
|
}),
|
|
throwsStateError,
|
|
);
|
|
});
|
|
|
|
test("Doesn't throw a StateError if Timer is left cleaned up", () async {
|
|
final TestBed testbed = TestBed();
|
|
|
|
await testbed.run(() async {
|
|
final Timer timer = Timer.periodic(const Duration(seconds: 1), (Timer timer) {});
|
|
timer.cancel();
|
|
});
|
|
});
|
|
|
|
test('Throws if ProcessUtils is injected', () {
|
|
final TestBed testbed = TestBed(overrides: <Type, Generator>{ProcessUtils: () => null});
|
|
|
|
expect(() => testbed.run(() {}), throwsStateError);
|
|
});
|
|
});
|
|
}
|
|
|
|
class A {}
|
|
|
|
class B extends A {}
|