mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
53b87635b0
There's currently a lot of code that handles RPC Errors that contain the text "Service connection disposed" because the error originally did not have a unique error code. A new error code was added in https://dart-review.googlesource.com/c/sdk/+/381501 but it's not currently used because it won't be caught by existing code. This change updates all places that check for this text, and now also handle the new error code in preperation for the code changing in future. See https://github.com/flutter/flutter/issues/153471 cc @bkonyi ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. Issue listed, but this change does not directly fix it, it just prepares for a related future change that will simplify handling these errors without string checks - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. |
||
|---|---|---|
| .. | ||
| migration | ||
| adb_log_reader_test.dart | ||
| android_device_discovery_test.dart | ||
| android_device_port_forwarder_test.dart | ||
| android_device_start_test.dart | ||
| android_device_test.dart | ||
| android_emulator_test.dart | ||
| android_gradle_builder_test.dart | ||
| android_install_test.dart | ||
| android_project_migration_test.dart | ||
| android_sdk_test.dart | ||
| android_studio_test.dart | ||
| android_studio_validator_test.dart | ||
| android_workflow_test.dart | ||
| build_validation_test.dart | ||
| deferred_components_gen_snapshot_validator_test.dart | ||
| deferred_components_prebuild_validator_test.dart | ||
| gradle_errors_test.dart | ||
| gradle_find_bundle_test.dart | ||
| gradle_test.dart | ||
| gradle_utils_test.dart | ||
| java_test.dart | ||
| template_test.dart | ||