flutter/dev/tools/test/update_icons_test.dart
Pierre-Louis 0919fb86f1
Improve handling of certain icons in RTL (#130979)
Fixes https://github.com/flutter/flutter/issues/130978 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-07-21 19:07:39 +02:00

122 lines
3.2 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:test/test.dart';
import '../update_icons.dart';
Map<String, String> codepointsA = <String, String>{
'airplane': '111',
'boat': '222',
};
Map<String, String> codepointsB = <String, String>{
'airplane': '333',
};
Map<String, String> codepointsC = <String, String>{
'airplane': '111',
'train': '444',
};
Map<String, String> codepointsUnderscore = <String, String>{
'airplane__123': '111',
};
void main() {
group('safety checks', () {
test('superset', () {
expect(testIsSuperset(codepointsA, codepointsA), true);
expect(testIsSuperset(codepointsA, codepointsB), true);
expect(testIsSuperset(codepointsB, codepointsA), false);
});
test('stability', () {
expect(testIsStable(codepointsA, codepointsA), true);
expect(testIsStable(codepointsA, codepointsB), false);
expect(testIsStable(codepointsB, codepointsA), false);
expect(testIsStable(codepointsA, codepointsC), true);
expect(testIsStable(codepointsC, codepointsA), true);
});
});
test('no double underscores', () {
expect(Icon(codepointsUnderscore.entries.first), 'abc_123');
});
test('usage string is correct', () {
expect(
Icon(const MapEntry<String, String>('abc', '')).usage,
'Icon(Icons.abc),',
);
});
test('usage string is correct with replacement', () {
expect(
Icon(const MapEntry<String, String>('123', '')).usage,
'Icon(Icons.onetwothree),',
);
expect(
Icon(const MapEntry<String, String>('123_rounded', '')).usage,
'Icon(Icons.onetwothree_rounded),',
);
});
test('certain icons should be mirrored in RTL', () {
// Exact match
expect(
Icon(const MapEntry<String, String>('help', '')).isMirroredInRTL,
true,
);
// Variant
expect(
Icon(const MapEntry<String, String>('help_rounded', '')).isMirroredInRTL,
true,
);
// Common suffixes
expect(
Icon(const MapEntry<String, String>('help_alt', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_new', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_off', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_on', '')).isMirroredInRTL,
true,
);
// Common suffixes + variant
expect(
Icon(const MapEntry<String, String>('help_alt_rounded', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_new_rounded', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_off_rounded', '')).isMirroredInRTL,
true,
);
expect(
Icon(const MapEntry<String, String>('help_on_rounded', '')).isMirroredInRTL,
true,
);
// No match
expect(
Icon(const MapEntry<String, String>('help_center_rounded', '')).isMirroredInRTL,
false,
);
// No match
expect(
Icon(const MapEntry<String, String>('arrow', '')).isMirroredInRTL,
false,
);
});
}