mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

A test was failing silently because of this (see https://github.com/flutter/flutter/issues/144353 and fixed in https://github.com/flutter/flutter/pull/144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows: ``` 00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following assertion was thrown running a test (but after the test had completed): setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not mounted) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9) #1 State.setState (package:flutter/src/widgets/framework.dart:1202:6) #2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5) <asynchronous suspension> ════════════════════════════════════════════════════════════════════════════════════════════════════ 00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart 00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E] Test failed. See exception logs above. The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart This test failed after it had already completed. Make sure to use a matching library which informs the test runner of pending async work. ```
157 lines
5.2 KiB
Dart
157 lines
5.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io' hide Platform;
|
|
|
|
import 'package:file/file.dart' as fs;
|
|
import 'package:file/memory.dart';
|
|
import 'package:path/path.dart' as path;
|
|
import 'package:process/process.dart';
|
|
|
|
import '../test.dart';
|
|
import 'common.dart';
|
|
|
|
/// Fails a test if the exit code of `result` is not the expected value. This
|
|
/// is favored over `expect(result.exitCode, expectedExitCode)` because this
|
|
/// will include the process result's stdio in the failure message.
|
|
void expectExitCode(ProcessResult result, int expectedExitCode) {
|
|
if (result.exitCode != expectedExitCode) {
|
|
fail(
|
|
'Process ${result.pid} exited with the wrong exit code.\n'
|
|
'\n'
|
|
'EXPECTED: exit code $expectedExitCode\n'
|
|
'ACTUAL: exit code ${result.exitCode}\n'
|
|
'\n'
|
|
'STDOUT:\n'
|
|
'${result.stdout}\n'
|
|
'STDERR:\n'
|
|
'${result.stderr}'
|
|
);
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
group('verifyVersion()', () {
|
|
late MemoryFileSystem fileSystem;
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem.test();
|
|
});
|
|
|
|
test('passes for valid version strings', () async {
|
|
const List<String> valid_versions = <String>[
|
|
'1.2.3',
|
|
'12.34.56',
|
|
'1.2.3.pre.1',
|
|
'1.2.3-4.5.pre',
|
|
'1.2.3-5.0.pre.12',
|
|
];
|
|
for (final String version in valid_versions) {
|
|
final File file = fileSystem.file('version');
|
|
file.writeAsStringSync(version);
|
|
|
|
expect(
|
|
await verifyVersion(file),
|
|
isNull,
|
|
reason: '$version is valid but verifyVersionFile said it was bad',
|
|
);
|
|
}
|
|
});
|
|
|
|
test('fails for invalid version strings', () async {
|
|
const List<String> invalid_versions = <String>[
|
|
'1.2.3.4',
|
|
'1.2.3.',
|
|
'1.2.pre.1',
|
|
'1.2.3-pre.1',
|
|
'1.2.3-pre.1+hotfix.1',
|
|
' 1.2.3',
|
|
'1.2.3-hotfix.1',
|
|
];
|
|
for (final String version in invalid_versions) {
|
|
final File file = fileSystem.file('version');
|
|
file.writeAsStringSync(version);
|
|
|
|
expect(
|
|
await verifyVersion(file),
|
|
'The version logic generated an invalid version string: "$version".',
|
|
reason: '$version is invalid but verifyVersionFile said it was fine',
|
|
);
|
|
}
|
|
});
|
|
});
|
|
|
|
group('flutter/packages version', () {
|
|
final MemoryFileSystem memoryFileSystem = MemoryFileSystem();
|
|
final fs.File packagesVersionFile = memoryFileSystem.file(path.join('bin','internal','flutter_packages.version'));
|
|
const String kSampleHash = '592b5b27431689336fa4c721a099eedf787aeb56';
|
|
setUpAll(() {
|
|
packagesVersionFile.createSync(recursive: true);
|
|
});
|
|
|
|
test('commit hash', () async {
|
|
packagesVersionFile.writeAsStringSync(kSampleHash);
|
|
final String actualHash = await getFlutterPackagesVersion(fileSystem: memoryFileSystem, packagesVersionFile: packagesVersionFile.path);
|
|
expect(actualHash, kSampleHash);
|
|
});
|
|
|
|
test('commit hash with newlines', () async {
|
|
packagesVersionFile.writeAsStringSync('\n$kSampleHash\n');
|
|
final String actualHash = await getFlutterPackagesVersion(fileSystem: memoryFileSystem, packagesVersionFile: packagesVersionFile.path);
|
|
expect(actualHash, kSampleHash);
|
|
});
|
|
});
|
|
|
|
group('test.dart script', () {
|
|
const ProcessManager processManager = LocalProcessManager();
|
|
|
|
Future<ProcessResult> runScript([
|
|
Map<String, String>? environment,
|
|
List<String> otherArgs = const <String>[],
|
|
]) async {
|
|
final String dart = path.absolute(
|
|
path.join('..', '..', 'bin', 'cache', 'dart-sdk', 'bin', 'dart'),
|
|
);
|
|
final ProcessResult scriptProcess = processManager.runSync(<String>[
|
|
dart,
|
|
'test.dart',
|
|
...otherArgs,
|
|
], environment: environment);
|
|
return scriptProcess;
|
|
}
|
|
|
|
test('subshards tests correctly', () async {
|
|
// When updating this test, try to pick shard numbers that ensure we're checking
|
|
// that unequal test distributions don't miss tests.
|
|
ProcessResult result = await runScript(
|
|
<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': '1_3'},
|
|
);
|
|
expectExitCode(result, 0);
|
|
expect(result.stdout, contains('Selecting subshard 1 of 3 (tests 1-3 of 9)'));
|
|
|
|
result = await runScript(
|
|
<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': '3_3'},
|
|
);
|
|
expectExitCode(result, 0);
|
|
expect(result.stdout, contains('Selecting subshard 3 of 3 (tests 7-9 of 9)'));
|
|
});
|
|
|
|
test('exits with code 1 when SUBSHARD index greater than total', () async {
|
|
final ProcessResult result = await runScript(
|
|
<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': '100_99'},
|
|
);
|
|
expectExitCode(result, 1);
|
|
expect(result.stdout, contains('Invalid subshard name'));
|
|
});
|
|
|
|
test('exits with code 255 when invalid SUBSHARD name', () async {
|
|
final ProcessResult result = await runScript(
|
|
<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': 'invalid_name'},
|
|
);
|
|
expectExitCode(result, 255);
|
|
expect(result.stdout, contains('Invalid subshard name'));
|
|
});
|
|
});
|
|
}
|