github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
9689f7f89c
flutter/packages
History
Taha Tesser e34a9e3f39
Fix chips delete icon override the default icon size and ignores IconTheme from the chip property and ChipThemeData (#146509) 
fixes [Provided delete icon overrides the default delete icon size](https://github.com/flutter/flutter/issues/146404)
fixes [Chips delete icon ignores `IconTheme` from `Chip.iconTheme` and `ChipThemeData.iconTheme`](https://github.com/flutter/flutter/issues/146501)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        chipTheme: const ChipThemeData(
          iconTheme: IconThemeData(
            color: Colors.red,
          ),
        ),
      ),
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              FilterChip(
                avatar: const Icon(Icons.favorite),
                onDeleted: () {},
                label: const Text('Filter Chip'),
                onSelected: (value) {},
              ),
              const SizedBox(height: 10),
              FilterChip(
                avatar: const Icon(Icons.favorite),
                // ignore: prefer_const_constructors
                deleteIcon: const Icon(Icons.delete),
                onDeleted: () {},
                label: const Text('Filter Chip'),
                onSelected: (value) {},
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before
![Screenshot 2024-04-09 at 16 48 48](https://github.com/flutter/flutter/assets/48603081/79d14a63-3c24-4f3e-bda4-5de76b319160)

### After

![Screenshot 2024-04-09 at 16 48 31](https://github.com/flutter/flutter/assets/48603081/8d54373f-53f1-4908-bd9c-2ee351227f27)
2024-04-23 19:24:00 +00:00
..
flutter Fix chips delete icon override the default icon size and ignores IconTheme from the chip property and ChipThemeData (#146509) 2024-04-23 19:24:00 +00:00
flutter_driver Bump meta to 1.14.0 (#146925) 2024-04-17 15:25:51 -07:00
flutter_goldens Fixed few typos (#147087) 2024-04-22 16:49:19 +00:00
flutter_localizations Bump meta to 1.14.0 (#146925) 2024-04-17 15:25:51 -07:00
flutter_test Bump meta to 1.14.0 (#146925) 2024-04-17 15:25:51 -07:00
flutter_tools Update icon tree shaker to allow system font fallback (#147202) 2024-04-23 16:40:29 +00:00
flutter_web_plugins Bump meta to 1.14.0 (#146925) 2024-04-17 15:25:51 -07:00
fuchsia_remote_debug_protocol Bump meta to 1.14.0 (#146925) 2024-04-17 15:25:51 -07:00
integration_test Add Swift Package Manager as new opt-in feature for iOS and macOS (#146256) 2024-04-18 21:12:36 +00:00
analysis_options.yaml