mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

https://github.com/flutter/flutter/issues/123917 Doc covering a broad set of issues related to android studio updating. https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1# Specifically this pr: - Adds new functions to find a projects AGP, Gradle and java versions, and tests. - Adds new functions that take versions and parse if the versions are compatible with each other, and tests. - Adds validator for `flutter analyze --suggestions` that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test. - Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11) - Moves `isWithinVersionRange` to version.dart, and tests. - Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies. Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big. Known work still left in this pr: * Understand why analyze integration tests are failing. Example output if Java and gradle are not compatible: ``` ┌───────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information. │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └───────────────────────────────────────────────────────────────────┘ ``` Example output if Gradle and AGP are not compatible ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Example output if Java/Gradle/Agp are not compatible. ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Commit messages - Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation - Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation. - Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false - Fill out and test java gradle compatibility function in gradle_utils - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version - Add java --version output parsing and tests - Add getJavaBinary test - Update comment in android_sdk for mac behavior with java_home -v ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.
720 lines
24 KiB
Dart
720 lines
24 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/src/android/android_sdk.dart';
|
|
import 'package:flutter_tools/src/android/gradle.dart';
|
|
import 'package:flutter_tools/src/android/gradle_utils.dart' as gradle_utils;
|
|
import 'package:flutter_tools/src/artifacts.dart';
|
|
import 'package:flutter_tools/src/base/common.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/logger.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/build_info.dart';
|
|
import 'package:flutter_tools/src/cache.dart';
|
|
import 'package:flutter_tools/src/globals.dart' as globals;
|
|
import 'package:flutter_tools/src/project.dart';
|
|
|
|
import '../../src/common.dart';
|
|
import '../../src/context.dart';
|
|
|
|
const String kModulePubspec = '''
|
|
name: test
|
|
flutter:
|
|
module:
|
|
androidPackage: com.example
|
|
androidX: true
|
|
''';
|
|
|
|
void main() {
|
|
Cache.flutterRoot = getFlutterRoot();
|
|
|
|
group('build artifacts', () {
|
|
late FileSystem fileSystem;
|
|
|
|
setUp(() {
|
|
fileSystem = MemoryFileSystem.test();
|
|
});
|
|
|
|
testWithoutContext('getApkDirectory in app projects', () {
|
|
final FlutterProject project = FlutterProject.fromDirectoryTest(fileSystem.currentDirectory);
|
|
|
|
expect(
|
|
getApkDirectory(project).path, '/build/app/outputs/flutter-apk',
|
|
);
|
|
});
|
|
|
|
testWithoutContext('getApkDirectory in module projects', () {
|
|
fileSystem.currentDirectory
|
|
.childFile('pubspec.yaml')
|
|
.writeAsStringSync(kModulePubspec);
|
|
final FlutterProject project = FlutterProject.fromDirectoryTest(fileSystem.currentDirectory);
|
|
|
|
expect(project.isModule, true);
|
|
expect(
|
|
getApkDirectory(project).path, '/build/host/outputs/apk',
|
|
);
|
|
});
|
|
|
|
testWithoutContext('getBundleDirectory in app projects', () {
|
|
final FlutterProject project = FlutterProject.fromDirectoryTest(fileSystem.currentDirectory);
|
|
|
|
expect(
|
|
getBundleDirectory(project).path, '/build/app/outputs/bundle',
|
|
);
|
|
});
|
|
|
|
testWithoutContext('getBundleDirectory in module projects', () {
|
|
fileSystem.currentDirectory
|
|
.childFile('pubspec.yaml')
|
|
.writeAsStringSync(kModulePubspec);
|
|
final FlutterProject project = FlutterProject.fromDirectoryTest(fileSystem.currentDirectory);
|
|
|
|
expect(project.isModule, true);
|
|
expect(
|
|
getBundleDirectory(project).path, '/build/host/outputs/bundle',
|
|
);
|
|
});
|
|
|
|
testWithoutContext('getRepoDirectory', () {
|
|
expect(
|
|
getRepoDirectory(fileSystem.directory('foo')).path,
|
|
equals(fileSystem.path.join('foo','outputs', 'repo')),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('gradle tasks', () {
|
|
testWithoutContext('assemble release', () {
|
|
expect(
|
|
getAssembleTaskFor(const BuildInfo(BuildMode.release, null, treeShakeIcons: false)),
|
|
equals('assembleRelease'),
|
|
);
|
|
expect(
|
|
getAssembleTaskFor(const BuildInfo(BuildMode.release, 'flavorFoo', treeShakeIcons: false)),
|
|
equals('assembleFlavorFooRelease'),
|
|
);
|
|
});
|
|
|
|
testWithoutContext('assemble debug', () {
|
|
expect(
|
|
getAssembleTaskFor(BuildInfo.debug),
|
|
equals('assembleDebug'),
|
|
);
|
|
expect(
|
|
getAssembleTaskFor(const BuildInfo(BuildMode.debug, 'flavorFoo', treeShakeIcons: false)),
|
|
equals('assembleFlavorFooDebug'),
|
|
);
|
|
});
|
|
|
|
testWithoutContext('assemble profile', () {
|
|
expect(
|
|
getAssembleTaskFor(const BuildInfo(BuildMode.profile, null, treeShakeIcons: false)),
|
|
equals('assembleProfile'),
|
|
);
|
|
expect(
|
|
getAssembleTaskFor(const BuildInfo(BuildMode.profile, 'flavorFoo', treeShakeIcons: false)),
|
|
equals('assembleFlavorFooProfile'),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('listApkPaths', () {
|
|
testWithoutContext('Finds APK without flavor in debug', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.debug, '', treeShakeIcons: false)),
|
|
);
|
|
expect(apks, <String>['app-debug.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK with flavor in debug', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.debug, 'flavor1', treeShakeIcons: false)),
|
|
);
|
|
expect(apks, <String>['app-flavor1-debug.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK without flavor in release', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, '', treeShakeIcons: false)),
|
|
);
|
|
|
|
expect(apks, <String>['app-release.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK with flavor in release mode', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, 'flavor1', treeShakeIcons: false)),
|
|
);
|
|
|
|
expect(apks, <String>['app-flavor1-release.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK with flavor in release mode', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, 'flavorA', treeShakeIcons: false)),
|
|
);
|
|
|
|
expect(apks, <String>['app-flavora-release.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK with flavor in release mode - AGP v3', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, 'flavor1', treeShakeIcons: false)),
|
|
);
|
|
|
|
expect(apks, <String>['app-flavor1-release.apk']);
|
|
});
|
|
|
|
testWithoutContext('Finds APK with split-per-abi', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, 'flavor1', treeShakeIcons: false), splitPerAbi: true),
|
|
);
|
|
|
|
expect(apks, unorderedEquals(<String>[
|
|
'app-armeabi-v7a-flavor1-release.apk',
|
|
'app-arm64-v8a-flavor1-release.apk',
|
|
'app-x86_64-flavor1-release.apk',
|
|
]));
|
|
});
|
|
|
|
testWithoutContext('Finds APK with split-per-abi when flavor contains uppercase letters', () {
|
|
final Iterable<String> apks = listApkPaths(
|
|
const AndroidBuildInfo(BuildInfo(BuildMode.release, 'flavorA', treeShakeIcons: false), splitPerAbi: true),
|
|
);
|
|
|
|
expect(apks, unorderedEquals(<String>[
|
|
'app-armeabi-v7a-flavora-release.apk',
|
|
'app-arm64-v8a-flavora-release.apk',
|
|
'app-x86_64-flavora-release.apk',
|
|
]));
|
|
});
|
|
|
|
});
|
|
|
|
group('gradle build', () {
|
|
testUsingContext('do not crash if there is no Android SDK', () async {
|
|
expect(() {
|
|
gradle_utils.updateLocalProperties(project: FlutterProject.fromDirectoryTest(globals.fs.currentDirectory));
|
|
}, throwsToolExit(
|
|
message: '${globals.logger.terminal.warningMark} No Android SDK found. Try setting the ANDROID_SDK_ROOT environment variable.',
|
|
));
|
|
}, overrides: <Type, Generator>{
|
|
AndroidSdk: () => null,
|
|
});
|
|
});
|
|
|
|
group('Gradle local.properties', () {
|
|
late Artifacts localEngineArtifacts;
|
|
late FileSystem fs;
|
|
|
|
setUp(() {
|
|
fs = MemoryFileSystem.test();
|
|
localEngineArtifacts = Artifacts.test(localEngine: 'out/android_arm');
|
|
});
|
|
|
|
void testUsingAndroidContext(String description, dynamic Function() testMethod) {
|
|
testUsingContext(description, testMethod, overrides: <Type, Generator>{
|
|
Artifacts: () => localEngineArtifacts,
|
|
Platform: () => FakePlatform(),
|
|
FileSystem: () => fs,
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
});
|
|
}
|
|
|
|
String? propertyFor(String key, File file) {
|
|
final Iterable<String> result = file.readAsLinesSync()
|
|
.where((String line) => line.startsWith('$key='))
|
|
.map((String line) => line.split('=')[1]);
|
|
return result.isEmpty ? null : result.first;
|
|
}
|
|
|
|
Future<void> checkBuildVersion({
|
|
required String manifest,
|
|
BuildInfo? buildInfo,
|
|
String? expectedBuildName,
|
|
String? expectedBuildNumber,
|
|
}) async {
|
|
final File manifestFile = globals.fs.file('path/to/project/pubspec.yaml');
|
|
manifestFile.createSync(recursive: true);
|
|
manifestFile.writeAsStringSync(manifest);
|
|
|
|
|
|
gradle_utils.updateLocalProperties(
|
|
project: FlutterProject.fromDirectoryTest(globals.fs.directory('path/to/project')),
|
|
buildInfo: buildInfo,
|
|
requireAndroidSdk: false,
|
|
);
|
|
|
|
final File localPropertiesFile = globals.fs.file('path/to/project/android/local.properties');
|
|
expect(propertyFor('flutter.versionName', localPropertiesFile), expectedBuildName);
|
|
expect(propertyFor('flutter.versionCode', localPropertiesFile), expectedBuildNumber);
|
|
}
|
|
|
|
testUsingAndroidContext('extract build name and number from pubspec.yaml', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0+1
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.0',
|
|
expectedBuildNumber: '1',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('extract build name from pubspec.yaml', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.0',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to override build name', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0+1
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, buildName: '1.0.2', treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.2',
|
|
expectedBuildNumber: '1',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to override build number', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0+1
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, buildNumber: '3', treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.0',
|
|
expectedBuildNumber: '3',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to override build name and number', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0+1
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, buildName: '1.0.2', buildNumber: '3', treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.2',
|
|
expectedBuildNumber: '3',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to override build name and set number', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
version: 1.0.0
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, buildName: '1.0.2', buildNumber: '3', treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.2',
|
|
expectedBuildNumber: '3',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to set build name and number', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
const BuildInfo buildInfo = BuildInfo(BuildMode.release, null, buildName: '1.0.2', buildNumber: '3', treeShakeIcons: false);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: buildInfo,
|
|
expectedBuildName: '1.0.2',
|
|
expectedBuildNumber: '3',
|
|
);
|
|
});
|
|
|
|
testUsingAndroidContext('allow build info to unset build name and number', () async {
|
|
const String manifest = '''
|
|
name: test
|
|
dependencies:
|
|
flutter:
|
|
sdk: flutter
|
|
flutter:
|
|
''';
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: const BuildInfo(BuildMode.release, null, treeShakeIcons: false),
|
|
);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: const BuildInfo(BuildMode.release, null, buildName: '1.0.2', buildNumber: '3', treeShakeIcons: false),
|
|
expectedBuildName: '1.0.2',
|
|
expectedBuildNumber: '3',
|
|
);
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: const BuildInfo(BuildMode.release, null, buildName: '1.0.3', buildNumber: '4', treeShakeIcons: false),
|
|
expectedBuildName: '1.0.3',
|
|
expectedBuildNumber: '4',
|
|
);
|
|
// Values don't get unset.
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
expectedBuildName: '1.0.3',
|
|
expectedBuildNumber: '4',
|
|
);
|
|
// Values get unset.
|
|
await checkBuildVersion(
|
|
manifest: manifest,
|
|
buildInfo: const BuildInfo(BuildMode.release, null, treeShakeIcons: false),
|
|
);
|
|
});
|
|
});
|
|
|
|
group('gradgradle_utils.le version', () {
|
|
testWithoutContext('should be compatible with the Android plugin version', () {
|
|
// Grangradle_utils.ular versions.
|
|
expect(gradle_utils.getGradleVersionFor('1.0.0'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.0.1'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.0.2'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.0.4'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.0.8'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.1.0'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.1.2'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.1.2'), '2.3');
|
|
expect(gradle_utils.getGradleVersionFor('1.1.3'), '2.3');
|
|
// Versgradle_utils.ion Ranges.
|
|
expect(gradle_utils.getGradleVersionFor('1.2.0'), '2.9');
|
|
expect(gradle_utils.getGradleVersionFor('1.3.1'), '2.9');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('1.5.0'), '2.2.1');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('2.0.0'), '2.13');
|
|
expect(gradle_utils.getGradleVersionFor('2.1.2'), '2.13');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('2.1.3'), '2.14.1');
|
|
expect(gradle_utils.getGradleVersionFor('2.2.3'), '2.14.1');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('2.3.0'), '3.3');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('3.0.0'), '4.1');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('3.1.0'), '4.4');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('3.2.0'), '4.6');
|
|
expect(gradle_utils.getGradleVersionFor('3.2.1'), '4.6');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('3.3.0'), '4.10.2');
|
|
expect(gradle_utils.getGradleVersionFor('3.3.2'), '4.10.2');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('3.4.0'), '5.6.2');
|
|
expect(gradle_utils.getGradleVersionFor('3.5.0'), '5.6.2');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('4.0.0'), '6.7');
|
|
expect(gradle_utils.getGradleVersionFor('4.1.0'), '6.7');
|
|
|
|
expect(gradle_utils.getGradleVersionFor('7.0'), '7.5');
|
|
expect(gradle_utils.getGradleVersionFor('7.1.2'), '7.5');
|
|
expect(gradle_utils.getGradleVersionFor('7.2'), '7.5');
|
|
expect(gradle_utils.getGradleVersionFor('8.0'), '8.0');
|
|
expect(gradle_utils.getGradleVersionFor(gradle_utils.maxKnownAgpVersion), '8.0');
|
|
});
|
|
|
|
testWithoutContext('throws on unsupported versions', () {
|
|
expect(() => gradle_utils.getGradleVersionFor('3.6.0'),
|
|
throwsA(predicate<Exception>((Exception e) => e is ToolExit)));
|
|
});
|
|
});
|
|
|
|
group('isAppUsingAndroidX', () {
|
|
late FileSystem fs;
|
|
|
|
setUp(() {
|
|
fs = MemoryFileSystem.test();
|
|
});
|
|
|
|
testUsingContext('returns true when the project is using AndroidX', () async {
|
|
final Directory androidDirectory = globals.fs.systemTempDirectory.createTempSync('flutter_android.');
|
|
|
|
androidDirectory
|
|
.childFile('gradle.properties')
|
|
.writeAsStringSync('android.useAndroidX=true');
|
|
|
|
expect(isAppUsingAndroidX(androidDirectory), isTrue);
|
|
|
|
}, overrides: <Type, Generator>{
|
|
FileSystem: () => fs,
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
});
|
|
|
|
testUsingContext('returns false when the project is not using AndroidX', () async {
|
|
final Directory androidDirectory = globals.fs.systemTempDirectory.createTempSync('flutter_android.');
|
|
|
|
androidDirectory
|
|
.childFile('gradle.properties')
|
|
.writeAsStringSync('android.useAndroidX=false');
|
|
|
|
expect(isAppUsingAndroidX(androidDirectory), isFalse);
|
|
|
|
}, overrides: <Type, Generator>{
|
|
FileSystem: () => fs,
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
});
|
|
|
|
testUsingContext('returns false when gradle.properties does not exist', () async {
|
|
final Directory androidDirectory = globals.fs.systemTempDirectory.createTempSync('flutter_android.');
|
|
|
|
expect(isAppUsingAndroidX(androidDirectory), isFalse);
|
|
|
|
}, overrides: <Type, Generator>{
|
|
FileSystem: () => fs,
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
});
|
|
});
|
|
|
|
group('printHowToConsumeAar', () {
|
|
late BufferLogger logger;
|
|
late FileSystem fileSystem;
|
|
|
|
setUp(() {
|
|
logger = BufferLogger.test();
|
|
fileSystem = MemoryFileSystem.test();
|
|
});
|
|
|
|
testWithoutContext('stdout contains release, debug and profile', () async {
|
|
printHowToConsumeAar(
|
|
buildModes: const <String>{'release', 'debug', 'profile'},
|
|
androidPackage: 'com.mycompany',
|
|
repoDirectory: fileSystem.directory('build/'),
|
|
buildNumber: '2.2',
|
|
logger: logger,
|
|
fileSystem: fileSystem,
|
|
);
|
|
|
|
expect(
|
|
logger.statusText,
|
|
contains(
|
|
'\n'
|
|
'Consuming the Module\n'
|
|
' 1. Open <host>/app/build.gradle\n'
|
|
' 2. Ensure you have the repositories configured, otherwise add them:\n'
|
|
'\n'
|
|
' String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"\n'
|
|
' repositories {\n'
|
|
' maven {\n'
|
|
" url 'build/'\n"
|
|
' }\n'
|
|
' maven {\n'
|
|
' url "\$storageUrl/download.flutter.io"\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
' 3. Make the host app depend on the Flutter module:\n'
|
|
'\n'
|
|
' dependencies {\n'
|
|
" releaseImplementation 'com.mycompany:flutter_release:2.2'\n"
|
|
" debugImplementation 'com.mycompany:flutter_debug:2.2'\n"
|
|
" profileImplementation 'com.mycompany:flutter_profile:2.2'\n"
|
|
' }\n'
|
|
'\n'
|
|
'\n'
|
|
' 4. Add the `profile` build type:\n'
|
|
'\n'
|
|
' android {\n'
|
|
' buildTypes {\n'
|
|
' profile {\n'
|
|
' initWith debug\n'
|
|
' }\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
'To learn more, visit https://flutter.dev/go/build-aar\n'
|
|
)
|
|
);
|
|
});
|
|
|
|
testWithoutContext('stdout contains release', () async {
|
|
printHowToConsumeAar(
|
|
buildModes: const <String>{'release'},
|
|
androidPackage: 'com.mycompany',
|
|
repoDirectory: fileSystem.directory('build/'),
|
|
logger: logger,
|
|
fileSystem: fileSystem,
|
|
);
|
|
|
|
expect(
|
|
logger.statusText,
|
|
contains(
|
|
'\n'
|
|
'Consuming the Module\n'
|
|
' 1. Open <host>/app/build.gradle\n'
|
|
' 2. Ensure you have the repositories configured, otherwise add them:\n'
|
|
'\n'
|
|
' String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"\n'
|
|
' repositories {\n'
|
|
' maven {\n'
|
|
" url 'build/'\n"
|
|
' }\n'
|
|
' maven {\n'
|
|
' url "\$storageUrl/download.flutter.io"\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
' 3. Make the host app depend on the Flutter module:\n'
|
|
'\n'
|
|
' dependencies {\n'
|
|
" releaseImplementation 'com.mycompany:flutter_release:1.0'\n"
|
|
' }\n'
|
|
'\n'
|
|
'To learn more, visit https://flutter.dev/go/build-aar\n'
|
|
)
|
|
);
|
|
});
|
|
|
|
testWithoutContext('stdout contains debug', () async {
|
|
printHowToConsumeAar(
|
|
buildModes: const <String>{'debug'},
|
|
androidPackage: 'com.mycompany',
|
|
repoDirectory: fileSystem.directory('build/'),
|
|
logger: logger,
|
|
fileSystem: fileSystem,
|
|
);
|
|
|
|
expect(
|
|
logger.statusText,
|
|
contains(
|
|
'\n'
|
|
'Consuming the Module\n'
|
|
' 1. Open <host>/app/build.gradle\n'
|
|
' 2. Ensure you have the repositories configured, otherwise add them:\n'
|
|
'\n'
|
|
' String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"\n'
|
|
' repositories {\n'
|
|
' maven {\n'
|
|
" url 'build/'\n"
|
|
' }\n'
|
|
' maven {\n'
|
|
' url "\$storageUrl/download.flutter.io"\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
' 3. Make the host app depend on the Flutter module:\n'
|
|
'\n'
|
|
' dependencies {\n'
|
|
" debugImplementation 'com.mycompany:flutter_debug:1.0'\n"
|
|
' }\n'
|
|
'\n'
|
|
'To learn more, visit https://flutter.dev/go/build-aar\n'
|
|
)
|
|
);
|
|
});
|
|
|
|
testWithoutContext('stdout contains profile', () async {
|
|
printHowToConsumeAar(
|
|
buildModes: const <String>{'profile'},
|
|
androidPackage: 'com.mycompany',
|
|
repoDirectory: fileSystem.directory('build/'),
|
|
buildNumber: '1.0',
|
|
logger: logger,
|
|
fileSystem: fileSystem,
|
|
);
|
|
|
|
expect(
|
|
logger.statusText,
|
|
contains(
|
|
'\n'
|
|
'Consuming the Module\n'
|
|
' 1. Open <host>/app/build.gradle\n'
|
|
' 2. Ensure you have the repositories configured, otherwise add them:\n'
|
|
'\n'
|
|
' String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"\n'
|
|
' repositories {\n'
|
|
' maven {\n'
|
|
" url 'build/'\n"
|
|
' }\n'
|
|
' maven {\n'
|
|
' url "\$storageUrl/download.flutter.io"\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
' 3. Make the host app depend on the Flutter module:\n'
|
|
'\n'
|
|
' dependencies {\n'
|
|
" profileImplementation 'com.mycompany:flutter_profile:1.0'\n"
|
|
' }\n'
|
|
'\n'
|
|
'\n'
|
|
' 4. Add the `profile` build type:\n'
|
|
'\n'
|
|
' android {\n'
|
|
' buildTypes {\n'
|
|
' profile {\n'
|
|
' initWith debug\n'
|
|
' }\n'
|
|
' }\n'
|
|
' }\n'
|
|
'\n'
|
|
'To learn more, visit https://flutter.dev/go/build-aar\n'
|
|
)
|
|
);
|
|
});
|
|
});
|
|
|
|
test('Current settings.gradle is in our legacy settings.gradle file set', () {
|
|
// If this test fails, you probably edited templates/app/android.tmpl.
|
|
// That's fine, but you now need to add a copy of that file to gradle/settings.gradle.legacy_versions, separated
|
|
// from the previous versions by a line that just says ";EOF".
|
|
final File templateSettingsDotGradle = globals.fs.file(globals.fs.path.join(Cache.flutterRoot!, 'packages', 'flutter_tools', 'templates', 'app', 'android.tmpl', 'settings.gradle'));
|
|
final File legacySettingsDotGradleFiles = globals.fs.file(globals.fs.path.join(Cache.flutterRoot!, 'packages','flutter_tools', 'gradle', 'settings.gradle.legacy_versions'));
|
|
expect(
|
|
legacySettingsDotGradleFiles.readAsStringSync().split(';EOF').map<String>((String body) => body.trim()),
|
|
contains(templateSettingsDotGradle.readAsStringSync().trim()),
|
|
);
|
|
// TODO(zanderso): This is an integration test and should be moved to the integration shard.
|
|
}, skip: true); // https://github.com/flutter/flutter/issues/87922
|
|
}
|