github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
9f8fe3f04c
flutter/dev/integration_tests/windows_startup_test
History
Chris Bracken 9f8fe3f04c
[Windows] Fix signed/unsigned int comparison (#142341) 
Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:

```
windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
```

WideCharToMultiByte returns:
* 0 on error
* the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.

As a result it's safe to store the return value in an unsigned int, which eliminates the warning.

No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.

Fixes: https://github.com/flutter/flutter/issues/134227
2024-02-07 00:09:57 +00:00
..
lib Fix violation of the render rule in Windows Startup Test (#134245) 2023-09-21 17:43:07 +00:00
test_driver Test Utf8FromUtf16 (#118647) 2023-01-23 16:07:55 -05:00
windows [Windows] Fix signed/unsigned int comparison (#142341) 2024-02-07 00:09:57 +00:00
.metadata [Windows] Add app startup integration test (#110114) 2022-08-25 18:54:20 -07:00
pubspec.yaml Unpin test (#141427) 2024-02-01 18:53:23 +00:00
README.md [Windows] Add app startup integration test (#110114) 2022-08-25 18:54:20 -07:00

README.md

Windows start up test

This test verifies that Flutter draws a frame before the Windows app is shown.