mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
3dec6a6930
All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`. I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests. While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others. Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
311 lines
13 KiB
Dart
311 lines
13 KiB
Dart
// Copyright 2017 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:convert';
|
|
import 'dart:io' hide Platform;
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:mockito/mockito.dart';
|
|
import 'package:path/path.dart' as path;
|
|
import 'package:platform/platform.dart' show FakePlatform;
|
|
|
|
import '../prepare_package.dart';
|
|
import 'common.dart';
|
|
import 'fake_process_manager.dart';
|
|
|
|
void main() {
|
|
const String testRef = 'deadbeefdeadbeefdeadbeefdeadbeefdeadbeef';
|
|
test('Throws on missing executable', () async {
|
|
// Uses a *real* process manager, since we want to know what happens if
|
|
// it can't find an executable.
|
|
final ProcessRunner processRunner = new ProcessRunner(subprocessOutput: false);
|
|
expect(
|
|
expectAsync1((List<String> commandLine) async {
|
|
return processRunner.runProcess(commandLine);
|
|
})(<String>['this_executable_better_not_exist_2857632534321']),
|
|
throwsA(isInstanceOf<ProcessRunnerException>()));
|
|
try {
|
|
await processRunner.runProcess(<String>['this_executable_better_not_exist_2857632534321']);
|
|
} on ProcessRunnerException catch (e) {
|
|
expect(
|
|
e.message,
|
|
contains('Invalid argument(s): Cannot find executable for this_executable_better_not_exist_2857632534321.'),
|
|
);
|
|
}
|
|
});
|
|
for (String platformName in <String>['macos', 'linux', 'windows']) {
|
|
final FakePlatform platform = new FakePlatform(
|
|
operatingSystem: platformName,
|
|
environment: <String, String>{},
|
|
);
|
|
group('ProcessRunner for $platform', () {
|
|
test('Returns stdout', () async {
|
|
final FakeProcessManager fakeProcessManager = new FakeProcessManager();
|
|
fakeProcessManager.fakeResults = <String, List<ProcessResult>>{
|
|
'echo test': <ProcessResult>[new ProcessResult(0, 0, 'output', 'error')],
|
|
};
|
|
final ProcessRunner processRunner = new ProcessRunner(
|
|
subprocessOutput: false, platform: platform, processManager: fakeProcessManager);
|
|
final String output = await processRunner.runProcess(<String>['echo', 'test']);
|
|
expect(output, equals('output'));
|
|
});
|
|
test('Throws on process failure', () async {
|
|
final FakeProcessManager fakeProcessManager = new FakeProcessManager();
|
|
fakeProcessManager.fakeResults = <String, List<ProcessResult>>{
|
|
'echo test': <ProcessResult>[new ProcessResult(0, -1, 'output', 'error')],
|
|
};
|
|
final ProcessRunner processRunner = new ProcessRunner(
|
|
subprocessOutput: false, platform: platform, processManager: fakeProcessManager);
|
|
expect(
|
|
expectAsync1((List<String> commandLine) async {
|
|
return processRunner.runProcess(commandLine);
|
|
})(<String>['echo', 'test']),
|
|
throwsA(isInstanceOf<ProcessRunnerException>()));
|
|
});
|
|
});
|
|
group('ArchiveCreator for $platformName', () {
|
|
ArchiveCreator creator;
|
|
Directory tempDir;
|
|
Directory flutterDir;
|
|
FakeProcessManager processManager;
|
|
final List<List<String>> args = <List<String>>[];
|
|
final List<Map<Symbol, dynamic>> namedArgs = <Map<Symbol, dynamic>>[];
|
|
String flutter;
|
|
|
|
Future<Uint8List> fakeHttpReader(Uri url, {Map<String, String> headers}) {
|
|
return new Future<Uint8List>.value(new Uint8List(0));
|
|
}
|
|
|
|
setUp(() async {
|
|
processManager = new FakeProcessManager();
|
|
args.clear();
|
|
namedArgs.clear();
|
|
tempDir = Directory.systemTemp.createTempSync('flutter_prepage_package_test.');
|
|
flutterDir = new Directory(path.join(tempDir.path, 'flutter'));
|
|
flutterDir.createSync(recursive: true);
|
|
creator = new ArchiveCreator(
|
|
tempDir,
|
|
tempDir,
|
|
testRef,
|
|
Branch.dev,
|
|
processManager: processManager,
|
|
subprocessOutput: false,
|
|
platform: platform,
|
|
httpReader: fakeHttpReader,
|
|
);
|
|
flutter = path.join(creator.flutterRoot.absolute.path, 'bin', 'flutter');
|
|
});
|
|
|
|
tearDown(() async {
|
|
tryToDelete(tempDir);
|
|
});
|
|
|
|
test('sets PUB_CACHE properly', () async {
|
|
final String createBase = path.join(tempDir.absolute.path, 'create_');
|
|
final Map<String, List<ProcessResult>> calls = <String, List<ProcessResult>>{
|
|
'git clone -b dev https://chromium.googlesource.com/external/github.com/flutter/flutter': null,
|
|
'git reset --hard $testRef': null,
|
|
'git remote set-url origin https://github.com/flutter/flutter.git': null,
|
|
'git describe --tags --abbrev=0': <ProcessResult>[new ProcessResult(0, 0, 'v1.2.3', '')],
|
|
};
|
|
if (platform.isWindows) {
|
|
calls['7za x ${path.join(tempDir.path, 'mingit.zip')}'] = null;
|
|
}
|
|
calls.addAll(<String, List<ProcessResult>>{
|
|
'$flutter doctor': null,
|
|
'$flutter update-packages': null,
|
|
'$flutter precache': null,
|
|
'$flutter ide-config': null,
|
|
'$flutter create --template=app ${createBase}app': null,
|
|
'$flutter create --template=package ${createBase}package': null,
|
|
'$flutter create --template=plugin ${createBase}plugin': null,
|
|
'git clean -f -X **/.packages': null,
|
|
});
|
|
final String archiveName = path.join(tempDir.absolute.path,
|
|
'flutter_${platformName}_v1.2.3-dev${platform.isLinux ? '.tar.xz' : '.zip'}');
|
|
if (platform.isWindows) {
|
|
calls['7za a -tzip -mx=9 $archiveName flutter'] = null;
|
|
} else if (platform.isMacOS) {
|
|
calls['zip -r -9 $archiveName flutter'] = null;
|
|
} else if (platform.isLinux) {
|
|
calls['tar cJf $archiveName flutter'] = null;
|
|
}
|
|
processManager.fakeResults = calls;
|
|
await creator.initializeRepo();
|
|
await creator.createArchive();
|
|
expect(
|
|
verify(processManager.start(
|
|
captureAny,
|
|
workingDirectory: captureAnyNamed('workingDirectory'),
|
|
environment: captureAnyNamed('environment'),
|
|
)).captured[2]['PUB_CACHE'],
|
|
endsWith(path.join('flutter', '.pub-cache')),
|
|
);
|
|
});
|
|
|
|
test('calls the right commands for archive output', () async {
|
|
final String createBase = path.join(tempDir.absolute.path, 'create_');
|
|
final Map<String, List<ProcessResult>> calls = <String, List<ProcessResult>>{
|
|
'git clone -b dev https://chromium.googlesource.com/external/github.com/flutter/flutter': null,
|
|
'git reset --hard $testRef': null,
|
|
'git remote set-url origin https://github.com/flutter/flutter.git': null,
|
|
'git describe --tags --abbrev=0': <ProcessResult>[new ProcessResult(0, 0, 'v1.2.3', '')],
|
|
};
|
|
if (platform.isWindows) {
|
|
calls['7za x ${path.join(tempDir.path, 'mingit.zip')}'] = null;
|
|
}
|
|
calls.addAll(<String, List<ProcessResult>>{
|
|
'$flutter doctor': null,
|
|
'$flutter update-packages': null,
|
|
'$flutter precache': null,
|
|
'$flutter ide-config': null,
|
|
'$flutter create --template=app ${createBase}app': null,
|
|
'$flutter create --template=package ${createBase}package': null,
|
|
'$flutter create --template=plugin ${createBase}plugin': null,
|
|
'git clean -f -X **/.packages': null,
|
|
});
|
|
final String archiveName = path.join(tempDir.absolute.path,
|
|
'flutter_${platformName}_v1.2.3-dev${platform.isLinux ? '.tar.xz' : '.zip'}');
|
|
if (platform.isWindows) {
|
|
calls['7za a -tzip -mx=9 $archiveName flutter'] = null;
|
|
} else if (platform.isMacOS) {
|
|
calls['zip -r -9 $archiveName flutter'] = null;
|
|
} else if (platform.isLinux) {
|
|
calls['tar cJf $archiveName flutter'] = null;
|
|
}
|
|
processManager.fakeResults = calls;
|
|
creator = new ArchiveCreator(
|
|
tempDir,
|
|
tempDir,
|
|
testRef,
|
|
Branch.dev,
|
|
processManager: processManager,
|
|
subprocessOutput: false,
|
|
platform: platform,
|
|
httpReader: fakeHttpReader,
|
|
);
|
|
await creator.initializeRepo();
|
|
await creator.createArchive();
|
|
processManager.verifyCalls(calls.keys.toList());
|
|
});
|
|
|
|
test('throws when a command errors out', () async {
|
|
final Map<String, List<ProcessResult>> calls = <String, List<ProcessResult>>{
|
|
'git clone -b dev https://chromium.googlesource.com/external/github.com/flutter/flutter':
|
|
<ProcessResult>[new ProcessResult(0, 0, 'output1', '')],
|
|
'git reset --hard $testRef': <ProcessResult>[new ProcessResult(0, -1, 'output2', '')],
|
|
};
|
|
processManager.fakeResults = calls;
|
|
expect(expectAsync0(creator.initializeRepo),
|
|
throwsA(isInstanceOf<ProcessRunnerException>()));
|
|
});
|
|
});
|
|
|
|
group('ArchivePublisher for $platformName', () {
|
|
FakeProcessManager processManager;
|
|
Directory tempDir;
|
|
|
|
setUp(() async {
|
|
processManager = new FakeProcessManager();
|
|
tempDir = Directory.systemTemp.createTempSync('flutter_prepage_package_test.');
|
|
});
|
|
|
|
tearDown(() async {
|
|
tryToDelete(tempDir);
|
|
});
|
|
|
|
test('calls the right processes', () async {
|
|
final String releasesName = 'releases_$platformName.json';
|
|
final String archiveName = platform.isLinux ? 'archive.tar.xz' : 'archive.zip';
|
|
final String archiveMime = platform.isLinux ? 'application/x-gtar' : 'application/zip';
|
|
final String archivePath = path.join(tempDir.absolute.path, archiveName);
|
|
final String gsArchivePath = 'gs://flutter_infra/releases/release/$platformName/$archiveName';
|
|
final String jsonPath = path.join(tempDir.absolute.path, releasesName);
|
|
final String gsJsonPath = 'gs://flutter_infra/releases/$releasesName';
|
|
final String releasesJson = '''{
|
|
"base_url": "https://storage.googleapis.com/flutter_infra/releases",
|
|
"current_release": {
|
|
"beta": "3ea4d06340a97a1e9d7cae97567c64e0569dcaa2",
|
|
"dev": "5a58b36e36b8d7aace89d3950e6deb307956a6a0"
|
|
},
|
|
"releases": [
|
|
{
|
|
"hash": "5a58b36e36b8d7aace89d3950e6deb307956a6a0",
|
|
"channel": "dev",
|
|
"version": "v0.2.3",
|
|
"release_date": "2018-03-20T01:47:02.851729Z",
|
|
"archive": "dev/$platformName/flutter_${platformName}_v0.2.3-dev.zip"
|
|
},
|
|
{
|
|
"hash": "b9bd51cc36b706215915711e580851901faebb40",
|
|
"channel": "beta",
|
|
"version": "v0.2.2",
|
|
"release_date": "2018-03-16T18:48:13.375013Z",
|
|
"archive": "dev/$platformName/flutter_${platformName}_v0.2.2-dev.zip"
|
|
},
|
|
{
|
|
"hash": "$testRef",
|
|
"channel": "release",
|
|
"version": "v0.0.0",
|
|
"release_date": "2018-03-20T01:47:02.851729Z",
|
|
"archive": "release/$platformName/flutter_${platformName}_v0.0.0-dev.zip"
|
|
}
|
|
]
|
|
}
|
|
''';
|
|
new File(jsonPath).writeAsStringSync(releasesJson);
|
|
final Map<String, List<ProcessResult>> calls = <String, List<ProcessResult>>{
|
|
'gsutil rm $gsArchivePath': null,
|
|
'gsutil -h Content-Type:$archiveMime cp $archivePath $gsArchivePath': null,
|
|
'gsutil cp $gsJsonPath $jsonPath': null,
|
|
'gsutil rm $gsJsonPath': null,
|
|
'gsutil -h Content-Type:application/json cp $jsonPath $gsJsonPath': null,
|
|
};
|
|
processManager.fakeResults = calls;
|
|
final File outputFile = new File(path.join(tempDir.absolute.path, archiveName));
|
|
assert(tempDir.existsSync());
|
|
final ArchivePublisher publisher = new ArchivePublisher(
|
|
tempDir,
|
|
testRef,
|
|
Branch.release,
|
|
'v1.2.3',
|
|
outputFile,
|
|
processManager: processManager,
|
|
subprocessOutput: false,
|
|
platform: platform,
|
|
);
|
|
assert(tempDir.existsSync());
|
|
await publisher.publishArchive();
|
|
processManager.verifyCalls(calls.keys.toList());
|
|
final File releaseFile = new File(jsonPath);
|
|
expect(releaseFile.existsSync(), isTrue);
|
|
final String contents = releaseFile.readAsStringSync();
|
|
// Make sure new data is added.
|
|
expect(contents, contains('"hash": "$testRef"'));
|
|
expect(contents, contains('"channel": "release"'));
|
|
expect(contents, contains('"archive": "release/$platformName/$archiveName"'));
|
|
// Make sure existing entries are preserved.
|
|
expect(contents, contains('"hash": "5a58b36e36b8d7aace89d3950e6deb307956a6a0"'));
|
|
expect(contents, contains('"hash": "b9bd51cc36b706215915711e580851901faebb40"'));
|
|
expect(contents, contains('"channel": "beta"'));
|
|
expect(contents, contains('"channel": "dev"'));
|
|
// Make sure old matching entries are removed.
|
|
expect(contents, isNot(contains('v0.0.0')));
|
|
final Map<String, dynamic> jsonData = json.decode(contents);
|
|
final List<dynamic> releases = jsonData['releases'];
|
|
expect(releases.length, equals(3));
|
|
// Make sure the new entry is first (and hopefully it takes less than a
|
|
// minute to go from publishArchive above to this line!).
|
|
expect(
|
|
new DateTime.now().difference(DateTime.parse(releases[0]['release_date'])),
|
|
lessThan(const Duration(minutes: 1)),
|
|
);
|
|
const JsonEncoder encoder = JsonEncoder.withIndent(' ');
|
|
expect(contents, equals(encoder.convert(jsonData)));
|
|
});
|
|
});
|
|
}
|
|
}
|