mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
4b0c8414fc
## Description This PR exposed `PopupMenuButton.menuPadding` parameter to override the hardcoded value. Credits to @Moluram for the original PR https://github.com/flutter/flutter/pull/81996. And to @arafaysaleem for the update in https://github.com/flutter/flutter/pull/96657. https://github.com/flutter/flutter/pull/96657 was reverted due to a Google testing failure. `PopupMenuButton` implementation has evolved since that time so maybe we will not hit this Google testing failure. And if we do, we will try to figure out what is going on. ## Related Issue Fixes https://github.com/flutter/flutter/issues/143512. Fixes https://github.com/flutter/flutter/issues/57110 ## Tests Adds 2 tests, updates several tests.
57 lines
2.1 KiB
Dart
57 lines
2.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'template.dart';
|
|
|
|
class PopupMenuTemplate extends TokenTemplate {
|
|
const PopupMenuTemplate(super.blockName, super.fileName, super.tokens, {
|
|
super.colorSchemePrefix = '_colors.',
|
|
super.textThemePrefix = '_textTheme.',
|
|
});
|
|
|
|
@override
|
|
String generate() => '''
|
|
class _${blockName}DefaultsM3 extends PopupMenuThemeData {
|
|
_${blockName}DefaultsM3(this.context)
|
|
: super(elevation: ${elevation('md.comp.menu.container')});
|
|
|
|
final BuildContext context;
|
|
late final ThemeData _theme = Theme.of(context);
|
|
late final ColorScheme _colors = _theme.colorScheme;
|
|
late final TextTheme _textTheme = _theme.textTheme;
|
|
|
|
@override MaterialStateProperty<TextStyle?>? get labelTextStyle {
|
|
return MaterialStateProperty.resolveWith((Set<MaterialState> states) {
|
|
// TODO(quncheng): Update this hard-coded value to use the latest tokens.
|
|
final TextStyle style = _textTheme.labelLarge!;
|
|
if (states.contains(MaterialState.disabled)) {
|
|
return style.apply(color: ${componentColor('md.comp.list.list-item.disabled.label-text')});
|
|
}
|
|
return style.apply(color: ${componentColor('md.comp.list.list-item.label-text')});
|
|
});
|
|
}
|
|
|
|
@override
|
|
Color? get color => ${componentColor('md.comp.menu.container')};
|
|
|
|
@override
|
|
Color? get shadowColor => ${color("md.comp.menu.container.shadow-color")};
|
|
|
|
@override
|
|
Color? get surfaceTintColor => ${colorOrTransparent("md.comp.menu.container.surface-tint-layer.color")};
|
|
|
|
@override
|
|
ShapeBorder? get shape => ${shape("md.comp.menu.container")};
|
|
|
|
// TODO(bleroux): This is taken from https://m3.material.io/components/menus/specs
|
|
// Update this when the token is available.
|
|
@override
|
|
EdgeInsets? get menuPadding => const EdgeInsets.symmetric(vertical: 8.0);
|
|
|
|
// TODO(tahatesser): This is taken from https://m3.material.io/components/menus/specs
|
|
// Update this when the token is available.
|
|
static EdgeInsets menuItemPadding = const EdgeInsets.symmetric(horizontal: 12.0);
|
|
}''';
|
|
}
|