flutter/dev/devicelab/lib/tasks/keyboard_hot_restart_test.dart
Loïc Sharma 4b1d2644cb
Fix keyboard_hot_restart_ios flakes (#168518)
The keyboard hot restart test does these steps:

1. It launches an app that forces the keyboard to be visible
2. It checks that the keyboard is visible by examining the app's logs
3. It updates the app to no longer force the keyboard to be visible and
hot restarts the app
4. It checks that the keyboard is no longer visible by examining the
app's logs

Previously, the test app printed the keyboard status whenever the app
rebuilt. The test would move on as soon as it saw a log that indicates
the keyboard was in the expected state. However, since the app could log
the keyboard's visibility _before_ the Dart VM was available, hot
restart commands could be ignored (or at least, that's my theory from
the DeviceLab logs).

Now, the test app prints the keyboard status non-stop. The test now
waits until the Dart VM is available before checking if the logs
indicate the keyboard is open. Also, the test now waits until the hot
restart has completed before checking if the keyboard is closed. In
theory, this should ensure that hot restart does not happen until after
the Dart VM is available.

Follow-up to: https://github.com/flutter/flutter/pull/167013
Part of: https://github.com/flutter/flutter/issues/10713

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-19 19:05:09 +00:00

176 lines
5.8 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'package:path/path.dart' as path;
import '../framework/devices.dart';
import '../framework/framework.dart';
import '../framework/task_result.dart';
import '../framework/utils.dart';
// This test verifies that hot restart hides the keyboard if it is visible.
//
// Steps:
//
// 1. Launch an app that focuses a text field at startup.
// This makes the keyboard visible.
// 2. Wait until the keyboard is visible.
// 3. Update the app's source code to no longer focus a text field at startup.
// 4. Hot restart the app
// 5. Wait until the keyboard is no longer visible.
//
// App under test: //dev/integration_tests/keyboard_hot_restart/lib/main.dart
//
// Since this test must hot restart the app under test, this test cannot use
// testing frameworks like XCUITest or Flutter's integration_test as they don't
// support hot restart. Instead, this test uses the Flutter tool to run the app,
// hot restart it, and verify its log output.
TaskFunction createKeyboardHotRestartTest({
String? deviceIdOverride,
bool checkAppRunningOnLocalDevice = false,
List<String>? additionalOptions,
}) {
final Directory appDir = dir(
path.join(flutterDirectory.path, 'dev/integration_tests/keyboard_hot_restart'),
);
// This file is modified during the test and needs to be restored at the end.
final File mainFile = file(path.join(appDir.path, 'lib/main.dart'));
final String oldContents = mainFile.readAsStringSync();
// When the test starts, the app forces the keyboard to be visible.
// The test turns off this behavior by mutating the app's source code from
// `forceKeyboardOn` to `forceKeyboardOff`.
// See: //dev/integration_tests/keyboard_hot_restart/lib/main.dart
const String forceKeyboardOn = 'const bool forceKeyboard = true;';
const String forceKeyboardOff = 'const bool forceKeyboard = false;';
return () async {
if (deviceIdOverride == null) {
final Device device = await devices.workingDevice;
await device.unlock();
deviceIdOverride = device.deviceId;
}
return inDirectory<TaskResult>(appDir, () async {
try {
section('Create app');
await createAppProject();
// Ensure the app forces the keyboard to be visible.
final String newContents = oldContents.replaceFirst(forceKeyboardOff, forceKeyboardOn);
mainFile.writeAsStringSync(newContents);
section('Launch app');
bool success = false;
TestState state = TestState.waitUntilDartVmAvailable;
final int exitCode = await runApp(
options: <String>['-d', deviceIdOverride!],
onLine: (String line, Process process) {
if (state == TestState.waitUntilDartVmAvailable) {
if (!line.contains('A Dart VM Service') || !line.contains('is available at')) {
return;
}
section('Wait until keyboard is visible');
state = TestState.waitUntilKeyboardOpen;
} else if (state == TestState.waitUntilKeyboardOpen) {
if (!line.contains('flutter: Keyboard is open')) {
return;
}
section('Update the app to no longer force the keyboard to be visible');
final String newContents = oldContents.replaceFirst(
forceKeyboardOn,
forceKeyboardOff,
);
mainFile.writeAsStringSync(newContents);
process.stdin.writeln('R');
section('Wait until the app hot restarts');
state = TestState.waitUntilHotRestart;
} else if (state == TestState.waitUntilHotRestart) {
if (!line.contains('Restarted application in ')) {
return;
}
section('Wait until the keyboard is no longer visible');
state = TestState.waitUntilKeyboardClosed;
} else if (state == TestState.waitUntilKeyboardClosed) {
if (!line.contains('flutter: Keyboard is closed')) {
return;
}
// Quit the app. This makes the 'flutter run' process exit.
process.stdin.writeln('q');
success = true;
}
},
);
if (exitCode != 0) {
return TaskResult.failure('flutter run exited with non-zero exit code: $exitCode');
}
if (!success) {
return TaskResult.failure('Test did not complete successfully');
}
} finally {
mainFile.writeAsStringSync(oldContents);
}
return TaskResult.success(null);
});
};
}
enum TestState {
waitUntilDartVmAvailable,
waitUntilKeyboardOpen,
waitUntilHotRestart,
waitUntilKeyboardClosed,
}
Future<void> createAppProject() async {
await exec(path.join(flutterDirectory.path, 'bin', 'flutter'), <String>[
'create',
'--platforms=android,ios',
'.',
]);
}
Future<int> runApp({
required List<String> options,
required void Function(String, Process) onLine,
}) async {
final Process process = await startFlutter('run', options: options);
final Completer<void> stdoutDone = Completer<void>();
final Completer<void> stderrDone = Completer<void>();
void onStdout(String line) {
print('stdout: $line');
onLine(line, process);
}
process.stdout
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen(onStdout, onDone: stdoutDone.complete);
process.stderr
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) => print('stderr: $line'), onDone: stderrDone.complete);
await Future.wait<void>(<Future<void>>[stdoutDone.future, stderrDone.future]);
return process.exitCode;
}