mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This PR removes redundant useMaterial3: true as described in https://github.com/flutter/flutter/issues/162818 *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* - https://github.com/flutter/flutter/issues/162818 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
136 lines
4.8 KiB
Dart
136 lines
4.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_localizations/flutter_localizations.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
testWidgets('Material3 - Nested Localizations', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
// Creates the outer Localizations widget.
|
|
home: ListView(
|
|
children: <Widget>[
|
|
const LocalizationTracker(key: ValueKey<String>('outer')),
|
|
Localizations(
|
|
locale: const Locale('zh', 'CN'),
|
|
delegates: GlobalMaterialLocalizations.delegates,
|
|
child: const LocalizationTracker(key: ValueKey<String>('inner')),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
// Most localized aspects of the TextTheme text styles are the same for the default US local and
|
|
// for Chinese for Material3. The baselines for all text styles differ.
|
|
final LocalizationTrackerState outerTracker = tester.state(
|
|
find.byKey(const ValueKey<String>('outer'), skipOffstage: false),
|
|
);
|
|
expect(outerTracker.textBaseline, TextBaseline.alphabetic);
|
|
final LocalizationTrackerState innerTracker = tester.state(
|
|
find.byKey(const ValueKey<String>('inner'), skipOffstage: false),
|
|
);
|
|
expect(innerTracker.textBaseline, TextBaseline.ideographic);
|
|
});
|
|
|
|
testWidgets('Material2 - Nested Localizations', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
// Creates the outer Localizations widget.
|
|
theme: ThemeData(useMaterial3: false),
|
|
home: ListView(
|
|
children: <Widget>[
|
|
const LocalizationTracker(key: ValueKey<String>('outer')),
|
|
Localizations(
|
|
locale: const Locale('zh', 'CN'),
|
|
delegates: GlobalMaterialLocalizations.delegates,
|
|
child: const LocalizationTracker(key: ValueKey<String>('inner')),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
// Most localized aspects of the TextTheme text styles are the same for the default US local and
|
|
// for Chinese for Material2. The baselines for all text styles differ.
|
|
final LocalizationTrackerState outerTracker = tester.state(
|
|
find.byKey(const ValueKey<String>('outer'), skipOffstage: false),
|
|
);
|
|
expect(outerTracker.textBaseline, TextBaseline.alphabetic);
|
|
final LocalizationTrackerState innerTracker = tester.state(
|
|
find.byKey(const ValueKey<String>('inner'), skipOffstage: false),
|
|
);
|
|
expect(innerTracker.textBaseline, TextBaseline.ideographic);
|
|
});
|
|
|
|
testWidgets(
|
|
'Localizations is compatible with ChangeNotifier.dispose() called during didChangeDependencies',
|
|
(WidgetTester tester) async {
|
|
// PageView calls ScrollPosition.dispose() during didChangeDependencies.
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
supportedLocales: const <Locale>[Locale('en', 'US'), Locale('es', 'ES')],
|
|
localizationsDelegates: <LocalizationsDelegate<dynamic>>[
|
|
_DummyLocalizationsDelegate(),
|
|
...GlobalMaterialLocalizations.delegates,
|
|
],
|
|
home: PageView(),
|
|
),
|
|
);
|
|
|
|
await tester.binding.setLocale('es', 'US');
|
|
await tester.pump();
|
|
await tester.pumpWidget(Container());
|
|
},
|
|
);
|
|
|
|
testWidgets('Locale without countryCode', (WidgetTester tester) async {
|
|
// Regression test for https://github.com/flutter/flutter/pull/16782
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
localizationsDelegates: GlobalMaterialLocalizations.delegates,
|
|
supportedLocales: const <Locale>[Locale('es', 'ES'), Locale('zh')],
|
|
home: Container(),
|
|
),
|
|
);
|
|
|
|
await tester.binding.setLocale('zh', '');
|
|
await tester.pump();
|
|
await tester.binding.setLocale('es', 'US');
|
|
await tester.pump();
|
|
});
|
|
}
|
|
|
|
/// A localizations delegate that does not contain any useful data, and is only
|
|
/// used to trigger didChangeDependencies upon locale change.
|
|
class _DummyLocalizationsDelegate extends LocalizationsDelegate<DummyLocalizations> {
|
|
@override
|
|
Future<DummyLocalizations> load(Locale locale) async => DummyLocalizations();
|
|
|
|
@override
|
|
bool isSupported(Locale locale) => true;
|
|
|
|
@override
|
|
bool shouldReload(_DummyLocalizationsDelegate old) => true;
|
|
}
|
|
|
|
class DummyLocalizations {}
|
|
|
|
class LocalizationTracker extends StatefulWidget {
|
|
const LocalizationTracker({super.key});
|
|
|
|
@override
|
|
State<StatefulWidget> createState() => LocalizationTrackerState();
|
|
}
|
|
|
|
class LocalizationTrackerState extends State<LocalizationTracker> {
|
|
late TextBaseline textBaseline;
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
textBaseline = Theme.of(context).textTheme.bodySmall!.textBaseline!;
|
|
return Container();
|
|
}
|
|
}
|