mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
b06c05c6f4
🚫 **Do not merge** until https://flutter-review.googlesource.com/c/recipes/+/64220/1 is merged. --- Closes https://github.com/flutter/flutter/issues/165618. The `devicelab/bin/test_runner.dart upload-metrics` command use to have _two_ responsibilities: - Well, upload test **metrics** (benchmarks) to Skia Perf (it still does that) - Upload test **status** to Cocoon (it did until https://github.com/flutter/flutter/pull/165614) As https://github.com/flutter/flutter/pull/165614 proved, this API predated the current LUCI setup, where Cocoon itself receives task status updates from LUCI, and it turns out this entire time, DeviceLab was making (at best) NOP calls, and at worst, causing crashes and corrupt data (https://github.com/flutter/flutter/issues/165610). In other words, this is removing entirely dead/unused code (though the recipes have to be updated first). /cc @jason-simmons as I need Jason's help reviewing the recipes change and want to provide context. |
||
|---|---|---|
| .. | ||
| ab.dart | ||
| apk_utils.dart | ||
| browser.dart | ||
| dependency_smoke_test_task_definition.dart | ||
| devices.dart | ||
| framework.dart | ||
| host_agent.dart | ||
| ios.dart | ||
| metrics_center.dart | ||
| runner.dart | ||
| running_processes.dart | ||
| talkback.dart | ||
| task_result.dart | ||
| utils.dart | ||