mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
8cda3bea23
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change. |
||
|---|---|---|
| .. | ||
| deserialization_factory.dart | ||
| diagnostics_tree.dart | ||
| enum_util.dart | ||
| error.dart | ||
| find.dart | ||
| frame_sync.dart | ||
| fuchsia_compat.dart | ||
| geometry.dart | ||
| gesture.dart | ||
| handler_factory.dart | ||
| health.dart | ||
| layer_tree.dart | ||
| message.dart | ||
| render_tree.dart | ||
| request_data.dart | ||
| semantics.dart | ||
| text_input_action.dart | ||
| text.dart | ||
| wait.dart | ||