mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

The keyboard hot restart test listens to `flutter run` logs and then does an action. However, the test prints the `flutter run` log after the action. This results in confusing logs. For example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8716606099574306145/+/u/run_keyboard_hot_restart_ios/stdout ``` ═══════════╡ ••• Launch app and wait for keyboard to be visible ••• ╞═══════════ ... stdout: Installing and launching... 37.2s stdout: Syncing files to device swarming’s iPhone... ════╡ ••• Update the app to no longer force the keyboard to be visible ••• ╞════ ════════════════════════╡ ••• Hot restart the app ••• ╞═════════════════════════ ════════════╡ ••• Wait until the keyboard is no longer visible ••• ╞════════════ stdout: flutter: Keyboard is open ``` Here, the test waits until the keyboard is visible before moving onto the test's next step. However, the log that triggers this action (`flutter: Keyboard is open`) is printed after the action was taken (`Update the app to no longer force the keyboard to be visible` and `Wait until the keyboard is no longer visible`). This is confusing. Follow-up to: https://github.com/flutter/flutter/pull/167013 Part of: https://github.com/flutter/flutter/issues/10713
153 lines
5.1 KiB
Dart
153 lines
5.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:convert';
|
|
import 'dart:io';
|
|
|
|
import 'package:path/path.dart' as path;
|
|
|
|
import '../framework/devices.dart';
|
|
import '../framework/framework.dart';
|
|
import '../framework/task_result.dart';
|
|
import '../framework/utils.dart';
|
|
|
|
// This test verifies that hot restart hides the keyboard if it is visible.
|
|
//
|
|
// Steps:
|
|
//
|
|
// 1. Launch an app that focuses a text field at startup.
|
|
// This makes the keyboard visible.
|
|
// 2. Wait until the keyboard is visible.
|
|
// 3. Update the app's source code to no longer focus a text field at startup.
|
|
// 4. Hot restart the app
|
|
// 5. Wait until the keyboard is no longer visible.
|
|
//
|
|
// App under test: //dev/integration_tests/keyboard_hot_restart/lib/main.dart
|
|
//
|
|
// Since this test must hot restart the app under test, this test cannot use
|
|
// testing frameworks like XCUITest or Flutter's integration_test as they don't
|
|
// support hot restart. Instead, this test uses the Flutter tool to run the app,
|
|
// hot restart it, and verify its log output.
|
|
TaskFunction createKeyboardHotRestartTest({
|
|
String? deviceIdOverride,
|
|
bool checkAppRunningOnLocalDevice = false,
|
|
List<String>? additionalOptions,
|
|
}) {
|
|
final Directory appDir = dir(
|
|
path.join(flutterDirectory.path, 'dev/integration_tests/keyboard_hot_restart'),
|
|
);
|
|
|
|
// This file is modified during the test and needs to be restored at the end.
|
|
final File mainFile = file(path.join(appDir.path, 'lib/main.dart'));
|
|
final String oldContents = mainFile.readAsStringSync();
|
|
|
|
// When the test starts, the app forces the keyboard to be visible.
|
|
// The test turns off this behavior by mutating the app's source code from
|
|
// `forceKeyboardOn` to `forceKeyboardOff`.
|
|
// See: //dev/integration_tests/keyboard_hot_restart/lib/main.dart
|
|
const String forceKeyboardOn = 'const bool forceKeyboard = true;';
|
|
const String forceKeyboardOff = 'const bool forceKeyboard = false;';
|
|
|
|
return () async {
|
|
if (deviceIdOverride == null) {
|
|
final Device device = await devices.workingDevice;
|
|
await device.unlock();
|
|
deviceIdOverride = device.deviceId;
|
|
}
|
|
|
|
return inDirectory<TaskResult>(appDir, () async {
|
|
try {
|
|
section('Create app');
|
|
await createAppProject();
|
|
|
|
// Ensure the app forces the keyboard to be visible.
|
|
final String newContents = oldContents.replaceFirst(forceKeyboardOff, forceKeyboardOn);
|
|
mainFile.writeAsStringSync(newContents);
|
|
|
|
section('Launch app and wait for keyboard to be visible');
|
|
|
|
TestState state = TestState.waitUntilKeyboardOpen;
|
|
|
|
final int exitCode = await runApp(
|
|
options: <String>['-d', deviceIdOverride!],
|
|
onLine: (String line, Process process) {
|
|
if (state == TestState.waitUntilKeyboardOpen) {
|
|
if (!line.contains('flutter: Keyboard is open')) {
|
|
return;
|
|
}
|
|
|
|
section('Update the app to no longer force the keyboard to be visible');
|
|
final String newContents = oldContents.replaceFirst(
|
|
forceKeyboardOn,
|
|
forceKeyboardOff,
|
|
);
|
|
mainFile.writeAsStringSync(newContents);
|
|
|
|
section('Hot restart the app');
|
|
process.stdin.writeln('R');
|
|
|
|
section('Wait until the keyboard is no longer visible');
|
|
state = TestState.waitUntilKeyboardClosed;
|
|
} else if (state == TestState.waitUntilKeyboardClosed) {
|
|
if (!line.contains('flutter: Keyboard is closed')) {
|
|
return;
|
|
}
|
|
|
|
// Quit the app. This makes the 'flutter run' process exit.
|
|
process.stdin.writeln('q');
|
|
}
|
|
},
|
|
);
|
|
|
|
if (exitCode != 0) {
|
|
return TaskResult.failure('flutter run exited with non-zero exit code: $exitCode');
|
|
}
|
|
} finally {
|
|
mainFile.writeAsStringSync(oldContents);
|
|
}
|
|
|
|
return TaskResult.success(null);
|
|
});
|
|
};
|
|
}
|
|
|
|
enum TestState { waitUntilKeyboardOpen, waitUntilKeyboardClosed }
|
|
|
|
Future<void> createAppProject() async {
|
|
await exec(path.join(flutterDirectory.path, 'bin', 'flutter'), <String>[
|
|
'create',
|
|
'--platforms=android,ios',
|
|
'.',
|
|
]);
|
|
}
|
|
|
|
Future<int> runApp({
|
|
required List<String> options,
|
|
required void Function(String, Process) onLine,
|
|
}) async {
|
|
final Process process = await startFlutter('run', options: options);
|
|
|
|
final Completer<void> stdoutDone = Completer<void>();
|
|
final Completer<void> stderrDone = Completer<void>();
|
|
|
|
void onStdout(String line) {
|
|
print('stdout: $line');
|
|
onLine(line, process);
|
|
}
|
|
|
|
process.stdout
|
|
.transform<String>(utf8.decoder)
|
|
.transform<String>(const LineSplitter())
|
|
.listen(onStdout, onDone: stdoutDone.complete);
|
|
|
|
process.stderr
|
|
.transform<String>(utf8.decoder)
|
|
.transform<String>(const LineSplitter())
|
|
.listen((String line) => print('stderr: $line'), onDone: stderrDone.complete);
|
|
|
|
await Future.wait<void>(<Future<void>>[stdoutDone.future, stderrDone.future]);
|
|
return process.exitCode;
|
|
}
|