Mikhail Novoseltsev b8902e6a17 [tool] Allow using archiveName in android bundle build (#162390) ... fixes #126971 Also, for some reason, fixes #147261 , which shouldn't have been ever broken since this case tested here: b007899d3a/packages/flutter_tools/test/general.shard/android/gradle_find_bundle_test.dart (L153-L173) <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Key change here is replacing the optimistic approach of guessing the filename based on buildInfo parameters with the actual discovery of built artifacts on the filesystem. This change is needed because there is no way the build can determine the archiveName from Gradle, which differentiates this part from other parameters such as buildType and flavor. Flutter build contains information about them, but not about the base name. <img width="673" alt="Screenshot 2025-01-29 at 22 42 29" src="https://github.com/user-attachments/assets/ab530a00-031f-48e2-962c-ed010b4009c9" /> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com> Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Reid Baker <reidbaker@google.com>		2025-02-28 14:57:20 +00:00
..
src	[tool] Allow using archiveName in android bundle build (#162390)	2025-02-28 14:57:20 +00:00
executable.dart	Align web terminal messages with the VM (#163268)	2025-02-14 19:57:53 +00:00
runner.dart	Auto-format Framework (#160545)	2024-12-19 20:06:21 +00:00