mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
c759c22e71
There are two issues in the previous implementation: 1. `_populateDevices` will return the devices from `deviceNotifier` if it had been initialized, assuming that once it's initialized, it has been properly populated. That assumption is not true because calling getters like `onAdded` would initialize `deviceNotifier` without populating it. 2. `deviceNotifier` instance might be replaced in some cases, causing `onAdded` subscribers to lose any future updates. To fix (1), this commit added the `isPopulated` field in `deviceNotifier` as a more accurate flag to determine if we need to populate it. To fix (2), this commit made `deviceNotifier` a final member in `PolingDeviceDiscovery`.
63 lines
2.1 KiB
Dart
63 lines
2.1 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter_tools/src/base/utils.dart';
|
|
|
|
import '../src/common.dart';
|
|
|
|
void main() {
|
|
group('ItemListNotifier', () {
|
|
test('sends notifications', () async {
|
|
final ItemListNotifier<String> list = ItemListNotifier<String>();
|
|
expect(list.items, isEmpty);
|
|
|
|
final Future<List<String>> addedStreamItems = list.onAdded.toList();
|
|
final Future<List<String>> removedStreamItems = list.onRemoved.toList();
|
|
|
|
list.updateWithNewList(<String>['aaa']);
|
|
list.removeItem('bogus');
|
|
list.updateWithNewList(<String>['aaa', 'bbb', 'ccc']);
|
|
list.updateWithNewList(<String>['bbb', 'ccc']);
|
|
list.removeItem('bbb');
|
|
|
|
expect(list.items, <String>['ccc']);
|
|
list.dispose();
|
|
|
|
final List<String> addedItems = await addedStreamItems;
|
|
final List<String> removedItems = await removedStreamItems;
|
|
|
|
expect(addedItems.length, 3);
|
|
expect(addedItems.first, 'aaa');
|
|
expect(addedItems[1], 'bbb');
|
|
expect(addedItems[2], 'ccc');
|
|
|
|
expect(removedItems.length, 2);
|
|
expect(removedItems.first, 'aaa');
|
|
expect(removedItems[1], 'bbb');
|
|
});
|
|
|
|
test('becomes populated when item is added', () async {
|
|
final ItemListNotifier<String> list = ItemListNotifier<String>();
|
|
expect(list.isPopulated, false);
|
|
expect(list.items, isEmpty);
|
|
|
|
// Becomes populated when a new list is added.
|
|
list.updateWithNewList(<String>['a']);
|
|
expect(list.isPopulated, true);
|
|
expect(list.items, <String>['a']);
|
|
|
|
// Remain populated even when the last item is removed.
|
|
list.removeItem('a');
|
|
expect(list.isPopulated, true);
|
|
expect(list.items, isEmpty);
|
|
});
|
|
|
|
test('is populated by default if initialized with list of items', () async {
|
|
final ItemListNotifier<String> list = ItemListNotifier<String>.from(<String>['a']);
|
|
expect(list.isPopulated, true);
|
|
expect(list.items, <String>['a']);
|
|
});
|
|
});
|
|
}
|