mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

https://github.com/flutter/flutter/issues/123917 Doc covering a broad set of issues related to android studio updating. https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1# Specifically this pr: - Adds new functions to find a projects AGP, Gradle and java versions, and tests. - Adds new functions that take versions and parse if the versions are compatible with each other, and tests. - Adds validator for `flutter analyze --suggestions` that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test. - Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11) - Moves `isWithinVersionRange` to version.dart, and tests. - Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies. Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big. Known work still left in this pr: * Understand why analyze integration tests are failing. Example output if Java and gradle are not compatible: ``` ┌───────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information. │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └───────────────────────────────────────────────────────────────────┘ ``` Example output if Gradle and AGP are not compatible ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Example output if Java/Gradle/Agp are not compatible. ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Commit messages - Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation - Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation. - Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false - Fill out and test java gradle compatibility function in gradle_utils - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version - Add java --version output parsing and tests - Add getJavaBinary test - Update comment in android_sdk for mac behavior with java_home -v ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.
400 lines
14 KiB
Dart
400 lines
14 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter_tools/src/base/terminal.dart';
|
|
import 'package:flutter_tools/src/base/utils.dart';
|
|
import 'package:flutter_tools/src/base/version.dart';
|
|
|
|
import '../src/common.dart';
|
|
|
|
void main() {
|
|
group('SettingsFile', () {
|
|
testWithoutContext('parse', () {
|
|
final SettingsFile file = SettingsFile.parse('''
|
|
# ignore comment
|
|
foo=bar
|
|
baz=qux
|
|
''');
|
|
expect(file.values['foo'], 'bar');
|
|
expect(file.values['baz'], 'qux');
|
|
expect(file.values, hasLength(2));
|
|
});
|
|
});
|
|
|
|
group('Version', () {
|
|
testWithoutContext('can parse and compare', () {
|
|
expect(Version.unknown.toString(), equals('unknown'));
|
|
expect(Version(null, null, null).toString(), equals('0'));
|
|
expect(const Version.withText(1, 2, 3, 'versionText').toString(), 'versionText');
|
|
|
|
final Version v1 = Version.parse('1')!;
|
|
expect(v1.major, equals(1));
|
|
expect(v1.minor, equals(0));
|
|
expect(v1.patch, equals(0));
|
|
|
|
expect(v1, greaterThan(Version.unknown));
|
|
|
|
final Version v2 = Version.parse('1.2')!;
|
|
expect(v2.major, equals(1));
|
|
expect(v2.minor, equals(2));
|
|
expect(v2.patch, equals(0));
|
|
|
|
final Version v3 = Version.parse('1.2.3')!;
|
|
expect(v3.major, equals(1));
|
|
expect(v3.minor, equals(2));
|
|
expect(v3.patch, equals(3));
|
|
|
|
final Version v4 = Version.parse('1.12')!;
|
|
expect(v4, greaterThan(v2));
|
|
|
|
expect(v3, greaterThan(v2));
|
|
expect(v2, greaterThan(v1));
|
|
|
|
final Version v5 = Version(1, 2, 0, text: 'foo');
|
|
expect(v5, equals(v2));
|
|
|
|
expect(Version.parse('Preview2.2'), isNull);
|
|
});
|
|
|
|
group('isWithinVersionRange', () {
|
|
test('unknown not included', () {
|
|
expect(isWithinVersionRange('unknown', min: '1.0.0', max: '1.1.3'),
|
|
isFalse);
|
|
});
|
|
|
|
test('pre java 8 format included', () {
|
|
expect(isWithinVersionRange('1.0.0_201', min: '1.0.0', max: '1.1.3'),
|
|
isTrue);
|
|
});
|
|
|
|
test('min included by default', () {
|
|
expect(
|
|
isWithinVersionRange('1.0.0', min: '1.0.0', max: '1.1.3'), isTrue);
|
|
});
|
|
|
|
test('max included by default', () {
|
|
expect(
|
|
isWithinVersionRange('1.1.3', min: '1.0.0', max: '1.1.3'), isTrue);
|
|
});
|
|
|
|
test('inclusive min excluded', () {
|
|
expect(
|
|
isWithinVersionRange('1.0.0',
|
|
min: '1.0.0', max: '1.1.3', inclusiveMin: false),
|
|
isFalse);
|
|
});
|
|
|
|
test('inclusive max excluded', () {
|
|
expect(
|
|
isWithinVersionRange('1.1.3',
|
|
min: '1.0.0', max: '1.1.3', inclusiveMax: false),
|
|
isFalse);
|
|
});
|
|
|
|
test('lower value excluded', () {
|
|
expect(
|
|
isWithinVersionRange('0.1.0', min: '1.0.0', max: '1.1.3'), isFalse);
|
|
});
|
|
|
|
test('higher value excluded', () {
|
|
expect(
|
|
isWithinVersionRange('1.1.4', min: '1.0.0', max: '1.1.3'), isFalse);
|
|
});
|
|
|
|
test('middle value included', () {
|
|
expect(
|
|
isWithinVersionRange('1.1.0', min: '1.0.0', max: '1.1.3'), isTrue);
|
|
});
|
|
});
|
|
});
|
|
|
|
group('Misc', () {
|
|
testWithoutContext('snakeCase', () async {
|
|
expect(snakeCase('abc'), equals('abc'));
|
|
expect(snakeCase('abC'), equals('ab_c'));
|
|
expect(snakeCase('aBc'), equals('a_bc'));
|
|
expect(snakeCase('aBC'), equals('a_b_c'));
|
|
expect(snakeCase('Abc'), equals('abc'));
|
|
expect(snakeCase('AbC'), equals('ab_c'));
|
|
expect(snakeCase('ABc'), equals('a_bc'));
|
|
expect(snakeCase('ABC'), equals('a_b_c'));
|
|
});
|
|
|
|
testWithoutContext('sentenceCase', () async {
|
|
expect(sentenceCase('abc'), equals('Abc'));
|
|
expect(sentenceCase('ab_c'), equals('Ab_c'));
|
|
expect(sentenceCase('a b c'), equals('A b c'));
|
|
expect(sentenceCase('a B c'), equals('A B c'));
|
|
expect(sentenceCase('Abc'), equals('Abc'));
|
|
expect(sentenceCase('ab_c'), equals('Ab_c'));
|
|
expect(sentenceCase('a_bc'), equals('A_bc'));
|
|
expect(sentenceCase('a_b_c'), equals('A_b_c'));
|
|
});
|
|
|
|
testWithoutContext('snakeCaseToTitleCase', () async {
|
|
expect(snakeCaseToTitleCase('abc'), equals('Abc'));
|
|
expect(snakeCaseToTitleCase('ab_c'), equals('Ab C'));
|
|
expect(snakeCaseToTitleCase('a_b_c'), equals('A B C'));
|
|
expect(snakeCaseToTitleCase('a_B_c'), equals('A B C'));
|
|
expect(snakeCaseToTitleCase('Abc'), equals('Abc'));
|
|
expect(snakeCaseToTitleCase('ab_c'), equals('Ab C'));
|
|
expect(snakeCaseToTitleCase('a_bc'), equals('A Bc'));
|
|
expect(snakeCaseToTitleCase('a_b_c'), equals('A B C'));
|
|
});
|
|
});
|
|
|
|
group('text wrapping', () {
|
|
const int lineLength = 40;
|
|
const String longLine = 'This is a long line that needs to be wrapped.';
|
|
final String longLineWithNewlines = 'This is a long line with newlines that\n'
|
|
'needs to be wrapped.\n\n'
|
|
'${'0123456789' * 5}';
|
|
final String longAnsiLineWithNewlines = '${AnsiTerminal.red}This${AnsiTerminal.resetAll} is a long line with newlines that\n'
|
|
'needs to be wrapped.\n\n'
|
|
'${AnsiTerminal.green}0123456789${AnsiTerminal.resetAll}'
|
|
'${'0123456789' * 3}'
|
|
'${AnsiTerminal.green}0123456789${AnsiTerminal.resetAll}';
|
|
const String onlyAnsiSequences = '${AnsiTerminal.red}${AnsiTerminal.resetAll}';
|
|
final String indentedLongLineWithNewlines = ' This is an indented long line with newlines that\n'
|
|
'needs to be wrapped.\n\tAnd preserves tabs.\n \n '
|
|
'${'0123456789' * 5}';
|
|
const String shortLine = 'Short line.';
|
|
const String indentedLongLine = ' This is an indented long line that needs to be '
|
|
'wrapped and indentation preserved.';
|
|
testWithoutContext('does not wrap by default in tests', () {
|
|
expect(wrapText(longLine, columnWidth: 80, shouldWrap: true), equals(longLine));
|
|
});
|
|
|
|
testWithoutContext('can override wrap preference if preference is off', () {
|
|
expect(wrapText(longLine, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is a long line that needs to be
|
|
wrapped.'''));
|
|
});
|
|
|
|
testWithoutContext('can override wrap preference if preference is on', () {
|
|
expect(wrapText(longLine, shouldWrap: false, columnWidth: 80), equals(longLine));
|
|
});
|
|
|
|
testWithoutContext('does not wrap at all if not told to wrap', () {
|
|
expect(wrapText(longLine, columnWidth: 80, shouldWrap: false), equals(longLine));
|
|
});
|
|
|
|
testWithoutContext('does not wrap short lines.', () {
|
|
expect(wrapText(shortLine, columnWidth: lineLength, shouldWrap: true), equals(shortLine));
|
|
});
|
|
|
|
testWithoutContext('able to wrap long lines', () {
|
|
expect(wrapText(longLine, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is a long line that needs to be
|
|
wrapped.'''));
|
|
});
|
|
|
|
testWithoutContext('able to handle dynamically changing terminal column size', () {
|
|
expect(wrapText(longLine, columnWidth: 20, shouldWrap: true), equals('''
|
|
This is a long line
|
|
that needs to be
|
|
wrapped.'''));
|
|
|
|
expect(wrapText(longLine, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is a long line that needs to be
|
|
wrapped.'''));
|
|
});
|
|
|
|
testWithoutContext('wrap long lines with no whitespace', () {
|
|
expect(wrapText('0123456789' * 5, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
0123456789012345678901234567890123456789
|
|
0123456789'''));
|
|
});
|
|
|
|
testWithoutContext('refuses to wrap to a column smaller than 10 characters', () {
|
|
expect(wrapText('$longLine ${'0123456789' * 4}', columnWidth: 1, shouldWrap: true), equals('''
|
|
This is a
|
|
long line
|
|
that needs
|
|
to be
|
|
wrapped.
|
|
0123456789
|
|
0123456789
|
|
0123456789
|
|
0123456789'''));
|
|
});
|
|
testWithoutContext('preserves indentation', () {
|
|
expect(wrapText(indentedLongLine, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is an indented long line that
|
|
needs to be wrapped and indentation
|
|
preserved.'''));
|
|
});
|
|
|
|
testWithoutContext('preserves indentation and stripping trailing whitespace', () {
|
|
expect(wrapText('$indentedLongLine ', columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is an indented long line that
|
|
needs to be wrapped and indentation
|
|
preserved.'''));
|
|
});
|
|
|
|
testWithoutContext('wraps text with newlines', () {
|
|
expect(wrapText(longLineWithNewlines, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is a long line with newlines that
|
|
needs to be wrapped.
|
|
|
|
0123456789012345678901234567890123456789
|
|
0123456789'''));
|
|
});
|
|
|
|
testWithoutContext('wraps text with ANSI sequences embedded', () {
|
|
expect(wrapText(longAnsiLineWithNewlines, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
${AnsiTerminal.red}This${AnsiTerminal.resetAll} is a long line with newlines that
|
|
needs to be wrapped.
|
|
|
|
${AnsiTerminal.green}0123456789${AnsiTerminal.resetAll}012345678901234567890123456789
|
|
${AnsiTerminal.green}0123456789${AnsiTerminal.resetAll}'''));
|
|
});
|
|
|
|
testWithoutContext('wraps text with only ANSI sequences', () {
|
|
expect(wrapText(onlyAnsiSequences, columnWidth: lineLength, shouldWrap: true),
|
|
equals('${AnsiTerminal.red}${AnsiTerminal.resetAll}'));
|
|
});
|
|
|
|
testWithoutContext('preserves indentation in the presence of newlines', () {
|
|
expect(wrapText(indentedLongLineWithNewlines, columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is an indented long line with
|
|
newlines that
|
|
needs to be wrapped.
|
|
\tAnd preserves tabs.
|
|
|
|
01234567890123456789012345678901234567
|
|
890123456789'''));
|
|
});
|
|
|
|
testWithoutContext('removes trailing whitespace when wrapping', () {
|
|
expect(wrapText('$longLine \t', columnWidth: lineLength, shouldWrap: true), equals('''
|
|
This is a long line that needs to be
|
|
wrapped.'''));
|
|
});
|
|
|
|
testWithoutContext('honors hangingIndent parameter', () {
|
|
expect(wrapText(longLine, columnWidth: lineLength, hangingIndent: 6, shouldWrap: true), equals('''
|
|
This is a long line that needs to be
|
|
wrapped.'''));
|
|
});
|
|
|
|
testWithoutContext('handles hangingIndent with a single unwrapped line.', () {
|
|
expect(wrapText(shortLine, columnWidth: lineLength, hangingIndent: 6, shouldWrap: true), equals('''
|
|
Short line.'''));
|
|
});
|
|
|
|
testWithoutContext('handles hangingIndent with two unwrapped lines and the second is empty.', () {
|
|
expect(wrapText('$shortLine\n', columnWidth: lineLength, hangingIndent: 6, shouldWrap: true), equals('''
|
|
Short line.
|
|
'''));
|
|
});
|
|
|
|
testWithoutContext('honors hangingIndent parameter on already indented line.', () {
|
|
expect(wrapText(indentedLongLine, columnWidth: lineLength, hangingIndent: 6, shouldWrap: true), equals('''
|
|
This is an indented long line that
|
|
needs to be wrapped and
|
|
indentation preserved.'''));
|
|
});
|
|
|
|
testWithoutContext('honors hangingIndent and indent parameters at the same time.', () {
|
|
expect(wrapText(indentedLongLine, columnWidth: lineLength, indent: 6, hangingIndent: 6, shouldWrap: true), equals('''
|
|
This is an indented long line
|
|
that needs to be wrapped
|
|
and indentation
|
|
preserved.'''));
|
|
});
|
|
|
|
testWithoutContext('honors indent parameter on already indented line.', () {
|
|
expect(wrapText(indentedLongLine, columnWidth: lineLength, indent: 6, shouldWrap: true), equals('''
|
|
This is an indented long line
|
|
that needs to be wrapped and
|
|
indentation preserved.'''));
|
|
});
|
|
|
|
testWithoutContext('honors hangingIndent parameter on already indented line.', () {
|
|
expect(wrapText(indentedLongLineWithNewlines, columnWidth: lineLength, hangingIndent: 6, shouldWrap: true), equals('''
|
|
This is an indented long line with
|
|
newlines that
|
|
needs to be wrapped.
|
|
And preserves tabs.
|
|
|
|
01234567890123456789012345678901234567
|
|
890123456789'''));
|
|
});
|
|
|
|
testWithoutContext('', () {
|
|
expect(wrapText(
|
|
'${' ' * 7}abc def ghi', columnWidth: 20, hangingIndent: 5, indent: 3, shouldWrap: true),
|
|
equals(
|
|
' abc def\n'
|
|
' ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi', columnWidth: 0, hangingIndent: 5, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi', columnWidth: 0, indent: 5, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
' abc def ghi', columnWidth: 0, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi', columnWidth: kMinColumnWidth - 2, hangingIndent: 5, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi', columnWidth: kMinColumnWidth - 2, indent: 5, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
' abc def ghi', columnWidth: kMinColumnWidth - 2, shouldWrap: true),
|
|
equals(
|
|
'abc def\n'
|
|
'ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi jkl', columnWidth: kMinColumnWidth + 2, hangingIndent: 5, shouldWrap: true),
|
|
equals(
|
|
'abc def ghi\n'
|
|
' jkl'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
'abc def ghi', columnWidth: kMinColumnWidth + 2, indent: 5, shouldWrap: true),
|
|
equals(
|
|
' abc def\n'
|
|
' ghi'
|
|
),
|
|
);
|
|
expect(wrapText(
|
|
' abc def ghi', columnWidth: kMinColumnWidth + 2, shouldWrap: true),
|
|
equals(
|
|
' abc def\n'
|
|
' ghi'
|
|
),
|
|
);
|
|
});
|
|
});
|
|
}
|