github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
ca5aa2329a
flutter/dev/tools
History
Taha Tesser ca5aa2329a
Update ListTile text defaults to use ColorScheme (#128581) 
fixes https://github.com/flutter/flutter/issues/128569

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const ListTileApp());
}

class ListTileApp extends StatelessWidget {
  const ListTileApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
      ),
      home: const Scaffold(
        body: Center(
          child: ListTile(
            title: Text('title'),
            subtitle: Text('subtitle'),
          ),
        ),
      ),
    );
  }
}

``` 
	
</details>

# Description
M3 ListTile couldn't be customized using `ColorScheme` colors. 

- This PR updates the list tile text defaults to `ColorScheme` text color tokens.
- Improved the `ListTile` template to use the token group.
- Update docs and tests.

```dart
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
```

### Before

![Screenshot 2023-06-09 at 17 47 04](https://github.com/flutter/flutter/assets/48603081/c0130371-3c7c-428c-bb57-504822cf64b5)

### After

![Screenshot 2023-06-09 at 17 46 17](https://github.com/flutter/flutter/assets/48603081/3b4d6f8c-7fdd-4546-a6f0-00dd34cb5a96)
2023-06-12 14:52:06 +00:00
..
bin Fix Gradle warning in a freshly flutter createed Android project (#122290) 2023-03-21 23:41:49 +00:00
gen_defaults Update ListTile text defaults to use ColorScheme (#128581) 2023-06-12 14:52:06 +00:00
gen_keycodes Reland "Migrate benchmarks to package:web" (#128266) 2023-06-08 22:25:40 +00:00
localization Fix gen_date_localizations script and regenerate (#124547) 2023-04-11 16:54:54 -07:00
test Refactor icon update script (#122392) 2023-03-13 22:17:35 +01:00
vitool Reland "Migrate benchmarks to package:web" (#128266) 2023-06-08 22:25:40 +00:00
.gitignore [flutter_conductor] update dev/tools with release tool (#69791) 2020-11-06 11:14:04 -08:00
dartdoc_checker.dart Migrate dartdoc to null safety (#84153) 2021-06-07 17:09:03 -07:00
dartdoc.dart Remove null-safety argument from DartPad doc samples (#127345) 2023-05-23 00:10:11 +00:00
examples_smoke_test.dart Fix bug thattimeDilation is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (#113830) 2022-11-01 22:50:00 +00:00
find_engine_commit.dart begin migrating //flutter/dev/tools to null-safety (#80834) 2021-04-23 20:24:03 -07:00
java_and_objc_doc.dart Copy doc files from new to old location. (#109316) 2022-08-10 17:14:07 +00:00
mega_gallery.dart Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
pubspec.yaml Reland "Migrate benchmarks to package:web" (#128266) 2023-06-08 22:25:40 +00:00
repackage_gradle_wrapper.sh Point to a new artifacts location. (#70673) 2021-02-04 18:44:47 -08:00
update_icons.dart Refactor icon update script (#122392) 2023-03-13 22:17:35 +01:00