flutter/dev/manual_tests
Loïc Sharma ce61eda70c
[Windows] Ensure window is shown (#127046)
## Background

The Windows runner has a race at startup:

1. **Platform thread**: creates a hidden window
2. **Platform thread**: launches the Flutter engine
3. **UI/Raster threads**: renders the first frame
4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered.

Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown.

As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](1f09a8662d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp (L60-L64)), can flake if the first frame is rendered before the show window callback has been registered.

## Solution

This change makes the runner schedule a frame after it registers the next frame callback. If step 3 hasn't completed yet, this no-ops as a frame is already scheduled. If step 3 has already completed, a new frame will be rendered, which will call the next frame callback and show the window.

Part of https://github.com/flutter/flutter/issues/119415

See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
2023-05-19 22:25:55 +00:00
..
android [Reland] Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#125836) 2023-05-03 21:00:06 +00:00
ios Migrate Xcode projects last version checks to Xcode 14.3 (#125827) 2023-05-02 00:06:33 +00:00
lib Remove 1745 decorative breaks (#123259) 2023-03-22 21:12:22 +00:00
linux Update repo generated_plugins.cmake (#98034) 2022-02-09 15:15:27 +01:00
macos Migrate Xcode projects last version checks to Xcode 14.3 (#125827) 2023-05-02 00:06:33 +00:00
test Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
web Update platform shims in dev/manual_tests (#94616) 2022-01-07 12:16:24 -08:00
windows [Windows] Ensure window is shown (#127046) 2023-05-19 22:25:55 +00:00
.gitignore Check in manual_tests gitignores (#71761) 2020-12-04 19:31:05 -08:00
.metadata Update manual_tests to be able to run on macOS/web (#44830) 2019-11-19 11:29:35 -08:00
pubspec.yaml Upgrade leak_tracker to 5.0.0 (#126367) 2023-05-16 04:39:26 +00:00