mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides. This allows removing a work around where web devices needed to look up directly from the context in non-test code. Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
239 lines
7.2 KiB
Dart
239 lines
7.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/runner.dart' as runner;
|
|
import 'package:flutter_tools/src/base/common.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/io.dart' as io;
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/base/user_messages.dart';
|
|
import 'package:flutter_tools/src/cache.dart';
|
|
import 'package:flutter_tools/src/globals.dart' as globals;
|
|
import 'package:flutter_tools/src/reporting/reporting.dart';
|
|
import 'package:flutter_tools/src/runner/flutter_command.dart';
|
|
import 'package:mockito/mockito.dart';
|
|
|
|
import '../../src/common.dart';
|
|
import '../../src/context.dart';
|
|
|
|
const String kCustomBugInstructions = 'These are instructions to report with a custom bug tracker.';
|
|
|
|
void main() {
|
|
group('runner', () {
|
|
setUp(() {
|
|
// Instead of exiting with dart:io exit(), this causes an exception to
|
|
// be thrown, which we catch with the onError callback in the zone below.
|
|
io.setExitFunctionForTests((int _) { throw 'test exit';});
|
|
Cache.disableLocking();
|
|
});
|
|
|
|
tearDown(() {
|
|
io.restoreExitFunction();
|
|
Cache.enableLocking();
|
|
});
|
|
|
|
testUsingContext('error handling crash report', () async {
|
|
final Completer<void> completer = Completer<void>();
|
|
// runner.run() asynchronously calls the exit function set above, so we
|
|
// catch it in a zone.
|
|
unawaited(runZoned<Future<void>>(
|
|
() {
|
|
unawaited(runner.run(
|
|
<String>['test'],
|
|
() => <FlutterCommand>[
|
|
CrashingFlutterCommand(),
|
|
],
|
|
// This flutterVersion disables crash reporting.
|
|
flutterVersion: '[user-branch]/',
|
|
reportCrashes: true,
|
|
));
|
|
return null;
|
|
},
|
|
onError: (Object error, StackTrace stack) { // ignore: deprecated_member_use
|
|
expect(error, 'test exit');
|
|
completer.complete();
|
|
},
|
|
));
|
|
await completer.future;
|
|
|
|
// This is the main check of this test.
|
|
//
|
|
// We are checking that, even though crash reporting failed with an
|
|
// exception on the first attempt, the second attempt tries to report the
|
|
// *original* crash, and not the crash from the first crash report
|
|
// attempt.
|
|
final CrashingUsage crashingUsage = globals.flutterUsage as CrashingUsage;
|
|
expect(crashingUsage.sentException, 'an exception % --');
|
|
}, overrides: <Type, Generator>{
|
|
Platform: () => FakePlatform(environment: <String, String>{
|
|
'FLUTTER_ANALYTICS_LOG_FILE': 'test',
|
|
'FLUTTER_ROOT': '/',
|
|
}),
|
|
FileSystem: () => MemoryFileSystem(),
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
Usage: () => CrashingUsage(),
|
|
});
|
|
|
|
testUsingContext('create local report', () async {
|
|
final Completer<void> completer = Completer<void>();
|
|
// runner.run() asynchronously calls the exit function set above, so we
|
|
// catch it in a zone.
|
|
unawaited(runZoned<Future<void>>(
|
|
() {
|
|
unawaited(runner.run(
|
|
<String>['test'],
|
|
() => <FlutterCommand>[
|
|
CrashingFlutterCommand(),
|
|
],
|
|
// This flutterVersion disables crash reporting.
|
|
flutterVersion: '[user-branch]/',
|
|
reportCrashes: true,
|
|
));
|
|
return null;
|
|
},
|
|
onError: (Object error, StackTrace stack) { // ignore: deprecated_member_use
|
|
expect(error, 'test exit');
|
|
completer.complete();
|
|
},
|
|
));
|
|
await completer.future;
|
|
|
|
final String errorText = testLogger.errorText;
|
|
expect(
|
|
errorText,
|
|
containsIgnoringWhitespace('Oops; flutter has exited unexpectedly: "an exception % --".\n'),
|
|
);
|
|
|
|
final File log = globals.fs.file('/flutter_01.log');
|
|
final String logContents = log.readAsStringSync();
|
|
expect(logContents, contains(kCustomBugInstructions));
|
|
expect(logContents, contains('flutter test'));
|
|
expect(logContents, contains('String: an exception % --'));
|
|
expect(logContents, contains('CrashingFlutterCommand.runCommand'));
|
|
expect(logContents, contains('[✓] Flutter'));
|
|
|
|
final VerificationResult argVerification = verify(globals.crashReporter.informUser(captureAny, any));
|
|
final CrashDetails sentDetails = argVerification.captured.first as CrashDetails;
|
|
expect(sentDetails.command, 'flutter test');
|
|
expect(sentDetails.error, 'an exception % --');
|
|
expect(sentDetails.stackTrace.toString(), contains('CrashingFlutterCommand.runCommand'));
|
|
expect(sentDetails.doctorText, contains('[✓] Flutter'));
|
|
}, overrides: <Type, Generator>{
|
|
Platform: () => FakePlatform(
|
|
environment: <String, String>{
|
|
'FLUTTER_ANALYTICS_LOG_FILE': 'test',
|
|
'FLUTTER_ROOT': '/',
|
|
},
|
|
operatingSystem: 'linux'
|
|
),
|
|
FileSystem: () => MemoryFileSystem(),
|
|
ProcessManager: () => FakeProcessManager.any(),
|
|
UserMessages: () => CustomBugInstructions(),
|
|
});
|
|
});
|
|
}
|
|
|
|
class CrashingFlutterCommand extends FlutterCommand {
|
|
@override
|
|
String get description => null;
|
|
|
|
@override
|
|
String get name => 'test';
|
|
|
|
@override
|
|
Future<FlutterCommandResult> runCommand() async {
|
|
throw 'an exception % --'; // Test URL encoding.
|
|
}
|
|
}
|
|
|
|
class CrashingUsage implements Usage {
|
|
CrashingUsage() : _impl = Usage(
|
|
versionOverride: '[user-branch]',
|
|
runningOnBot: true,
|
|
);
|
|
|
|
final Usage _impl;
|
|
|
|
dynamic get sentException => _sentException;
|
|
dynamic _sentException;
|
|
|
|
bool _firstAttempt = true;
|
|
|
|
// Crash while crashing.
|
|
@override
|
|
void sendException(dynamic exception) {
|
|
if (_firstAttempt) {
|
|
_firstAttempt = false;
|
|
throw 'sendException';
|
|
}
|
|
_sentException = exception;
|
|
}
|
|
|
|
@override
|
|
bool get isFirstRun => _impl.isFirstRun;
|
|
|
|
@override
|
|
bool get suppressAnalytics => _impl.suppressAnalytics;
|
|
|
|
@override
|
|
set suppressAnalytics(bool value) {
|
|
_impl.suppressAnalytics = value;
|
|
}
|
|
|
|
@override
|
|
bool get enabled => _impl.enabled;
|
|
|
|
@override
|
|
set enabled(bool value) {
|
|
_impl.enabled = value;
|
|
}
|
|
|
|
@override
|
|
String get clientId => _impl.clientId;
|
|
|
|
@override
|
|
void sendCommand(String command, {Map<String, String> parameters}) =>
|
|
_impl.sendCommand(command, parameters: parameters);
|
|
|
|
@override
|
|
void sendEvent(
|
|
String category,
|
|
String parameter, {
|
|
String label,
|
|
int value,
|
|
Map<String, String> parameters,
|
|
}) => _impl.sendEvent(
|
|
category,
|
|
parameter,
|
|
label: label,
|
|
value: value,
|
|
parameters: parameters,
|
|
);
|
|
|
|
@override
|
|
void sendTiming(
|
|
String category,
|
|
String variableName,
|
|
Duration duration, {
|
|
String label,
|
|
}) => _impl.sendTiming(category, variableName, duration, label: label);
|
|
|
|
@override
|
|
Stream<Map<String, dynamic>> get onSend => _impl.onSend;
|
|
|
|
@override
|
|
Future<void> ensureAnalyticsSent() => _impl.ensureAnalyticsSent();
|
|
|
|
@override
|
|
void printWelcome() => _impl.printWelcome();
|
|
}
|
|
|
|
class CustomBugInstructions extends UserMessages {
|
|
@override
|
|
String get flutterToolBugInstructions => kCustomBugInstructions;
|
|
}
|