mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
3750beacb4
Updates the platform shims in dev/manual_tests so that Windows and Linux can be built. I had to update the Windows shims, because I was unable to build a Windows app there. Also updates the analyze.dart script to report all license issues simultaneously instead of just dying after the first failure. The only substantive code changes are in dev/bots/analyze.dart and dev/bots/test/analyze_test.dart
210 lines
12 KiB
Dart
210 lines
12 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
|
|
import 'package:path/path.dart' as path;
|
|
|
|
import '../analyze.dart';
|
|
import '../utils.dart';
|
|
import 'common.dart';
|
|
|
|
typedef AsyncVoidCallback = Future<void> Function();
|
|
|
|
Future<String> capture(AsyncVoidCallback callback, { int exitCode = 0 }) async {
|
|
final StringBuffer buffer = StringBuffer();
|
|
final PrintCallback oldPrint = print;
|
|
try {
|
|
print = (Object line) {
|
|
buffer.writeln(line);
|
|
};
|
|
try {
|
|
await callback();
|
|
expect(exitCode, 0);
|
|
} on ExitException catch (error) {
|
|
expect(error.exitCode, exitCode);
|
|
}
|
|
} finally {
|
|
print = oldPrint;
|
|
}
|
|
if (stdout.supportsAnsiEscapes) {
|
|
// Remove ANSI escapes when this test is running on a terminal.
|
|
return buffer.toString().replaceAll(RegExp(r'(\x9B|\x1B\[)[0-?]{1,3}[ -/]*[@-~]'), '');
|
|
} else {
|
|
return buffer.toString();
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
final String testRootPath = path.join('test', 'analyze-test-input', 'root');
|
|
final String dartName = Platform.isWindows ? 'dart.exe' : 'dart';
|
|
final String dartPath = path.canonicalize(path.join('..', '..', 'bin', 'cache', 'dart-sdk', 'bin', dartName));
|
|
|
|
test('analyze.dart - verifyDeprecations', () async {
|
|
final String result = await capture(() => verifyDeprecations(testRootPath, minimumMatches: 2), exitCode: 1);
|
|
final String lines = <String>[
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:12: Deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:18: Deprecation notice should be a grammatically correct sentence and start with a capital letter; see style guide: STYLE_GUIDE_URL',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:25: Deprecation notice should be a grammatically correct sentence and end with a period.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:29: Deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:32: Deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:37: Deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:41: Deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:48: End of deprecation notice does not match required pattern.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:51: Unexpected deprecation notice indent.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:70: Deprecation notice does not accurately indicate a dev branch version number; please see RELEASES_URL to find the latest dev build version number.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:76: Deprecation notice does not accurately indicate a dev branch version number; please see RELEASES_URL to find the latest dev build version number.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:82: Deprecation notice does not accurately indicate a dev branch version number; please see RELEASES_URL to find the latest dev build version number.',
|
|
'test/analyze-test-input/root/packages/foo/deprecation.dart:99: Deprecation notice does not match required pattern. You might have used double quotes (") for the string instead of single quotes (\').',
|
|
]
|
|
.map((String line) {
|
|
return line
|
|
.replaceAll('/', Platform.isWindows ? r'\' : '/')
|
|
.replaceAll('STYLE_GUIDE_URL', 'https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo')
|
|
.replaceAll('RELEASES_URL', 'https://flutter.dev/docs/development/tools/sdk/releases');
|
|
})
|
|
.join('\n');
|
|
expect(result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'$lines\n'
|
|
'See: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
});
|
|
|
|
test('analyze.dart - verifyGoldenTags', () async {
|
|
final String result = await capture(() => verifyGoldenTags(testRootPath, minimumMatches: 6), exitCode: 1);
|
|
const String noTag = 'Files containing golden tests must be '
|
|
'tagged using `@Tags(...)` at the top of the file before import statements.';
|
|
const String missingTag = 'Files containing golden tests must be '
|
|
"tagged with 'reduced-test-set'.";
|
|
String lines = <String>[
|
|
'test/analyze-test-input/root/packages/foo/golden_missing_tag.dart: $missingTag',
|
|
'test/analyze-test-input/root/packages/foo/golden_no_tag.dart: $noTag',
|
|
]
|
|
.map((String line) {
|
|
return line
|
|
.replaceAll('/', Platform.isWindows ? r'\' : '/');
|
|
})
|
|
.join('\n');
|
|
|
|
try {
|
|
expect(
|
|
result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'$lines\n'
|
|
'See: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
} catch (_) {
|
|
// This list of files may come up in one order or the other.
|
|
lines = <String>[
|
|
'test/analyze-test-input/root/packages/foo/golden_no_tag.dart: $noTag',
|
|
'test/analyze-test-input/root/packages/foo/golden_missing_tag.dart: $missingTag',
|
|
]
|
|
.map((String line) {
|
|
return line
|
|
.replaceAll('/', Platform.isWindows ? r'\' : '/');
|
|
})
|
|
.join('\n');
|
|
expect(
|
|
result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'$lines\n'
|
|
'See: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
}
|
|
});
|
|
|
|
test('analyze.dart - verifyNoMissingLicense', () async {
|
|
final String result = await capture(() => verifyNoMissingLicense(testRootPath, checkMinimums: false), exitCode: 1);
|
|
final String file = 'test/analyze-test-input/root/packages/foo/foo.dart'
|
|
.replaceAll('/', Platform.isWindows ? r'\' : '/');
|
|
expect(result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'The following file does not have the right license header for dart files:\n'
|
|
' $file\n'
|
|
'The expected license header is:\n'
|
|
'// Copyright 2014 The Flutter Authors. All rights reserved.\n'
|
|
'// Use of this source code is governed by a BSD-style license that can be\n'
|
|
'// found in the LICENSE file.\n'
|
|
'...followed by a blank line.\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'License check failed.\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
});
|
|
|
|
test('analyze.dart - verifyNoTrailingSpaces', () async {
|
|
final String result = await capture(() => verifyNoTrailingSpaces(testRootPath, minimumMatches: 2), exitCode: 1);
|
|
final String lines = <String>[
|
|
'test/analyze-test-input/root/packages/foo/spaces.txt:5: trailing U+0020 space character',
|
|
'test/analyze-test-input/root/packages/foo/spaces.txt:9: trailing blank line',
|
|
]
|
|
.map((String line) => line.replaceAll('/', Platform.isWindows ? r'\' : '/'))
|
|
.join('\n');
|
|
expect(result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'$lines\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
});
|
|
|
|
test('analyze.dart - verifyNoBinaries - positive', () async {
|
|
final String result = await capture(() => verifyNoBinaries(
|
|
testRootPath,
|
|
legacyBinaries: <Hash256>{const Hash256(0x39A050CD69434936, 0, 0, 0)},
|
|
), exitCode: Platform.isWindows ? 0 : 1);
|
|
if (!Platform.isWindows) {
|
|
expect(result,
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
'test/analyze-test-input/root/packages/foo/serviceaccount.enc:0: file is not valid UTF-8\n'
|
|
'All files in this repository must be UTF-8. In particular, images and other binaries\n'
|
|
'must not be checked into this repository. This is because we are very sensitive to the\n'
|
|
'size of the repository as it is distributed to all our developers. If you have a binary\n'
|
|
'to which you need access, you should consider how to fetch it from another repository;\n'
|
|
'for example, the "assets-for-api-docs" repository is used for images in API docs.\n'
|
|
'━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n'
|
|
);
|
|
}
|
|
});
|
|
|
|
test('analyze.dart - verifyInternationalizations - comparison fails', () async {
|
|
final String result = await capture(() => verifyInternationalizations(testRootPath, dartPath), exitCode: 1);
|
|
final String genLocalizationsScript = path.join('dev', 'tools', 'localization', 'bin', 'gen_localizations.dart');
|
|
expect(result,
|
|
contains('$dartName $genLocalizationsScript --cupertino'));
|
|
expect(result,
|
|
contains('$dartName $genLocalizationsScript --material'));
|
|
final String generatedFile = path.join(testRootPath, 'packages', 'flutter_localizations',
|
|
'lib', 'src', 'l10n', 'generated_material_localizations.dart');
|
|
expect(result,
|
|
contains('The contents of $generatedFile are different from that produced by gen_localizations.'));
|
|
expect(result,
|
|
contains(r'Did you forget to run gen_localizations.dart after updating a .arb file?'));
|
|
});
|
|
|
|
test('analyze.dart - verifyNoBinaries - negative', () async {
|
|
await capture(() => verifyNoBinaries(
|
|
testRootPath,
|
|
legacyBinaries: <Hash256>{
|
|
const Hash256(0xA8100AE6AA1940D0, 0xB663BB31CD466142, 0xEBBDBD5187131B92, 0xD93818987832EB89), // sha256("\xff")
|
|
const Hash256(0x155644D3F13D98BF, 0, 0, 0),
|
|
},
|
|
));
|
|
});
|
|
|
|
test('analyze.dart - verifyNullInitializedDebugExpensiveFields', () async {
|
|
final String result = await capture(() => verifyNullInitializedDebugExpensiveFields(
|
|
testRootPath,
|
|
minimumMatches: 1,
|
|
), exitCode: 1);
|
|
|
|
expect(result, contains('L15'));
|
|
expect(result, isNot(contains('L12')));
|
|
});
|
|
}
|