mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
d45bf1457c
Previously, RenderObjectElements didn't support being marked dirty. This is fine, except for MixedViewport and HomogeneousViewport, which have builder functions to which they hand themselves as a BuildContext. If those builder functions call, e.g., Theme.of(), then when the theme changes, the Inherited logic tries to tell the RenderObjectElement object that its dependencies changed and that doesn't go down well. This patch fixes this by making RenderObjectElement a BuildableElement, and making MixedViewport and HomogeneousViewport hook into that to rebuild themselves appropriately. Also, this was only found at all because ThemeData didn't implement operator==, so we were aggressively marking the entire tree dirty all the time. That's fixed here too. Also, I changed card_collection.dart to have more features to make this easier to test. This found bugs #1524, #1522, #1528, #1529, #1530, #1531. |
||
|---|---|---|
| .. | ||
| big_switch.dart | ||
| BUILD.gn | ||
| card_collection.dart | ||
| container.dart | ||
| date_picker.dart | ||
| drag_and_drop.dart | ||
| ensure_visible.dart | ||
| horizontal_scrolling.dart | ||
| navigation.dart | ||
| overlay_geometry.dart | ||
| pageable_list.dart | ||
| piano.dart | ||
| progress_indicator.dart | ||
| pubspec.yaml | ||
| scale.dart | ||
| sector.dart | ||
| spinning_mixed.dart | ||
| styled_text.dart | ||
| tabs.dart | ||