mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
9f8fe3f04c
Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows: ``` windows\runner\utils.cpp(54,43): warning C4018: '>': signed/unsigned mismatch ``` WideCharToMultiByte returns: * 0 on error * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success. As a result it's safe to store the return value in an unsigned int, which eliminates the warning. No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings. Fixes: https://github.com/flutter/flutter/issues/134227 |
||
|---|---|---|
| .. | ||
| complex_layout | ||
| macrobenchmarks | ||
| microbenchmarks | ||
| multiple_flutters | ||
| platform_channels_benchmarks | ||
| platform_views_layout | ||
| platform_views_layout_hybrid_composition | ||
| test_apps/stocks | ||