mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
df676dc6e7
Fixes https://github.com/flutter/flutter/issues/159444 Fixes https://github.com/flutter/flutter/issues/146089 This adds callbacks to TabBar for onHover and onFocusChange. They pipe through to the underlying Inkwell widget that is wrapped around each Tab of the TabBar during build. #### Alternatives - I did consider adding these callbacks to Tab instead, but felt that going through TabBar would be better. If implemented in Tab, the user would need to define callbacks for each tab. This PR makes it so there is only need for one callback, and the associated Tab index is provided. Also, since the Inkwell is applied in the TabBar, it's kludgy to have to extract that from the Tabs _in_ TabBar later to pass on to the Inkwell. 👃 - Digging in to the requests in the linked issues, the user wants to change various stylings in response to these events. WidgetStateProperties were considered, but there are so many potential styling properties that going this route would require greatly increasing the API surface here. Tab.child allows the user to provide whatever widget they would like to have as the content. Being able to modify Tab.child in response to these events is a better way go instead of exposing a ton of different properties. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md |
||
|---|---|---|
| .. | ||
| about | ||
| action_buttons | ||
| action_chip | ||
| animated_icon | ||
| app | ||
| app_bar | ||
| autocomplete | ||
| badge | ||
| banner | ||
| bottom_app_bar | ||
| bottom_navigation_bar | ||
| bottom_sheet | ||
| button_style | ||
| button_style_button | ||
| card | ||
| carousel | ||
| checkbox | ||
| checkbox_list_tile | ||
| chip | ||
| choice_chip | ||
| color_scheme | ||
| context_menu | ||
| data_table | ||
| date_picker | ||
| dialog | ||
| divider | ||
| drawer | ||
| dropdown | ||
| dropdown_menu | ||
| elevated_button | ||
| expansion_panel | ||
| expansion_tile | ||
| filled_button | ||
| filter_chip | ||
| flexible_space_bar | ||
| floating_action_button | ||
| floating_action_button_location | ||
| icon_button | ||
| ink | ||
| ink_well | ||
| input_chip | ||
| input_decorator | ||
| list_tile | ||
| material_state | ||
| menu_anchor | ||
| navigation_bar | ||
| navigation_drawer | ||
| navigation_rail | ||
| outlined_button | ||
| page_transitions_theme | ||
| paginated_data_table | ||
| platform_menu_bar | ||
| popup_menu | ||
| progress_indicator | ||
| radio | ||
| radio_list_tile | ||
| range_slider | ||
| refresh_indicator | ||
| reorderable_list | ||
| scaffold | ||
| scrollbar | ||
| search_anchor | ||
| segmented_button | ||
| selectable_region | ||
| selection_area | ||
| selection_container | ||
| slider | ||
| snack_bar | ||
| stepper | ||
| switch | ||
| switch_list_tile | ||
| tab_controller | ||
| tabs | ||
| text_button | ||
| text_field | ||
| text_form_field | ||
| theme | ||
| theme_data | ||
| time_picker | ||
| toggle_buttons | ||
| tooltip | ||
| widget_state_input_border | ||