![]() <!-- start_original_pr_link --> Reverts: flutter/flutter#168662 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Broke integration tests that do not run on presubmit: - https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20macos_chrome_dev_mode/8715/overview - https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20linux_chrome_dev_mode/7617/overview <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: mosuem <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Switch Flutter to use pub workspaces as a preparation to unpin selected packages. Assumptions: 1. No packages in this repository are published to pub.dev --> We can use `any` dependencies in most local pubspecs, as the global constraint defines the version. An exception are the packages used outside of this repo with an `sdk` dependency, namely `flutter_localizations`, `flutter_test`, and `flutter`. 2. The "universes" `{flutter_tools}` and `{flutter, flutter_localizations, flutter_goldens}` can use different packages versions, as they are not resolved together. --> We do not need to upgrade them in sync, we can first do one "universe", then the other. Based on these assumptions, we use https://github.com/mosuem/pubspec_merger.dart to merge all packages in the `flutter` universe into a top-level pub workspace. The `flutter` and `flutter_tools` workspaces being separate also ensures that changes to `flutter` will not inadvertently break `flutter_tools`, with not-so-nice consequences for our users which would be unable to run `flutter upgrade`. There is a third "top-level" pubspec besides `./pubspec.yaml` and `packages/flutter_tools/pubspec.yaml`, namely `packages/flutter_tools/.../widget_preview_scaffold/pubspec.yaml`. This is an artifact due to it living under `flutter_tools`, so it can't be part of the `./pubspec.yaml` workspace. Moving it would be a larger change, and out of the scope of this PR. This required a rewrite of the update-packages tool, but the main functionality stays the same, as well as the argument names, to ensure a seamless transition. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com> |
||
---|---|---|
.. | ||
lib | ||
test | ||
pubspec.yaml | ||
README.md |
Flutter Framework localizations
This package contains the localizations used by the Flutter framework itself.
See the localization README for more detailed information about the localizations themselves.
Adding a new string to localizations
If you (someone contributing to the Flutter framework) want to add a new
string to the MaterialLocalizations
, WidgetsLocalizations
or the
CupertinoLocalizations
objects (e.g. because you've added a new widget
and it has a tooltip), follow these steps (these instructions are for
MaterialLocalizations
, but apply equally to CupertinoLocalizations
and WidgetsLocalizations
, with appropriate name substitutions):
-
For messages without parameters, add new getter
String get showMenuTooltip;
to the localizations class
MaterialLocalizations
, inpackages/flutter/lib/src/material/material_localizations.dart
;For messages with parameters, add new function
String aboutListTileTitle(String applicationName);
to the same localization class.
-
Implement a default return value in
DefaultMaterialLocalizations
in the same file as in step 1.Messages without parameters:
@override String get showMenuTooltip => 'Show menu';
Messages with parameters:
@override String aboutListTileTitle(String applicationName) => 'About $applicationName';
For messages with parameters, do also add the function to
GlobalMaterialLocalizations
inpackages/flutter_localizations/lib/src/material_localizations.dart
, and add a raw getter as demonstrated below:/// The raw version of [aboutListTileTitle], with `$applicationName` verbatim /// in the string. @protected String get aboutListTileTitleRaw; @override String aboutListTileTitle(String applicationName) { final String text = aboutListTileTitleRaw; return text.replaceFirst(r'$applicationName', applicationName); }
-
Add a test to
test/material/localizations_test.dart
that verifies that this new value is implemented. -
Update the
flutter_localizations
package. To add a new string to theflutter_localizations
package, you must first add it to the English translations (lib/src/l10n/material_en.arb
), including a description.Messages without parameters:
"showMenuTooltip": "Show menu", "@showMenuTooltip": { "description": "The tooltip for the button that shows a popup menu." },
Messages with parameters:
"aboutListTileTitle": "About $applicationName", "@aboutListTileTitle": { "description": "The default title for the drawer item that shows an about page for the application. The value of $applicationName is the name of the application, like GMail or Chrome.", "parameters": "applicationName" },
Then you need to add new entries for the string to all of the other language locale files by running:
dart dev/tools/localization/bin/gen_missing_localizations.dart
Which will copy the English strings into the other locales as placeholders until they can be translated.
Finally you need to re-generate lib/src/l10n/localizations.dart by running:
dart dev/tools/localization/bin/gen_localizations.dart --overwrite
If you got an error when running this command, this issue might be helpful.
TL;DR: If you got the same type of errors as discussed in the issue, run this instead:
dart dev/tools/localization/bin/gen_localizations.dart --overwrite --remove-undefined
There is a localization README file with further information in the
lib/src/l10n/
directory. -
If you are a Google employee, you should then also follow the instructions at
go/flutter-l10n
. If you're not, don't worry about it.
Updating an existing string
If you or someone contributing to the Flutter framework wants to modify an existing string in the MaterialLocalizations objects, follow these steps:
-
Modify the default value of the relevant getter(s) in
DefaultMaterialLocalizations
below. -
Update the
flutter_localizations
package. Modify the out-of-date English strings inlib/src/l10n/material_en.arb
.You also need to re-generate
lib/src/l10n/localizations.dart
by running:dart dev/tools/localization/bin/gen_localizations.dart --overwrite
This script may result in your updated getters being created in newer locales and set to the old value of the strings. This is to be expected. Leave them as they were generated, and they will be picked up for translation.
There is a localization README file with further information in the
lib/src/l10n/
directory. -
If you are a Google employee, you should then also follow the instructions at
go/flutter-l10n
. If you're not, don't worry about it.