mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
f02a93bc88
Relands https://github.com/flutter/flutter/pull/166998. On top of the original PR: 1. fixes unfortunate mistake in commenting the fix 2. adds to the `runIf` cases to better cover when this test should be run in presubmit 3. pins a lower version of `shared_preferences_android`, as we need to use a plugin with `compileSdk 34` for those lower AGP versions. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
74 lines
2.5 KiB
Dart
74 lines
2.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
|
|
import 'package:file/local.dart';
|
|
import 'package:flutter_devicelab/framework/dependency_smoke_test_task_definition.dart';
|
|
import 'package:flutter_devicelab/framework/framework.dart';
|
|
|
|
// Methodology:
|
|
// - AGP: all versions within our support range (*).
|
|
// - Gradle: The version that AGP lists as the default Gradle version for that
|
|
// AGP version under the release notes, e.g.
|
|
// https://developer.android.com/build/releases/past-releases/agp-8-4-0-release-notes.
|
|
// - Kotlin: No methodology as of yet.
|
|
// (*) - support range defined in packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts.
|
|
List<VersionTuple> versionTuples = <VersionTuple>[
|
|
VersionTuple(
|
|
agpVersion: '7.0.1',
|
|
gradleVersion: '7.0.2',
|
|
kotlinVersion: '1.7.10',
|
|
compileSdkVersion: '34',
|
|
),
|
|
VersionTuple(
|
|
agpVersion: '7.1.0',
|
|
gradleVersion: '7.2',
|
|
kotlinVersion: '1.7.10',
|
|
compileSdkVersion: '34',
|
|
),
|
|
VersionTuple(
|
|
agpVersion: '7.2.0',
|
|
gradleVersion: '7.3.3',
|
|
kotlinVersion: '1.7.10',
|
|
compileSdkVersion: '34',
|
|
),
|
|
VersionTuple(
|
|
agpVersion: '7.3.0',
|
|
gradleVersion: '7.4',
|
|
kotlinVersion: '1.7.10',
|
|
compileSdkVersion: '34',
|
|
),
|
|
// minSdk bump required due to a bug in the default version of r8 used by AGP
|
|
// 7.4.0. See http://issuetracker.google.com/issues/357553178.
|
|
VersionTuple(
|
|
agpVersion: '7.4.0',
|
|
gradleVersion: '7.5',
|
|
kotlinVersion: '1.8.10',
|
|
compileSdkVersion: '34',
|
|
minSdkVersion: '24',
|
|
),
|
|
];
|
|
|
|
// This test requires a Java version less than 17 due to the intentionally low
|
|
// version of Gradle. We choose 11 because this was the primary version used in
|
|
// CI before 17, and hence it is also hosted on CIPD. It also overrides to
|
|
// compileSdkVersion 34 because compileSdk 35 requires AGP 8.0+.
|
|
// https://docs.gradle.org/current/userguide/compatibility.html
|
|
Future<void> main() async {
|
|
/// The [FileSystem] for the integration test environment.
|
|
const LocalFileSystem fileSystem = LocalFileSystem();
|
|
|
|
final Directory tempDir = fileSystem.systemTempDirectory.createTempSync(
|
|
'flutter_android_dependency_version_tests',
|
|
);
|
|
await task(() {
|
|
return buildFlutterApkWithSpecifiedDependencyVersions(
|
|
versionTuples: versionTuples,
|
|
tempDir: tempDir,
|
|
localFileSystem: fileSystem,
|
|
);
|
|
});
|
|
}
|