github/intel-device-plugins-for-kubernetes
7
0
Fork 0
mirror of https://github.com/intel/intel-device-plugins-for-kubernetes.git synced 2025-06-03 03:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #536 from rojkov/pref-alloc-tests

Browse Source 
api: improve code coverage
This commit is contained in:
Mikko Ylinen 2020-12-30 13:58:41 +02:00 committed by GitHub
commit 005db1b9cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/deviceplugin/manager_test.go
View File

@ -164,6 +164,10 @@ func (*devicePluginStub) PreStartContainer(*pluginapi.PreStartContainerRequest)
return nil
}
func (*devicePluginStub) GetPreferredAllocation(*pluginapi.PreferredAllocationRequest) (*pluginapi.PreferredAllocationResponse, error) {
return nil, nil
}
func TestHandleUpdate(t *testing.T) {
tcases := []struct {
name string

34
pkg/deviceplugin/server_test.go
View File

@ -492,7 +492,7 @@ func TestGetDevicePluginOptions(t *testing.T) {
func TestPreStartContainer(t *testing.T) {
tcases := []struct {
name string
preStartContainer func(*pluginapi.PreStartContainerRequest) error
preStartContainer preStartContainerFunc
expectedError bool
}{
{
@ -523,9 +523,35 @@ func TestPreStartContainer(t *testing.T) {
}
func TestGetPreferredAllocation(t *testing.T) {
srv := &server{}
if _, err := srv.GetPreferredAllocation(context.Background(), nil); err == nil {
t.Error("expected an unimplemented error, but got success")
tcases := []struct {
name string
getPreferredAllocation getPreferredAllocationFunc
expectedError bool
}{
{
name: "success",
getPreferredAllocation: func(*pluginapi.PreferredAllocationRequest) (*pluginapi.PreferredAllocationResponse, error) {
return nil, nil
},
},
{
name: "error",
expectedError: true,
},
}
for _, tc := range tcases {
t.Run(tc.name, func(t *testing.T) {
srv := &server{
getPreferredAllocation: tc.getPreferredAllocation,
}
_, err := srv.GetPreferredAllocation(context.Background(), nil)
if !tc.expectedError && err != nil {
t.Errorf("unexpected error: %v", err)
} else if tc.expectedError && err == nil {
t.Error("didn't failed when expected to fail")
return
}
})
}
}