From 0670a82cb1e826cfcd2a95da18bef656522acd29 Mon Sep 17 00:00:00 2001 From: Ukri Niemimuukko Date: Fri, 10 Sep 2021 14:10:53 +0300 Subject: [PATCH] gpu rm linter comment fixes Signed-off-by: Ukri Niemimuukko --- cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go | 4 ++++ cmd/internal/pluginutils/sriov.go | 1 + 2 files changed, 5 insertions(+) diff --git a/cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go b/cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go index 5fa11d91..1415c91a 100644 --- a/cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go +++ b/cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go @@ -73,6 +73,7 @@ type DeviceInfo struct { type getClientFunc func(string, time.Duration, int) (podresourcesv1.PodResourcesListerClient, *grpc.ClientConn, error) +// ResourceManager interface for the fractional resource handling. type ResourceManager interface { ReallocateWithFractionalResources(*pluginapi.AllocateRequest) (*pluginapi.AllocateResponse, error) SetDevInfos(DeviceInfoMap) @@ -88,6 +89,7 @@ type resourceManager struct { prGetClientFunc getClientFunc } +// NewDeviceInfo creates a new DeviceInfo. func NewDeviceInfo(nodes []pluginapi.DeviceSpec, mounts []pluginapi.Mount, envs map[string]string) *DeviceInfo { return &DeviceInfo{ nodes: nodes, @@ -96,8 +98,10 @@ func NewDeviceInfo(nodes []pluginapi.DeviceSpec, mounts []pluginapi.Mount, envs } } +// DeviceInfoMap is a map of device infos. deviceId -> *DeviceInfo. type DeviceInfoMap map[string]*DeviceInfo +// NewDeviceInfoMap creates a new DeviceInfoMap. func NewDeviceInfoMap() DeviceInfoMap { return DeviceInfoMap{} } diff --git a/cmd/internal/pluginutils/sriov.go b/cmd/internal/pluginutils/sriov.go index b3e6d1a4..966ead41 100644 --- a/cmd/internal/pluginutils/sriov.go +++ b/cmd/internal/pluginutils/sriov.go @@ -20,6 +20,7 @@ import ( "strings" ) +// IsSriovPFwithVFs returns true if the device with given pfpath has virtual functions, false otherwise. func IsSriovPFwithVFs(pfpath string) bool { dat, err := os.ReadFile(path.Join(pfpath, "device/sriov_numvfs"))