linter: enable nakedret check

.golangci.yml

@@ -26,6 +26,7 @@ linters:
     - interfacer
     - maligned
     - misspell
+    - nakedret
     - nolintlint
     - rowserrcheck
     - structcheck

cmd/fpga_tool/fpga_tool.go

@@ -143,7 +143,7 @@ func installBitstream(fname string, dryRun, force, quiet bool) (err error) {
 	}
 	defer dst.Close()
 	_, err = io.Copy(dst, src)
-	return
+	return err
 }
 
 func printBitstreamInfo(fname string, quiet bool) (err error) {
@@ -247,21 +247,34 @@ func printFpgaPort(f fpga.Port, quiet bool) (err error) {
 	fmt.Printf("Port Id                          : %d\n", num)
 	fmt.Printf("Interface UUID                   : %s\n", f.GetInterfaceUUID())
 	fmt.Printf("Accelerator UUID                 : %s\n", f.GetAcceleratorTypeUUID())
-	if !quiet {
-		if apiVer, err := f.GetAPIVersion(); err == nil {
-			fmt.Printf("Kernet API Version               : %d\n", apiVer)
-			pi, err := f.PortGetInfo()
-			if err == nil {
-				fmt.Printf("Port Regions                     : %d\n", pi.Regions)
-				for idx := 0; uint32(idx) < pi.Regions; idx++ {
-					if ri, err := f.PortGetRegionInfo(uint32(idx)); err == nil {
-						fmt.Printf("Port Region (Index/Size/Offset)  : %d / %d / %d\n", ri.Index, ri.Size, ri.Offset)
-					}
-				}
-			}
-		}
+
+	if quiet {
+		return err
 	}
-	return
+
+	apiVer, err := f.GetAPIVersion()
+	if err != nil {
+		return err
+	}
+
+	fmt.Printf("Kernet API Version               : %d\n", apiVer)
+
+	pi, err := f.PortGetInfo()
+	if err != nil {
+		return err
+	}
+
+	fmt.Printf("Port Regions                     : %d\n", pi.Regions)
+	for idx := uint32(0); idx < pi.Regions; idx++ {
+		ri, err := f.PortGetRegionInfo(idx)
+		if err != nil {
+			return err
+		}
+
+		fmt.Printf("Port Region (Index/Size/Offset)  : %d / %d / %d\n", ri.Index, ri.Size, ri.Offset)
+	}
+
+	return nil
 }
 
 func printPCIeInfo(pci *fpga.PCIDevice, quiet bool) {