From 9a16e80f2b1eb815550c7b662b7af8857b1a37c3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 15 Dec 2021 11:41:35 +0000 Subject: [PATCH] build(deps): bump google.golang.org/grpc from 1.42.0 to 1.43.0 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.42.0 to 1.43.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.42.0...v1.43.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... --- In addition to changes made by dependabot, I add nolint comments to ignore staticcheck(SA1019) errors. It is because insecure.NewCredentials() recommended as an alternative is still declared experimental. So keep grpc.withInsecure() with nolint comment. Signed-off-by: Hyeongju Johannes Lee --- cmd/gpu_plugin/rm/gpu_plugin_resource_manager_test.go | 1 + go.mod | 2 +- go.sum | 4 ++-- pkg/deviceplugin/server.go | 2 ++ pkg/deviceplugin/server_test.go | 2 ++ 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/cmd/gpu_plugin/rm/gpu_plugin_resource_manager_test.go b/cmd/gpu_plugin/rm/gpu_plugin_resource_manager_test.go index 532b292c..0d9c995f 100644 --- a/cmd/gpu_plugin/rm/gpu_plugin_resource_manager_test.go +++ b/cmd/gpu_plugin/rm/gpu_plugin_resource_manager_test.go @@ -85,6 +85,7 @@ func (w *mockPodResources) GetAllocatableResources(ctx context.Context, } func newMockResourceManager(pods []v1.Pod) ResourceManager { + //nolint: staticcheck client, err := grpc.Dial("", grpc.WithInsecure()) if err != nil { os.Exit(1) diff --git a/go.mod b/go.mod index 3ab60c72..2fe2c55d 100644 --- a/go.mod +++ b/go.mod @@ -12,7 +12,7 @@ require ( github.com/onsi/gomega v1.17.0 github.com/pkg/errors v0.9.1 golang.org/x/sys v0.0.0-20211205182925-97ca703d548d - google.golang.org/grpc v1.42.0 + google.golang.org/grpc v1.43.0 k8s.io/api v0.23.0 k8s.io/apimachinery v0.23.0 k8s.io/client-go v1.5.2 diff --git a/go.sum b/go.sum index 4462238d..494cc776 100644 --- a/go.sum +++ b/go.sum @@ -1084,8 +1084,8 @@ google.golang.org/grpc v1.36.1/go.mod h1:qjiiYl8FncCW8feJPdyg3v6XW24KsRHe+dy9BAG google.golang.org/grpc v1.37.0/go.mod h1:NREThFqKR1f3iQ6oBuvc5LadQuXVGo9rkm5ZGrQdJfM= google.golang.org/grpc v1.38.0/go.mod h1:NREThFqKR1f3iQ6oBuvc5LadQuXVGo9rkm5ZGrQdJfM= google.golang.org/grpc v1.40.0/go.mod h1:ogyxbiOoUXAkP+4+xa6PZSE9DZgIHtSpzjDTB9KAK34= -google.golang.org/grpc v1.42.0 h1:XT2/MFpuPFsEX2fWh3YQtHkZ+WYZFQRfaUgLZYj/p6A= -google.golang.org/grpc v1.42.0/go.mod h1:k+4IHHFw41K8+bbowsex27ge2rCb65oeWqe4jJ590SU= +google.golang.org/grpc v1.43.0 h1:Eeu7bZtDZ2DpRCsLhUlcrLnvYaMK1Gz86a+hMVvELmM= +google.golang.org/grpc v1.43.0/go.mod h1:k+4IHHFw41K8+bbowsex27ge2rCb65oeWqe4jJ590SU= google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8= google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0= google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM= diff --git a/pkg/deviceplugin/server.go b/pkg/deviceplugin/server.go index 4ab9e721..11a52e2c 100644 --- a/pkg/deviceplugin/server.go +++ b/pkg/deviceplugin/server.go @@ -324,6 +324,7 @@ func watchFile(file string) error { func (srv *server) registerWithKubelet(kubeletSocket, pluginEndPoint, resourceName string) error { ctx := context.Background() + //nolint: staticcheck conn, err := grpc.DialContext(ctx, kubeletSocket, grpc.WithInsecure(), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, "unix", addr) @@ -357,6 +358,7 @@ func waitForServer(socket string, timeout time.Duration) error { defer cancel() + //nolint: staticcheck conn, err := grpc.DialContext(ctx, socket, grpc.WithInsecure(), grpc.WithBlock(), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, "unix", addr) diff --git a/pkg/deviceplugin/server_test.go b/pkg/deviceplugin/server_test.go index dbd8e265..95b6f879 100644 --- a/pkg/deviceplugin/server_test.go +++ b/pkg/deviceplugin/server_test.go @@ -179,6 +179,7 @@ func TestSetupAndServe(t *testing.T) { ctx := context.Background() + //nolint: staticcheck conn, err := grpc.DialContext(ctx, pluginSocket, grpc.WithInsecure(), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, "unix", addr) @@ -229,6 +230,7 @@ func TestSetupAndServe(t *testing.T) { time.Sleep(1 * time.Second) } + //nolint: staticcheck conn, err = grpc.DialContext(ctx, pluginSocket, grpc.WithInsecure(), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, "unix", addr)