From fa6d027b246c1bbbc2ee9e6f6a65dec41e1cb25f Mon Sep 17 00:00:00 2001 From: Tuomas Katila Date: Mon, 19 Aug 2024 15:26:30 +0300 Subject: [PATCH] Fix some lint errors Signed-off-by: Tuomas Katila --- cmd/gpu_plugin/gpu_plugin_test.go | 4 ++-- pkg/idxd/plugin_test.go | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cmd/gpu_plugin/gpu_plugin_test.go b/cmd/gpu_plugin/gpu_plugin_test.go index e0ecd6b2..230e0629 100644 --- a/cmd/gpu_plugin/gpu_plugin_test.go +++ b/cmd/gpu_plugin/gpu_plugin_test.go @@ -589,7 +589,7 @@ func createBypathTestFiles(t *testing.T, card, root, linkFile string, bypathFile t.Fatal("Couldn't create test drm dir", err) } - if err := os.WriteFile(devPath, []byte{0}, os.ModePerm); err != nil { + if err := os.WriteFile(devPath, []byte{0}, 0o600); err != nil { t.Fatal("Couldn't create card file", err) } @@ -604,7 +604,7 @@ func createBypathTestFiles(t *testing.T, card, root, linkFile string, bypathFile } for _, f := range bypathFiles { - if err := os.WriteFile(path.Join(byPath, f), []byte{1}, os.ModePerm); err != nil { + if err := os.WriteFile(path.Join(byPath, f), []byte{1}, 0o600); err != nil { t.Fatal("WriteFile failed:", path.Join(byPath, f)) } } diff --git a/pkg/idxd/plugin_test.go b/pkg/idxd/plugin_test.go index 92d4cf84..45116d9d 100644 --- a/pkg/idxd/plugin_test.go +++ b/pkg/idxd/plugin_test.go @@ -39,7 +39,10 @@ func getFakeDevNodes(devDir, charDevDir, wqName string) ([]pluginapi.DeviceSpec, var devNum, queueNum int - fmt.Sscanf(wqName, "wq%d.%d", &devNum, &queueNum) + if _, err := fmt.Sscanf(wqName, "wq%d.%d", &devNum, &queueNum); err != nil { + return []pluginapi.DeviceSpec{}, err + } + charDevPath := path.Join(charDevDir, fmt.Sprintf("%d:%d", dsaMajor, devNum*10+queueNum)) return []pluginapi.DeviceSpec{