As the operator container image is available from a registry, we should
guide users to use it rather than build and deploy it locally.
Further, drop (un)deploy-operator targets in favor of simply using
kubectl for deployment.
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Our 'make push' started failing and it looks docker picks :latest tag
for the image it just built but fails because it does not exist:
Using default tag: latest
...
tag does not exist:
cloud-native-image-registry.westus.cloudapp.azure.com/intel-deviceplugin-operator:latest
Fix 'make push' to explicitly use the image tag set by Jenkins.
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Users had no options to specify extra builder arguments to $BUILDER.
With this patch it's possible, e.g., to build QAT plugin with kernel
mode support:
make intel-qat-plugin EXTRA_BUILD_ARGS="--build-arg TAGS_KERNELDRV=kernel
Fixes: #234
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
This commit adds bash scripts with the proper granularity for each sub-stage,
needed for QAT device main stage validation.
Signed-off-by: Rivera Gonzalez, Julio C <julio.c.rivera.gonzalez@intel.com>
This change, adds a conditional step on Jenkins in order to push images,
built and be published.
Signed-off-by: Rivera Gonzalez, Julio C <julio.c.rivera.gonzalez@intel.com>
In preparations to get some of the images to hub.docker.com/intel,
start using intel/ prefix.
Moreover, set the Makefile variables so that the images built
by make [images|demos] can easily be pushed to any registry/org
by 'docker push' (e.g., by Jenkins).
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Added alternative builder for project images: buildah
https://github.com/containers/buildah
Considering that some of our plugins use CRI-O runtime it could be
a good idea to get rid of docker as a builder. It should allow us
not to run docker daemon at all, even for build purposes.
Kubernetes also goes this way encouraging users to switch to CRI
runtimes (CRI-O and containerd), so having non-docker builds supported
looks good from this perspective too.
Docker documentation recommends configuring proxy in
a Docker client configuration file ~/.docker/config.json for Docker
version >= 17.07: https://docs.docker.com/network/proxy/
Using --build-arg for this purpose is not recommended, hence
removing.
Used gofmt instead of go fmt to show the changes and simplify the code.
Made 'make format' to exit with error when formatting is not correct.
Fixes: #57
'make images' command fails with this error output:
...
docker build -f build/docker/intel-fpga-crihook.Dockerfile --build-arg
HTTP_PROXY --build-arg HTTPS_PROXY --build-arg NO_PROXY --build-arg
http_proxy --build-arg https_proxy --build-arg no_proxy --pull -t
intel-fpga-crihook:4ec2c4acb63ce677684c42d2eb986227182e0742 .
unable to prepare context: unable to evaluate symlinks in Dockerfile
path: lstat
build/docker/intel-fpga-crihook.Dockerfile:
no such file or directory
Makefile:46: recipe for target 'intel-fpga-crihook' failed
make: *** [intel-fpga-crihook] Error 1
This is caused by incorrect assumption that there is a Docker file for
every item in cmd/
Reimplemented 'make images' to build only images that have Docker
files in build/docker directory.
make lint always returs 0 even if there were errors found by golint
Fixed it by using golint command line option -set_exit_status and
checking golint return code
