intel-device-plugins-for-ku.../test/envtest/qatdeviceplugin_controller_test.go
Mikko Ylinen fe3eaeeb0b qat: drop AppArmor annotations
"unconfined" annotation was needed to get writes to new_id / bind
to succeed on AppArmor enabled OSes.

However, many things have changed:

* new_id should not be used anymore and it was dropped in the plugin.
* QAT initcontainer has assumed the role of HW initialization.
* vfio-pci is the preferred "dpdkDriver" and starting with QAT Gen4, it
is the only available VF driver so unbind isn't necessary.
* k8s AppArmor is "GA" since 1.30 and the annotation is deprecated.

As of now, the initcontainer will take care of binding QAT VFs to vfio-pci
so the plugin does not neeed to set AppArmor at all.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
2025-01-16 13:54:37 +02:00

204 lines
7.3 KiB
Go

// Copyright 2020-2022 Intel Corporation. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package envtest
import (
"context"
"strconv"
"time"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
devicepluginv1 "github.com/intel/intel-device-plugins-for-kubernetes/pkg/apis/deviceplugin/v1"
)
var _ = Describe("QatDevicePlugin Controller", func() {
const timeout = time.Second * 30
const interval = time.Second * 1
Context("Basic CRUD operations", func() {
It("should handle QatDevicePlugin objects correctly", func() {
spec := devicepluginv1.QatDevicePluginSpec{
Image: "qat-testimage",
InitImage: "qat-testinitimage",
NodeSelector: map[string]string{"qat-nodeselector": "true"},
}
key := types.NamespacedName{
Name: "qatdeviceplugin-test",
}
toCreate := &devicepluginv1.QatDevicePlugin{
ObjectMeta: metav1.ObjectMeta{
Name: key.Name,
},
Spec: spec,
}
expectedDsName := "intel-qat-plugin-qatdeviceplugin-test"
By("creating QatDevicePlugin successfully")
Expect(k8sClient.Create(context.Background(), toCreate)).Should(Succeed())
time.Sleep(time.Second * 5)
fetched := &devicepluginv1.QatDevicePlugin{}
Eventually(func() bool {
_ = k8sClient.Get(context.Background(), key, fetched)
return len(fetched.Status.ControlledDaemonSet.UID) > 0
}, timeout, interval).Should(BeTrue())
By("checking DaemonSet is created successfully")
ds := &apps.DaemonSet{}
err = k8sClient.Get(context.Background(), types.NamespacedName{Namespace: ns, Name: expectedDsName}, ds)
Expect(err).To(BeNil())
Expect(ds.Spec.Template.Spec.Containers[0].Image).To(Equal(spec.Image))
Expect(ds.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(ds.Spec.Template.Spec.InitContainers[0].Image).To(Equal(spec.InitImage))
Expect(ds.Spec.Template.Spec.NodeSelector).To(Equal(spec.NodeSelector))
Expect(ds.Spec.Template.Spec.Tolerations).To(HaveLen(0))
By("updating QatDevicePlugin successfully")
updatedImage := "updated-qat-testimage"
updatedInitImage := "updated-qat-testinitimage"
updatedProvisioningConfig := "updated-qat-provisioningconfig"
updatedLogLevel := 2
updatedDpdkDriver := "igb_uio"
updatedKernelVfDrivers := "c3xxxvf"
updatedMaxNumDevices := 16
updatedPreferredAllocationPolicy := "balanced"
updatedNodeSelector := map[string]string{"updated-qat-nodeselector": "true"}
fetched.Spec.Image = updatedImage
fetched.Spec.InitImage = updatedInitImage
fetched.Spec.ProvisioningConfig = updatedProvisioningConfig
fetched.Spec.LogLevel = updatedLogLevel
fetched.Spec.DpdkDriver = updatedDpdkDriver
fetched.Spec.KernelVfDrivers = []devicepluginv1.KernelVfDriver{devicepluginv1.KernelVfDriver(updatedKernelVfDrivers)}
fetched.Spec.MaxNumDevices = updatedMaxNumDevices
fetched.Spec.PreferredAllocationPolicy = updatedPreferredAllocationPolicy
fetched.Spec.NodeSelector = updatedNodeSelector
Expect(k8sClient.Update(context.Background(), fetched)).Should(Succeed())
fetchedUpdated := &devicepluginv1.QatDevicePlugin{}
Eventually(func() devicepluginv1.QatDevicePluginSpec {
_ = k8sClient.Get(context.Background(), key, fetchedUpdated)
return fetchedUpdated.Spec
}, timeout, interval).Should(Equal(fetched.Spec))
time.Sleep(interval)
By("checking DaemonSet is updated successfully")
err = k8sClient.Get(context.Background(), types.NamespacedName{Namespace: ns, Name: expectedDsName}, ds)
Expect(err).To(BeNil())
expectArgs := []string{
"-v",
strconv.Itoa(updatedLogLevel),
"-dpdk-driver",
updatedDpdkDriver,
"-kernel-vf-drivers",
updatedKernelVfDrivers,
"-max-num-devices",
strconv.Itoa(updatedMaxNumDevices),
"-allocation-policy",
updatedPreferredAllocationPolicy,
}
mode := int32(0440)
expectedVolume := v1.Volume{
Name: "intel-qat-config-volume",
VolumeSource: v1.VolumeSource{
ConfigMap: &v1.ConfigMapVolumeSource{
LocalObjectReference: v1.LocalObjectReference{Name: updatedProvisioningConfig},
DefaultMode: &mode,
},
},
}
Expect(ds.Spec.Template.Spec.Containers[0].Args).Should(ConsistOf(expectArgs))
Expect(ds.Spec.Template.Spec.Containers[0].Image).Should(Equal(updatedImage))
Expect(ds.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(ds.Spec.Template.Spec.InitContainers[0].Image).To(Equal(updatedInitImage))
Expect(ds.Spec.Template.Spec.Volumes).To(ContainElement(expectedVolume))
Expect(ds.Spec.Template.Spec.NodeSelector).Should(Equal(updatedNodeSelector))
By("updating QatDevicePlugin with different values successfully")
updatedInitImage = ""
updatedNodeSelector = map[string]string{}
fetched.Spec.InitImage = updatedInitImage
fetched.Spec.NodeSelector = updatedNodeSelector
Expect(k8sClient.Update(context.Background(), fetched)).Should(Succeed())
time.Sleep(interval)
By("checking DaemonSet is updated with different values successfully")
err = k8sClient.Get(context.Background(), types.NamespacedName{Namespace: ns, Name: expectedDsName}, ds)
Expect(err).To(BeNil())
Expect(ds.Spec.Template.Spec.InitContainers).To(HaveLen(0))
Expect(ds.Spec.Template.Spec.Volumes).ShouldNot(ContainElement(expectedVolume))
Expect(ds.Spec.Template.Spec.NodeSelector).Should(And(HaveLen(1), HaveKeyWithValue("kubernetes.io/arch", "amd64")))
By("updating QatDevicePlugin with tolerations")
tolerations := []v1.Toleration{
{Key: "foo", Operator: "Equal", Value: "bar", Effect: "NoSchedule"},
}
fetched.Spec.Tolerations = tolerations
Expect(k8sClient.Update(context.Background(), fetched)).Should(Succeed())
time.Sleep(interval)
By("checking DaemonSet is updated with tolerations")
err = k8sClient.Get(context.Background(), types.NamespacedName{Namespace: ns, Name: expectedDsName}, ds)
Expect(err).To(BeNil())
Expect(ds.Spec.Template.Spec.Tolerations).To(Equal(tolerations))
By("deleting QatDevicePlugin successfully")
Eventually(func() error {
f := &devicepluginv1.QatDevicePlugin{}
_ = k8sClient.Get(context.Background(), key, f)
return k8sClient.Delete(context.Background(), f)
}, timeout, interval).Should(Succeed())
Eventually(func() error {
f := &devicepluginv1.QatDevicePlugin{}
return k8sClient.Get(context.Background(), key, f)
}, timeout, interval).ShouldNot(Succeed())
})
})
It("upgrades", func() {
dp := &devicepluginv1.QatDevicePlugin{}
var image, initimage string
testUpgrade("qat", dp, &image, &initimage)
Expect(dp.Spec.Image == image).To(BeTrue())
Expect(dp.Spec.InitImage == initimage).To(BeTrue())
})
var _ = AfterEach(func() {
CleanupAfter("qat", &devicepluginv1.QatDevicePlugin{})
})
})