mirror of
https://github.com/intel/intel-device-plugins-for-kubernetes.git
synced 2025-06-03 03:59:37 +00:00
c6b947e594
Move CRD validating webhooks' image min version checks to use common constant across all the plugins. After the change, we carry the same min version for all devices and this version becomes easier to maintain when we make new releases. Each CRD webhook still carries its own xyzMinVersion if we decide to go back to CRD specific versions later. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
97 lines
3.4 KiB
Go
97 lines
3.4 KiB
Go
// Copyright 2020 Intel Corporation. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package v1
|
|
|
|
import (
|
|
"github.com/pkg/errors"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/util/version"
|
|
ctrl "sigs.k8s.io/controller-runtime"
|
|
logf "sigs.k8s.io/controller-runtime/pkg/log"
|
|
"sigs.k8s.io/controller-runtime/pkg/webhook"
|
|
|
|
"github.com/intel/intel-device-plugins-for-kubernetes/pkg/controllers"
|
|
)
|
|
|
|
const (
|
|
gpuPluginKind = "GpuDevicePlugin"
|
|
)
|
|
|
|
var (
|
|
// gpudevicepluginlog is for logging in this package.
|
|
gpudevicepluginlog = logf.Log.WithName("gpudeviceplugin-resource")
|
|
|
|
gpuMinVersion = version.MustParseSemantic(imageMinVersion)
|
|
)
|
|
|
|
// SetupWebhookWithManager sets up a webhook for GpuDevicePlugin custom resources.
|
|
func (r *GpuDevicePlugin) SetupWebhookWithManager(mgr ctrl.Manager) error {
|
|
return ctrl.NewWebhookManagedBy(mgr).
|
|
For(r).
|
|
Complete()
|
|
}
|
|
|
|
// +kubebuilder:webhook:path=/mutate-deviceplugin-intel-com-v1-gpudeviceplugin,mutating=true,failurePolicy=fail,groups=deviceplugin.intel.com,resources=gpudeviceplugins,verbs=create;update,versions=v1,name=mgpudeviceplugin.kb.io,sideEffects=None,admissionReviewVersions=v1
|
|
|
|
var _ webhook.Defaulter = &GpuDevicePlugin{}
|
|
|
|
// Default implements webhook.Defaulter so a webhook will be registered for the type.
|
|
func (r *GpuDevicePlugin) Default() {
|
|
gpudevicepluginlog.Info("default", "name", r.Name)
|
|
|
|
if len(r.Spec.Image) == 0 {
|
|
r.Spec.Image = "intel/intel-gpu-plugin:" + gpuMinVersion.String()
|
|
}
|
|
}
|
|
|
|
// +kubebuilder:webhook:verbs=create;update,path=/validate-deviceplugin-intel-com-v1-gpudeviceplugin,mutating=false,failurePolicy=fail,groups=deviceplugin.intel.com,resources=gpudeviceplugins,versions=v1,name=vgpudeviceplugin.kb.io,sideEffects=None,admissionReviewVersions=v1
|
|
|
|
var _ webhook.Validator = &GpuDevicePlugin{}
|
|
|
|
// ValidateCreate implements webhook.Validator so a webhook will be registered for the type.
|
|
func (r *GpuDevicePlugin) ValidateCreate() error {
|
|
gpudevicepluginlog.Info("validate create", "name", r.Name)
|
|
|
|
if controllers.GetDevicePluginCount(gpuPluginKind) > 0 {
|
|
return errors.Errorf("an instance of %q already exists in the cluster", gpuPluginKind)
|
|
}
|
|
|
|
return r.validatePlugin()
|
|
}
|
|
|
|
// ValidateUpdate implements webhook.Validator so a webhook will be registered for the type.
|
|
func (r *GpuDevicePlugin) ValidateUpdate(old runtime.Object) error {
|
|
gpudevicepluginlog.Info("validate update", "name", r.Name)
|
|
|
|
return r.validatePlugin()
|
|
}
|
|
|
|
// ValidateDelete implements webhook.Validator so a webhook will be registered for the type.
|
|
func (r *GpuDevicePlugin) ValidateDelete() error {
|
|
gpudevicepluginlog.Info("validate delete", "name", r.Name)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *GpuDevicePlugin) validatePlugin() error {
|
|
if r.Spec.InitImage != "" {
|
|
if err := validatePluginImage(r.Spec.InitImage, "intel-gpu-initcontainer", gpuMinVersion); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return validatePluginImage(r.Spec.Image, "intel-gpu-plugin", gpuMinVersion)
|
|
}
|