Build multi-arch manifests (amd64 and arm64) for PR 'build`, 'master'
images, and 'release' images. In the doc/crds/daemonset-install.yaml
file, remove amd64-specific items, and use the 'latest' manifest that
will autoselect the appropriate architecture for the system.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
The build-push action for master 'latest-arm64' images were being done
for amd64 incorrectly. Fix this.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
The ARM image build complains of a qemu script not being present. It
seems that qemu is required for `docker buildx` to work.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Add the 'platforms' option to arm64 image builds. Otherwise, builds are
still in amd64 containers.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Whenever the docs folder - or the README - changes, there is no need to
run the unit tests, nor the e2e tests. As such, do not run those actions
when the code changes are purely related to docs.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
An issue template will help the community to know what information is required when requesting an enhancement from whereabouts.
This will improve the triage procedure, and reduce the back n' forth of the maintainers (no need to ask for info...).
An issue template will help the community to know what information is required for a bug.
This will improve the triage procedure, and reduce the back n' forth of the maintainers (no need to ask for info...).
* build: generate ip pool clientSet/informers/listers
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* vendor: update vendor stuff
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* build: vendor net-attach-def-client types
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* config: look for the whereabouts config file in multiple places
The reconciler controller will have access to the whereabouts
configuration via a mount point. As such, we need a way to specify its
path.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* reconcile-loop: requires the IP ranges in normalized format
The IP reconcile loop also requires the IP ranges in a normalized
format; as such, we export it into a function, which will be used in a
follow-up commit.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* config: allow IPAM config parsing from a NetConfList
Currently whereabouts is only able to parse network configurations in
the strict [0] format - i.e. **do not accept** a plugin list - [1].
The `ip-control-loop` must recover the full plugin configuration, which
may be in the network configuration format.
This commit allows whereabouts to now understand both formats.
Furthermore, the current CNI release - v1.0.Z - removed the support for
[0], meaning that only the configuration list format is now supported
[2].
[0] - https://github.com/containernetworking/cni/blob/v0.8.1/SPEC.md#network-configuration
[1] - https://github.com/containernetworking/cni/blob/v0.8.1/SPEC.md#network-configuration-lists
[2] - https://github.com/containernetworking/cni/blob/master/SPEC.md#released-versions
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* reconcile-loop: add a controller
Listen to pod deletion, and for every deleted pod, assure their IPs
are gone.
The rough algorithm goes like this:
- for every network-status in the pod's annotations:
- read associated net-attach-def from the k8s API
- extract the range from the net-attach-def
- find the corresponding IP pool
- look for allocations belonging to the deleted pod
- delete them using `IPManagement(..., types.Deallocate, ...)`
All the API reads go through the informer cache, which is kept updated
whenever the objects are updated on the API.
The dockerfiles are also updated, to ship this new binary.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* e2e tests: remove manual cluster reconciliation
This would leave the `ip-control-loop` as the reconciliation tool.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* unit tests: assure stale IPAllocation cleanup
This commit adds a unit where it is checked that the pod deletion leads
to the cleanup of a stale IP address.
This commit features the automatic provisioning of the controller informer cache
with the data present on the fake clientset tracker (the "fake" datastore).
This way, users can just create the client with provisioned data, and
that'll trickle down to the informer cache of the pod controller.
Because the `network-attachment-definitions` resources feature dashes,
the heuristic function that guesses - yes, guesses. very deterministic
... - the name of the resource can't be used - [0]. As such, it was
needed to create an alternate `newFakeNetAttachDefClient` where it is
possible to specify the correct resource name.
[0] - 2fd7267afc/vendor/k8s.io/client-go/testing/fixture.go (L331)
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* unit tests: move helper funcs to other files
The helper files are tagged with the `test` build tag, to prevent them
from being shipped on the production code binary.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* control loop, queueing: use a rate-limiting queue
Using a queue allows us to re-queue errors.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* control loop: add IPAllocation cleanup related events
Adds two new events related to garbage collection of the whereabouts IP
addresses:
- when an IP address is garbage collected
- when a cleanup operation fails and is not re-queued
The former event looks like:
```
116s Normal IPAddressGarbageCollected pod/macvlan1-worker1 \
successful cleanup of IP address [192.168.2.1] from network \
whereabouts-conf
```
The latter event looks like:
```
10s Warning IPAddressGarbageCollectionFailed failed to garbage \
collect addresses for pod default/macvlan1-worker1
```
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* e2e tests: check out statefulset scenarios
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* e2e tests: test different scale up/down order and instance deltas
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* ci: test e2e bash scripts last
These ugly tests do not cleanup after themselves; this way, the golang
based tests (which **do** cleanup after themselves) will not be impacted by
these left-overs.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* ip control loop, unit tests: test negative scenarios
Check the event thrown when a request is dropped from the queue, and
assure reconciling an allocation is impossible without having access to
the attachment configuration data.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* e2e tests: test fix for issue #182
Issue [0] reports an error when a pod associated to a `StatefulSet`
whose IPPool is already full is deleted. According to it, the new pod -
scheduled by the `StatefulSet` - cannot run because the IPPool is
already full, and the old pod's IP cannot be garbage collected because
we match by pod reference - and the "new" pod is stuck in `creating`
phase.
[0] - https://github.com/k8snetworkplumbingwg/whereabouts/issues/182
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* ip-control-loop: strip pod before queueing it
The ip reconcile loop only requires the pod metadata and its network
status annotatations to garbage collect the stale IP addresses.
As such, we remove the status and spec parameters from the pod before
queueing it.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* reconcile-loop: focus on networks w/ whereabouts IPAM type
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
The new `staticcheck` release - v0.3.0 - can only be installed on golang
1.17 or 1.18, since golang 1.16 already hit EOL.
This is tracked in issue [0].
A follow up PR should update whereabouts to use golang 1.17, but this PR
unlocks CI right now.
[0] - https://github.com/dominikh/go-tools/issues/1238
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Goling is deprecated, as per their page [0]; its readme says that tools
such as `go vet` and `staticcheck` should be used instead.
As such, this patch replaces golint with the suggested tools.
[0] - https://github.com/golang/lint
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Pass the path to the kubeconfig, and cleanup some variables that are not
in use.
Also, ensure that the e2e tests are not executed when the
`hack/test-go.sh` script is executed - that is for the unit tests only.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* build: synch the golang builders w/ the go version on go.mod
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
* build: use golang 1.16
Bump the golang version in the module file and in the Dockerfiles
used to build the images.
The github actions config files are also updated accordingly.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Before checking for stale IP addresses, trigger the `ip-reconciler`
tool, which will cleanup stale IP addresses.
In order to manually run the reconciler, we need to build it first;
as such, the github action must be updated.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Test cases are simple and check that:
* IPs seen in IP pool are what is assigned
to pods.
* No stale IPs in IP pool following test run.
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
The binaries (built for amd64, arm64 and arm) are uploaded using a
Github workflow every time a new Github release is created. This
simplifies consumption of these binaries by other projects, and creates
an "official" build.
Signed-off-by: Antonin Bas <abas@vmware.com>
