github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary BuildableIOSApp from "build ios-framework" (#49659)

Browse Source
This commit is contained in:
Jenn Magder 2020-01-29 14:27:43 -08:00 committed by GitHub
parent d85ea51384
commit 02dc0ab37f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View File

@ -9,7 +9,6 @@ import 'package:meta/meta.dart';
import 'package:platform/platform.dart';
import '../aot.dart';
import '../application_package.dart';
import '../artifacts.dart';
import '../base/common.dart';
import '../base/file_system.dart';
@ -159,16 +158,15 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
throwToolExit('--output is required.');
}
final BuildableIOSApp iosProject = await applicationPackages.getPackageForPlatform(TargetPlatform.ios) as BuildableIOSApp;
if (iosProject == null) {
throwToolExit("Module's iOS folder missing");
if (!_project.ios.existsSync()) {
throwToolExit('Module does not support iOS');
}
final Directory outputDirectory = globals.fs.directory(globals.fs.path.absolute(globals.fs.path.normalize(outputArgument)));
final String productBundleIdentifier = await _project.ios.productBundleIdentifier;
for (final BuildMode mode in buildModes) {
globals.printStatus('Building frameworks for $iosProject in ${getNameForBuildMode(mode)} mode...');
globals.printStatus('Building frameworks for $productBundleIdentifier in ${getNameForBuildMode(mode)} mode...');
final String xcodeBuildConfiguration = toTitleCase(getNameForBuildMode(mode));
final Directory modeDirectory = outputDirectory.childDirectory(xcodeBuildConfiguration);