github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix CODEOWNERS after monorepo merge (#165217)

Browse Source 
GitHub's CODEOWNERS feature [picks the first file it finds in the root,
`.github/`, or `docs/`
directory](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location).
GitHub does not support nested CODEOWNERS files.

For example, this PR updates the embedder API but did not request
reviews from the embedder API reviewers:
https://github.com/flutter/flutter/pull/164577

To fix this, this merges all `CODEOWNERS` files to the root of the repo.

cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.
This commit is contained in:
Loïc Sharma 2025-03-26 13:32:14 -07:00 committed by GitHub
parent 78d0639743
commit 5c3bc83f26
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
CODEOWNERS
View File

@ -6,11 +6,18 @@
#
# Use git ls-files '<pattern>' without a / prefix to see the list of matching files.
/packages/flutter_tools/templates/module/ios/ @jmagman
/packages/flutter_tools/templates/**/Podfile* @jmagman
/packages/flutter_tools/lib/src/ios/ @jmagman
/engine/src/build/config/ios/** @vashworth
/packages/flutter_tools/templates/module/ios/ @vashworth
/packages/flutter_tools/templates/**/Podfile* @vashworth
/packages/flutter_tools/lib/src/ios/ @vashworth
# flutter_driver, integration_test, and internal dev infra.
/dev/** @matanlurey
/packages/flutter_driver/** @matanlurey
/packages/integration_test/** @matanlurey
# The following files define an Application Binary Interface (ABI) that must maintain
# both forward and backward compatibility. Changes should be heavily
# scrutinized as mistakes are irreversible.
/engine/src/flutter/shell/platform/embedder/embedder.h @cbracken @chinmaygarde @loic-sharma
/engine/src/flutter/shell/platform/embedder/tests/embedder_frozen.h @cbracken @chinmaygarde @loic-sharma

9
engine/src/CODEOWNERS
View File

@ -1,9 +0,0 @@
# Below is a list of Flutter hackers GitHub handles who are
# suggested reviewers for contributions to this repository.
#
# These names are just suggestions. It is fine to have your changes
# reviewed by someone else.
#
# Use git ls-files '<pattern>' without a / prefix to see the list of matching files.
/build/config/ios/** @jmagman

5
engine/src/flutter/CODEOWNERS
View File

@ -1,5 +0,0 @@
# The following files define an Application Binary Interface (ABI) that must maintain
# both forward and backward compatibility. Changes should be heavily
# scrutinized as mistakes are irreversible.
/shell/platform/embedder/embedder.h @cbracken @chinmaygarde
/shell/platform/embedder/tests/embedder_frozen.h @cbracken @chinmaygarde @loic-sharma

2
engine/src/flutter/ci/licenses_golden/excluded_files
View File

@ -3,7 +3,6 @@
../../../.gitignore
../../../.gn
../../../AUTHORS
../../../CODEOWNERS
../../../README.md
../../../build
../../../build_overrides
@ -16,7 +15,6 @@
../../../flutter/.gitignore
../../../flutter/.style.yapf
../../../flutter/AUTHORS
../../../flutter/CODEOWNERS
../../../flutter/CONTRIBUTING.md
../../../flutter/Doxyfile
../../../flutter/README.md