github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Turn off unused changes report during hot reload (#16520)

Browse Source 
* A new UI is being designed to make the unused reload messaging clearer,
the UI will use the coverage data to highlight lines in the UI that were not executed during a reload.

In lieu of that we are turning off the unused reload messages experiment.

There were some issues in Dart2 also with this functionality
- source fingerprinting is not implemented in Dart2
- some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out.
This commit is contained in:
Siva 2018-04-12 14:24:10 -07:00 committed by GitHub
parent 5129d8ffa6
commit dbddcf26b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/run_hot.dart
View File

@ -500,6 +500,7 @@ class HotRunner extends ResidentRunner {
// change from host path to a device path). Subsequent reloads will
// not be affected, so we resume reporting reload times on the second
// reload.
final bool reportUnused = !debuggingOptions.buildInfo.previewDart2;
final bool shouldReportReloadTime = !_runningFromSnapshot;
final Stopwatch reloadTimer = new Stopwatch()..start();
@ -660,7 +661,7 @@ class HotRunner extends ResidentRunner {
flutterUsage.sendTiming('hot', 'reload', reloadTimer.elapsed);
String unusedElementMessage;
if (!reassembleAndScheduleErrors && !reassembleTimedOut) {
if (reportUnused && !reassembleAndScheduleErrors && !reassembleTimedOut) {
final List<Future<List<ProgramElement>>> unusedReports =
<Future<List<ProgramElement>>>[];
for (FlutterDevice device in flutterDevices)