github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove a misfiring assert in the test framework plugin (#7397)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/7351

When a test runs to completion, the test harness closes the stream side of the
StreamChannel, causing the sink side to be closed as well.  So by the time we
receive a test result of completed/harnessBailed, the controller sink has been
closed.
This commit is contained in:
Jason Simmons 2017-01-09 16:52:00 -08:00 committed by GitHub
parent 2eecb8be37
commit fb8179bfed
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter_tools/lib/src/test/flutter_platform.dart
View File

@ -164,7 +164,6 @@ class FlutterPlatform extends PlatformPlugin {
harnessToTest.cancel(); harnessToTest.cancel();
testToHarness.cancel(); testToHarness.cancel();
assert(!controllerSinkClosed);
switch (testResult) { switch (testResult) {
case _TestResult.crashed: case _TestResult.crashed:
int exitCode = await process.exitCode; int exitCode = await process.exitCode;