Commit Graph

9340 Commits

Author SHA1 Message Date
Alexander Aprelev
07c592d901
Report early error if appropriate host local engine is not found. (#26766) 2019-01-18 11:26:54 -08:00
MH Johnson
5d0c1b86ee
[Material] Inline the single Theme.of(context) call in BAB (#26765) 2019-01-18 14:13:14 -05:00
Jonah Williams
8c5a41113e
Add support for reverse to ReorderableListView (#26203) 2019-01-18 10:10:44 -08:00
Jonah Williams
830c0dfe83
Allow attaching to profile builds (#26720) 2019-01-18 10:09:44 -08:00
Greg Spencer
179fa90489
Fix some doc references (#26441) 2019-01-18 10:07:55 -08:00
Liam Appelbe
9eada88b3e
Experimental flags in flutter (#26715)
* exp flags in flutter

* Fix test failures
2019-01-18 09:07:14 -08:00
jslavitz
4fe79442c8 Reverts default DragStartBehavior to DragStartBehavior.down (#26734) 2019-01-17 19:36:48 -08:00
Jason Simmons
f4c5e3eef2
[Gradle] Copy ICU data to flutter_shared only when building an AAR module (#26668)
This is based on 9880baa396
but will support building APKs with --local-engine
2019-01-17 16:33:14 -08:00
MH Johnson
6c07863f8d
[Material] Refactor _build<Widget> methods in BottomNavBar (#26722) 2019-01-17 19:02:34 -05:00
Konstantin Pozin
29fb6159db [flutter_localizations] Add BUILD.gn for flutter_localizations (#26440) 2019-01-17 15:47:57 -08:00
mcplectrum
b4daf33807 Fix Podfile issue #24342 (#25079)
* Fix Podfile issue #24342

Sometimes base configurations  (config.base_configuration_reference) can be nil, which leads to undefined method `real_path' for nil:NilClass.

* Disable bitcode in every case
2019-01-17 15:00:51 -08:00
Michael Goderbauer
45a70efa8a
Respect EditableText.keyboardAppearance (#26721) 2019-01-17 14:54:35 -08:00
Will Larche
60e9c5856d
[FAB] Adding FAB as class in tests. (#26192)
* [FAB] Adding FAB as class in tests.

* [Material] FAB theme tests corrected. Also deeper into Material for elevation testing.

* [Material] Comment clarification.

* [Material] TODO formatting.

* [Material] Formatting.

* [Material] Comment correction.

* [Material] Updated values.

* [Material] Removing comment, low-level check, and adding safety.
2019-01-17 14:39:22 -08:00
Stanislav Baranov
eb8219edd5
Emulator support for dynamic mode on Intel architecture (#26565) 2019-01-17 14:21:35 -08:00
David Shuckerow
9e4c964072
Add animation tests for changes to the FloatingActionButtonLocation (#23677)
* Add more animation tests for rotation

* Test animation progress

* Progress on the tests

* Everything 'works'

* We don't need to guarantee the rotation of the fab as it exits.

* Remove print statement

* Cleanup extra lines

* Remove whitespace
2019-01-17 14:48:28 -06:00
Michael Goderbauer
975ea595e9
Fix missing const analyzer warning (#26716)
Introduced by merging an old PR (https://github.com/flutter/flutter/pull/21157).
2019-01-17 12:23:55 -08:00
Remi Rousselet
649f49d4bf Swap scope with gesture (#21157) 2019-01-17 11:11:35 -08:00
Michael Goderbauer
56039b4ba7
Make getOffsetToReveal work with nested Viewports (#26663)
Fixes #20893, the most-upvoted bug for framework.

A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Gazihan Alankus
7e22b5f2c5 Doc fix: SliverChildBuilderDelegate is the lazy one (#26690) 2019-01-17 09:51:50 -08:00
Jonah Williams
fb2467d0af
Add documentation for how to use annotated region (#24989) 2019-01-17 09:30:05 -08:00
abykov2
3c0a74ef0f Adding a shutdown hook to HotRunnerConfig (#26604) 2019-01-17 08:49:02 -08:00
Kenzie Schmoll
33bfa6a7c5
Register hotRestart service in flutter_tools. (#26669)
* Register hot restart service in flutter_tools.
2019-01-17 08:28:54 -08:00
Danny Tuppeny
244b077bee
Give integration tests unique temp folder names (#26227)
This will help track down any that aren't cleaning up and also may help track down leaked flutter_tester processes (https://github.com/dart-lang/sdk/issues/35549).
2019-01-17 11:29:18 +00:00
Jonah Williams
83b9497c69
do not exit tool if fuchsia workflow fails (#26589) 2019-01-16 17:43:01 -08:00
Ian Hickson
800a6e1670 Quick fix for tap-to-show-keyboard regression (#26629)
* Fixes Android keyboard bug
2019-01-16 17:30:26 -08:00
Dan Field
4c99958df6
Revert "Move flutter_assets to App.framework (#26630)" (#26675)
This reverts commit d8db70af1a.
2019-01-16 16:46:37 -08:00
Luca Zuccarini
36a493602c Create an injectable factory for application packages. (#26422) 2019-01-16 14:12:47 -08:00
Dan Field
d8db70af1a
Move flutter_assets to App.framework (#26630)
* move flutter_assets to App.framework

* remove flutter_assets references from all pbxproj files checked in
2019-01-16 14:02:54 -08:00
Vyacheslav Egorov
8f65ee9f53
Fix --build-shared-library on newer NDKs (#26642)
Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.

Fixes #23458
2019-01-16 21:30:37 +01:00
Kenzie Schmoll
a172de0159
Send ServiceExtensionToggled event when service extension is set to a value. (#26426) 2019-01-16 12:29:20 -08:00
Vyacheslav Egorov
7c434a5cf2
Revert "Add flutter_shared assets to module artifact (#23782)" (#26644)
This reverts commit 9880baa396.

Reason for revert: broke `--local-engine` command line option.
2019-01-16 21:23:18 +01:00
Kyrel Jerome
a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Chris Bracken
9a7b1a73bd
Replace platform check with swtich (#24752)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-16 10:31:44 -08:00
MH Johnson
5e8e39723d
[Material] TabBarTheme text style parameters (#26533)
* Add labelStyle + unselectedLabelStyle to TabBarTheme
2019-01-16 13:30:21 -05:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Justin McCandless
14faa8d935
Fix rounding error in build tests (#26652) 2019-01-16 09:48:04 -08:00
Michael Goderbauer
b4e9d0a440
Add tests for getOffsetToReveal on RenderSlivers (#26598) 2019-01-16 08:47:37 -08:00
rami-a
f22043e25f
Prevent crash when calling lerp for IconThemeData with null arguments (#26592)
The lerp method for IconThemeData was not doing anything to prevent exceptions when null arguments are used. This change fixes that and adds a test for it.
2019-01-16 11:42:29 -05:00
Hans Muller
14f486685e
Updated AlertDialog content doc (#26613) 2019-01-16 08:35:51 -08:00
Hans Muller
fbedd97682
IconButton backgroundColor doc sample (#26611) 2019-01-16 08:35:34 -08:00
Justin McCandless
105026cd68
Fix descenders cutoff in TextField (#26309)
* Include caret gaps in position calculation to avoid descender cutoff

* Calculate caret offset instead of exposing it

* Test that textfields scroll vertically by full line height

* Only add offset to end of caret to avoid going above 0.0

* Fix and test horizontal vs. vertical scrolling

* CR: docs and top caret offset logic

* Take max instead of assuming caretRect.top is always a full line down

* Always subtract caretOffset from caretTop since caretRect.top can be negative
2019-01-16 08:13:00 -08:00
Chris Bracken
584ef083c7
Replace Android-specific check with switch (#24754)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-15 19:42:55 -08:00
Seth Westphal
71a15896d8 Fix error message and other typos (#25126) 2019-01-15 19:22:32 -08:00
Michael Goderbauer
f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Michael Goderbauer
e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 (#26596) 2019-01-15 19:00:05 -08:00
Gary Qian
fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson
29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00
Chris Bracken
d7458e3da4
Add asserts for @required parameters (#26449)
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:

  package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.

becomes:

  package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
2019-01-15 10:24:06 -08:00
Igor Borges
9880baa396 Add flutter_shared assets to module artifact (#23782)
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
2019-01-15 10:23:19 -08:00
Amir Hardon
cbff7ca43c
Cleanup temporary catchError. (#26454)
This was added to make sure we don't crash before the engine is rolled
with the system channel API addition and is no longer needed.
2019-01-15 10:13:48 -08:00