Commit Graph

1300 Commits

Author SHA1 Message Date
Nils Reichardt
64db621980
Remove new keyword in a few files (#104438) 2022-06-06 16:08:06 -07:00
Darren Austin
c27a1a70f3
Update material_color_utilities dependency to 0.1.5. (#104771) 2022-05-27 11:18:12 -07:00
Anna Gringauze
5cd979e441
Retry getting tabs in chrome launcher on ConnectionException (#104218) 2022-05-26 15:20:11 -07:00
Pierre-Louis
74cfc3db67
Use curly_braces_in_flow_control_structures for non-flutter packages (#104629)
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`

* fix comments

* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`

* fix indentation
2022-05-25 20:01:11 +02:00
Michael Goderbauer
2b14e993a7
Cleanup random dead test code (#104568) 2022-05-25 10:23:10 -07:00
Xilai Zhang
de230d393c
Revert "Add ability for ModalRoutes to ignore pointers during transitions and do so on Cupertino routes (#95757)" (#104520)
This reverts commit 4c0b0be2da.
2022-05-24 11:10:13 -07:00
Casey Hillers
da105b2b24
Revert "[framework] inline AbstractNode into RenderObject" (#104257) 2022-05-20 11:43:11 -07:00
Tong Mu
23bc3d64eb
[Mouse] Remove all pointers at the end of tests (#102694) 2022-05-19 17:48:10 -07:00
Will Lockwood
4c0b0be2da
Add ability for ModalRoutes to ignore pointers during transitions and do so on Cupertino routes (#95757) 2022-05-19 15:33:12 -07:00
Jonah Williams
24bd28f696
[framework] inline AbstractNode into RenderObject (#103832) 2022-05-19 14:28:09 -07:00
Chris Bracken
27c6cdb416
Roll dependendencies (#103771)
Roll dependendencies

This rolls depdendencies to latest using
flutter update-packages --force-upgrade

This change includes three code changes:

* Removes charcode from the dependencies allowlist since it no longer
  appears in the transitive closure of dependencies of the flutter,
  flutter_test, flutter_driver, flutter_localizations, and
  integration_test packages.

* Uses Resolver.create instead of the deprecated Resolver constructor.
  The default Resolver constructor has been deprecated in favour of the
  static Resolver.create() factory function, which unfortunately happens
  to be async. Propagated the async-ness up the chain.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

* Eliminates the use of the deprecated packagesPath parameter to
  HitMap.parseJson. This parameter was deprecated and replaced with
  packagePath in https://github.com/dart-lang/coverage/pull/370 which
  was part of the overall deprecation of the .packages file in Dart
  itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
  being that end-user code shouldn't need to know about implementation
  details such as whether dependency information is stored in a
  .packages file or a package_info.json file, but rather use the
  package_config package to obtain the package metadata and perform
  other functions such as resolving its dependencies to filesystem
  paths. packagesPath was replaced by packagePath, which takes the path
  to the package directory itself. Internally, package:coverage then
  uses package_config to do the rest of the package/script URI
  resolution to filesystem paths.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

This is a pre-update prior to updating flutter_template_images in
https://github.com/flutter/flutter/pull/103739

Issue: https://github.com/flutter/flutter/issues/103371
Issue: https://github.com/flutter/flutter/issues/103775
Issue: https://github.com/flutter/flutter/issues/103830

When re-applying the partially-reverted changes to code coverage,
we'll need to patch host_entrypoint.dart internally to await the Future
that we'll be returning rather than a non-async value.
2022-05-14 16:34:10 -07:00
Christopher Fujino
e8c01a8aa8
[flutter_tools] pub roll (#103220)
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2022-05-10 10:26:54 -07:00
xubaolin
b20e27e77e
Does not replace the root layer unnecessarily (#101748) 2022-05-05 18:44:10 -07:00
Callum Moffat
b5321d182a
Reland "Fix position of CupertinoContextMenu within Transform.scale" (#102943)
* Fix position of CupertinoContextMenu within Transform.scale (#97896)

* Fix after rebase
2022-05-04 11:13:21 +02:00
Phil Quitslund
20f029e3bc
[devicelab, flutter_test, ...] rename local functions with _s (#102833) 2022-05-03 10:29:06 -07:00
Darren Austin
7965ee25dd
Revert "Fix position of CupertinoContextMenu within Transform.scale (#97896)" (#102938)
This reverts commit 6ddb99e98f.
2022-05-02 13:40:12 -07:00
Callum Moffat
6ddb99e98f
Fix position of CupertinoContextMenu within Transform.scale (#97896) 2022-05-02 21:56:09 +02:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Sai Sandeep Mutyala
7b580fd5df
Enable TestDefaultBinaryMessenger to intercept all platform channels. (#100049) 2022-04-25 10:44:07 -07:00
Daniel Cardona Rojas
a3a9a23e46
Add matcher to find at least a given number of widgets (#102081) (#102342) 2022-04-22 15:24:10 -07:00
chunhtai
2ebc7bee9c
Adds tooltip to semantics node (#87684) 2022-04-21 12:14:09 -07:00
8rine23
9313fb8e28
The sample code used within the comments in textContaining is wrong (#100860) 2022-04-20 14:36:14 -07:00
chunhtai
796df06c32
Add API sample code to AccessibilityGuideline (#102161) 2022-04-19 14:34:08 -07:00
Callum Moffat
30a501801a
Support trackpad gestures in framework (#89944)
* Implement trackpad gestures in framework

* Touch and Pan/Zoom pointers have separate IDs now

* Handle trackpad pointer device type

* Respect supportedDevices for pan/zoom events

* Update after rebase

* Fix check failures

* Avoid error with very short drags

* Address feedback

* Refactor drag event handler

* Address more feedback

* Add some missing punctuation
2022-04-12 19:47:01 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
Greg Spencer
efe76a5373
Update key examples to use Focus widgets instead of RawKeyboardListener (#101537)
This updates the examples for PhysicalKeyboardKey and LogicalKeyboardKey to use Focus widgets that handle the keys instead of using RawKeyboardListener, since that usually leads people down the wrong path. Updated the See Also and added tests as well. Also exposed the `physicalKey` attribute for `tester.sendKeyEvent`.
2022-04-08 12:05:41 -07:00
Anna Gringauze
74944d528f
Run update-packages (#101450)
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
2022-04-07 17:07:05 -07:00
matasb-google
120b3deb18
Improve A11Y guidelines/tests for flutter (#100267)
* Incorrect size comparison
* Code cleanup/formatting
* Additional tests
2022-04-06 10:59:37 +02:00
Michael Goderbauer
3e406c6781
Prepare packages (minus tools,framework) for use_super_parameters (#100510) 2022-03-30 15:31:59 -07:00
Christopher Fujino
ef8e3578c1
[flutter_tools] update pub packages (#100726) 2022-03-25 16:45:09 -07:00
Brian Quinlan
f6c4c3df19
Remove unnecessary ignore: override_on_non_overriding_member (#99793) 2022-03-16 19:10:17 -07:00
Harsh Bhikadia
fece72cac7
docs(flutter_test): fix mention of non-existing matchesSemanticsNode (#99659) 2022-03-16 18:55:18 -07:00
moko256
13bf7515f4
Web: treat modifier key without location (#98460) 2022-03-15 19:50:10 -07:00
Valentin Marquis
4f4c7816c3
Fix/text containing finder work with rich texts (#99682) 2022-03-13 23:35:07 -07:00
Ben Konyi
1880066dd3
Update dependencies (#99874) 2022-03-10 14:13:59 -07:00
Jonah Williams
67f25caf72
Remove package:typed_data from package:flutter dependencies (#99604) 2022-03-07 10:41:21 -08:00
Viren Khatri
671aa9e95e
complete migration of flutter repo to Object.hash* (#99505) 2022-03-04 12:56:21 -08:00
Michael Goderbauer
852bfe2a73
Use BindingBase.platformDispatcher over BindingBase.window where possible (#99443) 2022-03-04 11:11:07 -08:00
LongCatIsLooong
81464ff642
Reland "[EditableText] honor the "brieflyShowPassword" system setting #97769 " (#98150) 2022-02-11 02:30:14 -08:00
Brian Quinlan
76855aa893
Add keyLog and connectionFactory to HttpClient implementations (#98045) 2022-02-11 00:35:16 -08:00
Callum Moffat
3f9c0e74f2
PointerDeviceKind forwards-compatibility in flutter_test (#98202) 2022-02-10 19:50:27 -08:00
godofredoc
3bdea6bb92
Revert "[EditableText] honor the "brieflyShowPassword" system setting (#97769)" (#98089)
This reverts commit 63f48d1ff8.
2022-02-08 20:11:08 -08:00
LongCatIsLooong
63f48d1ff8
[EditableText] honor the "brieflyShowPassword" system setting (#97769) 2022-02-08 17:50:20 -08:00
Jonah Williams
4f975cbe2f
[framework] inline casts on Element.widget getter to improve web performance (#97822) 2022-02-08 13:05:21 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Harry Terkelsen
03f1d37935
Add a benchmark for a scrolling list of Links (#94638) 2022-02-03 14:38:58 -08:00
Pierre-Louis
a22cf5d6b9
Update packages (#97592)
* update packages

* implement

* remove trailing spaces

* Revert "remove trailing spaces"

This reverts commit d3bffbef57.

* Revert "implement"

This reverts commit 6b6172a827.
2022-02-02 09:16:05 +01:00
Jami Couch
af89a25e5b
Re-land "Support Scribble Handwriting" (#96615) (#97437) 2022-02-01 09:50:07 -08:00
Justin McCandless
40c4da5cb8
Revert "Re-land "Support Scribble Handwriting" (#96615) (#96881)" (#97405)
This reverts commit c54ce01575.
2022-01-27 16:11:02 -08:00
Jami Couch
c54ce01575
Re-land "Support Scribble Handwriting" (#96615) (#96881) 2022-01-27 15:10:21 -08:00
Lasse R.H. Nielsen
b8fd21b04e
Adds CommonFinders.bySubtype<T extends Widget>() finder. (#91415) 2022-01-25 12:35:14 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Alberto
ee6a693cde
chore(flutter_test): updated 'matchesGoldenFile' documentation (#96194) 2022-01-20 15:25:20 -08:00
Konstantin Scheglov
06515fe058
Ignore in _Location (#96553) 2022-01-13 13:25:05 -08:00
LongCatIsLooong
9c23106711
Revert "Support Scribble Handwriting" (#96615) 2022-01-13 12:00:19 -08:00
Michael Goderbauer
40a2689b9c
enable unnecessary_late (#96417) 2022-01-12 21:10:19 -08:00
Michael Goderbauer
5ac9714066
Enable no_leading_underscores_for_library_prefixes (#96420) 2022-01-11 17:35:13 -08:00
Jami Couch
9490917408
Support Scribble Handwriting (#75472) 2022-01-11 11:00:12 -08:00
Jenn Magder
3e6e996f9e
Run update-packages --force-upgrade (#96325) 2022-01-10 13:55:16 -08:00
Andrei Diaconu
a35e7aaed9
Add display features to MediaQuery (#92906) 2021-12-21 10:04:19 -08:00
Rami
1a3dc1b32a
Update color scheme seed generation to use color utils package (#95175)
* Update color scheme seed generation to use color utils package
2021-12-14 13:53:36 -08:00
Jia Hao
22dd0f42ef
[flutter_test] Fix incorrect missed budget count (#95003) 2021-12-10 18:44:11 -08:00
Michael Goderbauer
5a862ebecd
Replace dynamic with Object? in SystemChannels (#94629) 2021-12-03 15:34:04 -08:00
chunhtai
049ea73c4d
MinimumTextContrastGuideline should exclude disabled component (#94489) 2021-12-01 20:19:02 -08:00
Darren Austin
418cd95661
Added material_color_utilities as a dependency for flutter package. (#94377) 2021-12-01 14:19:04 -08:00
Nick Abalov
544527caa5
Skip links in MinimumTapTargetGuideline. (#93869) 2021-11-30 17:34:05 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
nt4f04uNd
3a18e6ee42
Fix reassemble in LiveTestWidgetsFlutterBinding (#92217) 2021-11-22 02:01:00 -08:00
Alexander Dahlberg
fbf8391288
Fixed leak and removed no-shuffle tag in window_test.dart (#93604) 2021-11-17 14:53:04 -08:00
Jacob MacDonald
a4fa2affe9
Update packages (#92924) 2021-11-05 12:03:03 -07:00
Ian Hickson
299d484903
Enable more lints (#91642) 2021-10-14 22:03:03 -07:00
Ian Hickson
9421627324
Enable only_throw_errors (#91567) 2021-10-11 14:13:03 -07:00
Ian Hickson
f90b019c68
Enable prefer_relative_imports and fix files. (#91573) 2021-10-11 10:28:07 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Ian Hickson
2bab6514b0
Enable avoid_implementing_value_types lint (#91078) 2021-10-04 13:48:04 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
Kenzie (Schmoll) Davisson
15967669b2
Add richMessage parameter to the Tooltip widget. (#88539) 2021-09-29 15:31:54 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Ian Hickson
2420718389
Remove our extra timeout logic. (#89952) 2021-09-15 09:42:05 -07:00
Sam Rawlins
bcb5db7758
Remove "unnecessary" imports from packages/ (#89795) 2021-09-15 01:27:02 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Jim Graham
abfb889fff
Add raster cache metrics to timeline summaries (#89393) 2021-09-04 18:31:03 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar (#88439) 2021-09-03 15:09:31 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
嘟囔
7df68b906c
feat: widget finders add widgetWithImage method (#89020) 2021-08-26 22:11:02 -07:00
嘟囔
86fd222fab
feat: add Image support to finder (#88761) 2021-08-26 12:51:05 -07:00
Dan Field
c5861cfb56
Revert "Fix DPR in test view configuration (#88609)" (#88889)
This reverts commit 5feee0d8fa.
2021-08-25 10:09:03 -07:00
Dan Field
5feee0d8fa
Fix DPR in test view configuration (#88609) 2021-08-24 14:26:54 -07:00
creativecreatorormaybenot
87b17c8ccf
Add RichText support to find.text() (#87197) 2021-08-23 14:47:29 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
nt4f04uNd
123ec80cfd
init (#88427) 2021-08-20 14:57:03 -07:00
Christopher Fujino
81eb54bf78
update-packages (#88387) 2021-08-17 18:49:32 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Gary Qian
a562b3cb3d
Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Tong Mu
31d0787d20
Revert "Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297)" (#88293)
This reverts commit 91f8b6be51.
2021-08-16 09:38:25 -07:00
Tong Mu
91f8b6be51
Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297)
This reverts commit ccf6f0353a.

New impl

Remove temp

Format
2021-08-11 00:37:54 -07:00
Darren Austin
271ed8b21f
Updated skipped tests for flutter_test directory. (#87880) 2021-08-09 11:06:35 -07:00
Jonah Williams
5792c7347c
Use Device specific gesture configuration for scroll views (#87604) 2021-08-09 10:50:02 -07:00
Anna Gringauze
cc63c81408
Update all packages (#87579)
- Update dwds and and the rest of the packages

Closes: https://github.com/flutter/flutter/issues/87100
2021-08-03 16:37:48 -07:00
Jonah Williams
0d3b44e835
[flutter] replace 'checked mode' with 'debug mode' (#87408) 2021-08-03 13:25:05 -07:00
Darren Austin
8322e178fa
Revert "Added 'exclude' parameter to 'testWidgets()'. (#86397)" (#87515) 2021-08-02 18:05:04 -07:00
chunhtai
67cee63087
Add string attribute api to text span (#86667) 2021-07-30 15:49:04 -07:00
Cody Goldberg
ab6ce71402
[flutter_test/integration_test] added setSurfaceSize test coverage (#82712)
This PR includes an updated test case for integration_test and a new test case for flutter_test to ensure that hit tests transform properly when using setSurfaceSize, for both the IntegrationTestWidgetsFlutterBinding and LiveTestWidgetsFlutterBinding bindings.
2021-07-30 13:47:20 -07:00
Tong Mu
a7899c1961
[gen_keycodes] Remove nonexistent Web keys and improve their emulation (#87098) 2021-07-29 16:44:06 -07:00
Tong Mu
884158a6e3
Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#87239)
* Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912)" (#87233)"

This reverts commit 5b80d32a84.

* Record tap positions
2021-07-29 15:11:26 -07:00
Tong Mu
caf876cf40
Reland: Keyboard events (#87174) 2021-07-29 14:24:03 -07:00
Tong Mu
ccf6f0353a
Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)
This reverts commit 7707f42318.
2021-07-29 01:50:54 -07:00
Tong Mu
7707f42318
Restores surface size in the postTest of test binding (#87240) 2021-07-28 19:28:28 -07:00
Tong Mu
5b80d32a84
Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912)" (#87233)
This reverts commit b50991d683.
2021-07-28 15:44:09 -07:00
Jason Simmons
fca95838e6
Restore the WidgetTester's original surface size after testing setSurfaceSize (#87202)
Fixes https://github.com/flutter/flutter/issues/87194
2021-07-28 09:40:08 -07:00
Tong Mu
2f4f170dd2
Revert "Keyboard events (#83752)" (#87171)
This reverts commit 5f792ba170.
2021-07-28 02:32:08 -07:00
Tong Mu
b50991d683
Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912) 2021-07-27 14:44:03 -07:00
Greg Spencer
738ce43d97
Randomize tests, exclude tests that fail with randomization. (#86793)
* Randomize tests, exclude tests that fail with randomization.

* Disable some more tool tests
2021-07-26 23:40:49 -07:00
Tong Mu
5f792ba170
Keyboard events (#83752) 2021-07-26 12:28:05 -07:00
Darren Austin
eb62bce924
Added 'exclude' parameter to 'testWidgets()'. (#86397) 2021-07-22 12:35:40 -07:00
Tong Mu
24ad608bd8
Revert "Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86739)" (#86823)
This reverts commit cf3d9409b3.
2021-07-21 16:13:10 -07:00
Tong Mu
cf3d9409b3
Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86739)
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-21 12:49:26 -07:00
Michael Goderbauer
b0e51db8d5
Fixes for upcoming changes to avoid_classes_with_only_static_members (#86744) 2021-07-20 16:12:12 -07:00
Emmanuel Garcia
0504fac7e2
Android e2e screenshot (#84472) 2021-07-20 13:36:04 -07:00
Kate Lovett
8802e325a0
Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86449)" (#86730)
This reverts commit cd78190b0c.
2021-07-20 14:56:50 -04:00
Danny Tuppeny
91b67e8eb1
Add a "variant: " prefix to variant descriptions in test names (#86701) 2021-07-20 09:16:03 -07:00
Tong Mu
cd78190b0c
Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86449)
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-19 14:54:24 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs (#86438)" (#86484)
This reverts commit d056500bfe.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs (#86438) 2021-07-14 14:41:24 -07:00
Eng Zer Jun
57a4b023f1
build: update dependencies (#86433) 2021-07-14 13:46:04 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs (#86388)" (#86404)
This reverts commit 31de052e3f.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs (#86388) 2021-07-13 18:31:11 -07:00
Jonah Williams
2900347afe
[flutter] prevent errant text field clicks from losing focus (#86041) 2021-07-13 16:46:04 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs (#83843)" (#86386)
This reverts commit e2490f2906.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs (#83843) 2021-07-13 12:41:03 -07:00
Yegor
78e06e716b
[web] move e2e tests from flutter/engine to flutter/flutter (#86119)
* [web] move e2e tests from flutter/engine to flutter/flutter
* flutter update-packages --force-upgrade
2021-07-09 15:31:49 -07:00
Alexandre Ardhuin
80990c21e2
code formatting (#85783) 2021-07-07 23:06:05 -07:00
Kaushik Iska
eb742ea8fe
Specify rasterFinishWallTime (#85731)
This is to transition `rasterFinishWallTime` to a required field in `dart:ui`.
2021-07-01 20:34:48 -04:00
Janice Collins
52e2ca38fc
squash (#85484) 2021-07-01 15:06:05 -07:00
Ahmed Ashour
a3dc90c4f5
Add space before curly parentheses. (#85306) 2021-07-01 13:51:05 -07:00
Janice Collins
cea5d552b2
Fix three additional cases (#85497) 2021-06-28 18:36:02 -07:00
Janice Collins
b046218413
Update flutter doc references to conform to new lookup code restrictions (#85412) 2021-06-28 13:11:03 -07:00
chunhtai
50a2fad986
Remove namesless todo (#85151) 2021-06-23 14:29:14 -07:00
nt4f04uNd
555608dad2
init (#84365) 2021-06-17 16:09:02 -07:00
chunhtai
00ee2e59e7
Adds text attributes support for semantics (#79599)
* Adds label attributes

* fix test

* comments

* list equal
2021-06-17 09:45:34 -07:00
Jonah Williams
cd13c91119
[versions] update dependencies (#84639) 2021-06-15 11:08:57 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. (#84476)
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.

Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Alexandre Ardhuin
e467018d06
alignment of doc comments and annotations (#84256) 2021-06-09 07:54:02 -07:00
Michael Goderbauer
811f0d9a15
"Migrate" dummy packages to null safety (#84013) 2021-06-04 22:14:03 -07:00
Sam Rawlins
da9b11ec24
Remove "unnecessary" imports. (#83959) 2021-06-04 10:54:05 -07:00
Tong Mu
e3da1bd7aa
Test WidgetTester handling test pointers (#83337)
Adds tests to the following behaviors, which have existed without tests:

- When tapping during live testing, a message is printed with widgets that contain the tap location.
- When tapping during live testing, a mark is displayed on screen on the tap location.
2021-06-02 11:50:09 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors (#83744) 2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings (#83407) 2021-06-01 11:14:06 -07:00
Jonah Williams
025a3a7da3
[versions] roll package test redux (#83367) 2021-05-26 17:22:28 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push (#82564) 2021-05-21 15:09:03 -07:00
nt4f04uNd
80a2b6b015
Fix typos (#82589) 2021-05-20 17:19:09 -07:00
Tong Mu
01c98fa95e
Character activator (#81807) 2021-05-18 20:19:03 -07:00
Jenn Magder
d7e49e559b
Run update packages, pick up file 6.1.1 (#82770) 2021-05-18 13:09:03 -07:00
Dan Field
304b9c668e
Reland GC tracking benchmarks (#82069) 2021-05-14 19:59:24 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push (#82057)" (#82525) 2021-05-14 12:09:03 -07:00
Abhishek Ghaskata
b554f893bd
Enable unnecessary_null_checks lint (#82084) 2021-05-14 10:44:03 -07:00
Jia Hao
08154b22ce
Revert "Init licenses for test bindings (#81961)" (#82337) 2021-05-13 21:29:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push (#82057) 2021-05-13 14:34:04 -07:00
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last (#82457) 2021-05-13 13:39:04 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227)
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Alexandre Ardhuin
7d46d43635
use throwsXxx instead of throwsA(isA<Xxx>()) (#82328) 2021-05-12 09:59:02 -07:00
Alexandre Ardhuin
c03e7488b4
remove noop primitive operations (#82297) 2021-05-12 00:04:02 -07:00
Alexandre Ardhuin
4881b33515
use throwsA matcher instead of try-catch-fail (#82290) 2021-05-11 23:34:02 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Jia Hao
b3f7ebe069
Init licenses for test bindings (#81961) 2021-05-07 17:54:02 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() (#81859) 2021-05-07 14:54:02 -07:00
Dan Field
3101374f60
Revert "Reland GC benchmark changes again (#82042)" (#82059)
This reverts commit 99a947c3e5.
2021-05-07 13:19:56 -07:00
Dan Field
99a947c3e5
Reland GC benchmark changes again (#82042) 2021-05-07 12:29:01 -07:00
Zachary Anderson
4056ac057d
Revert "Reland GC related bench update (#81794)" (#82005)
This reverts commit 714dea5e03.
2021-05-06 19:03:59 -07:00
Dan Field
714dea5e03
Reland GC related bench update (#81794) 2021-05-06 16:49:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push (#81235)" (#81829)
This reverts commit 35ad43f20c.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push (#81235) 2021-05-03 17:14:03 -07:00
Jonah Williams
fff8ecfb94
[flutter] reject mouse drags by default in scrollables (#81569) 2021-05-03 16:54:02 -07:00
Ian Hickson
ec91c6582b
Update documentation for scrollUntilVisible and friends. (#81497) 2021-05-01 18:29:03 -07:00
Jonah Williams
2b0d09dd81
[versions] roll versions and add ffi dep (#81403) 2021-04-28 11:19:03 -07:00
Angjie Li
cbdd9c4787
Revert "Refactor text editing test APIs (Mark III) (#80003)" (#81316)
This reverts commit 285b475124.
2021-04-27 11:34:36 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push (#76288)" (#81226)
This reverts commit c26ed03c8a.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push (#76288)
* Migrate to ChannelBuffers.push

* Move TestDefaultBinaryMessenger to its own file

* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Ian Hickson
285b475124
Refactor text editing test APIs (Mark III) (#80003) 2021-04-21 18:29:04 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Tong Mu
eb73516739
Shortcut activator (#78522)
This PR introduced a new class, ShortcutActivator, and refactored the the definition and lookup system of shortcuts, in order to solve a few issues of the previous algorithm.
2021-04-15 01:42:49 -07:00
Justin McCandless
0efb28d706
Revert "Fix a legacy TODO (#77454) (#79061)" (#79959)
This reverts commit b070ed3c04.
2021-04-07 12:24:22 -07:00
Ian Hickson
b070ed3c04
Fix a legacy TODO (#77454) (#79061) 2021-04-02 22:39:03 -07:00
LongCatIsLooong
c1c5b492be
Reland 79654 (#79656) 2021-04-02 15:44:02 -07:00
LongCatIsLooong
bf6e38db2b
Revert "enterText to move the caret to the end (#79506)" (#79654)
This reverts commit 67d8556baa.
2021-04-02 10:57:14 -07:00
LongCatIsLooong
67d8556baa
enterText to move the caret to the end (#79506) 2021-04-01 20:29:03 -07:00
Tong Mu
dbcac7f177
Reland Make LogicalKeyboardKey.keyLabel a getter and better #79100 (#79302) 2021-04-01 16:39:02 -07:00
Chris Bracken
3e7e06512c
Correct misspellings throughout the codebase (#79500) 2021-04-01 10:04:03 -07:00
Alexander Brusher
beb62a663d
Rolls isKeyboardKey engine change with fix (#79407)
* Adds a semantics node flag to identify sliders.

* [fuchsia] Fix roll of engine PR #25167

This changes fixes tests failing due to new isKeyboardKey semantics
flag.

* Fix typo

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-03-31 10:43:58 -07:00
Jonah Williams
443d07b707
[versions] roll to latest test (#79099) 2021-03-31 07:45:40 -07:00
Michael Bui
39499bd2bf
make showKeyboard respect finder's skipOffstage value (#79034) 2021-03-29 18:19:03 -07:00
Tong Mu
a603714610
Revert "Make LogicalKeyboardKey.keyLabel a getter and better (#79100)" (#79217) 2021-03-28 03:54:02 -07:00
Tong Mu
b60c855af5
Make LogicalKeyboardKey.keyLabel a getter and better (#79100) 2021-03-26 22:14:01 -07:00
Alexandre Ardhuin
e384ca7979
use null aware operators for function invocations (#79049) 2021-03-26 09:34:03 -07:00
Tong Mu
eb6e56761e
Revert "Remove keyLabel and debugName from Logical/PhysicalKeyboardKey (#78263)" (#79005)
This reverts commit 515ef91ba1.
2021-03-24 13:31:02 -07:00
Tong Mu
515ef91ba1
Remove keyLabel and debugName from Logical/PhysicalKeyboardKey (#78263)
- Remove `LogicalKeyboardKey.keyLabel`
- Make `Physical/LogicalKeyboardKey.debugName` getters
- Make `Physical/LogicalKeyboardKey()` factory constructors, which cache non-predefined instances.
2021-03-24 04:59:57 -07:00
Shi-Hao Hong
7a88eb97ea
Typo fixes (#78755) 2021-03-23 09:23:43 +08:00
Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything (#78493) 2021-03-19 15:32:46 -07:00
Angjie Li
6515806717
Revert "Fix a legacy TODO (#77454)" (#78584)
This reverts commit 5e4e530e93.
2021-03-19 10:08:12 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Ian Hickson
5e4e530e93
Fix a legacy TODO (#77454) 2021-03-16 10:48:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer
d637b1874f
non-breaking changes for prefer_mixin lint (#77837) 2021-03-11 19:50:03 -08:00
Kate Lovett
9840d65943
Make LocalFileComparator.compare easier to override (#77825) 2021-03-10 12:20:04 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Chris Bracken
565e48777a
Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions) (#77386)
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of https://github.com/flutter/engine/pull/24734.

299eb3e710...67abe7f9a9

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-05 10:10:32 -08:00
Michael Goderbauer
ed755fba5e
Enable avoid_unnecessary_containers lint (#77294) 2021-03-04 15:29:03 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint (#77163) 2021-03-04 08:59:17 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. (#77099) 2021-03-03 17:29:02 -08:00
Michael Goderbauer
0f91f0d48a
Clean-up analysis_options files (#77098) 2021-03-02 21:14:03 -08:00
Michael Goderbauer
0f568298d8
enable use_key_in_widget_constructors lint (#77032) 2021-03-02 10:14:02 -08:00
Kate Lovett
6ec9014298
Expose the diff from ComparisonResult (#77014) 2021-03-02 10:09:03 -08:00
Ferhat
cc9b78fc5c
[web] Treeshake keymaps for web (4% code size reduction in hello world) (#75945) 2021-02-25 13:26:03 -08:00
Jonah Williams
db1e9f053f
update all packages (#76254) 2021-02-17 17:33:56 -08:00
Jason Simmons
6757c7dd47
Use a null default skip value in testWidgets so it can inherit the group's skip flag (#76174) 2021-02-17 14:31:03 -08:00
Sam Rawlins
fcad4e2efe
Remove "unnecessary" imports in flutter_test (#76157) 2021-02-16 16:01:05 -08:00
Jonah Williams
7088c5ba2a
Update all packages (#76143) 2021-02-16 15:29:12 -08:00
Todd Volkert
835c7fab45
Fix FocusManager constructor (#75894)
The FocusManager constructor was registering global event handlers
on the shared RawKeyboard instance and the global pointer router.
This posed a few problems: (1) there was no way to unregister these
handlers, and (2) instantiating a second FocusManager would overwrite
the existing focus manager's RawKeyboard handler. This was manifesting
in unexpected ways, such as the fact that constructing a second
BuildOwner (for a parallel tree, for instance) was obliterating the
event handler for the main BuildOwner's focus manager, thus messing
with focus.

This change separates those global event registrations into a
dedicated method, registerGlobalHandlers(), and overrides dispose()
to properly unregister those handlers.
2021-02-12 17:19:20 -08:00
Dan Field
bc1cf49458
roll packages (#75370) 2021-02-04 11:41:03 -08:00
Ian Hickson
824042f9b2
Catch cases in tests where people try to tap on widgets that aren't reachable. (#74798) 2021-02-03 16:11:02 -08:00
Anas35
091a74dab6
removed new keyword (#75049) 2021-02-01 09:59:53 -08:00
Yegor
791edc230d
always pass filterQuality specified in the Image widget to canvas (#74854) 2021-01-28 21:54:03 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
Ian Hickson
37a0189773
Don't leak exceptions thrown by message channels (#74446) 2021-01-27 11:19:04 -08:00
Jia Hao
8a5ace25a5
Improve performance of Widget Tests (#70730) 2021-01-12 17:29:03 -08:00
Ian Hickson
544a41eb55
Remove an obsolete comment from pubspec.yaml (#73505) 2021-01-07 15:59:04 -08:00
creativecreatorormaybenot
508c4b4d29
Correct flutter_test flutter_test_configuration.dart documentation (#70862) 2020-11-25 13:38:05 -08:00
Michael Goderbauer
7a3a29e71f
Fixes Intrinsics for RenderParagraph and RenderWrap (#70656) 2020-11-20 17:24:58 -08:00
Greg Spencer
2d836a99b6
Remove some unnecessary casts, now that changes have rolled from the engine (#70491) 2020-11-13 16:28:06 -08:00
Michael Goderbauer
cca1215939
Properly initialize RestorationManager in the TestBinding (#70398) 2020-11-12 13:59:05 -08:00
Greg Spencer
86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead (#70319)
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.

Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Greg Spencer
0937207f5b
Fix Platform channel errors in web tests (#70252) 2020-11-12 10:24:07 -08:00
Greg Spencer
bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow (#69617)
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate

* remove new test platform dispatchers

* Amend documentation
2020-11-09 15:26:29 -08:00
Zachary Anderson
e59ab90ae1
Add Dart SDK constraint to a pubspec (#70030)
This will unblock the roll of the next Dart SDK
2020-11-07 11:42:05 -08:00
Jonah Williams
6fe800abd5
[null-safety] remove enable experiment flags (#69930) 2020-11-05 23:58:11 -08:00
Jonah Williams
0823d625bc
[null-safety] update version constraint (#69900) 2020-11-05 11:39:26 -08:00
Jonah Williams
e8efde6a54
[versions] update more null safe versions (#69892) 2020-11-05 09:09:03 -08:00
Jason Simmons
9470a7e864
Revert "[null-safety] update Dart SDK constraints (#69831)" (#69854)
This reverts commit e375651cc5.
2020-11-04 21:49:59 -08:00
Jonah Williams
e375651cc5
[null-safety] update Dart SDK constraints (#69831) 2020-11-04 16:50:24 -08:00
Jonah Williams
580cacf4bd
[versions] roll versions (#69810) 2020-11-04 15:38:58 -08:00
Greg Spencer
88809aa247
Standardize dartdoc macro names (#69445) 2020-11-02 13:28:05 -08:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041)
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
2020-10-26 14:31:13 -07:00