Commit Graph

28 Commits

Author SHA1 Message Date
Matan Lurey
a5e020c8b6
Update CODEOWNERS (#166444)
Use tighter directory structures.
2025-04-02 19:47:58 +00:00
Loïc Sharma
1937cae5a9
Fix CODEOWNERS for the iOS review team (#166178)
GitHub's CODEOWNERS syntax requires the `@org/team-name` format. See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
2025-03-31 16:41:53 +00:00
Loïc Sharma
8d49d67564
Add the ios-reviewers review team (#166034)
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jenn Magder <magder@google.com>
2025-03-28 21:01:49 +00:00
Loïc Sharma
5c3bc83f26
Fix CODEOWNERS after monorepo merge (#165217)
GitHub's CODEOWNERS feature [picks the first file it finds in the root,
`.github/`, or `docs/`
directory](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location).
GitHub does not support nested CODEOWNERS files.

For example, this PR updates the embedder API but did not request
reviews from the embedder API reviewers:
https://github.com/flutter/flutter/pull/164577

To fix this, this merges all `CODEOWNERS` files to the root of the repo.

cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.
2025-03-26 20:32:14 +00:00
Matan Lurey
25f89bf8fb
FYI matanlurey (does not require review, but probably should) on dev/test infra. (#162642)
I'm the primary contributor to these areas, so I'd like to know if
significant changes are proposed.

No impact to the code approval process.
2025-02-10 19:24:40 +00:00
Jenn Magder
5d93dd0adb
Add iOS tool codeowner (#162167)
No guarantee I'll review iOS tool PRs but I'd like to be on the reviewer
list!
2025-01-31 02:51:46 +00:00
Christopher Fujino
a0e75cd309
remove fujino from CODEOWNERS (#155369)
Every time someone tries to merge stable into master, I get pinged. It's not worth the distraction. I initially added myself as CODEOWNER because I wanted to make sure people weren't adding unneccessary dependencies to the tool, but I give up.
2024-09-26 17:02:24 +00:00
Matan Lurey
d436acf808
Notify me of changes to flutter_driver. (#152188)
Part of https://github.com/flutter/flutter/issues/148028.
2024-07-23 20:41:22 +00:00
Jenn Magder
a52e266b79
Remove CODEOWNERS trailing whitespace (#150882)
New analyze error in an unrelated PR 
```
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ /b/s/w/ir/x/w/flutter/CODEOWNERS:13: trailing U+0020 space character
╚═══════════════════════════════════════════════════════════════════════════════
```

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8744032390138579057/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

On this commit 

2537b49e4e
2024-06-26 14:59:56 -07:00
Matan Lurey
2537b49e4e
Remind folks we are moving. (#150872)
Part of https://github.com/flutter/flutter/issues/150869.

This should mitigate accidental new files or significant changes, or at
least make me aware I suppose?
2024-06-26 14:13:53 -07:00
auto-submit[bot]
54e9f2dbe6
Reverts "Refactor external_uiexternal_textures" (#142173)
Reverts flutter/flutter#142062
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming:

1. Almost[^1] anything named `external_ui` is renamed `external_textures`
1. Extended the README to explain the intent of the test, as well as how to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends)

Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes.

[^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
2024-01-24 21:41:17 +00:00
Matan Lurey
2e2042ff8e
Refactor external_uiexternal_textures (#142062)
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:

1. Almost[^1] anything named `external_ui` is renamed
`external_textures`
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)

Given how complex (and in-flux) this directory is, I'm also requesting
either John, Jonah or I review any changes.

[^1]: Except the name of the `.ci.yaml` task, i.e. `name:
Linux_pixel_7pro external_ui_integration_test` because I'm apparently
not able to change that without creating a new task as `bringup: true`
and playing a bit of a dance. Maybe that's worth doing though (in future
PRs)?
2024-01-24 12:44:31 -08:00
Jenn Magder
b33b872d99
Add self back to CODEOWNERS (#140080)
I'm back from leave.  Revert https://github.com/flutter/flutter/pull/125337 but don't take back the `CODEOWNERS` file itself.
2023-12-14 05:56:29 +00:00
Jenn Magder
a2c247117b
Remove self from CODEOWNERS (#125337)
Remove self from `CODEOWNERS` file for `flutter_tools`. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.

Also remove ownership of the `CODEOWNERS` file itself.
2023-04-21 22:33:05 +00:00
keyonghan
cc8c51bf95
remove (#122624)
Remove ownership on ci.yaml
2023-03-14 22:15:58 +00:00
Christopher Fujino
048725981e
remove Christopher Fujino from codeowners of //dev/ci (#121281)
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
2023-02-23 01:09:48 +00:00
Kate Lovett
a13fb5f6f7
Remove Piinks from Owners (#111929) 2022-09-19 23:37:56 +00:00
Christopher Fujino
3ce2ab9159
Auto-submit pub packages autoroll PRs (#108635) 2022-07-29 19:53:05 +00:00
Casey Hillers
10142b5817
[CODEOWNERS] Remove caseyhillers from ci.yaml (#100642) 2022-03-24 18:47:19 -07:00
Casey Hillers
261fcf1f4f
[codeowners] Remove *_builders.json ownership (#91691) 2021-10-12 13:23:05 -07:00
keyonghan
3b4c2c42df
Add owners for .ci.yaml (#91687) 2021-10-12 11:38:03 -07:00
Casey Hillers
e38a0e97d5
Remove CODEOWNERS on .ci.yaml (#82977) 2021-05-20 10:14:03 -07:00
Casey Hillers
3fe3719022
Lock prod_builders.json/try_builders.json (#82305) 2021-05-11 17:24:02 -07:00
Casey Hillers
8743f94f49
Create dev/ci.yaml (#79396) 2021-04-02 11:09:03 -07:00
Kate Lovett
2ce36f6199
Goldens owner, removed obsolete pattern (#54206) 2020-04-07 12:26:02 -07:00
Jenn Magder
1da96a9cdf Add @christopherfujino as owner of dev/ci (docker) (#48261) 2020-01-06 13:55:03 -08:00
Kate Lovett
55c979ea09
Updating code owners for golden file changes (#38564) 2019-08-15 09:13:45 -07:00
Jenn Magder
11d3d45b6b
Add GitHub CODEOWNERS file to auto-add reviewers by path (#36492) 2019-07-22 10:23:12 -07:00