Commit Graph

2136 Commits

Author SHA1 Message Date
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools (#45153)
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
2019-11-24 06:54:43 +01:00
Emmanuel Garcia
b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Jonah Williams
b54bb6abbb
Dont crash if the tool cannot delete asset directory during debugging (#45407) 2019-11-22 14:06:05 -08:00
Jonah Williams
35b571ccfc
Revert "Improve time to development by initializing frontend_server concurrently with platform build (#45236)" (#45422) 2019-11-22 13:36:12 -08:00
Jonah Williams
c63c576bca
Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams
60869e0a93
Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
xster
942707591d
Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams
6640c8b9b4
catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams
497ae83c82
Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Yegor
aa3943316b
Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Amir Hardon
e43a69a9fe
Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
Zachary Anderson
05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds (#45350)
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
2019-11-21 12:55:39 -08:00
Jonah Williams
785e557a43
remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Zachary Anderson
0216953674
Revert "[flutter_tool] Fuchsia AOT builds (#45187)" (#45349)
This reverts commit a57dddd217.
2019-11-21 09:41:46 -08:00
Zachary Anderson
a57dddd217
[flutter_tool] Fuchsia AOT builds (#45187) 2019-11-21 08:32:58 -08:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Amir Hardon
53c7ca7d5a
Allow unknown fields in pubspec plugin section (#45303) 2019-11-20 17:00:46 -08:00
Jonah Williams
106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291)
This reverts commit 6b5634fed3.
2019-11-20 14:45:32 -08:00
Jonah Williams
6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
Danny Tuppeny
73c32545b7
Fix device daemon test when desktop or web are enabled (#45172) 2019-11-20 11:02:35 +00:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Jonah Williams
c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a.
2019-11-19 16:47:39 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny
37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Jonah Williams
df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jonah Williams
e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Jonah Williams
a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino
ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
Danny Tuppeny
81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
Jonah Williams
2a576b774c
remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00
Zachary Anderson
29c026fac4
[flutter_tool] Don't crash when failing to delete downloaded artifacts (#44933)
* [flutter_tool] Don't crash when failing to delete downloaded artifacts

* Add space

* Add more spaces.
2019-11-15 10:05:45 -08:00
Danny Tuppeny
5376e90fda
Print a message when modifying settings that you may need to reload IDE/editor (#44574)
* Print a message when modifying settings that you may need to reload IDEs/editors

* Add a test for `flutter config` output

* Remove blank line
2019-11-14 17:54:22 +00:00
Jonah Williams
e77c24ef91
Update package test (#44882) 2019-11-14 09:31:36 -08:00
Jenn Magder
25b33a8c3b
Fake locale in doctor_test (#44878) 2019-11-13 19:08:10 -08:00
Jenn Magder
6498f64399
Catch and display version check errors during doctor (#44868) 2019-11-13 18:23:05 -08:00
Jonah Williams
e3cb2c3fcf
Reland: Allow specifying device-vmservice-port and host-vmservice-port (#44853) 2019-11-13 16:02:46 -08:00
Jonah Williams
985da83139
Revert "Allow specifying device-vmservice-port and host-vmservice-port (#44027)" (#44843)
This reverts commit c0af77bf87.
2019-11-13 14:35:07 -08:00
Emmanuel Garcia
0019599411
Build AAR for all build variants by default (#44797) 2019-11-13 13:27:10 -08:00
Jonah Williams
c0af77bf87
Allow specifying device-vmservice-port and host-vmservice-port (#44027) 2019-11-13 13:01:41 -08:00
Emmanuel Garcia
f766871eb9
Forward ProcessException to error handlers (#44783) 2019-11-13 10:02:46 -08:00
Jonah Williams
7caef218b5
refactorings to testbed.run and testbed.test (#44488) 2019-11-12 15:35:59 -08:00
Jonah Williams
2779361b38
Ensure web-server does not force usage of dwds (#44744) 2019-11-12 15:24:45 -08:00
Jonah Williams
3383b564a1
Always link desktop platforms (#44753) 2019-11-12 15:24:18 -08:00
xster
9e0df259df
Show a warning when a module uses a v1 only plugin (#44499) 2019-11-11 15:56:43 -08:00
Yegor
e7073f9a1f
add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root (#44468) 2019-11-08 14:38:44 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly (#43876)
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
chunhtai
6a9b72c16b
fixing todo comments in flutter tests to include url link. (#42691) 2019-11-07 17:34:36 -08:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396)
This reverts commit e5d6d92498.
2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
Zachary Anderson
12c190f746
[flutter_tool] Stream artifact downloads to files (#44360) 2019-11-07 14:01:57 -08:00
Emmanuel Garcia
b0ad6072ef
Don't print how to consume AARs when building plugins as AARs (#44301) 2019-11-07 10:18:55 -08:00
Emmanuel Garcia
cb614d1339
Fix v1 embedding support heuristic for plugins (#44214) 2019-11-07 08:24:19 -08:00
xster
d2e87a5d2c
Build ios framework (#44065) 2019-11-06 14:54:15 -08:00
Emmanuel Garcia
bb8cf609ec
Build local maven repo when using local engine (#44243) 2019-11-06 12:52:37 -08:00
Jonah Williams
383e90eb13
Use platform appropriate filepaths when constructing asset bundle (#44221) 2019-11-06 12:50:18 -08:00
Jonah Williams
aa333fda25
link platform should be true for profile (#44279) 2019-11-06 12:21:41 -08:00
Kaushik Iska
8e8add524e
[flutter_tool] Screenshot command must require device only for _kDeviceType (#44227)
There are cases where we have access to the observatory without having a device connection accessible.
2019-11-06 10:59:29 -08:00
James D. Lin
1f0c3d462e
Make ProjectFileInvalidator injectable (#44200)
Allow ProjectFileInvalidator to be overridden with a different
implementation.

I stole this from https://github.com/flutter/flutter/pull/39217.
2019-11-05 21:40:48 -08:00
chunhtai
7aebde1904
added new lifecycle state (#39945)
* added new lfecycle state

* update

* update
2019-11-05 20:03:09 -08:00
Michael Klimushyn
02aac5072c
Revert "Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026)"
This missed some plugins that _do_ support the v1 embedding
(shared_preferences as one known case) so caused unexpected breakages.

This reverts commit b94c1a41ca.
2019-11-05 14:38:09 -08:00
Kaushik Iska
7dceec21f7
[flutter_tool] --flutter_runner will download the debug symbols (#44119)
This makes the flutter tool download the debug symbols for Flutter and Dart runners to be used in Fuchsia dev environment.
2019-11-05 14:07:48 -08:00
xster
ba26f926c7
Add Android embedding version analytics (#44043) 2019-11-05 12:38:42 -08:00
Zachary Anderson
372fe290e4
[flutter_tool] Update analytics policy, send event on disable (#43217) 2019-11-05 10:43:52 -08:00
Jonah Williams
0f6c093d68
Remove Source.behavior, fix bug in depfile invalidation (#43945)
* remove Source.behavior, fix bug in depfile invalidation

* more cleanup of assets

* Add skip

* address comments

* Update build_system.dart
2019-11-04 16:37:43 -08:00
Emmanuel Garcia
76957c9da8
build aar prints how to consume the artifacts (#44127) 2019-11-04 16:28:27 -08:00
Emmanuel Garcia
b94c1a41ca Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026) 2019-11-04 13:37:51 -08:00
Jonah Williams
3422540bc4
copy chrome preferences to seeded data dir (#44032) 2019-11-04 09:09:20 -08:00
Jonah Williams
5e1bb20c83
support --no-resident on the web (#44028) 2019-11-04 09:08:40 -08:00
Jonah Williams
f1186b0758
Asset server fix for sourcemaps (#44017) 2019-11-01 22:33:52 -07:00
Emmanuel Garcia
ade8dfac3d
Move the plugin registrant to io.flutter.plugins and add the @Keep annotation (#44011) 2019-11-01 16:58:26 -07:00
Jenn Magder
2e7d9130b2
Observe logging from VM service on iOS 13 (#43915) 2019-11-01 14:37:17 -07:00
Jonah Williams
71740bef74
remove listDartSources (#43950) 2019-11-01 11:06:24 -07:00
Jonah Williams
7d4a968f0c
make more spinner tests not flaky (#43955) 2019-11-01 10:55:15 -07:00
Jonah Williams
0cd8cef8f5
require awaiting Testbed.run (#43952) 2019-11-01 10:55:04 -07:00
Emmanuel Garcia
dea35da040
Log additional Android build failures (#43941) 2019-11-01 10:06:23 -07:00
Jonah Williams
a192e29603
check for instanceof instead of runtimeType and wait for testbed (#43870) 2019-10-31 19:31:42 -07:00
Jonah Williams
a60a47ae2c
Serve correct mime type on release dev server (#43907) 2019-10-31 14:57:34 -07:00
Emmanuel Garcia
175b37247d
Refactor gradle.dart (#43479) 2019-10-31 13:19:15 -07:00
Jonah Williams
79323f7c13
Ensure target platform is passed is always passed to assemble (#43862) 2019-10-30 19:40:19 -07:00
Jonah Williams
79bc6cafc5
implement build aot with assemble for Android target platforms (#43282) 2019-10-30 15:23:25 -07:00
Zachary Anderson
d0d8e6edcb
[flutter_tool] Teach the tool about local engine Fuchsia artifacts (#43759) 2019-10-30 14:11:18 -07:00
Jonah Williams
417449e2f3
Deflake flutter tool logger test (#43800) 2019-10-30 13:09:26 -07:00
Jonah Williams
349d694fb7
Revert "Added a null check for ranges in the sourceReport map. (#43667)" (#43827)
This reverts commit 0dc5ea4a95.
2019-10-30 10:57:35 -07:00
Efthymis Sarmpanis
c5b3b3ac26 Flutter doctor should require java 1.8+ (#41989) 2019-10-30 10:40:27 -07:00
Nate Bosch
7cf362fc31 Handle onError callback with optional argument (#43436)
Check for a binary callback first since a function with an optional
second argument will match both typedefs.

Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.

Add a test for a unary error handler and an error handler with an
optional stack trace argument.
2019-10-30 10:39:50 -07:00
Larry McKenzie
0dc5ea4a95 Added a null check for ranges in the sourceReport map. (#43667) 2019-10-30 10:35:45 -07:00
stuartmorgan
f6f6e86eb8
Split desktop config fallback variable by platform (#43758)
The environment variable for all desktop platforms is currently
ENABLE_FLUTTER_DESKTOP to allow backward compatibility with existing
workflows. However, this is actually causing issues since 'flutter
config' provides a better experience (most importantly, IDEs will work
correctly, which is generally not the case with the environemnt
variable). Currently people following old (third-patry) instructions
don't realize that they are missing available functionality, so aren't
looking for the current instructions.

In adddition, this will be confusing as different platform graduate to
channels other than master at different times.

To resolve both issues, the environment variable fallback is now
separate for each desktop platform, and follows a naming scheme
consistent with the web environment variable.
2019-10-29 21:43:25 -07:00
Jonah Williams
9cb2047139
Make Spinner test case use mockStopwatch (#43761) 2019-10-29 21:36:19 -07:00
Jonah Williams
50da3bd062
check if libimobiledevice executables exist (#43767) 2019-10-29 21:35:51 -07:00
Jonah Williams
b1aff28593
pass --no-gen-bytecode to aot kernel compiler invocations (#43753) 2019-10-29 16:05:54 -07:00
Emmanuel Garcia
7e60a65ff0
Don't read AndroidManifest.xml if it doesn't exit (#43669) 2019-10-29 16:05:13 -07:00
liyuqian
c523149819
Reland "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43455)
This reverts commit b9eb3f717a.

We fixed the issue by updating the constructors.
2019-10-29 14:20:22 -07:00
Jonah Williams
331d19ff4b
Add reloadMethod RPC (#43725) 2019-10-29 13:21:06 -07:00
Jonah Williams
1d7afd9c1d
Don't indefinitely persist file hashes, handle more error conditions (#43602) 2019-10-29 13:20:51 -07:00
Jenn Magder
01dc19b93f
Pass environment variables through to xcodebuild (#43553) 2019-10-28 19:58:06 -07:00
Jonah Williams
19e551c7a6
Remove Poller class from flutter_tools (#43685) 2019-10-28 19:35:43 -07:00
Jonah Williams
e25cd84a06
Catch failed startup error from build_daemon (#43598) 2019-10-28 15:58:14 -07:00
Jonah Williams
b142c9bbdb
catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599) 2019-10-28 10:54:03 -07:00
Jonah Williams
450a72488d
set trace to true for desktop builds (#43577) 2019-10-28 10:27:11 -07:00
Jonah Williams
36d50a48f4
Catch MissingPortFile exception (#43573) 2019-10-28 10:26:43 -07:00
Jonah Williams
d983c1d1ae
Ensure Chrome is closed on tab close (#43586) 2019-10-28 10:26:18 -07:00
Zachary Anderson
0dfabb2ae1
[flutter_tool] Use engine flutter_runner prebuilts (#43381)
* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
2019-10-28 09:38:08 -07:00
Jonah Williams
ab260bacd2
Refactor BuildMode into class, add jit_release configuration (#42476) 2019-10-28 09:37:29 -07:00
Jonah Williams
553662d101
Catch AppConnectionException from dwds (#43544) 2019-10-25 20:35:19 -07:00
Jonah Williams
4bd5eb5915
Enable track widget creation on by default (#43471) 2019-10-25 15:04:06 -07:00
Jonah Williams
4c47fdadd4
Add devfs for incremental compiler JavaScript bundle (#43219) 2019-10-25 15:03:13 -07:00
Jonah Williams
ed931e7941
initial bootstrap script for incremental compiler support (#43292)
* initial bootstrap script for incremental compiler support

* add more comments

* update to two scripts
2019-10-25 15:03:00 -07:00
Jonah Williams
ae207b5e42
Handle permission error during flutter clean (#43401) 2019-10-25 15:02:38 -07:00
Harry Terkelsen
eba69caf97
Don't html-escape in the plugin registrant templates. (#43448)
* Don't html-escape in the plugin registrant templates.

Fixes #43382

* Add test
2019-10-25 15:00:05 -07:00
Jonah Williams
b9eb3f717a
Revert "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43438)
This reverts commit 4f385c8fb7.
2019-10-24 11:18:55 -07:00
liyuqian
4f385c8fb7 Enable dump-skp-on-shader-compilation in drive (#43022) 2019-10-24 11:04:59 -07:00
Jonah Williams
c1d3ca07fe
catch ChromeDebugException from dwds (#43390) 2019-10-24 10:55:42 -07:00
Harry Terkelsen
dee4232d0c For --profile builds on web, still use -O4 but unminified names. (#43214) 2019-10-24 10:08:12 -07:00
Jonah Williams
096a8ac40a handle format error from vswhere (#43402) 2019-10-24 10:07:05 -07:00
Jonah Williams
9e7b6f9500
Catch version and option skew errors from build_daemon (#43403) 2019-10-24 09:06:45 -07:00
Jonah Williams
2237451711
Don't eagerly call runMain when --start-paused is provided to web application (#42144) 2019-10-24 07:57:52 -07:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert (#43315) 2019-10-22 22:05:00 -07:00
James D. Lin
83704b1d91
Make ProjectFileInvalidator.findInvalidated able to use the async FileStat.stat (#42028)
Empirical measurements indicate on the network file system we use
internally, using `FileStat.stat` on thousands of files is much
faster than using `FileStat.statSync`. (It can be slower for files
on a local SSD, however.)

Add a flag to `ProjectFileInvalidator.findInvalidated` to let it
use `FileStat.stat` instead of `FileStat.statSync` when scanning for
modified files.  This can be enabled by overriding `HotRunnerConfig`.

I considered creating a separate, asynchronous version of
`findInvalidated`, but that led to more code duplication than I
liked, and it would be harder to avoid drift between the versions.
2019-10-22 20:48:23 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode (#43225) 2019-10-22 20:35:43 -07:00
Jonah Williams
79a985f9fd
Add compiler configuration to support dartdevc target (#43281) 2019-10-22 20:35:05 -07:00
Jonah Williams
8cac409d90
Clarify hot restart behavior on the web (#42931) 2019-10-22 12:36:56 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert (#42491)" (#43235)
This reverts commit 3597bae6a0.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0 Extra defensive programming for pub modification time assert (#42491) 2019-10-21 20:15:20 -07:00
Emmanuel Garcia
e82ddc4c7a
Ensure android.enableR8 is appended to a new line (#43187) 2019-10-21 16:52:30 -07:00
Jonah Williams
27105cba2f
switch dart2js build to depfile, remove Source.function (#42977) 2019-10-21 16:46:44 -07:00
Jonah Williams
6c91a13731
Adding missing break in plugin validation check (#43180) 2019-10-21 16:46:07 -07:00
Jonah Williams
31a4ff80c7
add samsungexynos7570 to list of known physical devices (#43042) 2019-10-21 16:45:48 -07:00
Jonah Williams
6db4c44da8
remove period from URL so that it opens correctly in vscode (#43200) 2019-10-21 16:43:11 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
Jonah Williams
39e4d9d152
Expand scope of rethrown gradle errors (#42966) 2019-10-18 14:56:39 -07:00
Jonah Williams
6fc99e98ad
rename headless server to web server (#42970) 2019-10-18 12:41:47 -07:00
Jonah Williams
21be8372c9
implement debugTogglePlatform for the web (#42951) 2019-10-18 12:41:15 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode (#43016) 2019-10-18 12:40:50 -07:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Jonah Williams
863fb2f2cc
Remove linux-x64 unpack logic (#42962) 2019-10-17 19:22:03 -07:00
Jonah Williams
f53b32eb23
refactor depfile usage and update linux rule (#42487) 2019-10-17 17:42:40 -07:00
Ferhat
f7ce5ae3fc
[web] Update web runner message with flutter.dev/web (#42676)
* Update web runner message with flutter.dev/web

* Update spoopy test to use Warning instead
2019-10-17 15:08:15 -07:00
Emmanuel Garcia
08c645b3b2
Test the Android embedding v2 (#42708)
* Test the Android embedding v2

* Update integration tests

* Split into shards
2019-10-16 21:26:10 -07:00
Jonah Williams
cb518c4219
Fix progress indicators for release/profile builds of web. (#42857) 2019-10-16 16:10:06 -07:00
Jonah Williams
01f779e97a
Fix NPE in Chrome Device (#42813) 2019-10-16 15:46:07 -07:00
Emmanuel Garcia
0a93f4eb75
Remove isNewAndroidEmbeddingEnabled flag when reading an existing pro… (#42684) 2019-10-16 12:47:04 -07:00
Jenn Magder
357d02c87b
Always embed Flutter.framework build mode version from Xcode configuration (#42029) 2019-10-15 15:33:55 -07:00
Jonah Williams
ad1d67e0a1
serve correct content type from debug server (#42701) 2019-10-15 15:25:57 -07:00
Jonah Williams
68e768dbcf
fix type error in manifest asset bundle (#42791) 2019-10-15 15:25:33 -07:00
liyuqian
31cb44825c
Add --cache-sksl flag to drive and run (#42353)
So we can test SkSL precompile using the command line tools.
See https://github.com/flutter/engine/pull/12412.
2019-10-15 14:28:55 -07:00
Jonah Williams
e22d4aa140
Add debugging option to write vmservice address to file after starting (#41583) 2019-10-15 13:05:47 -07:00
Christopher Fujino
428d7d7f2d
dispose devices on cleanupAtFinish() for run_cold.dart (#42668) 2019-10-15 12:50:44 -07:00
Jenn Magder
dda74a1993
Increase template Swift version from 4 to 5 (#41882) 2019-10-15 12:37:13 -07:00
Jonah Williams
e372641789
Ensure we stop the status when browser connection is complete (#42698) 2019-10-14 21:36:31 -07:00
Jonah Williams
f8a5baf359
Dont close debug connection on exit (#42655) 2019-10-14 17:29:04 -07:00
Jonah Williams
0dce0c6e30
catch appInstanceId error from dwds (#42656) 2019-10-14 17:28:28 -07:00
Ryan Macnak
b7773da37b
Pass build mode-specific bytecode generation options to frontend_server. (#42471)
Fixes various Flutter framework test failures when bytecode is enabled.
2019-10-14 15:26:14 -07:00
Jenn Magder
a62bb3d9ab
Update minimum version to Xcode 10.2 (#42254) 2019-10-14 12:45:40 -07:00
Mouad Debbar
ba70e0e074
Print correct hostname when web server is launched (#42531) 2019-10-14 09:54:36 -07:00
Jonah Williams
04e04ffa95
Deflake wildcard asset test (#42597) 2019-10-14 08:49:02 -07:00
chunhtai
9423a01204
fix flutter error report correct local widget (#41224) 2019-10-13 18:41:22 -07:00
Emmanuel Garcia
532a8fed41
Print message and log event when app isn't using AndroidX (#42548) 2019-10-12 18:58:22 -07:00
Dan Field
3fea2838df
Skip test (#42557) 2019-10-11 16:18:00 -07:00
Zachary Anderson
af93b6af80
[flutter_tool] Improve yaml font map validation (#42538) 2019-10-11 12:17:37 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Jason Simmons
db9a035e7c
Wait for isolate start before proceeding with expression evaluation tests (#42464)
Fixes https://github.com/flutter/flutter/issues/42359
2019-10-11 11:04:39 -07:00
Jonah Williams
7ab653c6ca
Add error logging to flutter generate (#42209) 2019-10-11 07:16:11 -07:00
Ian Hickson
53be552ae1
Be more verbose when pub fails (#42187) 2019-10-10 19:37:01 -07:00
Jonah Williams
2b635816c6
Wrap dwds in async guard, only catch known error types (#42364) 2019-10-10 16:34:27 -07:00
Jonah Williams
03a45dc383
Add support for Android x86_64 ABI to Flutter (#42401) 2019-10-10 16:34:16 -07:00
Ryan Macnak
2a40c2ddb5
Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. (#42354)
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
2019-10-10 10:41:24 -07:00
Sahil Soni
ff15a39c07 [BUG] Process all children of intent-filter instead of just the first one to identify default activity (#40029) 2019-10-10 10:05:43 -07:00
Danny Tuppeny
e8c5d66b5a
Use processManager.run() instead of manually capturing streams in test_utils getPackages() (#41687)
* Capture stdout in test helper

* Simplify running getPackages() in test utils

* Remove unused import
2019-10-10 07:47:26 +01:00
Lau Ching Jun
5a41374ac3
Add option to precache unsigned mac binaries. (#42376) 2019-10-09 22:24:15 -07:00
Christopher Fujino
ed482c3e09
Stop leaking iproxy processes (#42026) 2019-10-09 16:30:27 -07:00
stuartmorgan
d992d6de20 Make desktop stopApp only apply to processes Flutter started (#41519) 2019-10-09 16:28:10 -07:00
Jonah Williams
861fe0a276
Ensure precache --web works on dev branch (#42289) 2019-10-09 16:27:39 -07:00
Jonah Williams
6a99a8d9e4
Ensure web restart analytics events aren't sent for failures/dont serve devtools by default (#42260) 2019-10-08 20:06:13 -07:00
Jonah Williams
14c1c211d5
Catch argument error from Make when it isn't installed (#42252) 2019-10-08 14:53:55 -07:00
Jonah Williams
fde267516b
Make Pub an interface in the flutter tool (#42257) 2019-10-08 14:53:28 -07:00
Alexandre Ardhuin
83e5a8a0e4
some formatting changes (#41640) 2019-10-08 18:32:10 +02:00
Ian Hickson
cdc2d9901d
More consistent temp directory naming (#42063)
Applying our style guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#have-good-hygiene-when-using-temporary-directories
2019-10-07 16:43:04 -07:00
Jonah Williams
9638756c2a
Apply mocks to test command to deflake web_fs test (#42118) 2019-10-07 15:20:33 -07:00
Zachary Anderson
cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values (#42016) 2019-10-07 15:04:55 -07:00
Dan Field
4566b34033
Do not validate the Android SDK when building an appbundle (#41946) 2019-10-07 10:38:19 -07:00
Dan Field
3af16678ad
Reland "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)" (#42038)
This reverts commit 142a8630ec.
2019-10-07 10:37:58 -07:00
Zachary Anderson
3b66db6bf7
Updates packages (#41936) 2019-10-07 09:46:57 -07:00
Ian Hickson
97e00b2288 Skip sdk_validation_test again (#42091) 2019-10-07 08:11:45 -07:00
Ian Hickson
682e6383ac
Refactor sdk_validation_test (#42064) 2019-10-06 14:39:16 -07:00
Ian Hickson
1196f91f71
Fix local test failures in flutter_tools (#42015)
* Minor clean-up in terminal.dart

* Don't wrap text in tests (otherwise we'll be sensitive to the terminal width).
2019-10-06 14:38:17 -07:00
Dan Field
f4b4616f87
Diagnose failure in CI, Mark III (#42037) 2019-10-04 20:01:04 -07:00
Ian Hickson
a22f4e9be5
trying to diagnose failure in CI, mark II (#42036)
* remove prints

* Remove the setUpAll() to see if that changes the error message.
2019-10-04 19:43:54 -07:00
Ian Hickson
4e6b77c087
trying to diagnose failure in CI (#42035) 2019-10-04 19:01:37 -07:00
Ian Hickson
142a8630ec
Revert "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030)
This reverts commit 3024053c82.
2019-10-04 17:51:51 -07:00
James D. Lin
14c5c6e161
Clean up ProjectFileInvalidator.findInvalidated a bit (#41889)
In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)
2019-10-04 12:55:17 -07:00
Jonah Williams
3024053c82
AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) 2019-10-04 12:13:36 -07:00
Ryan Macnak
cdb3578b14
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832)
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
2019-10-04 12:07:23 -07:00
Emmanuel Garcia
5961bcc505
Generate projects using the new Android embedding (#41666)
* Generate projects using the new Android embedding

* Add comment about usesNewEmbedding:true

* Feedback

* Rework way to detect new embedding in new apps
2019-10-04 06:23:03 -07:00
Alexandre Ardhuin
890b939401
indent formal parameters correctly (#41644) 2019-10-04 11:00:18 +02:00
Jonah Williams
ae18f07324
Ensure plugin registrants are generated in build_web (#41906) 2019-10-04 00:36:09 -07:00
Jonah Williams
db9ad60bfe
Deflake web_fs_test.dart in flutter_tools (#41952) 2019-10-03 19:07:38 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event (#41652) 2019-10-03 11:08:42 -07:00
Jonah Williams
517c08e801
Make output directory a build input (#41862) 2019-10-03 11:07:53 -07:00
Jonah Williams
aeede20785
Handle missing .packages file in the flutter tool for prebuilt artifacts (#41697) 2019-10-02 15:18:34 -07:00
Ian Hickson
8c6d60bcfd
Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00
Jonah Williams
39f85f94ec
Reland: don't update last compile time when compilation is rejected. (#41580)
* dont update last compiled time when compilation is rejected

* lets try flushing, thats a neat trick

* windows man

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* Update devfs.dart

* Update hot_reload_test.dart

* Update hot_reload_test.dart

* add test that verifies when compile is good that time is updated

* Update devfs_test.dart
2019-10-02 12:46:33 -07:00
Jonah Williams
0af2a84cbb
Handle empty entry in asset list and add more explicit validation (#41735) 2019-10-02 12:45:51 -07:00
Jonah Williams
b2f38396f4
Reland: Switch to assemble API for dart2js (#41659)
* Stop using build_runner for dart2js

* fixes to yield when computing hashes and to imports

* add missing await

* Update filecache_test.dart

* Fix paths in filecache test

* use file uri for import

* add test cases and configurable override

* remove test dep

* fix filepaths for windows

* test no longer failing

* fix paths for test cases

* fix typo

* address comments

* make a constant

* make filehash async and use constant

* fix silly logic error
2019-10-01 14:03:42 -07:00
Jonah Williams
ce2c708a90
Add more information to cannot find Chrome message (#41695) 2019-10-01 14:03:12 -07:00
Jonah Williams
06a6fdbf23
Revert "Switch to assemble API for dart2js (#41447)" (#41658) 2019-09-30 18:35:01 -07:00
Jonah Williams
ccc3dd968c
Switch to assemble API for dart2js (#41447) 2019-09-30 18:26:28 -07:00
Jenn Magder
1eb1e2226b
Skip pod initialization if version >= 1.8.0. (#41491) 2019-09-30 13:14:42 -07:00
Jonah Williams
e8517a434d
Add analytics tracking for compile and refresh times for Flutter Web (#41545) 2019-09-30 12:45:03 -07:00
Jonah Williams
06864e445c
Rename Server/web device to Headless Server/headless-server (#41618) 2019-09-30 12:19:45 -07:00
Jonah Williams
41b87255f5
Add support for depfile dependency in assemble (#41530) 2019-09-30 12:17:45 -07:00
Alexandre Ardhuin
f0553ba58e
Missing trailing commas (#41473)
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
stuartmorgan
d1761f1072
Pass Linux build mode on command line (#41551)
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
2019-09-30 09:36:40 -07:00
Jonah Williams
c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug (#40066) 2019-09-30 08:41:12 -07:00
Zachary Anderson
45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal (#41493)
* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Danny Tuppeny
7e73cd74b1
Fix visibility of web server device when Chrome is not available (#40757)
* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
2019-09-30 14:45:30 +01:00
Alexander Aprelev
839fdbd2ed
Retry devfs uploads in case they fail. (#41406)
* Retry devfs uploads in case they fail.

Fixes #34959.
2019-09-29 21:32:06 -07:00
Jonah Williams
07e5cf005c
Reland: Exit resident web runner on compilation failure (#41505) 2019-09-27 18:54:58 -07:00
Jonah Williams
7a487b2cbf
Ensure we find dart.exe on local engines (#41514) 2019-09-27 18:54:24 -07:00
Jonah Williams
d968b7cfd6
Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515) 2019-09-27 15:18:06 -07:00
Zachary Anderson
feaaa5d738
[flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) 2019-09-27 12:18:59 -07:00
Jonah Williams
618fac92c9
Revert "Exit resident web runner on initial compilation failure (#41441)" (#41498) 2019-09-27 11:50:23 -07:00
Jonah Williams
d7a8dda219
Dont update last compiled time when compilation is rejected (#41424) 2019-09-27 10:32:57 -07:00
Jonah Williams
a1852a1993
Exit resident web runner on initial compilation failure (#41441) 2019-09-27 10:32:38 -07:00
Zachary Anderson
716a672bc8
[flutter_tools] Adds tests of mdns analytics events (#41410) 2019-09-27 08:07:26 -07:00
Alexandre Ardhuin
f11c34109c
fix bad indentations(mainly around collection literals) (#41355) 2019-09-27 10:46:45 +02:00
Devon Carew
1044457225
add tests to ensure the sdk is well-formed (#41408)
add tests to ensure the sdk is well-formed
2019-09-26 18:22:25 -07:00
Jonah Williams
efd2ba296b
Flutter build bundle without --precompiled should always perform a debug build. (#41401) 2019-09-26 15:57:57 -07:00
Jonah Williams
c93839131c
Fix timing issues in initialization of web resident runner (#41347) 2019-09-26 14:23:19 -07:00
stuartmorgan
56d68a9071
Add the beginnings of plugin support for Windows and Linux (#41015)
Adds very preliminary support for Windows and Linux plugins:
- Adds those platforms to the new plugin schema, initially supporting just a plugin class.
- Adds C++ plugin registrant generation for any Windows or Linux plugins found.

This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work.

As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or
'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
2019-09-26 14:01:57 -07:00
Jonah Williams
0980fa2ddd
Serve every html file under web (#41386) 2019-09-26 13:24:05 -07:00
Zachary Anderson
7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers (#41304) 2019-09-26 08:12:48 -07:00
Jonah Williams
89ebd700f2
Support deferred imports on profile/release builds of Flutter Web (#41222) 2019-09-25 15:12:58 -07:00
Jonah Williams
7065e43306
Allow skipping chrome launch with --no-web-browser-launch (#40627) 2019-09-25 13:55:54 -07:00
Jonah Williams
9bd02a1787
Re-Re-Re-land implement flutter build bundle with assemble (#41302) 2019-09-25 13:55:29 -07:00
Francisco Magdaleno
d2a95ee344
Fix crash on vswhere query on missing installations (#40786) 2019-09-25 13:38:53 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events (#40988) 2019-09-25 11:26:06 -07:00
Jonah Williams
cc3ca9a916
Revert "Re-Re-land Implement flutter build bundle with assemble (#41230)" (#41295) 2019-09-25 10:57:58 -04:00
Jonah Williams
84a476a4db
Re-Re-land Implement flutter build bundle with assemble (#41230) 2019-09-25 10:17:04 -04:00
Emmanuel Garcia
48ce60824a
Revert "Revert "Use AndroidX in new projects by default (#40925)" (#40995)" (#41001)
This reverts commit 8e23179627.
2019-09-24 16:55:09 -07:00
Emmanuel Garcia
16d408a7a0
Reland #40810: Re-enable AAR plugins when an AndroidX failure occurred (#41160) 2019-09-24 16:16:22 -07:00
Alexandre Ardhuin
b873162194
fix some bad indentations (#41172) 2019-09-24 21:03:37 +02:00
Alexandre Ardhuin
89427d672d
add missing trailing commas in flutter_tools (#40968) 2019-09-24 08:06:09 +02:00
Liam Appelbe
b0563e1a3d
Unit test for build.dart::GenSnapshot (#37642)
* Unit test for build.dart::GenSnapshot

* Fix analysis errors

* Switch to testLogger
2019-09-23 10:09:22 -07:00
Emmanuel Garcia
2c8813c86c
Revert "Re-enable AAR plugins when an AndroidX failure occurred (#40810)" (#41042)
This reverts commit 96482eeb5c.
2019-09-23 09:28:38 -07:00
Emmanuel Garcia
8e23179627
Revert "Use AndroidX in new projects by default (#40925)" (#40995) 2019-09-20 13:37:10 -07:00
Emmanuel Garcia
f7173dcc60
Use AndroidX in new projects by default (#40925) 2019-09-20 08:29:21 -07:00
Emmanuel Garcia
96482eeb5c
Re-enable AAR plugins when an AndroidX failure occurred (#40810) 2019-09-20 08:28:52 -07:00
stuartmorgan
0412977e48
Support create for macOS (app and plugin) (#40851)
Adds macOS support for `flutter create`:
- Currently it is behind a hidden flag.
- Adds a TargetPlatform workaround to lib/main.dart in the standard app template when enabled.
- Supports `app` and `plugin`; `module` support doesn't yet exist for macOS in general.

This will eliminate the need to use FDE's examples as templates on macOS. The templates are based on the current state of FDE's examples, with templating support added (and with adoption of the new application delegate in the app, which hadn't been done yet in FDE, eliminating some boilerplate from the template).

Fixes #30703
2019-09-19 17:06:18 -07:00
Jonah Williams
f8ba6756c3
Revert "Reland: implement build bundle with assemble (#40470)" (#40862) 2019-09-19 09:04:07 -07:00
Jonah Williams
ea7876ae82
Reland: implement build bundle with assemble (#40470) 2019-09-19 07:46:50 -07:00
Jonah Williams
2a36ad31fa
Ensure Flutter for Web debug builds are only accessible through Flutter run (#40783) 2019-09-18 23:10:24 -07:00
stuartmorgan
c32e543207
Invalidate macOS pods on plugin changes (#40730)
When the plugin list changes, iOS pods are invalidated, but that was
never wired up for macOS.

Should fix #39327
2019-09-18 21:42:57 -07:00
Jenn Magder
d95adf999c
Move build info checks from generating files to the xcode build (#40792) 2019-09-18 16:57:31 -07:00
Christopher Fujino
0b24a5a2ff
Implement mdns for flutter run (#40447) 2019-09-18 11:01:08 -07:00
Jonah Williams
5de5bb0172
fix platform environment (#40692) 2019-09-17 17:07:55 -07:00
Jenn Magder
9a68b0df3e
Warn when build number and version can't be parsed on iOS (#40611) 2019-09-17 17:07:41 -07:00
Emmanuel Garcia
8a1bf5b827
Reland #39157 (#39798) 2019-09-17 08:19:33 -07:00
Alexandre Ardhuin
df4bf453ab
more UI-as-code (#35516) 2019-09-17 16:23:44 +02:00
stuartmorgan
d03aecab58
Add an ephemeral directory for Linux (#40587)
Moves the generated config into that directory. Matches the structure of
the other desktop projects.

Also fixes #40265
2019-09-16 16:04:55 -07:00
Zachary Anderson
8a33d2446d
[flutter_tool] Remove the synchronous -showBuildSettings (#40435) 2019-09-16 07:51:50 -07:00
Emmanuel Garcia
4d404da6df
Update Kotlin and Gradle version (#40181) 2019-09-13 19:37:07 -07:00
Emmanuel Garcia
2c857b9370
Enable R8 (#40453) 2019-09-13 19:06:40 -07:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures (#40446) 2019-09-13 14:51:35 -07:00
Jonah Williams
6ba8fa9987
Remove direct flutter tool usage of protobuf for encoding file caches (#40410) 2019-09-13 12:49:03 -07:00
Jonah Williams
69a296463e
Allow skipping webOnlyInitializePlatform in Flutter for Web (#40301) 2019-09-13 10:20:30 -07:00
Francisco Magdaleno
09bb07f8dd
Adds list required components when VS is not installed (#40397) 2019-09-12 18:44:36 -07:00
stuartmorgan
72888c7f75
Harden macOS build use of Xcode project getInfo (#40375)
- Makes build_macos.dart handle the case where there is only one Xcode
  project in the macos/ directory, but it's not called Runner.xcodeproj
- Makes getInfo throw a tool exit when trying to get project info and it
  can't find a project, since that is a configuration error by the user
  rather than a tool bug.
2019-09-12 16:03:02 -07:00
Francisco Magdaleno
576a455a64
[windows] Refactor to optimize vswhere queries (#40197) 2019-09-12 15:48:25 -07:00
Jonah Williams
1fec30efb6
Place existing dill into hot reload temp directory to boost initialization time (#40366) 2019-09-12 12:45:53 -07:00
Jonah Williams
925a52fa6b
add host and port to run configuration for web devices (#40191) 2019-09-12 08:58:49 -07:00
Francisco Magdaleno
f5733f7a62 Fix crash on vswhere search from flutter doctor (#40263)
Fixes a crash introduced on #40011 due to an incorrect type in the vswhere search

Fixes #40238
2019-09-11 21:03:42 -07:00
Jonah Williams
270878fc50
fix copy command and remove resolve sync for macOS assemble (#40294) 2019-09-11 20:29:27 -07:00
Zachary Anderson
73c10e8ced
[flutter_tool] process.dart cleanup (#39899) 2019-09-11 18:20:42 -07:00
Emmanuel Garcia
3712ea63d8
Flip the default for proguard (#40282) 2019-09-11 17:51:51 -07:00
Jonah Williams
6d37867c4a
Place hot reload artifacts in a temp directory (#40171) 2019-09-11 12:57:43 -07:00
Jonah Williams
8eee93fa64
Ensure we send hot restart events for flutter web (#40175) 2019-09-11 09:38:42 -07:00
Christopher Fujino
c5e2bf5cfe
catch errors during gradle update (#37526) 2019-09-11 09:21:42 -07:00
Zachary Anderson
2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams (#40159) 2019-09-11 08:30:29 -07:00
stuartmorgan
e6ae95c4ce
Add an ephemeral directory to Windows projects (#40194)
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).

Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
2019-09-11 07:46:57 -07:00
Jonah Williams
609a78fdca
Revert "build bundle with assemble (#37508)" (#40204) 2019-09-10 20:03:52 -07:00
Jonah Williams
f614144f0a
Add "web" server device to allow running flutter for web on arbitrary browsers (#39951)
* add web server device

* remove extra async

* fixes to server device

* testing updates

* fix test cases

* address comments
2019-09-10 19:29:31 -07:00
Jonah Williams
a7aff56741
build bundle with assemble (#37508) 2019-09-10 19:28:38 -07:00
Emmanuel Garcia
f098de1fde
Enable Proguard by default on release mode (#39986) 2019-09-10 17:22:55 -07:00
Francisco Magdaleno
362cde43ff
[windows] Searches for pre-release and 'all' Visual Studio installations (#40011) 2019-09-10 17:01:53 -07:00
Jenn Magder
12229264e2
Show CocoaPods version in hint text (#40117) 2019-09-10 13:26:32 -07:00
Jonah Williams
f877c97b3b
Use persisted build information to automatically clean old outputs in assemble (#39654) 2019-09-10 09:57:47 -07:00
Jonah Williams
477ae6b8ce
cleanup use of build runner internals (#40045) 2019-09-09 18:16:03 -07:00
Jonah Williams
0f365d3add
remove dart dir chrome profile (#39934) 2019-09-09 18:14:13 -07:00
Jonah Williams
b4c3671718
Register reload sources call and make 'r' restart for web (#39950) 2019-09-06 10:41:15 -07:00
stuartmorgan
4c2c7c417d
Switch to the Win32 Windows embedding (#39836)
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.

Fixes #38590
2019-09-05 10:09:12 -07:00
stuartmorgan
3948e8759e
Allow specifying a project for Xcode getInfo (#39782)
Avoids unnecessarily breaking projects that have another .xcodeproj in
their macos/ directory, which worked until the addition of the getInfo
call.
2019-09-05 10:07:03 -07:00
Jonah Williams
dd7694256e
remove input files argument to target (#39769) 2019-09-05 09:56:37 -07:00
Zachary Anderson
0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command (#39579) 2019-09-05 09:50:46 -07:00
Kenzie Schmoll
d50d9c5e60
Register flutterVersion service in flutter_tools. (#39524)
* Register getFlutterVersion service in flutter_tools.

* Add short revision ids to response.

* Rename method and remove obsolete comments.

* Fix broken test by adding sendPeerNotifications flag.

* Implement mockPeer.sendNotification.
2019-09-05 09:50:36 -07:00
Emmanuel Garcia
d230234d67
Revert Maven dependencies (#39747) (39157) (#39784) 2019-09-03 17:49:10 -07:00
Jonah Williams
d804097014
print launching on device message (#39748) 2019-09-03 12:55:06 -07:00
Jonah Williams
af851ab6bc
Revert "remove input files argument to target (#39701)" (#39768)
This reverts commit 5e7beaf7b8.
2019-09-03 12:47:33 -07:00
Jonah Williams
5e7beaf7b8
remove input files argument to target (#39701) 2019-09-03 12:46:08 -07:00
Jonah Williams
cc9b614efd
minor cleanup and prevent multiple exit (#39751) 2019-09-03 11:00:39 -07:00
Harry Terkelsen
d33cf11556
Automatically generated registrants for web plugins (#39628)
* WIP on web plugin registry

* WIP on registering plugins

* WIP on web plugin registration

* Only generate `package:flutter_web_plugins` imports if plugins are
defined

* Add parsing test

* Add documentation

* Fix analyzer warnings

* add license headers

* Add tests for package:flutter_web_plugins

* Run `flutter update-packages --force-upgrade`

* Fix analyzer errors

* Fix analyzer error in test

* Update copyright and remove flutter SDK constraints

* Enable tests since engine has rolled

* add flutter_web_plugins tests to bots

* Create an empty .packages file for WebFs test
2019-09-03 10:37:34 -07:00
Zachary Anderson
b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor (#39445) 2019-09-03 08:14:44 -07:00
Emmanuel Garcia
b63cb44105
Use new Maven artifacts from Gradle (#39157) 2019-09-02 10:35:17 -07:00
Jonah Williams
f12a5ec347
dont hide build commands (#39555) 2019-09-01 23:57:11 -07:00
Kaushik Iska
fc05c3738c
Flutter Plugin Tool supports multi-platform plugin config (#38632) 2019-08-29 21:51:31 -07:00
Jonah Williams
b2a4ebe38f
Handle single unsupported device (#39541) 2019-08-29 21:39:38 -07:00
Emmanuel Garcia
6266d5f35d
Log flags in build apk and appbundle (#39457) 2019-08-29 21:37:35 -07:00
Jonah Williams
2dbf0106d8
Create dart tool directory if it is missing (#39543) 2019-08-29 21:31:57 -07:00
Dan Field
eefe9d9527
keep symbols for profile (#39530) 2019-08-29 20:54:30 -07:00
Jonah Williams
359b532570
Remove run in shell and add unit test for chrome launching (#39462) 2019-08-29 19:35:06 -07:00
Dan Field
632526aab9
Update validation to support Xcode11 version (#39463) 2019-08-29 15:28:05 -07:00
Dan Field
cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" (#39434) 2019-08-28 15:19:04 -07:00
Emmanuel Garcia
4a1c62c28b
Add missing files in the Gradle wrapper directory (#39145) 2019-08-28 14:52:08 -07:00
Jonah Williams
f362419601
make sure profile is forwarded through build web command (#39414) 2019-08-28 14:05:01 -07:00
Jonah Williams
393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode (#39357)" (#39431)
This reverts commit 202c1b4224.
2019-08-28 13:12:45 -07:00
Dan Field
202c1b4224
Relax requirements around local engine, build hello_world with bitcode (#39357) 2019-08-28 10:27:01 -07:00
Zachary Anderson
b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings (#39280) 2019-08-28 10:03:53 -07:00
xster
4640690d0f
let flutter build aar use a local engine (#39312) 2019-08-27 23:46:33 -07:00
Jonah Williams
55a1ba761d
Use output dir instead of specific paths in assemble rules (#39274) 2019-08-27 22:52:51 -07:00
Jonah Williams
23637844a3
fix source map loading and service protocol for flutter web (#39189) 2019-08-27 19:06:48 -07:00
Emmanuel Garcia
5353d5e877
Fid app bundle in Gradle 3.5 (#39126) 2019-08-27 17:08:02 -07:00
Zachary Anderson
91ae1409b9
[flutter_tool] Create a temp snapshot to run create_test.dart tests (#39338) 2019-08-27 14:28:03 -07:00
Jonah Williams
6f71ce26d6
Place terminalUi flag on terminal interface (#39214) 2019-08-27 14:20:51 -07:00
stuartmorgan
7407695816
Add profile support on macOS (#39264)
Fix some places where Debug/Release was treated as a binary switch.

Makes similar changes to Windows and Linux to simplify adding profile
support to those platforms in the future. This means `--profile` builds
will fail on Linux and Windows for now, but that's fine since they
aren't actually supported, and unlike `--release` don't provide useful
functionality at the native code level.

Also fixes 'stopApp' always using Debug on macOS, to avoid showing an
error when running Profile (or Release).

Fixes #33203
2019-08-26 16:30:30 -07:00
Jonah Williams
0f8b8c91a3
Kill resident runner on browser disconnect. (#39066) 2019-08-26 15:06:36 -07:00
Zachary Anderson
e9bd2ef087
[flutter_tool] Some additional input validation for 'version' (#39136) 2019-08-26 12:12:50 -07:00
Christopher Fujino
d1e0273ecb
refactor cocoapods validator to detect broken install (#38560) 2019-08-23 09:21:09 -07:00
Jonah Williams
b2d19d2af5
Add support for macOS release/profile mode (3 of 3) (#38909) 2019-08-23 08:46:24 -07:00
Michael Thomsen
01a5d112d5
Make forward calls run interactively (#39052) 2019-08-23 11:16:30 +02:00
Mehmet Fidanboylu
d921098dd4
Break dependency of tools/lib/src from lib/src/commands/ (#39072) 2019-08-22 21:14:03 -07:00
Jonah Williams
9818d2df3b
Add web workflow to default validators (#39006) 2019-08-22 09:30:19 -07:00
Zachary Anderson
663dc1d774
[flutter_tool] Teach crash reporter about HttpException (#39005) 2019-08-22 09:18:25 -07:00
Jonah Williams
33e7af728a
Dont throw StateError when calling assemble with bad target (#39000) 2019-08-21 23:44:39 -07:00
Jenn Magder
892d62f03a
Clean Xcode workspace during flutter clean (#38992) 2019-08-21 18:42:56 -07:00
∂ω∂
4277f364ff flutter_tools/version: git log.showSignature=false (#38576) 2019-08-21 13:55:57 -07:00
Zachary Anderson
36e8b93d1c
[flutter_tool] Only send one crash report per run (#38925) 2019-08-21 13:07:52 -07:00
Zachary Anderson
3ceef86b9a
[flutter_tool] Handle crashes from doctor validators (#38920) 2019-08-21 11:15:02 -07:00
stuartmorgan
01530928f0
Add build warning for non-debug desktop builds (#38932)
When building in profile or release mode on desktop, add a prominent
warning that it's actually a debug build. This is to help address issues
with people being unaware of the current state of builds due to
following third-party guides rather than official documentation.

macOS is not included since PRs are in flight for macOS release support.
2019-08-20 20:16:29 -07:00
Jonah Williams
3b4ab4eb30
Throw error when hot reload enters bad state (#38907) 2019-08-20 14:30:03 -07:00
Zachary Anderson
398ac1f6c8
[flutter_tool] Remove some async file io (#38654) 2019-08-20 13:15:08 -07:00
Zachary Anderson
28bedb10da
[flutter_tool] Move http request close under try-catch (#38894) 2019-08-20 12:53:59 -07:00
Jonah Williams
2504a416bb
Create correctly structured framework for macOS (#38748) 2019-08-20 10:49:15 -07:00
Jonah Williams
700020fc6b
per file caching (#38869) 2019-08-20 10:40:02 -07:00
stuartmorgan
2daab305aa
Use GLFW-name artifacts on Windows and Linux (#38858)
Switch from the un-suffixed Windows and Linux libraries to the
_glfw-suffixed versions, in preparation for having non-GLFW versions
using the previous library/wrapper names.

Part of #38589
2019-08-20 06:29:49 -07:00
Jonah Williams
ae29174560
Handle compilation failures from web application (#38723) 2019-08-19 17:33:46 -07:00
Jonah Williams
7ed27b51a3
print service url when connecting to web applications (#38823) 2019-08-19 17:32:43 -07:00
Michael Thomsen
79d8967500
Fix publish cmd (#38490) 2019-08-19 08:02:13 +01:00
Todd Volkert
c22ce95e15
Change from using defaults to plutil for Plist parsing (#38662)
We were using the `defaults` command-line utility to parse
Plist files, but it was never supported by Apple, and it
appears that in an upcoming OS release, it will be less likely
to work:

> WARNING: The defaults command will be changed in an upcoming
> major release to only operate on preferences domains. General
> plist manipulation utilities will be folded into a different
> command-line program.

Fixes https://github.com/flutter/flutter/issues/37701
2019-08-16 17:10:07 -07:00
Dan Field
a3221667de
Kill dead code (#38652) 2019-08-16 10:10:23 -07:00
Todd Volkert
1d8deb1bb8
Handle case of a connected unpaired iOS device (#38629)
Fixes https://github.com/flutter/flutter/issues/36789
Fixes https://github.com/flutter/flutter/issues/37000

https://github.com/flutter/flutter/issues/36524
https://github.com/flutter/flutter/issues/24600
2019-08-15 17:59:37 -07:00
Jonah Williams
1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) (#38645) 2019-08-15 17:38:35 -07:00
Jonah Williams
01feddbece
Support for macOS release mode (1 of 3) (#37425) 2019-08-15 16:36:45 -07:00
Zachary Anderson
0566971d29
[flutter_tool] Throw tool exit on malformed storage url override (#38637) 2019-08-15 14:59:46 -07:00
Zachary Anderson
e24a27d374
[flutter_tool] Flip create language defaults to swift and kotlin (#38339) 2019-08-15 12:13:28 -07:00
Zachary Anderson
a40ab895cf
[flutter_tool] Observatory connection error handling cleanup (#38353) 2019-08-15 12:13:03 -07:00
Alexander Aprelev
f5dcbdab3a Increase pattern that matches operation duration. (#36392)
On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.
2019-08-15 10:16:30 -07:00
Ingo Reinhart
ed88d28d52 use common emulator/device list (#38296) 2019-08-15 10:13:18 -07:00
Jonah Williams
5ec039dd45
Don't reload if compilation has errors (#38586) 2019-08-15 09:08:19 -07:00
Dan Field
07f079a932
Improve bitcode check (#38587) 2019-08-14 23:30:26 -07:00
Jonah Williams
64add554d7
handle unexpected exit from frontend server (#38497) 2019-08-14 19:00:31 -07:00
Jonah Williams
388d69eb9b
Catch errors thrown into the Zone by json_rpc (#38486) 2019-08-14 13:10:41 -07:00
Zachary Anderson
d220631eca
[flutter_tool] Fix bug in manifest yaml validation (#38472) 2019-08-14 07:57:30 -07:00
Christopher Fujino
cd1e55b58a
refactor flutter upgrade to be 2 part, with the second part re-entrant (#38325) 2019-08-13 15:53:54 -07:00
David Shuckerow
9615eb99aa
Tests for flutter test [some_directory] (#36866)
* Add a test for a directory instead of a single test.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Correct test.
2019-08-13 14:57:43 -07:00
Jonah Williams
ca5411e3aa
Fix type error hidden by implicit downcasts (#38102) 2019-08-12 15:21:28 -07:00
Jonah Williams
4b73746aff
Catch filesystem exception from flutter create (#38101) 2019-08-12 09:51:03 -07:00
Jonah Williams
2185825338
Catch FormatException caused by bad simctl output (#37958) 2019-08-10 00:57:23 -07:00
jmagman
0a58610ce7
Clean ephemeral directories (#37966) 2019-08-09 17:26:51 -07:00
Jonah Williams
77e15103da
Catch failure to create directory in cache (#37871) 2019-08-09 16:21:32 -07:00
David Martos
526339b63a Avoid killing Flutter tool process (#37471) (#37500) 2019-08-09 11:25:12 -07:00
Yegor
9bc298deb6
update dependencies; add a Web smoke test (#37816)
update dependencies; add a Web smoke test
2019-08-09 09:58:49 -07:00
Jonah Williams
f98df595f3
Restructure resident web runner usage to avoid SDK users that don't support dwds (#37815) 2019-08-08 16:36:27 -07:00
jmagman
5ed3b418a1
Add COMPILER_INDEX_STORE_ENABLE=NO to macOS build and tests (#37806) 2019-08-07 18:02:06 -07:00
Jonah Williams
8e6205fe1d
Handle thrown maps and rejects from fe server (#37743) 2019-08-07 17:00:36 -07:00
Jason Simmons
4f302dc18c
Remove unused no-build flag from the flutter run command (#37735)
The use-application-binary flag can be used to run a previously built
app package.
2019-08-07 12:44:02 -07:00
Christopher Fujino
39a04dcd7f
Support macOS Catalina-style signing certificate names (#37733) 2019-08-07 09:18:11 -07:00
Jonah Williams
fef69b2044
Partial macOS assemble revert (#37664) 2019-08-06 09:15:50 -07:00
Zachary Anderson
0bba472858
[flutter_tool] Remove unintended analytics screen send (#37514) 2019-08-06 09:08:43 -07:00
Jonah Williams
caa56d6ac4
enable track widget creation on debug builds (#37512) 2019-08-05 22:07:35 -07:00
Jonah Williams
a785db78fb
Reland "Integrate dwds into flutter tool for web support (#34252)" (#37649)" (#37650) 2019-08-05 16:51:57 -07:00
Jonah Williams
433436e1ee
Revert "Integrate dwds into flutter tool for web support (#34252)" (#37649) 2019-08-05 15:58:04 -07:00
Zachary Anderson
500d7c50df
[flutter_tool] Additional flutter manifest yaml validation (#37422) 2019-08-05 13:14:57 -07:00
Jonah Williams
4ccd81199f
Integrate dwds into flutter tool for web support (#34252) 2019-08-05 12:41:58 -07:00
Christopher Fujino
5fb2d2aeea
have xcodeSelectPath also catch ArgumentError (#37521) 2019-08-02 16:08:49 -07:00
Emmanuel Garcia
40c5cc9708
Find the app bundle when the flavor contains underscores (#37457) 2019-08-02 16:02:46 -07:00
Emmanuel Garcia
80ee3dd04c
Print message when HttpException is thrown after running flutter run (#37440) 2019-08-02 16:02:02 -07:00
stevemessick
93dd90fc1a
Add .android/Flutter/flutter.iml to module template. (#37405) 2019-08-01 15:47:00 -07:00
Majid Hajian
7244cbb9b2 add line-length to flutter format commandline (#36679) 2019-08-01 10:27:41 -07:00
Jonah Williams
cf6613583d
only build macOS kernel in debug mode (#37365) 2019-08-01 09:23:40 -07:00
Zachary Anderson
2e183b6233
[flutter_tool] Include the local timezone in analytics timestamp (#37345) 2019-07-31 23:28:18 -07:00
Jonah Williams
602f76ca00
fix errors caught by roll of macOS assemble (#37351) 2019-07-31 21:14:40 -07:00
Jonah Williams
2ab469952b
Flutter assemble for macos take 2! (#36987) 2019-07-31 16:19:22 -07:00
Jenn Magder
dd1fb3bcb7
Build number (part after +) is documented as optional, use entire app version if not present (#37036) 2019-07-31 16:18:09 -07:00
Zachary Anderson
c7596da5a4
[flutter_tool] Re-try sending the first crash report (#37198) 2019-07-31 13:51:19 -07:00
Dan Field
a8fbe02a9d hide symbols from spotlight (#37217) 2019-07-30 14:24:58 -07:00
Zachary Anderson
d208ce2dff
[flutter_tool] Usage refactor cleanup (#37186) 2019-07-30 12:18:15 -07:00
Zachary Anderson
a9aea962ab
[flutter_tool] Catch ProcessException from 'adb devices' (#37196) 2019-07-30 12:17:10 -07:00
Zachary Anderson
99d66f2709
[flutter_tool] Make a couple file operations synchronous (#37044) 2019-07-30 12:16:32 -07:00
Jenn Magder
bd47a31e32
Vend Flutter module App.framework as a local CocoaPod pod to be installed by a host app (#36793) 2019-07-30 09:58:39 -07:00
Zachary Anderson
a5d23d2a25
[flutter_tool] More gracefully handle Android sdkmanager failure (#37194) 2019-07-30 08:19:58 -07:00
Jonah Williams
c9a5f94372
Include flutter_runner in precache artifacts. (#36318) 2019-07-29 16:13:47 -07:00
Zachary Anderson
ef146f63bb
[flutter_tool] Clean up usage events and custom dimensions (#36785) 2019-07-29 07:24:02 -07:00
Jonah Williams
51d2d3511c
Expose functionality to compile dart to kernel for the VM (#36598) 2019-07-26 19:50:57 -07:00
Michael Klimushyn
30eec11e7d Roll back the AAR build experiment (#36966)
* Roll back the AAR build experiment

This has been breaking flutter/plugins CI for the past day.

* Remove integration tests that rely on the AAR flag
2019-07-25 20:54:10 -07:00
Jonah Williams
188093c912
Rearrange flutter assemble implementation (#36240) 2019-07-25 08:50:03 -07:00
Jonah Williams
76d058163b
Adjust phrasing of features (#36874)
* adjust phrasing of features

* word smithing

* more wordsmithing
2019-07-25 08:48:01 -07:00
Jonah Williams
16e484b179
Remove Chain terse parsing (#36860) 2019-07-25 08:47:39 -07:00
Siva
c15cfdd6af
flutter/engine@ef99738...72341ed (#36885)
flutter/engine@72341ed03 Roll fuchsia/sdk/core/linux-amd64 from gQ3ztEQmdEh3iE6n9EO6iGRdmDSX-edmP5WyE-Ui4BEC to gTG1jp04GzBudVJqRxulXYOEQgbYTUQgnqLDYAq7z3sC (#10115)
flutter/engine@d66031f2a Roll src/third_party/dart 82f657d7cb..0c97c31b6e (7 commits) (#10114)
flutter/engine@f742514a5 Cache font family lookups that fail to obtain a font collection (#10109)
flutter/engine@7c177724c Roll fuchsia/sdk/core/mac-amd64 from A21rwGAUjpjVTX8HgpT9Iyx6J_QZBRDhu-5GAclrf00C to UCAnzi4k9pA30l_iZ2Ru51Tc3Ke6iacIdjFMgVUVdRMC (#10107)
flutter/engine@c3165da09 Roll src/third_party/skia fdf4bfe6d389..b3956dc6ba6a (1 commits) (#10101)
flutter/engine@71702b3f8 Roll fuchsia/sdk/core/linux-amd64 from gPDgr6u-BPJTgV2Nf0tlg9MTY3JwGW0cETtsQcx365AC to gQ3ztEQmdEh3iE6n9EO6iGRdmDSX-edmP5WyE-Ui4BEC (#10103)
flutter/engine@f393da22d [fuchsia] copy over the cmx file (#10087)
flutter/engine@8ebd15d26 Roll src/third_party/skia f564f1515bde..fdf4bfe6d389 (1 commits) (#10100)
flutter/engine@f529a251b Roll fuchsia/sdk/core/mac-amd64 from lvLKs8Q4CKm_XLoZCQ72RO0RHI6yvJXnA9M_M8r4-aAC to A21rwGAUjpjVTX8HgpT9Iyx6J_QZBRDhu-5GAclrf00C (#10099)
flutter/engine@d409df823 Roll src/third_party/dart 9c148623c5..82f657d7cb (25 commits)
flutter/engine@acd139ce6 Roll src/third_party/skia 1cd1ed8976c4..f564f1515bde (1 commits) (#10097)
flutter/engine@f2c9da4a0 Roll src/third_party/skia 3ae30cc2e6e0..1cd1ed8976c4 (1 commits) (#10096)
flutter/engine@d2f0b9ef1 Roll fuchsia/sdk/core/linux-amd64 from MCDItwEzechMpZAiI0QOzuiTtNUGArUa4TprH0Er-7QC to gPDgr6u-BPJTgV2Nf0tlg9MTY3JwGW0cETtsQcx365AC (#10095)
flutter/engine@0f4db494a Roll fuchsia/sdk/core/mac-amd64 from EH_61w2lpSn0UmpJkynWM6tiT0nnKk1GhTRRKK2cGMwC to lvLKs8Q4CKm_XLoZCQ72RO0RHI6yvJXnA9M_M8r4-aAC (#10094)
flutter/engine@298799991 Roll src/third_party/skia 0f9c660aa939..3ae30cc2e6e0 (1 commits) (#10093)
flutter/engine@a4d2d3648 Roll fuchsia/sdk/core/linux-amd64 from tCzkXNr7cb5OAbS5NcJ4F_g0DgVj3w8rfbT14AcaTHoC to MCDItwEzechMpZAiI0QOzuiTtNUGArUa4TprH0Er-7QC (#10090)
flutter/engine@d27a6373d Roll fuchsia/sdk/core/mac-amd64 from xNAaLqZJk8Bkz00BaHGzE8hCpiohggO7KabM3g2wdsQC to EH_61w2lpSn0UmpJkynWM6tiT0nnKk1GhTRRKK2cGMwC (#10089)
flutter/engine@20dc17282 Roll src/third_party/skia d15571af2e1b..0f9c660aa939 (1 commits) (#10088)
flutter/engine@9e7260b9d Roll fuchsia/sdk/core/linux-amd64 from kU0OwJYlceN477ejdh9RXrl7Mp-wUTNvQozlaV96xmQC to tCzkXNr7cb5OAbS5NcJ4F_g0DgVj3w8rfbT14AcaTHoC (#10086)
flutter/engine@0e621d902 [fuchsia] Use the new far package model (#10085)
flutter/engine@bdc713695 [fuchsia] Add sysroot and clang libs to package (#10082)
flutter/engine@72f747ae4 Roll fuchsia/clang/linux-amd64 from apsjZJ9ZIwlS08divc0QwxuNgIFeN4X-52mKR9d8qacC to zHiuOGMDwdWPUkV1B2fHKyRy2fGWGcUgfa2z6dyGAZQC (#10084)
flutter/engine@bfe689ee8 Roll fuchsia/clang/mac-amd64 from USm3Qt9wen4bXoFF0T9Xt8NX-pyEfte2cTYi7geLAhQC to UYD9C8IEkWVi83ef4zwO1Ump2B8cP9Nd5WECjU8l3AUC (#10083)
flutter/engine@cf5d76c17 [fuchsia] Add support for libs in packages (#10081)
flutter/engine@c4c64896a Roll src/third_party/skia 829144cc76fe..d15571af2e1b (2 commits) (#10080)
flutter/engine@25e5d597e Roll fuchsia/sdk/core/linux-amd64 from S_24mhItBb7pfUof8zsJPPSctC7xdlfjDEXEtyO25GYC to kU0OwJYlceN477ejdh9RXrl7Mp-wUTNvQozlaV96xmQC (#10079)
flutter/engine@f7e0614b8 Change ParagraphBuilder to replace the parent style's font families with the child style's font families (#10074)
flutter/engine@eb74f2ce7 One more luci fix (#10078)
flutter/engine@6e732c7f1 Change flutter runner target for LUCI (#10075)
flutter/engine@44ec59b70 Roll src/third_party/dart fedd74669a..9c148623c5 (70 commits) (#10066)
flutter/engine@abf93699f Basic structure for flutter_jit_runner far (#10073)
flutter/engine@3c76b90b2 Track clusters and return cluster boundaries in getGlyphPositionForCoordinates (emoji fix) (#10063)
flutter/engine@e8fb641f6 Enable consts from environment in DDK for flutter_web (#10069)
flutter/engine@bd3870219 [macos] Revert check on FlutterCodecs and refactor message function] (#10009)
flutter/engine@d6e1a93e2 Roll src/third_party/skia e11dfd3da4d7..829144cc76fe (4 commits) (#10072)
flutter/engine@d595af681 Roll fuchsia/sdk/core/linux-amd64 from XqtWTBni4xpYCTr7gqU7rFTuXNY1TZ_zOqBJrZM8c_kC to S_24mhItBb7pfUof8zsJPPSctC7xdlfjDEXEtyO25GYC (#10071)
2019-07-24 22:44:12 -07:00
Jonah Williams
15e322c0e5
Expose build-dir config option (#36773) 2019-07-24 12:13:51 -07:00
sjindel-google
6e963b9985
Remove flaky check for analyzer message. (#36832) 2019-07-24 20:21:31 +02:00
Ian Hickson
e8d7306828
Some minor cleanup for flutter_tools (#36569) 2019-07-24 10:58:09 -07:00
Zachary Anderson
6fe45fb1ac
[flutter_tool] Improve Windows flutter clean error message (#36784) 2019-07-24 10:56:06 -07:00
Jonah Williams
3b4d9f6780
more resident runner verification tests (#36595) 2019-07-23 15:38:52 -07:00
Jonah Williams
694d54ccac
Place build outputs under dart tool (#36585) 2019-07-23 15:36:55 -07:00
Jonah Williams
14aa4d0a45
fix analytics reporting test (#36556) 2019-07-23 11:02:02 -07:00
Emmanuel Garcia
242a4225a1
Flutter build aar (#36732)
`flutter build aar`

This new build command works just like `flutter build apk` or `flutter build appbundle`, but for plugin and module projects.

This PR also refactors how plugins are included in app or module projects. By building the plugins as AARs, the Android Gradle plugin is able to use Jetifier to translate support libraries into AndroidX libraries for all the plugin's native code. Thus, reducing the error rate when using AndroidX in apps.

This change also allows to build modules as AARs, so developers can take these artifacts and distribute them along with the native host app without the need of the Flutter tool. This is a requirement for add to app.

`flutter build aar` generates POM artifacts (XML files) which contain metadata about the native dependencies used by the plugin. This allows Gradle to resolve dependencies at the app level. The result of this new build command is a single build/outputs/repo, the local repository that contains all the generated AARs and POM files.

In a Flutter app project, this local repo is used by the Flutter Gradle plugin to resolve the plugin dependencies. In add to app case, the developer needs to configure the local repo and the dependency manually in `build.gradle`:


repositories {
    maven {
        url "<path-to-flutter-module>build/host/outputs/repo"
    }
}

dependencies {
    implementation("<package-name>:flutter_<build-mode>:1.0@aar") {
       transitive = true
    }
}
2019-07-23 09:27:42 -07:00
Emmanuel Garcia
c9b466f9e2
Revert "Add flutter build aar (#35217)" (#36731)
This reverts commit 11460b8378.
2019-07-22 22:07:59 -07:00
Emmanuel Garcia
11460b8378
Add flutter build aar (#35217)
`flutter build aar`

This new build command works just like `flutter build apk` or `flutter build appbundle`, but for plugin and module projects.

This PR also refactors how plugins are included in app or module projects. By building the plugins as AARs, the Android Gradle plugin is able to use Jetifier to translate support libraries into AndroidX libraries for all the plugin's native code. Thus, reducing the error rate when using AndroidX in apps.

This change also allows to build modules as AARs, so developers can take these artifacts and distribute them along with the native host app without the need of the Flutter tool. This is a requirement for add to app.

`flutter build aar` generates POM artifacts (XML files) which contain metadata about the native dependencies used by the plugin. This allows Gradle to resolve dependencies at the app level. The result of this new build command is a single build/outputs/repo, the local repository that contains all the generated AARs and POM files.

In a Flutter app project, this local repo is used by the Flutter Gradle plugin to resolve the plugin dependencies. In add to app case, the developer needs to configure the local repo and the dependency manually in `build.gradle`:


repositories {
    maven {
        url "<path-to-flutter-module>build/host/outputs/repo"
    }
}

dependencies {
    implementation("<package-name>:flutter_<build-mode>:1.0@aar") {
       transitive = true
    }
}
2019-07-22 20:46:01 -07:00
Jonah Williams
e5ea996a1f
disable flaky windows test (#36722) 2019-07-22 18:14:43 -07:00
Jonah Williams
3fedb8cb5a
Reland: use flutter features for web and desktop (#36699) 2019-07-22 15:34:03 -07:00
Danny Tuppeny
d42d0c5171
Re-enable flutter test expression evaluation tests (#36431)
Plus:

- Resume the app being run after expression has been evaluated to prevent the test run being forcefully terminated because it didn't end
- Skip non-JSON when waiting for JSON (eg. when running in verbose mode for debugging locally)
- Pass defaultTimeout in waitForJson (otherwise the assert in _timeoutWithMessages fails when it's not provided)

Closes https://github.com/flutter/flutter/issues/26518 (the original reason for skip was fixed in https://github.com/dart-lang/sdk/issues/34224).
2019-07-22 19:43:37 +01:00
Jonah Williams
8eae2dfb92
Revert "Use FlutterFeatures to configure web and desktop devices (#36465)" (#36654)
This reverts commit bd52a78c71.
2019-07-21 21:47:43 -07:00
Jonah Williams
bd52a78c71
Use FlutterFeatures to configure web and desktop devices (#36465) 2019-07-21 18:21:15 -07:00
Zachary Anderson
76cbbeb627
[flutter_tool] Send the local time to analytics with screens and events (#36545) 2019-07-19 14:54:18 -07:00
Jonah Williams
6830edd0be
Clean up flutter driver device detection. (#36434) 2019-07-19 14:48:17 -07:00
Christopher Fujino
9bd2e4000b
Throw exception if instantiating IOSDevice on non-mac os platform (#36288) 2019-07-19 12:20:45 -07:00
Dan Field
c953cd19d2
Enable bitcode compilation for AOT (#36471) 2019-07-18 22:42:47 -07:00
Zachary Anderson
82a4ba40bb
[flutter_tool] Send analytics command before the command runs (#36490) 2019-07-18 18:05:44 -07:00
Todd Volkert
adb2aeebe3
Ensure that cache dirs and files have appropriate permissions (#28090)
This is a partial re-application of #24669, which was
reverted due to Fuchsia breakages.

https://github.com/flutter/flutter/issues/24413
2019-07-18 15:29:06 -07:00
Emmanuel Garcia
5a34e7981e
Catch exceptions thrown by runChecked* when possible (#36109) 2019-07-18 10:45:37 -07:00
Jonah Williams
757b5365fa
Add missing test case for Usage (#36379) 2019-07-18 10:41:13 -07:00
Jonah Williams
1957c66300
add testing to screenshot and printDetails method (#36418) 2019-07-18 10:40:40 -07:00
Christopher Fujino
42a9c031e5
Fix invocations of ideviceinstaller not passing DYLD_LIBRARY_PATH (#36327)
* add failing tests

* fix tests

* be more specific with try-catch

* add further mocking to get tests to pass again

* fix analyzer failure
2019-07-17 13:44:49 -07:00
xster
03220cacd1
Make sure add-to-app build bundle from outer xcodebuild/gradlew sends analytics (#36122) 2019-07-17 11:17:04 -07:00
Todd Volkert
57efab6e58
FakeHttpClientResponse improvements (#36289)
Update `FakeHttpClientResponse` to be impervious to Dart SDK
changes to the `HttpClientResponse` stream type (between `List<int>`
and `Uint8List`).
2019-07-17 08:42:12 -07:00
Jonah Williams
36c37ccab5
Implement feature flag system for flutter tools (#36138) 2019-07-16 17:33:28 -07:00
Todd Volkert
aa9a115181
Move reporting files to reporting/ (#36017)
Slight cleanup of file locations in flutter_tools
to make it easier to see which files are responsible
for data reporting.
2019-07-16 13:21:06 -07:00
Christopher Fujino
540c747656
Revert "Keep LLDB connection to iOS device alive while running from CLI. (#36194)" (#36293)
This reverts commit 5501a1c1e7.
2019-07-16 12:34:49 -07:00
sjindel-google
5501a1c1e7
Keep LLDB connection to iOS device alive while running from CLI. (#36194)
## Description

Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.

This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.

## Tests

This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.

I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.

## Breaking Change

I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").
2019-07-16 19:15:15 +02:00
Zachary Anderson
fa65ddf51d
[flutter_tool] Allow analytics without a terminal attached (#36208) 2019-07-16 09:48:49 -07:00
chunhtai
1166015931
Enable widget load assets in its own package in test (#35991) 2019-07-16 09:47:42 -07:00
Jonah Williams
b257c33b69
Use DeviceManager instead of device to determine if device supports project (#36213) 2019-07-15 16:10:39 -07:00
Jonah Williams
6b17840cbf
Don't try to flutterExit if isolate is still paused (#36199) 2019-07-15 15:44:58 -07:00
Christopher Fujino
102ab1e6d9
Reland bundle ios deps (#36093)
This updates the flutter tool cache to download binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-15 09:22:29 -07:00
Jonah Williams
e3ee5c6bbb
Add better handling of JSON-RPC exception (#36082) 2019-07-13 16:02:09 -07:00
Ian Hickson
d919e694b8
Move tools tests into a general.shard directory in preparation to changing how we shard tools tests (#36108) 2019-07-13 11:51:44 -07:00
Zachary Anderson
13382f41c0
[flutter_tool] Catch a yaml parse failure during project creation (#36105) 2019-07-12 23:24:04 -07:00
Christopher Fujino
e91822da24
Revert "Bundle ios dependencies (#34669)" (#36071)
This reverts commit 14d489adc5.
2019-07-12 09:03:34 -07:00
Jonah Williams
7b150f81c5
move reload and restart handling into terminal (#35846) 2019-07-12 08:48:14 -07:00
Christopher Fujino
14d489adc5
Bundle ios dependencies (#34669)
This updates the flutter tool to cache binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-12 08:36:18 -07:00
Jonah Williams
e91b98a41f
Add initial implementation of flutter assemble (#32816) 2019-07-11 16:53:17 -07:00
Jonah Williams
adf45d1e40
Refactor signal and command line handler from resident runner (#35406) 2019-07-09 13:10:26 -07:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget (#32511) 2019-07-09 10:18:30 -07:00
Alexandre Ardhuin
b041a589c8
enable lint prefer_if_null_operators (#35745) 2019-07-09 10:53:35 +02:00
Jenn Magder
559c9982dd
UIApplicationLaunchOptionsKey -> UIApplication.LaunchOptionsKey (#35763) 2019-07-08 16:55:27 -07:00
Jonah Williams
1e26c41f17
Remove web, fuchsia, and unsupported devices from all (#35709) 2019-07-08 15:58:38 -07:00
Jonah Williams
34467289d6
Add timer checking and Fake http client to testbed (#35392) 2019-07-08 10:04:48 -07:00
Jonah Williams
e6a7419603
disable a test case in xcode_backend.sh (#35708) 2019-07-08 08:04:48 -07:00
Todd Volkert
3bf91b5436
Prepare for Socket implements Stream<Uint8List> (#35646)
An upcoming change in the Dart SDK changes `Socket` from
implementing `Stream<List<int>>` to implementing `Stream<Uint8List>`.
This forwards-compatible change in flutter_tools prepares for that
Dart SDK change.

https://github.com/dart-lang/sdk/issues/36900
2019-07-05 12:59:32 -07:00
Jonah Williams
b8597f0a7e
Move usage flutter create tests into memory filesystem. (#35160) 2019-07-03 10:49:33 -07:00
Todd Volkert
4cd12fc8b7
Mark update-packages as non-experimental (#35467)
Marking it as experimental was breaking tests and packaging
scripts on stable branches.
2019-07-02 18:24:25 -07:00
Jonah Williams
556e374e02
fix default artifacts to exclude ios and android (#35303) 2019-07-02 17:40:55 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
stuartmorgan
d6bd1c0584
Add --target support for Windows and Linux (#34660)
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the desktop builds
2019-07-01 14:49:34 -07:00
Zachary Anderson
97127730f2
[flutter_tool] Fill in Fuchsia version string (#34516) 2019-06-28 12:12:53 -07:00
David Shuckerow
df6e4d4872
Make it possible to override the FLUTTER_TEST env variable (#34301)
* Make it possible to override the FLUTTER_TEST env variable without unsetting it.

* Switch to using platform instead of Platform.

* Document the bindings, and introduce tests that initialize multiple WidgetsBindings with different environments.

* Add tests for the flutter platform test.

* Add license headers

* Fix lints

* Remove trailing whitespace

* Respond to Jonahs comments

* Respond to Ians comments

* Mock out the HttpServer in flutter_platform_test

* Mock out the HttpServer in flutter_platform_test

* Explain why we mock out the HttpServer in flutter_platform_test
2019-06-28 10:37:27 -07:00
Jonah Williams
a1d3edc446
Twiggle bit to exclude dev and beta from desktop and web (#35221) 2019-06-27 19:04:02 -07:00
Jonah Williams
c9b283386b
ensure test isolate is paused before collecting coverage (#35188) 2019-06-27 13:50:47 -07:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Jonah Williams
a0b2878e76
Make tool coverage collection resilient to sentinel coverage data (#35186) 2019-06-27 11:17:58 -07:00
Jonah Williams
8532f4d08e
Allow multi-root web builds (#34896)
* fix multiroot builds

* remove shout

* add basic test

* Update web_compilation_delegate.dart

* Address review feedback

* Update multiroot_asset_reader_test.dart

* Update multiroot_asset_reader_test.dart

* remove unpassable test

* fix for windows

* facepalm
2019-06-27 06:01:41 -07:00
Todd Volkert
883d6eadcb
More HttpClientResponse implements Stream<Uint8List> fixes (#35149)
https://github.com/dart-lang/sdk/issues/36900
2019-06-26 16:56:10 -07:00
Jonah Williams
33ad5bac34
Attempt to enable tool coverage redux (#35074) 2019-06-26 16:02:49 -07:00
Dan Field
bb79ff3b49
More shards (#34877)
Shard tool_tests
2019-06-26 13:55:16 -07:00
Lau Ching Jun
c8cefce300
Move findTargetDevices to DeviceManager (#35084)
This allows us to override the behavior internally.
2019-06-26 10:09:14 -07:00
Danny Tuppeny
f3be1d9d95
Add emulatorID field to devices in daemon (#34794)
* Add emulatorId to Android and iOS emulator devices

* Update docs

* Review tweaks

* Add tests for AndroidConsole for getting avd names

* Remove unused import

* Remove duplicated header

* Fix imports
2019-06-26 16:39:23 +01:00
Alexandre Ardhuin
c7408be181
prepare for lint update of prefer_final_fields (#35059) 2019-06-25 19:39:34 +02:00
Emmanuel Garcia
2cf8213468
Break down flutter doctor validations and results (#34624) 2019-06-25 10:22:08 -07:00
Jonah Williams
25b5656969
Reland: rename web device (#34885) 2019-06-24 11:09:07 -07:00
Danny Tuppeny
8dbfc82bc7
Tweak the display name of emulators (#34785) 2019-06-24 11:41:02 +01:00
Todd Volkert
bb6c3f8131
Remove flutter_tools support for old AOT snapshotting (#34895)
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
Jonah Williams
d644015620
Revert "set web device name to Chrome (#34856)" (#34884) 2019-06-21 15:04:44 -07:00
Jonah Williams
19d7925f1f
set web device name to Chrome (#34856) 2019-06-21 14:26:25 -07:00
Jonah Williams
25a3121dfd
Prefer ephemeral devices from command line run (#34802) 2019-06-20 14:33:58 -07:00
Jenn Magder
fa491fc9fe
Close platform when tests are complete (dispose compiler and delete font files) (#34685) 2019-06-20 08:47:54 -07:00
Jonah Williams
b9932d55e7
Add linux doctor implementation (#34755) 2019-06-20 08:20:57 -07:00
Jonah Williams
830fb38640
Revert "Add basic desktop linux checks (#31873)" (#34753)
This reverts commit f221ad1f92.
2019-06-19 16:03:05 -07:00
Jonah Williams
f221ad1f92
Add basic desktop linux checks (#31873) 2019-06-19 15:51:21 -07:00
Jonah Williams
d4d10dac61
Revert "Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. (#34291)" (#34750)
This reverts commit 49449505b6.
2019-06-19 15:37:04 -07:00
Jonah Williams
0d9a1b201e
Remove environment variable guards for command line desktop and web (#33867) 2019-06-19 13:39:27 -07:00
Jonah Williams
7851a75183
Fix NPE in flutter tools (#34725) 2019-06-19 11:43:06 -07:00
Jonah Williams
0d4f4bddb6
Don't crash on invalid .packages file in initial run(#34527) 2019-06-19 10:52:23 -07:00
Jonah Williams
49449505b6
Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. (#34291) 2019-06-19 09:12:43 -07:00