Sam Rawlins
f104be7ae9
Ignore body_might_complete_normally_catch_error violations ( #105795 )
2022-06-16 23:12:06 +00:00
Alexandre Ardhuin
56c4e3cdd8
add some exports of public API in foundation/serialization.dart ( #104231 )
2022-06-08 13:33:12 -07:00
Nils Reichardt
64db621980
Remove new keyword in a few files ( #104438 )
2022-06-06 16:08:06 -07:00
Pierre-Louis
74cfc3db67
Use curly_braces_in_flow_control_structures for non-flutter packages ( #104629 )
...
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`
* fix comments
* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`
* fix indentation
2022-05-25 20:01:11 +02:00
Casey Hillers
da105b2b24
Revert "[framework] inline AbstractNode into RenderObject" ( #104257 )
2022-05-20 11:43:11 -07:00
Tong Mu
23bc3d64eb
[Mouse] Remove all pointers at the end of tests ( #102694 )
2022-05-19 17:48:10 -07:00
Jonah Williams
24bd28f696
[framework] inline AbstractNode into RenderObject ( #103832 )
2022-05-19 14:28:09 -07:00
xubaolin
b20e27e77e
Does not replace the root layer unnecessarily ( #101748 )
2022-05-05 18:44:10 -07:00
Callum Moffat
b5321d182a
Reland "Fix position of CupertinoContextMenu within Transform.scale" ( #102943 )
...
* Fix position of CupertinoContextMenu within Transform.scale (#97896 )
* Fix after rebase
2022-05-04 11:13:21 +02:00
Phil Quitslund
20f029e3bc
[devicelab, flutter_test, ...] rename local functions with _s ( #102833 )
2022-05-03 10:29:06 -07:00
Darren Austin
7965ee25dd
Revert "Fix position of CupertinoContextMenu within Transform.scale ( #97896 )" ( #102938 )
...
This reverts commit 6ddb99e98f
2022-05-02 13:40:12 -07:00
Callum Moffat
6ddb99e98f
Fix position of CupertinoContextMenu within Transform.scale ( #97896 )
2022-05-02 21:56:09 +02:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Sai Sandeep Mutyala
7b580fd5df
Enable TestDefaultBinaryMessenger to intercept all platform channels. ( #100049 )
2022-04-25 10:44:07 -07:00
Daniel Cardona Rojas
a3a9a23e46
Add matcher to find at least a given number of widgets ( #102081 ) ( #102342 )
2022-04-22 15:24:10 -07:00
chunhtai
2ebc7bee9c
Adds tooltip to semantics node ( #87684 )
2022-04-21 12:14:09 -07:00
8rine23
9313fb8e28
The sample code used within the comments in textContaining is wrong ( #100860 )
2022-04-20 14:36:14 -07:00
chunhtai
796df06c32
Add API sample code to AccessibilityGuideline ( #102161 )
2022-04-19 14:34:08 -07:00
Callum Moffat
30a501801a
Support trackpad gestures in framework ( #89944 )
...
* Implement trackpad gestures in framework
* Touch and Pan/Zoom pointers have separate IDs now
* Handle trackpad pointer device type
* Respect supportedDevices for pan/zoom events
* Update after rebase
* Fix check failures
* Avoid error with very short drags
* Address feedback
* Refactor drag event handler
* Address more feedback
* Add some missing punctuation
2022-04-12 19:47:01 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import ( #101600 )
2022-04-08 12:56:45 -07:00
Greg Spencer
efe76a5373
Update key examples to use Focus widgets instead of RawKeyboardListener ( #101537 )
...
This updates the examples for PhysicalKeyboardKey and LogicalKeyboardKey to use Focus widgets that handle the keys instead of using RawKeyboardListener, since that usually leads people down the wrong path. Updated the See Also and added tests as well. Also exposed the `physicalKey` attribute for `tester.sendKeyEvent`.
2022-04-08 12:05:41 -07:00
matasb-google
120b3deb18
Improve A11Y guidelines/tests for flutter ( #100267 )
...
* Incorrect size comparison
* Code cleanup/formatting
* Additional tests
2022-04-06 10:59:37 +02:00
Michael Goderbauer
3e406c6781
Prepare packages (minus tools,framework) for use_super_parameters ( #100510 )
2022-03-30 15:31:59 -07:00
Brian Quinlan
f6c4c3df19
Remove unnecessary ignore: override_on_non_overriding_member ( #99793 )
2022-03-16 19:10:17 -07:00
Harsh Bhikadia
fece72cac7
docs(flutter_test): fix mention of non-existing matchesSemanticsNode ( #99659 )
2022-03-16 18:55:18 -07:00
moko256
13bf7515f4
Web: treat modifier key without location ( #98460 )
2022-03-15 19:50:10 -07:00
Valentin Marquis
4f4c7816c3
Fix/text containing finder work with rich texts ( #99682 )
2022-03-13 23:35:07 -07:00
Viren Khatri
671aa9e95e
complete migration of flutter repo to Object.hash* ( #99505 )
2022-03-04 12:56:21 -08:00
Michael Goderbauer
852bfe2a73
Use BindingBase.platformDispatcher over BindingBase.window where possible ( #99443 )
2022-03-04 11:11:07 -08:00
LongCatIsLooong
81464ff642
Reland "[EditableText] honor the "brieflyShowPassword" system setting #97769 " ( #98150 )
2022-02-11 02:30:14 -08:00
Brian Quinlan
76855aa893
Add keyLog and connectionFactory to HttpClient implementations ( #98045 )
2022-02-11 00:35:16 -08:00
Callum Moffat
3f9c0e74f2
PointerDeviceKind forwards-compatibility in flutter_test ( #98202 )
2022-02-10 19:50:27 -08:00
godofredoc
3bdea6bb92
Revert "[EditableText] honor the "brieflyShowPassword" system setting ( #97769 )" ( #98089 )
...
This reverts commit 63f48d1ff8
2022-02-08 20:11:08 -08:00
LongCatIsLooong
63f48d1ff8
[EditableText] honor the "brieflyShowPassword" system setting ( #97769 )
2022-02-08 17:50:20 -08:00
Jonah Williams
4f975cbe2f
[framework] inline casts on Element.widget getter to improve web performance ( #97822 )
2022-02-08 13:05:21 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
Jami Couch
af89a25e5b
Re-land "Support Scribble Handwriting" ( #96615 ) ( #97437 )
2022-02-01 09:50:07 -08:00
Justin McCandless
40c4da5cb8
Revert "Re-land "Support Scribble Handwriting" ( #96615 ) ( #96881 )" ( #97405 )
...
This reverts commit c54ce01575
2022-01-27 16:11:02 -08:00
Jami Couch
c54ce01575
Re-land "Support Scribble Handwriting" ( #96615 ) ( #96881 )
2022-01-27 15:10:21 -08:00
Lasse R.H. Nielsen
b8fd21b04e
Adds CommonFinders.bySubtype<T extends Widget>() finder. ( #91415 )
2022-01-25 12:35:14 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers ( #96422 )
2022-01-21 14:43:59 -08:00
Alberto
ee6a693cde
chore(flutter_test): updated 'matchesGoldenFile' documentation ( #96194 )
2022-01-20 15:25:20 -08:00
LongCatIsLooong
9c23106711
Revert "Support Scribble Handwriting" ( #96615 )
2022-01-13 12:00:19 -08:00
Michael Goderbauer
40a2689b9c
enable unnecessary_late ( #96417 )
2022-01-12 21:10:19 -08:00
Michael Goderbauer
5ac9714066
Enable no_leading_underscores_for_library_prefixes ( #96420 )
2022-01-11 17:35:13 -08:00
Jami Couch
9490917408
Support Scribble Handwriting ( #75472 )
2022-01-11 11:00:12 -08:00
Andrei Diaconu
a35e7aaed9
Add display features to MediaQuery ( #92906 )
2021-12-21 10:04:19 -08:00
Jia Hao
22dd0f42ef
[flutter_test] Fix incorrect missed budget count ( #95003 )
2021-12-10 18:44:11 -08:00
Michael Goderbauer
5a862ebecd
Replace dynamic with Object? in SystemChannels ( #94629 )
2021-12-03 15:34:04 -08:00
chunhtai
049ea73c4d
MinimumTextContrastGuideline should exclude disabled component ( #94489 )
2021-12-01 20:19:02 -08:00
Nick Abalov
544527caa5
Skip links in MinimumTapTargetGuideline. ( #93869 )
2021-11-30 17:34:05 -08:00
nt4f04uNd
3a18e6ee42
Fix reassemble in LiveTestWidgetsFlutterBinding ( #92217 )
2021-11-22 02:01:00 -08:00
Ian Hickson
299d484903
Enable more lints ( #91642 )
2021-10-14 22:03:03 -07:00
Ian Hickson
9421627324
Enable only_throw_errors ( #91567 )
2021-10-11 14:13:03 -07:00
Ian Hickson
f90b019c68
Enable prefer_relative_imports and fix files. ( #91573 )
2021-10-11 10:28:07 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Ian Hickson
2bab6514b0
Enable avoid_implementing_value_types lint ( #91078 )
2021-10-04 13:48:04 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters ( #91067 )
2021-10-01 00:58:05 -07:00
Kenzie (Schmoll) Davisson
15967669b2
Add richMessage parameter to the Tooltip widget. ( #88539 )
2021-09-29 15:31:54 -07:00
Ian Hickson
2420718389
Remove our extra timeout logic. ( #89952 )
2021-09-15 09:42:05 -07:00
Sam Rawlins
bcb5db7758
Remove "unnecessary" imports from packages/ ( #89795 )
2021-09-15 01:27:02 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos ( #89485 )
2021-09-07 14:56:04 -07:00
Jim Graham
abfb889fff
Add raster cache metrics to timeline summaries ( #89393 )
2021-09-04 18:31:03 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar ( #88439 )
2021-09-03 15:09:31 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets ( #86821 )
2021-08-30 15:41:02 -07:00
嘟囔
7df68b906c
feat: widget finders add widgetWithImage method ( #89020 )
2021-08-26 22:11:02 -07:00
嘟囔
86fd222fab
feat: add Image support to finder ( #88761 )
2021-08-26 12:51:05 -07:00
Dan Field
c5861cfb56
Revert "Fix DPR in test view configuration ( #88609 )" ( #88889 )
...
This reverts commit 5feee0d8fa
2021-08-25 10:09:03 -07:00
Dan Field
5feee0d8fa
Fix DPR in test view configuration ( #88609 )
2021-08-24 14:26:54 -07:00
creativecreatorormaybenot
87b17c8ccf
Add RichText support to find.text() ( #87197 )
2021-08-23 14:47:29 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos ( #88707 )
2021-08-23 12:27:07 -07:00
nt4f04uNd
123ec80cfd
init ( #88427 )
2021-08-20 14:57:03 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS ( #88308 )
2021-08-16 21:37:03 -07:00
Tong Mu
31d0787d20
Revert "Revert "Revert "Restores surface size in the postTest of test binding ( #87240 )" ( #87258 )" ( #87297 )" ( #88293 )
...
This reverts commit 91f8b6be51
2021-08-16 09:38:25 -07:00
Tong Mu
91f8b6be51
Revert "Revert "Restores surface size in the postTest of test binding ( #87240 )" ( #87258 )" ( #87297 )
...
This reverts commit ccf6f0353a
2021-08-11 00:37:54 -07:00
Jonah Williams
5792c7347c
Use Device specific gesture configuration for scroll views ( #87604 )
2021-08-09 10:50:02 -07:00
Jonah Williams
0d3b44e835
[flutter] replace 'checked mode' with 'debug mode' ( #87408 )
2021-08-03 13:25:05 -07:00
Darren Austin
8322e178fa
Revert "Added 'exclude' parameter to 'testWidgets()'. ( #86397 )" ( #87515 )
2021-08-02 18:05:04 -07:00
chunhtai
67cee63087
Add string attribute api to text span ( #86667 )
2021-07-30 15:49:04 -07:00
Tong Mu
a7899c1961
[gen_keycodes] Remove nonexistent Web keys and improve their emulation ( #87098 )
2021-07-29 16:44:06 -07:00
Tong Mu
884158a6e3
Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #87239 )
...
* Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912 )" (#87233 )"
This reverts commit 5b80d32a84
2021-07-29 15:11:26 -07:00
Tong Mu
caf876cf40
Reland: Keyboard events ( #87174 )
2021-07-29 14:24:03 -07:00
Tong Mu
ccf6f0353a
Revert "Restores surface size in the postTest of test binding ( #87240 )" ( #87258 )
...
This reverts commit 7707f42318
2021-07-29 01:50:54 -07:00
Tong Mu
7707f42318
Restores surface size in the postTest of test binding ( #87240 )
2021-07-28 19:28:28 -07:00
Tong Mu
5b80d32a84
Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86912 )" ( #87233 )
...
This reverts commit b50991d683
2021-07-28 15:44:09 -07:00
Tong Mu
2f4f170dd2
Revert "Keyboard events ( #83752 )" ( #87171 )
...
This reverts commit 5f792ba170
2021-07-28 02:32:08 -07:00
Tong Mu
b50991d683
Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86912 )
2021-07-27 14:44:03 -07:00
Tong Mu
5f792ba170
Keyboard events ( #83752 )
2021-07-26 12:28:05 -07:00
Darren Austin
eb62bce924
Added 'exclude' parameter to 'testWidgets()'. ( #86397 )
2021-07-22 12:35:40 -07:00
Tong Mu
24ad608bd8
Revert "Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86739 )" ( #86823 )
...
This reverts commit cf3d9409b3
2021-07-21 16:13:10 -07:00
Tong Mu
cf3d9409b3
Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86739 )
...
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-21 12:49:26 -07:00
Michael Goderbauer
b0e51db8d5
Fixes for upcoming changes to avoid_classes_with_only_static_members ( #86744 )
2021-07-20 16:12:12 -07:00
Emmanuel Garcia
0504fac7e2
Android e2e screenshot ( #84472 )
2021-07-20 13:36:04 -07:00
Kate Lovett
8802e325a0
Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86449 )" ( #86730 )
...
This reverts commit cd78190b0c
2021-07-20 14:56:50 -04:00
Danny Tuppeny
91b67e8eb1
Add a "variant: " prefix to variant descriptions in test names ( #86701 )
2021-07-20 09:16:03 -07:00
Tong Mu
cd78190b0c
Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests ( #86449 )
...
This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events.
2021-07-19 14:54:24 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs ( #86438 )" ( #86484 )
...
This reverts commit d056500bfe
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs ( #86438 )
2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs ( #86388 )" ( #86404 )
...
This reverts commit 31de052e3f
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs ( #86388 )
2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs ( #83843 )" ( #86386 )
...
This reverts commit e2490f2906
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs ( #83843 )
2021-07-13 12:41:03 -07:00
Alexandre Ardhuin
80990c21e2
code formatting ( #85783 )
2021-07-07 23:06:05 -07:00
Janice Collins
52e2ca38fc
squash ( #85484 )
2021-07-01 15:06:05 -07:00
Janice Collins
cea5d552b2
Fix three additional cases ( #85497 )
2021-06-28 18:36:02 -07:00
Janice Collins
b046218413
Update flutter doc references to conform to new lookup code restrictions ( #85412 )
2021-06-28 13:11:03 -07:00
chunhtai
50a2fad986
Remove namesless todo ( #85151 )
2021-06-23 14:29:14 -07:00
nt4f04uNd
555608dad2
init ( #84365 )
2021-06-17 16:09:02 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. ( #84476 )
...
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.
Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Alexandre Ardhuin
e467018d06
alignment of doc comments and annotations ( #84256 )
2021-06-09 07:54:02 -07:00
Sam Rawlins
da9b11ec24
Remove "unnecessary" imports. ( #83959 )
2021-06-04 10:54:05 -07:00
Tong Mu
e3da1bd7aa
Test WidgetTester handling test pointers ( #83337 )
...
Adds tests to the following behaviors, which have existed without tests:
- When tapping during live testing, a message is printed with widgets that contain the tap location.
- When tapping during live testing, a mark is displayed on screen on the tap location.
2021-06-02 11:50:09 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Jonah Williams
025a3a7da3
[versions] roll package test redux ( #83367 )
2021-05-26 17:22:28 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push ( #82564 )
2021-05-21 15:09:03 -07:00
nt4f04uNd
80a2b6b015
Fix typos ( #82589 )
2021-05-20 17:19:09 -07:00
Tong Mu
01c98fa95e
Character activator ( #81807 )
2021-05-18 20:19:03 -07:00
Dan Field
304b9c668e
Reland GC tracking benchmarks ( #82069 )
2021-05-14 19:59:24 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push ( #82057 )" ( #82525 )
2021-05-14 12:09:03 -07:00
Abhishek Ghaskata
b554f893bd
Enable unnecessary_null_checks lint ( #82084 )
2021-05-14 10:44:03 -07:00
Jia Hao
08154b22ce
Revert "Init licenses for test bindings ( #81961 )" ( #82337 )
2021-05-13 21:29:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push ( #82057 )
2021-05-13 14:34:04 -07:00
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last ( #82457 )
2021-05-13 13:39:04 -07:00
Alexandre Ardhuin
c03e7488b4
remove noop primitive operations ( #82297 )
2021-05-12 00:04:02 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Jia Hao
b3f7ebe069
Init licenses for test bindings ( #81961 )
2021-05-07 17:54:02 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() ( #81859 )
2021-05-07 14:54:02 -07:00
Dan Field
3101374f60
Revert "Reland GC benchmark changes again ( #82042 )" ( #82059 )
...
This reverts commit 99a947c3e5
2021-05-07 13:19:56 -07:00
Dan Field
99a947c3e5
Reland GC benchmark changes again ( #82042 )
2021-05-07 12:29:01 -07:00
Zachary Anderson
4056ac057d
Revert "Reland GC related bench update ( #81794 )" ( #82005 )
...
This reverts commit 714dea5e03
2021-05-06 19:03:59 -07:00
Dan Field
714dea5e03
Reland GC related bench update ( #81794 )
2021-05-06 16:49:04 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push ( #81235 )" ( #81829 )
...
This reverts commit 35ad43f20c
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push ( #81235 )
2021-05-03 17:14:03 -07:00
Jonah Williams
fff8ecfb94
[flutter] reject mouse drags by default in scrollables ( #81569 )
2021-05-03 16:54:02 -07:00
Ian Hickson
ec91c6582b
Update documentation for scrollUntilVisible and friends. ( #81497 )
2021-05-01 18:29:03 -07:00
Angjie Li
cbdd9c4787
Revert "Refactor text editing test APIs (Mark III) ( #80003 )" ( #81316 )
...
This reverts commit 285b475124
2021-04-27 11:34:36 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push ( #76288 )" ( #81226 )
...
This reverts commit c26ed03c8a
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push ( #76288 )
...
* Migrate to ChannelBuffers.push
* Move TestDefaultBinaryMessenger to its own file
* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Ian Hickson
285b475124
Refactor text editing test APIs (Mark III) ( #80003 )
2021-04-21 18:29:04 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Tong Mu
eb73516739
Shortcut activator ( #78522 )
...
This PR introduced a new class, ShortcutActivator, and refactored the the definition and lookup system of shortcuts, in order to solve a few issues of the previous algorithm.
2021-04-15 01:42:49 -07:00
Justin McCandless
0efb28d706
Revert "Fix a legacy TODO ( #77454 ) ( #79061 )" ( #79959 )
...
This reverts commit b070ed3c04
2021-04-07 12:24:22 -07:00
Ian Hickson
b070ed3c04
Fix a legacy TODO ( #77454 ) ( #79061 )
2021-04-02 22:39:03 -07:00
LongCatIsLooong
c1c5b492be
Reland 79654 ( #79656 )
2021-04-02 15:44:02 -07:00
LongCatIsLooong
bf6e38db2b
Revert "enterText to move the caret to the end ( #79506 )" ( #79654 )
...
This reverts commit 67d8556baa
2021-04-02 10:57:14 -07:00
LongCatIsLooong
67d8556baa
enterText to move the caret to the end (#79506 )
2021-04-01 20:29:03 -07:00
Tong Mu
dbcac7f177
Reland Make LogicalKeyboardKey.keyLabel a getter and better #79100 ( #79302 )
2021-04-01 16:39:02 -07:00
Chris Bracken
3e7e06512c
Correct misspellings throughout the codebase ( #79500 )
2021-04-01 10:04:03 -07:00
Alexander Brusher
beb62a663d
Rolls isKeyboardKey engine change with fix ( #79407 )
...
* Adds a semantics node flag to identify sliders.
* [fuchsia] Fix roll of engine PR #25167
This changes fixes tests failing due to new isKeyboardKey semantics
flag.
* Fix typo
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-03-31 10:43:58 -07:00
Michael Bui
39499bd2bf
make showKeyboard respect finder's skipOffstage value ( #79034 )
2021-03-29 18:19:03 -07:00
Tong Mu
a603714610
Revert "Make LogicalKeyboardKey.keyLabel a getter and better ( #79100 )" ( #79217 )
2021-03-28 03:54:02 -07:00
Tong Mu
b60c855af5
Make LogicalKeyboardKey.keyLabel a getter and better ( #79100 )
2021-03-26 22:14:01 -07:00
Alexandre Ardhuin
e384ca7979
use null aware operators for function invocations ( #79049 )
2021-03-26 09:34:03 -07:00
Tong Mu
eb6e56761e
Revert "Remove keyLabel and debugName from Logical/PhysicalKeyboardKey ( #78263 )" ( #79005 )
...
This reverts commit 515ef91ba1
2021-03-24 13:31:02 -07:00
Tong Mu
515ef91ba1
Remove keyLabel and debugName from Logical/PhysicalKeyboardKey ( #78263 )
...
- Remove `LogicalKeyboardKey.keyLabel`
- Make `Physical/LogicalKeyboardKey.debugName` getters
- Make `Physical/LogicalKeyboardKey()` factory constructors, which cache non-predefined instances.
2021-03-24 04:59:57 -07:00
Shi-Hao Hong
7a88eb97ea
Typo fixes ( #78755 )
2021-03-23 09:23:43 +08:00
Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything ( #78493 )
2021-03-19 15:32:46 -07:00
Angjie Li
6515806717
Revert "Fix a legacy TODO ( #77454 )" ( #78584 )
...
This reverts commit 5e4e530e93
2021-03-19 10:08:12 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test ( #77118 ) ( #78343 )
2021-03-16 13:58:02 -07:00
Ian Hickson
5e4e530e93
Fix a legacy TODO ( #77454 )
2021-03-16 10:48:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test ( #77118 )" ( #78329 )
...
This reverts commit 0cbe597540
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test ( #77118 )
2021-03-15 16:28:02 -07:00
Michael Goderbauer
d637b1874f
non-breaking changes for prefer_mixin lint ( #77837 )
2021-03-11 19:50:03 -08:00
Kate Lovett
9840d65943
Make LocalFileComparator.compare easier to override ( #77825 )
2021-03-10 12:20:04 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint ( #77398 )
2021-03-05 18:29:04 -08:00
Chris Bracken
565e48777a
Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions) ( #77386 )
...
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of https://github.com/flutter/engine/pull/24734 .
299eb3e710...67abe7f9a9skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter/engine#24812 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter/engine#24811 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter/engine#24808 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter/engine#24806 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter/engine#24805 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter/engine#24804 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter/engine#24803 )
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter/engine#24801 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter/engine#24799 )
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter/engine#24734 )
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter/engine#24662 )
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter/engine#24794 )
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-05 10:10:32 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
Kate Lovett
6ec9014298
Expose the diff from ComparisonResult ( #77014 )
2021-03-02 10:09:03 -08:00
Ferhat
cc9b78fc5c
[web] Treeshake keymaps for web (4% code size reduction in hello world) ( #75945 )
2021-02-25 13:26:03 -08:00
Jason Simmons
6757c7dd47
Use a null default skip value in testWidgets so it can inherit the group's skip flag ( #76174 )
2021-02-17 14:31:03 -08:00
Sam Rawlins
fcad4e2efe
Remove "unnecessary" imports in flutter_test ( #76157 )
2021-02-16 16:01:05 -08:00
Todd Volkert
835c7fab45
Fix FocusManager constructor ( #75894 )
...
The FocusManager constructor was registering global event handlers
on the shared RawKeyboard instance and the global pointer router.
This posed a few problems: (1) there was no way to unregister these
handlers, and (2) instantiating a second FocusManager would overwrite
the existing focus manager's RawKeyboard handler. This was manifesting
in unexpected ways, such as the fact that constructing a second
BuildOwner (for a parallel tree, for instance) was obliterating the
event handler for the main BuildOwner's focus manager, thus messing
with focus.
This change separates those global event registrations into a
dedicated method, registerGlobalHandlers(), and overrides dispose()
to properly unregister those handlers.
2021-02-12 17:19:20 -08:00
Ian Hickson
824042f9b2
Catch cases in tests where people try to tap on widgets that aren't reachable. ( #74798 )
2021-02-03 16:11:02 -08:00
Anas35
091a74dab6
removed new keyword ( #75049 )
2021-02-01 09:59:53 -08:00
Yegor
791edc230d
always pass filterQuality specified in the Image widget to canvas ( #74854 )
2021-01-28 21:54:03 -08:00
Ian Hickson
37a0189773
Don't leak exceptions thrown by message channels ( #74446 )
2021-01-27 11:19:04 -08:00
Jia Hao
8a5ace25a5
Improve performance of Widget Tests ( #70730 )
2021-01-12 17:29:03 -08:00
Greg Spencer
2d836a99b6
Remove some unnecessary casts, now that changes have rolled from the engine ( #70491 )
2020-11-13 16:28:06 -08:00
Michael Goderbauer
cca1215939
Properly initialize RestorationManager in the TestBinding ( #70398 )
2020-11-12 13:59:05 -08:00
Greg Spencer
86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead ( #70319 )
...
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.
Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Greg Spencer
0937207f5b
Fix Platform channel errors in web tests ( #70252 )
2020-11-12 10:24:07 -08:00
Greg Spencer
bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow ( #69617 )
...
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate
* remove new test platform dispatchers
* Amend documentation
2020-11-09 15:26:29 -08:00
Greg Spencer
88809aa247
Standardize dartdoc macro names ( #69445 )
2020-11-02 13:28:05 -08:00
Alexander Brusher
099ae9b417
Re-enables tests previously failing due to new semantics flag. ( #66916 )
2020-10-22 15:32:03 -07:00
puelo
24d3999783
Generate RawKeyEvents for iOS 13.4+ ( #65193 )
...
* Added RawKeyEvent support for iOS
* Removed unused remnant
* added some missing keys
* Removed trailing whitespaces
* commit for build
* Added mapping names
* Made iOS keycodes generatable and collectable
* Fixed naming and formatting issues
* fixed raw_keyboard_test
2020-10-22 13:33:51 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test ( #68642 )
2020-10-21 10:09:11 -07:00
Greg Spencer
8c03ff8c1d
Mark keys that match a shortcut, but have no action defined as "not handled". ( #67359 )
...
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.
This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.
This PR includes:
- Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
- Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
- Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
- Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
2020-10-19 11:26:50 -07:00
Xavier Chrétien
f26fbb6bdd
Set slider semantics flag for sliders ( #68019 )
2020-10-19 08:12:03 -07:00
Dan Field
12f54e17f4
reland List queue search optimization ( #68214 )
...
* Revert "Revert "Improve performance of collectAllElements (#68065 )" (#68207 )"
This reverts commit 46ff57d6f1
2020-10-15 13:46:50 -07:00
Jonah Williams
46ff57d6f1
Revert "Improve performance of collectAllElements ( #68065 )" ( #68207 )
...
This reverts commit 8ba5732c4c
2020-10-15 08:04:59 -07:00
Dan Field
8ba5732c4c
Improve performance of collectAllElements ( #68065 )
2020-10-14 21:32:04 -07:00
Jonah Williams
bdfb07dffd
[flutter_test] export fake from flutter_test ( #68032 )
...
Fake has been moved from mockito to test to facilitate NNBD, re-export this from flutter_test
2020-10-13 11:38:00 -07:00
Alexandre Ardhuin
4acc790252
enable lint cast_nullable_to_non_nullable ( #67629 )
2020-10-08 21:05:43 +02:00
Alexandre Ardhuin
0d8d4f77aa
unnecessary null comparison ( #67525 )
2020-10-08 09:26:30 +02:00
Alexandre Ardhuin
f551178408
migrate material to nullsafety ( #67166 )
...
* migrate material to nullsafety
* address review comments
* address review comments
* fix build
2020-10-06 11:36:50 +02:00
Michael Goderbauer
8998167d0f
Make FlutterErrorDetails.exception non-nullable as documented ( #67364 )
2020-10-05 18:07:02 -07:00
Ming Lyu (CareF)
277a72e3fe
move resampler to handlePointerEvent and fix complex_layout_android__scroll_smoothness with PointerEvent ( #66745 )
2020-10-05 17:17:03 -07:00
Tong Mu
2cdf2f0059
Treat hover events as normal pointer events, and bring them back to Listener ( #63834 )
2020-10-05 12:12:04 -07:00
Dan Field
2cdec25877
Reland dispose images when done ( #67100 ) ( #67177 )
...
* Reland dispose images when done (#67100 )
Changes since last time:
- Test for CanvasKit image rendering
(https://github.com/flutter/flutter/pull/67176 )
- Fix CanvasKit dispose impl
(https://github.com/flutter/engine/pull/21555 )
- Update internal google3 customer with a problematic ImageStream
Listener impl (cl/335091311, cl/335459002)
This reverts commit 473358d93d
2020-10-05 12:03:27 -07:00
Dan Field
473358d93d
Revert dispose images when done ( #67100 )
...
* Revert "docs for image disposal (#67066 )"
This reverts commit bcb2ac5a55#66688 )"
This reverts commit a7954691da
2020-10-01 16:53:50 -07:00
Kate Lovett
d1178ae73b
Fix local gold output for flutter/flutter ( #66139 )
2020-10-01 11:17:03 -07:00
Dan Field
a7954691da
Dispose of images after using them ( #66688 )
...
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Michael Goderbauer
19e07d2beb
Migrate flutter_test ( #66663 )
2020-09-30 17:03:40 -07:00
Mehmet Fidanboylu
95d72bf9d8
Clarify the docs on what scrollUntilVisible does ( #65817 )
2020-09-30 14:58:13 -07:00
Ming Lyu (CareF)
3c321ac80f
cleanup ( #66743 )
2020-09-29 15:32:03 -07:00
Alexandre Ardhuin
c2e43403af
apply upcoming lint cast_nullable_to_non_nullable ( #66455 )
...
* apply upcoming lint cast_nullable_to_non_nullable
* make RenderObjectElement.renderObject non-nullable
2020-09-27 21:29:42 +02:00
Dan Field
7eb8447485
Allow new methods to be added to ui.Image for tests ( #65876 )
...
Remove fake image implementations, add createTestImage to flutter_test
2020-09-22 11:55:39 -07:00
Mouad Debbar
5024e1ea02
[web] Inform the engine when read-only flag is flipped ( #65499 )
2020-09-17 15:52:04 -07:00
Christian Mürtz
1415078828
Find text containing in tests ( #65072 )
2020-09-16 16:32:03 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Tong Mu
a48e14308e
Expose GestureBinding.handlePointerEvent, replacing dispatchEvent as the preferred way to dispatch events ( #64846 )
2020-09-15 22:17:06 -07:00
Greg Spencer
199a7c1964
Fix the character field of the RawKeyEvent to hold correct data on non-Android platforms. ( #65667 )
...
This fixes a problem where the character field of the RawKeyEvent was not being set at all for non-Android platforms.
I also updated the key maps, and corrected a problem with the Windows key map where the backquote character wasn't correctly mapped.
2020-09-15 13:02:16 -07:00
Yuqian Li
e1eddb401d
Revert the revert ( #65602 )
2020-09-11 16:20:03 -07:00
Ming Lyu (CareF)
28de49e358
Revert "Reland #61998 and update complex_layout ios files ( #64885 )" ( #64990 )
...
This reverts commit df83398687
2020-08-31 18:47:08 -07:00
Ming Lyu (CareF)
df83398687
Reland #61998 and update complex_layout ios files ( #64885 )
2020-08-31 17:23:06 -07:00
Shi-Hao Hong
34541c3073
Revert "A benchmark test case for measuring scroll smoothness ( #61998 )" ( #64883 )
...
This reverts commit 12b7355da1
2020-08-30 18:42:10 +08:00
Ming Lyu (CareF)
12b7355da1
A benchmark test case for measuring scroll smoothness ( #61998 )
2020-08-29 04:28:03 -07:00
Ian Hickson
8a6a76a334
migrate rendering to nullsafety ( #64621 )
2020-08-27 16:38:10 -07:00
Jonah Williams
41e553bbfc
[flutter_tools] migrate flutter_goldens, flutter_goldens client to null-safety ( #64201 )
2020-08-24 15:31:05 -07:00
Greg Spencer
041a3eaa84
Standardize the nullability of arguments to raw key data constructors. ( #63523 )
...
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty.
Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable.
Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
2020-08-19 15:03:17 -07:00
Greg Spencer
d1eff0b413
Hook up soft keyboard "next" and "previous" buttons so that they move the focus by default ( #63592 )
...
Focus will be moved automatically if onEditingComplete is not specified, but must
by moved manually if onEditingComplete is specified.
2020-08-18 16:46:58 -07:00
Ming Lyu (CareF)
2c716c4d49
add vsync overhead to FrameTimingSummarizer ( #63835 )
2020-08-17 16:51:04 -07:00
Ming Lyu (CareF)
04759e8559
doc typo spelling fix ( #63817 )
2020-08-17 12:21:08 -07:00
Jonah Williams
08254b2156
Revert "Remove TODOs added for HTTP abort() change in dart sdk ( #63924 )" ( #63972 )
...
This reverts commit b1c17313f6
2020-08-17 10:25:01 -07:00
zichangg
b1c17313f6
Remove TODOs added for HTTP abort() change in dart sdk ( #63924 )
2020-08-17 09:46:08 -07:00
Ming Lyu (CareF)
c2368bdd6f
bug fix for pointer id in test gestures ( #63816 )
2020-08-15 10:41:02 -07:00
Konstantin Scheglov
236507f058
Provide the argument for a required parameter 'data'. ( #63728 )
2020-08-14 16:46:03 -07:00
Michael Goderbauer
39a46bedad
Remove decommission from RestorationBuckets ( #63687 )
2020-08-13 15:01:04 -07:00
Nils Reichardt
337c5cfc52
Update finders.dart ( #63600 )
2020-08-13 11:30:34 -07:00
Ming Lyu (CareF)
0629030a05
WidgetTester.drag with time duration ( #63410 )
2020-08-12 21:01:03 -07:00
Jonah Williams
04bc6123a9
[null-safety] update to several framework test cases/APIs for null assertions ( #62946 )
2020-08-12 13:41:09 -07:00
LongCatIsLooong
cea055ef00
Make Scrollable's free scroll initial velocity matches that of iOS ( #60501 )
2020-08-12 13:31:05 -07:00
Ming Lyu (CareF)
b09dee59bf
add FrameTimingSummarizer ( #63434 )
2020-08-11 06:21:04 -07:00
Ming Lyu (CareF)
2965d81ae9
update for WidgetTester.move and WidgetTester.fling doc ( #63390 )
2020-08-10 21:21:03 -07:00
Panmari
9542a47e44
Fixing code snippet example for meetsGuideline. ( #63273 )
2020-08-10 21:11:04 -07:00
Ian Hickson
522d19e2ad
Unskip the bidi semantics test. ( #62823 )
2020-08-05 19:21:11 -07:00
Ming Lyu (CareF)
8081455394
revert widgettester breaking change ( #62914 )
2020-08-04 17:26:05 -07:00
Jonah Williams
428be90768
[null-safety] revert export of Fake from test_api ( #62894 )
2020-08-04 14:31:05 -07:00
Ming Lyu (CareF)
a36b0ba4f6
promote WidgetTester pumpAndSettle ( #62640 )
2020-08-04 08:31:08 -07:00
Ming Lyu (CareF)
e03980ec47
separate scroll until visible implementation for lower level accessibility ( #62462 )
2020-08-04 08:31:04 -07:00
Jonah Williams
32144161ae
[null-safety] remove some usages of mockito ( #62809 )
2020-08-04 08:26:12 -07:00
Michael Goderbauer
e5ca020d66
Make dartdoc warnings fatal for flutter_test ( #62614 )
2020-08-03 10:46:04 -07:00
Ming Lyu (CareF)
87dbfa8330
Update framePolicy docs ( #61773 )
2020-07-30 12:11:03 -07:00
Michael Goderbauer
395510134c
Random unresolved doc reference fixes I missed before ( #62582 )
2020-07-30 12:01:04 -07:00
Ming Lyu (CareF)
d053a4d00a
Move key event and semantics related method from WidgetTester to WidgetController ( #62362 )
2020-07-29 08:11:06 -07:00
Ming Lyu (CareF)
e9e36f3909
WidgetController.pump use optional duration ( #62091 )
2020-07-29 08:01:04 -07:00
Michael Goderbauer
f4e10b4fb5
Make dartdoc warnings fatal (& cleanup of warnings) ( #62367 )
2020-07-28 16:11:04 -07:00
Ming Lyu (CareF)
6d07b1b475
Add WidgetController.scrollUntilVisible ( #62097 )
2020-07-28 10:46:07 -07:00
Michael Goderbauer
175e5c9aca
Restoration Framework ( #60375 )
...
* state restoration
* added example
* typos and analyzer
* whitespace
* more typos
* remove unnecessary import
* whitespace
* fix sample code
* tests for restorationmanager and restorationid
* ++
* typo
* tests for bucket, part1
* rename tests
* more tests
* finished tests for service layer
* remove wrong todo
* ++
* review comments
* tests for Unmanaged and regular scope
* RootRestorationScope tests
* typo
* whitespace
* testing framework
* tests for properties
* last set of tests
* analyzer
* typo
* dan review
* whitespace
* ++
* refactor finalizers
* ++
* ++
* dispose guard
* ++
* ++
* dan review
* add manager assert
* ++
* analyzer
* greg review
* fix typo
* Ian & John review
* ian review
* RestorationID -> String
* revert comment
* Make primitives non-nullable in prep for NNBD
2020-07-28 10:16:36 -07:00
Ming Lyu (CareF)
056e455e94
Add a E2E based performance test case ( #61509 )
2020-07-23 08:31:04 -07:00
Ming Lyu (CareF)
9e2e0ef3b4
implement handlePointerEventRecord for LiveWidgetController ( #61266 )
2020-07-22 18:31:08 -07:00
Ming Lyu (CareF)
3e7fe378e3
Reland "LiveTestWidgetsFlutterBinding support for non-touch event" ( #61901 )
2020-07-21 02:36:03 -07:00
Ming Lyu (CareF)
f98a00c750
Revert "LiveTestWidgetsFlutterBinding support for non-touch event ( #61872 )" ( #61900 )
...
This reverts commit aa4b4d35e1
2020-07-20 17:20:30 -04:00
Ming Lyu (CareF)
aa4b4d35e1
LiveTestWidgetsFlutterBinding support for non-touch event ( #61872 )
2020-07-20 17:02:59 -04:00
Ming Lyu (CareF)
54c9441723
benchmarkLive: a new LiveTestWidgetsFlutterBindingFramePolicy for benchmark on device ( #61388 )
...
* add benchmarkLive flag and tests
* update handlePointerEventRecord doc
* using e2e 0.6.1
2020-07-17 18:56:12 -04:00
Ming Lyu (CareF)
c9cf9c9940
Promote WidgetTester.ensureVisible to WidgetController ( #61540 )
...
* Promtoe WidgetTester.ensureVisible
* modify according to tvolkert@
2020-07-15 14:54:49 -04:00
zichangg
3631adc99a
Fixing patch for coming breaking change in HttpClientRequest ( #61138 )
...
* Fixing patch for coming breaking change in HttpClientRequest
* Add noSuchMethod() and comment out abort()
* Add ignore: override_on_non_overriding_member
2020-07-15 10:07:57 -07:00
Jason Simmons
af47958eff
Update the golden image comparator to handle read-only image ByteData views ( #61406 )
2020-07-14 01:41:02 -07:00
Ming Lyu (CareF)
a76b5eb79f
Add support in WidgetTester for an array of inputs ( #60796 )
...
* Add input event array support
* Add a tap test
* remove unused import
* remove extra assert
2020-07-10 17:03:12 -04:00
Ming Lyu (CareF)
a5fa083906
Add comment explain dispatchEvent override ( #60734 )
2020-07-08 18:37:33 -04:00
Ming Lyu (CareF)
78bb587c70
respect line wrapping style guide ( #61118 )
2020-07-08 16:44:59 -04:00
Ming Lyu (CareF)
61477b5949
Fix PointerAddedEvent handling in LiveTestWidgetsFlutterBinding ( #61102 )
...
* Fix PointerAddedEvent handling in tester
2020-07-08 13:28:51 -04:00
Dan Field
fb57edcc80
Revert "Revert "Fix remaining holes in stack trace demangling ( #60478 )" ( #60916 )" ( #60996 )
...
This reverts commit 2c7e5dd935
2020-07-07 15:30:32 -07:00
Mehmet Fidanboylu
8c67781f36
Comments around hanging tests via runAsync. ( #60136 )
2020-07-07 09:14:02 -07:00
Dan Field
2c7e5dd935
Revert "Fix remaining holes in stack trace demangling ( #60478 )" ( #60916 )
...
This reverts commit d986fdc31a
2020-07-06 10:07:36 -07:00
Andre
d986fdc31a
Fix remaining holes in stack trace demangling ( #60478 )
...
* Implement stack trace demangling in the framework.
2020-07-06 08:11:03 -07:00
Pierre-Louis
0bc4368233
Typo sweep ( #60693 )
2020-07-02 13:08:02 -07:00
Michael Goderbauer
769468298b
Do not return partial semantics from tester.getSemantics ( #60367 )
2020-06-26 11:03:02 -07:00
David Worsham
db48cadd0d
Remove unused physicalDepth code ( #60152 )
2020-06-24 11:33:01 -07:00
Dan Field
868c4d8ce0
Fix issue with stack traces getting mangled ( #59900 )
2020-06-23 15:29:57 -07:00
Tong Mu
65b1956005
Add benchmark for Mouse region (web) ( #59803 )
2020-06-19 13:48:04 -07:00
Dan Field
68b131f313
[e2e] make test bindings friendlier to integration tests ( #58210 )
2020-05-29 11:50:12 -07:00
Dan Field
02b1080101
Functionality to check handlers set on platform channels ( #57696 )
2020-05-21 14:52:05 -07:00
cg021
1cfd792a38
remove pending timers list code out of assert message ( #57287 )
...
* move pending timers list code out of assert
* style change
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
* add unit tests
* formatting
* pending timer test
* pending timer assertion test
* add setup and teardown
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
2020-05-18 18:18:16 -05:00
Tong Mu
fb94d3fb78
Animation sheet recorder ( #55527 )
2020-05-14 14:32:03 -07:00
Tong Mu
7f8cb7f830
System mouse cursors ( #54171 )
...
Adds the basic framework for the mouse cursor system.
* Adds MouseRegion.cursor
* Adds SystemMouseCursors
* Adds mouseCursor to some widgets
2020-05-11 13:34:20 -07:00
Matt Mohandiss
1e150c5d95
Update finders.dart ( #55936 )
...
Fixed #55858
2020-04-29 14:33:47 -07:00
Katarina Sheremet
3b067049ad
Support tags in testWidgets ( #55141 )
2020-04-28 15:49:01 -07:00
chunhtai
d482163f59
Revert "Fix FlutterError.onError in debug mode ( #53843 )" ( #55484 )
...
This reverts commit d35671c6d1
2020-04-23 11:57:18 -07:00
chunhtai
d35671c6d1
Fix FlutterError.onError in debug mode ( #53843 )
...
* Fix FlutterError.onError in debug mode
* update
* fix comments
* add license header
* fix analyzer
* update
* another attempt
* fix test
* fix comment
2020-04-22 17:17:42 -07:00
Jacob MacDonald
6399be62d2
remove flutter_test quiver dep, use fake_async and clock instead ( #54125 )
...
## Description
Removes the `flutter_test` dependency on `quiver`, instead using the more targeted `clock` and `fake_async` packages.
## Related Issues
https://github.com/flutter/flutter/issues/53908
## Tests
No changes to tests
## Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I signed the [CLA].
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.
- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
- [x] I am willing to follow-up on review comments in a timely manner.
## Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].
- [ ] No, no existing tests failed, so this is *not* a breaking change.
- [x] Yes, this is a breaking change. *If not, delete the remainder of this section.*
- [x] I wrote a design doc: https://docs.google.com/document/d/1EkkLbECNBwHgddBQAZqEy7iQLTIxR1rgChKzxcLwhio/edit
- [x] I got input from the developer relations team, specifically from: @RedBrogdon
- [x] I wrote a migration guide: https://github.com/flutter/website/pull/3932
<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
2020-04-15 12:10:26 -07:00
Greg Spencer
c7b10df765
Fix initial value for highlight mode on desktop platforms. ( #54306 )
...
This fixes the initial value of FocusManager.highlightMode so that it gets initialized correctly on desktop platforms.
My recent update of this code (#52990 ) broke things so that the highlight mode never changed from the initial default of touch, which meant that focus highlights didn't show unless you set FocusManager.highlightStrategy to something (even automatic, the default: setting it caused the mode to be updated).
2020-04-10 13:23:55 -07:00
Jacob MacDonald
efdce3cf72
drop image package dependency for goldens ( #54144 )
2020-04-09 11:21:23 -07:00
Francisco Magdaleno
a0f7f6ca6d
[windows] Adds support for keyboard mapping. ( #54227 )
2020-04-08 10:07:02 -07:00
Michael Goderbauer
d47ad7ec0d
Reverse dependency between services and scheduler ( #54212 )
2020-04-08 09:12:03 -07:00
cjng96
d62c7ecce5
Ignore key events on edit control on web platform ( #52656 ) ( #52661 )
2020-04-01 00:31:03 -07:00
adityapstar
a57feac62e
fixed typo in HttpClient failure message ( #53211 )
2020-03-25 15:26:01 -07:00
Yegor
5ea13b8493
fix KeySet.hashCode; enable multiple web tests ( #52861 )
...
fix KeySet.hashCode; enable multiple web tests
2020-03-20 08:49:19 -07:00
Chris Yang
b05210c707
Move ios screenshot test to flutter gold. ( #52553 )
2020-03-19 16:27:41 -07:00
Greg Spencer
c5dd3ec47a
Fix stuck keys when shift is released before the letter. ( #51095 )
...
This fixes a problem where if you press "Shift" and then "A", then release "Shift" and then "a", then the "A" key will be "stuck" on because the logical key for the key down message is different (capital "A") from the logical key for the key up message (lowercase "a").
This PR changes the pressed keys logic so that it uses the physical key to add/remove keys from the list of pressed keys, but keeps the associated logical key.
This does mean that after the "Shift" key goes up, the pressed keys contains a capital "A" and it doesn't switch to be a lowercase "a", but there isn't currently any mechanism we can use to do that remapping. This is far less surprising than the current behavior, but is still not quite correct.
I fixed the event simulation code to take a physicalKey so that it could be matched with the logical key, but the event simulation code isn't up to the task, since it can only simulate keys that appear in the key maps. The new platform key event design should fix that (added TODOs).
2020-02-21 14:13:38 -08:00
Albertus Angga Raharja
aad941e3fa
Avoid using FlutterError.fromParts when possible ( #43696 )
...
This PR is a follow up of https://github.com/flutter/flutter/pull/42640
Some changes of that PR includes redundant changes using FlutterError.fromParts constructor even though it's not necessary.
Some minor changes are:
- Remove one unnecessary todo
- Fix indent consistencies
2020-02-20 07:51:53 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes ( #50368 )
2020-02-11 20:58:27 +01:00
Emmanuel Garcia
8c398a8ddd
Reland: Skia gold driver test ( #50160 )
2020-02-06 17:14:50 -08:00
