Commit Graph

4199 Commits

Author SHA1 Message Date
Jenn Magder
c93847d187
Remove IOSDeploy from globals, hoist to XCDevice constructor (#53203) 2020-03-24 16:50:35 -07:00
Jenn Magder
778c2ce923
Convert some code_signing_tests to testWithoutContext (#53142) 2020-03-24 15:30:35 -07:00
Jenn Magder
151c8db7dc
Remove dead vmservice.RPCError catch (#53193) 2020-03-24 13:35:29 -07:00
Jonah Williams
8e492fa845
[flutter_tools] fix type error with AppDomain current directory (#53181) 2020-03-24 12:58:40 -07:00
Jonah Williams
b5cd3ce854
[flutter_tools] test and catch more exception types in web runner (#53183) 2020-03-24 12:58:30 -07:00
Devon Carew
d6614dbafd
save and restore the chrome session local storage information (#53030)
save and restore the chrome session local storage information
2020-03-24 12:20:13 -07:00
Jenn Magder
c9323bdccd
Convert cocoapods_validator_test to testWithoutContext (#53177) 2020-03-24 11:34:57 -07:00
Jenn Magder
70c651b0a4
Move BuildSystem to globals (#53139) 2020-03-24 11:23:10 -07:00
Jenn Magder
0b321e6715
Remove IMobileDevice from globals, hoist to XCDevice constructor (#53144)
* Convert ios_device_logger_test.dart to testWithoutContext

* Remove IMobileDevice from globals, hoist to XCDevice constructor
2020-03-24 11:22:54 -07:00
Lasse R.H. Nielsen
af5194dbfd
Prepare Flutter for SDK changes to runZoned. (#52953)
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.

This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jonah Williams
10571920c0
[flutter_tools] update to latest dwds API (#52936)
Should fix issues introduced in web-server device and allow loading org-dartlang-app URIs
2020-03-23 18:47:50 -07:00
stuartmorgan
685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
Jonah Williams
b1664a27d9
ensure default value for report timings (#52978) 2020-03-20 14:30:33 -07:00
Jonah Williams
441665e21a
[flutter_tools] split logger test and create log reader testing interface (#52934) 2020-03-20 13:46:39 -07:00
Jonah Williams
590f22ce82
[flutter_tools] restore report timings functionality to build aot (#52918) 2020-03-20 13:46:19 -07:00
Christopher Fujino
7d1fbcae1a
Refactor exits happy (#52916) 2020-03-20 13:05:19 -07:00
Jonah Williams
a13c9cfc48
[flutter_tools] fix toFilePath called on null (#52931)
In certain circumstances, the .packages file or dart cache could be missing - since the tool runs from a snapshot this is otherwise fine.
2020-03-19 22:20:15 -07:00
Jonah Williams
62c9c89d6b
[flutter_tools] split start app android tests into new file (#52906) 2020-03-19 16:53:19 -07:00
Kirill Pertsev
bae2f2c108
Enables log reader on iOS Simulator to (rudimentary) process multiline messages (#52452) 2020-03-19 15:41:39 -07:00
Jason Simmons
bbc9d4f3a6
Do not check the executable status of gen_snapshot if it has not yet been downloaded (#52574) 2020-03-19 15:01:02 -07:00
Jonah Williams
b21e780aee
[flutter_tools] refactor AotBuilder, removing globals and duplicated kernel compilation (#52896)
Reland of #52091
2020-03-19 14:52:42 -07:00
Jonah Williams
9391e480b2
Revert "[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)" (#52893)
This reverts commit f65421aaca.
2020-03-19 10:16:20 -07:00
Jenn Magder
a61bff2fcf
Show Xcode workspace clean output with verbose flag (#52860) 2020-03-19 09:51:01 -07:00
Jonah Williams
f65421aaca
[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)
Remove dependency injection from GenSnapshot and AotBuilder and update tests to use FakeProcessManager
2020-03-19 09:36:38 -07:00
Jonah Williams
fe310148a1
[flutter_tool] Remove extra usage of .packages in vm service API (#52845) 2020-03-19 09:35:57 -07:00
Dan Field
53dc8db0e8
Do not throw when trying to discover a fuchsia device and the sshConfig is invalid (#52858)
* Do not throw when trying to discover a fuchsia device and the sshConfig is invalid
2020-03-19 09:28:54 -07:00
Jonah Williams
73b6702dee
[flutter_tools] refactor iOS tests for Device.startApp into new file (#52854) 2020-03-18 17:43:25 -07:00
Jenn Magder
ee845255de
Move XcodeProjectInterpreter to globals (#52847) 2020-03-18 15:55:09 -07:00
Jenn Magder
e0ab6fc00c
Move outputPreferences to globals (#52846) 2020-03-18 15:54:26 -07:00
Jonah Williams
0274f170fb
[flutter_tools] have the tool print the current canvaskit mode when toggling (#52841) 2020-03-18 15:51:23 -07:00
Yegor
7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Christopher Fujino
2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson
e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Jonah Williams
542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams
46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams
90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams
6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke
6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams
f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Jenn Magder
757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino
071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonah Williams
a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Jenn Magder
93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder
2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams
028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Michael Thomsen
e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Jenn Magder
73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Jenn Magder
8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field
98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams
bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Jonah Williams
3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
Jonah Williams
9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams
3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams
b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Jonah Williams
1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino
14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams
1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson
0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Jonah Williams
d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Finn
9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino
38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy
1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson
04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams
edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams
6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia
4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams
ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson
53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson
78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson
7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams
5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson
605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Zachary Anderson
733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams
fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams
2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams
377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder
fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams
60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams
3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams
88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams
bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
Angjie Li
665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Dan Field
e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field
db1f33fd70
Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams
c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino
2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Jonah Williams
e7d70fbf75
Revert "Fix version command for certain git workflows (#52062)" (#52128)
This reverts commit 20bf43b9eb.
2020-03-06 12:58:00 -08:00
Jenn Magder
a14ac4e3c8
Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson
6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021)
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Dan Field
20bf43b9eb
Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field
4d05ed5deb
Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Jonah Williams
d2f889b4f0
[flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams
bafa03e5b5
[flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams
8872d1d8c4
[flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Jenn Magder
b8472f25ab
Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams
ad16823e4c
[flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams
c411f588c6
Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045)
This reverts commit aed961993d.
2020-03-05 13:02:22 -08:00
Jonah Williams
ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams
aed961993d
[flutter_tools] supports tree-shake-icons for web builds (#51808)
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
2020-03-05 12:35:04 -08:00
Jonah Williams
1bf6f0232e
[flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams
bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Jonah Williams
374f85c976
[flutter_tools] pin exact build_runner version (#52033) 2020-03-05 11:09:41 -08:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Jenn Magder
db94472aeb
Skip iOS project migration when script is already embedding frameworks (#51963) 2020-03-04 16:12:13 -08:00
Jenn Magder
dc33334675
Update iOS project migration help URL (#51973) 2020-03-04 16:12:02 -08:00
Jenn Magder
cbbb7ec5a7
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774)" (#51960)
This reverts commit 57c6721cd5.
2020-03-04 12:40:15 -08:00
Flutter GitHub Bot
57c6721cd5
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774) 2020-03-04 11:41:02 -08:00
Ben Konyi
3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00
Zachary Anderson
a5bd678585
Revert "Write FLUTTER_BUILD_MODE when using a local engine (#51687)" (#51943)
This reverts commit 9b4b7d7ee0.
2020-03-04 08:56:53 -08:00
Dan Field
9b4b7d7ee0
Write FLUTTER_BUILD_MODE when using a local engine (#51687) 2020-03-04 07:36:55 -08:00
Christopher Fujino
2c846af1a0
Fix _checkPodCondition not handling CocoaPodsStatus.brokenInstall (#51676) 2020-03-03 17:55:02 -08:00
Konstantin Scheglov
fb953b719f
Cast to List<dynamic> and cast(). (#51591) 2020-03-03 14:49:02 -08:00
stuartmorgan
f9c118b6b2
Exit for missing Windows plugin projects (#51838)
Exit, rather than crash, if a Windows plugin is missing its project.

Fixes #51743
2020-03-03 22:43:42 +01:00
stuartmorgan
8d8439f8e3
Add pre-stable support for create on Linux (#51832)
Adds initial support for `flutter create` of apps and plugins. This is derived from the current FDE example app and sample plugin, with a few changes:
- Added template values where it makes sense.
- Moved some likely-to-change values into separate files for now, to simplify the delete/recreate cycle that will be necessary until it's stable.
- Added some minor Makefile flag handling improvements

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the `create` output about the fact that it won't be stable.
2020-03-03 22:42:52 +01:00
Jenn Magder
e491544588
Move embedding and linking Flutter frameworks into the tool (#51453)
* Move embedding and linking Flutter frameworks into the tool

* Unused import

* Migrate

* Rename run, add comments, remove typedef

* Add status log to tell the user what we did

* Remove Podfile migration, create IOSMigration superclass

* word-smiting

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* for space

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-03-03 12:11:28 -08:00
Shi-Hao Hong
d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer
1ba4f1f509
Add Linux and Windows target platforms (#51519)
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
2020-03-03 04:38:04 -08:00
zsunkun
fdbd1b14ff
fix pom file not found when run app with local engine (#51468) 2020-03-02 19:09:01 -08:00
Jonah Williams
3489da9328
[flutter_tools] no more MockLogger in tests (#51684) 2020-03-02 16:23:56 -08:00
Zachary Anderson
914bd76979
[flutter_tools] Handle errors on the std{out,err}.done future (#51660) 2020-02-28 22:31:01 -08:00
Jonah Williams
9b4159c5ee
[flutter_tools] support run -d chrome test scripts (#51658) 2020-02-28 14:21:02 -08:00
Jonah Williams
515027a91c
[flutter_tools] allow configuring libraries spec path for the web compilation (#51590) 2020-02-28 11:26:02 -08:00
Jonah Williams
42ae15f44e
[flutter_tools] remove LinuxWorkflow from injection and clean up tests (#51597) 2020-02-28 10:27:27 -08:00
Zachary Anderson
b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567)" (#51616)
This reverts commit 9de7787f25.
2020-02-27 22:57:13 -08:00
stuartmorgan
33bb1faf5b
Reland: Always use new plugin schema for plugin template (#49832)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-02-27 22:48:25 -08:00
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567) 2020-02-27 22:46:23 -08:00
Jonah Williams
e00d424de5
[flutter_tools] clean-ups to linux doctor test (#51593) 2020-02-27 15:15:35 -08:00
Jenn Magder
4fb9ce8414
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh (#51532) 2020-02-27 12:18:06 -08:00
Jonah Williams
080dfb5eb3
[flutter_tools] swap mustache dependency for mustache_template (#51578) 2020-02-27 11:23:41 -08:00
stuartmorgan
dd2756c36a
Generate a makefile for Linux plugins (#51520)
When generating the plugin registrant for Linux, also generate a
makefile that can be included in the app-level Makefile to manage all of
the plugin targets and flags, exporting them in a few known variables
for use in the outer makefile.

Part of #32720
2020-02-27 09:45:22 -08:00
Jonah Williams
3b5668c996
[flutter_tools] hide usage of package:mustache behind interface (#51500) 2020-02-27 09:17:42 -08:00
Jonah Williams
08d079f6c2
[flutter_tools] wire up complete support for Dart obfuscation (#50509) 2020-02-27 08:58:33 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception (#51440)" (#51539)
This reverts commit f1cd47ef5c.
2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception (#51440) 2020-02-26 21:45:02 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests (#51444) 2020-02-26 18:31:42 -08:00
Jenn Magder
e31521eab5
Validate empty pubspec plugin section (#51503) 2020-02-26 15:44:35 -08:00
Lynn
2243c42ebc
Fix flutter doctor (pluginsPath) check for Mac (#50324) 2020-02-26 13:41:03 -08:00
Jonah Williams
65a7941228
[flutter_tools] reduce globals in web validator and chrome launcher (#51443) 2020-02-26 10:37:52 -08:00
Jonah Williams
55072246d0
[flutter_tools] remove build script from tool package (#50690) 2020-02-26 08:25:04 -08:00
Jonah Williams
53457c2241
[flutter_tools] Reland initialize frontend_sever with build (#51477) 2020-02-26 08:06:03 -08:00
Jonah Williams
421056ee54
Revert "[flutter_tools] initialize frontend server with build (#49405)" (#51476)
This reverts commit 59cc3cdf01.
2020-02-26 07:24:18 -08:00
Alexandre Ardhuin
a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00
Zachary Anderson
bc4bd7bd55
[flutter_tools] Don't try to run pub before the version command (#51436) 2020-02-25 17:19:47 -05:00
stuartmorgan
22c807773a
Automatically add plugin projects to Windows .sln (#51246)
Adds utility code for managing list of plugin projects within a solution file, updating them as the plugins change.

This is a prototype of an approach to solution-level portion of Windows plugin tooling; it may not be what the final plugin handling on Windows uses, but it makes things much better in the short term, and gives us a baseline to evaluate other possible solution management systems against.

Part of #32719
2020-02-25 14:16:27 -08:00
Nate Bosch
9228b87eb3
Don't use a default test randomize ordering seed (#51018)
Fixes #51010

The test package differentiates between passing and not passing this
argument. A previous version had a bug that treated passing `0`
identically to not passing the argument, and the flutter test runner
relied on this bug by always passing a value and using a default of `0`.

- Remove the argument defaults throughout to make it clear that `null`
  is a valid value and the default.
- Remove the argument defaulting on the argument parser.
- Update the wording of the usage for this argument, this will also be
  updated on the `package:test` side.
2020-02-25 13:01:40 -08:00
Zachary Anderson
d73dd6b356
[flutter_tools] Rework iOS vmservice handshake failure usage event (#51419) 2020-02-25 15:22:17 -05:00
Christopher Fujino
704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:09:40 -08:00
Jonah Williams
59cc3cdf01
[flutter_tools] initialize frontend server with build (#49405) 2020-02-24 14:21:33 -08:00
Jonah Williams
3411129cc5
[flutter_tools] don't fix chrome window size, add more logs (#51346) 2020-02-24 12:26:05 -08:00
Jonah Williams
7572ec47bd
[flutter_tools] add more search paths for source maps (#51307) 2020-02-24 10:40:08 -08:00
Dan Field
4df8fdb7df
update cache for flutter test/fast command (#51235) 2020-02-22 18:24:03 -08:00
Angjie Li
5ee4147283
Allow developers to run flutter driver web test directly (#51084) 2020-02-22 16:49:03 -08:00
Jonah Williams
bb74a328b5
[flutter_tools] adds etag/cache control header to debug asset server (#51143) 2020-02-21 14:15:54 -08:00
Jonah Williams
25a813110d
[flutter_tools] reload dart_sdk when sources update (#51067) 2020-02-20 12:26:47 -08:00
Alexandre Ardhuin
7d7ac7c32b
start multiline strings with newline (#50825) 2020-02-20 10:16:28 +01:00
Jacob MacDonald
dda7a618ec
add support for the builders configuration for web (#50988) 2020-02-19 19:01:04 -08:00
Jonah Williams
6d0b1ef868
[flutter_tools] include LICENSE files as build dependencies (#50945) 2020-02-19 18:56:04 -08:00
Jenn Magder
85b54d4c0c
Change DeviceManager.getAllConnectedDevices() return value from Stream to List (#51015) 2020-02-19 17:40:24 -08:00
Francisco Magdaleno
6815e72086
Revert "[flutter_tools] move engine unpack to the flutter tool (#50707)" (#51076)
This reverts commit 0a623e879c.
2020-02-19 13:55:48 -08:00
Jonah Williams
0a623e879c
[flutter_tools] move engine unpack to the flutter tool (#50707) 2020-02-19 13:36:04 -08:00
Angjie Li
11549e45a3
Use Async WebDriver for WebFlutterDriver. (#50835) 2020-02-19 13:31:10 -08:00
Martin Kustermann
d2947571bd
Ensure to close connection to VM after collecting coverage (#50943) 2020-02-18 12:39:37 -08:00
Jacob MacDonald
11589ca20d
serve the generated main.dart file so source_maps work for it (#50976) 2020-02-18 12:36:03 -08:00
Jonah Williams
67362ce5e0
[flutter_tools] fix debug stack traces (#50872) 2020-02-18 11:28:02 -08:00
Jonah Williams
57acc68740
[flutter_tools] ensure zoned errors are caught in new web runner (#50895) 2020-02-18 11:27:14 -08:00
Jonah Williams
3bb4ba61bd
[flutter_tools] use uri resolution for asset requests (#50844) 2020-02-14 21:46:03 -08:00
Jonah Williams
238dac141b
Revert "[flutter_tools] More Linux version detail (#50739)" (#50840)
This reverts commit c725f107a1.
2020-02-14 16:10:47 -08:00
Jonah Williams
ea4d969ecc
[flutter_tools] move dwds imports to not require g3 visibility (#50823) 2020-02-14 14:56:03 -08:00
Zachary Anderson
bf32974189
[flutter_tools] Handle asynchronous errors writing to stdio (#50779) 2020-02-14 10:38:02 -08:00
Zachary Anderson
c268b6c3d4
[flutter_tools] Collect more information in ios-handshake failure event (#50804) 2020-02-14 09:40:52 -08:00
Yegor
b34046903b
Fix stack trace parsing on non-debug builds; add e2e tests (#50652)
* Fix stack trace parsing on non-debug builds; add e2e tests
2020-02-13 18:34:08 -08:00
Zachary Anderson
c725f107a1
[flutter_tools] More Linux version detail (#50739) 2020-02-13 14:49:11 -08:00
Jonah Williams
9431229e4c
[flutter_tools] remove globals from depfile usage (#50710) 2020-02-13 13:59:40 -08:00
stuartmorgan
f4177a6dde
Generate a Property Sheet for Windows plugins (#50740)
Generates a Property Sheet for Windows builds containing link and include path
information for any included plugins. This allows automating part of the process
of integrating plugins into the build that is currently manual.

To support this change, refactored msbuild_utils into a PropertySheet class so that
it can be used to make different property sheets.
2020-02-13 12:53:28 -08:00
Jonah Williams
e2554a9202
Add "flutter downgrade" command (#50506) 2020-02-13 11:56:45 -08:00
Jonah Williams
550c82d5d4
[flutter_tools] initialize web stack trace formatter (#50680) 2020-02-13 10:03:02 -08:00
Jonah Williams
d3a41816d1
[flutter_tools] ensure all source maps load correctly for release and profile (#50702) 2020-02-13 10:01:04 -08:00
Zachary Anderson
450fc25c1e
[flutter_tool] Disable analytics on more bots (#50669) 2020-02-13 09:58:03 -08:00
stuartmorgan
7bdd4757ec
Create plugin symlinks for Windows and Linux (#50599)
This makes ephemeral symlinks to each plugin, for use by build systems.
This is similar to the logic implemented in the Podfile on iOS and
macOS, but managed internally to the Flutter tool.

Exploration for addressing #32719 and #32720
Related to #41146
2020-02-12 16:23:27 -08:00
Dan Field
24f8f799da
add an --enable-vmservice flag (#50663) 2020-02-12 14:52:09 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots (#50641) 2020-02-12 10:58:02 -08:00
sjindel-google
3aa72cc2f2
Use ELF for AOT snapshots on Fuchsia. (#50468) 2020-02-12 10:53:04 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#50622)
This reverts commit 0a38f29c0d.
2020-02-11 22:47:41 -08:00
Jenn Magder
7c24ebc79b
Map arm64e devices to arm64 devices (#50612) 2020-02-11 19:43:43 -08:00
Jonah Williams
5406258fc6
[flutter_tools] fix crash when IsolateRef returns sentinel (#50611) 2020-02-11 16:03:45 -08:00
Jenn Magder
bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots (#50579) 2020-02-11 15:48:02 -08:00
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Jenn Magder
e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams
fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Jonah Williams
568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Zachary Anderson
c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal (#50446) 2020-02-10 10:23:35 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
Jenn Magder
4411d8e64e
Update minimum version to Xcode 11.0 (#50371) 2020-02-07 14:35:01 -08:00
Jenn Magder
48a9bd56b1
Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369)
This reverts commit 2b7582ef61.
2020-02-07 13:59:21 -08:00
Jenn Magder
2b7582ef61
Update minimum version to Xcode 11.0 (#50315) 2020-02-07 13:57:24 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Alexandre Ardhuin
5c28e3eeea
unnecessary escapes fixes (#50178)
* unnecessary escapes fixes

* replace some strings with raw strings

* update regexp

* address review comments
2020-02-07 06:35:50 +01:00
David Iglesias
b8199abd15
[flutter_tools] Prevent web ServiceWorker from modifying fetch requests. (#50312) 2020-02-06 18:43:03 -08:00
Jonah Williams
82410a5ae7
[flutter_tools] support iOS and macOS with split-debug-info and tree-shake-icons (#50296) 2020-02-06 18:39:34 -08:00
Harry Terkelsen
0fc1c6f6d7
[flutter_tool] Make the registrant import relative to the entrypoint (#50302) 2020-02-06 17:08:02 -08:00
Jonah Williams
181cdec079
[flutter_tools] remove automatic multiroot scheme (#50284) 2020-02-06 17:05:41 -08:00
Zachary Anderson
6bfff984de
[flutter_tools] Handle AndroidStudio validator crash (#50282) 2020-02-06 16:03:02 -08:00
Levi Lesches
149e06232b
Add option to clear the terminal by pressing "c" (#50034) 2020-02-06 15:53:04 -08:00
Jenn Magder
a9b8d360cf
Remove ideviceinfo, idevice_id artifacts (#50248) 2020-02-06 15:50:26 -08:00
Jenn Magder
2512163ebe
Allow Android to be missing from multi-platform manifest (#50304) 2020-02-06 15:50:03 -08:00
Christopher Fujino
e6e14b0dd2
Have android validator suggest ANDROID_SDK_ROOT instead of deprecated ANDROID_HOME (#49846) 2020-02-06 14:03:03 -08:00
Jonah Williams
db901ce5dd
[flutter_tools] remove dependencies checks that are no longer relevant in assemble-land (#50225) 2020-02-06 13:59:18 -08:00
Jonah Williams
69ecca554d
[flutter_tools] iOS fallback discovery protocol (#49735) 2020-02-06 13:58:03 -08:00
Gityuan
b8dd6bdd19
support endless recorder for timeline (#47419) 2020-02-06 12:33:01 -08:00
Jenn Magder
a0665aba49
Reland Replace ideviceinfo and idevice_id with xcdevice (#50252) 2020-02-06 11:38:47 -08:00
Nate Bosch
8159178238
Remove usages of StackTraceMapper (#50153)
* Remove usages of StackTraceMapper

This class will be replaced with a function type in `test_api`, clean up
usages ahead of time.

In `build_script.dart` the only reference to `StackTraceMapper` is in
the `browser_test.dart` file, but since nothing would call
`setStackTraceMapper` from that import it should be safe to remove the
definition. After reading a serialized mapper from the
`test.browser.mapper` channel, it was ignored.

In `flutter_web_platform.dart` we only were reading from `_mappers`,
never putting values in, so we can remove it entirely. The `load()`
function was never called with a `mapper` argument.
2020-02-06 10:34:50 -08:00
Lau Ching Jun
81525fa1a6
Support downloading font-subset for all platforms (#50240) 2020-02-06 10:33:02 -08:00
Jenn Magder
ce6fbf6668
Revert "Replace ideviceinfo and idevice_id with xcdevice (#49854)" (#50243)
This reverts commit 3aa7a80053.
2020-02-05 18:00:31 -08:00
Emmanuel Garcia
eb4b6dc91b
Retry Gradle command when failing to download a resource (#50223) 2020-02-05 17:48:04 -08:00
Jonah Williams
da4b5d68c4
[flutter_tools] support --split-debug-info option in android builds (#49650) 2020-02-05 17:45:24 -08:00
Jonah Williams
de7908f9e9
[flutter_tools] Reland flutter assemble for iOS (#50229) 2020-02-05 17:44:06 -08:00
Jonah Williams
91c342e213
[flutter_tools] force page refresh when hot restarting in profile/release mode (#50215) 2020-02-05 17:43:05 -08:00
Jenn Magder
3aa7a80053
Replace ideviceinfo and idevice_id with xcdevice (#49854) 2020-02-05 17:37:25 -08:00
Jonah Williams
4d2ce7be2c
Revert "[flutter_tools] Reland migrate xcode_backend.sh to flutter assemble (#50200)" (#50228)
This reverts commit 868b0e6d97.
2020-02-05 15:57:49 -08:00
Jonah Williams
868b0e6d97
[flutter_tools] Reland migrate xcode_backend.sh to flutter assemble (#50200) 2020-02-05 13:04:22 -08:00
Alexandre Ardhuin
94c7e823be
remove unnecessary string escapes (#50096) 2020-02-05 08:00:32 +01:00
Dan Field
4b8efad99b
Font subset in the tool (#49737) 2020-02-04 20:34:24 -08:00
Mehmet Oguz Derin
a4093edbcf
Fix Path Separator in Service Workers (#50154) 2020-02-04 20:18:01 -08:00
Jenn Magder
4485a65e60
Add -destination generic/platform=iOS to "build ios-framework" xcodebuild (#50140) 2020-02-04 18:08:03 -08:00
Zachary Anderson
103b12fc11
[flutter_tools] Isolate userHomePath, other cleanups (#50125) 2020-02-04 18:03:03 -08:00
Jonah Williams
52d5744ea2
Revert "[flutter_tools] Migrate xcode_backend.sh to flutter assemble (#49842)" (#50151)
This reverts commit c2353b2911.
2020-02-04 15:02:55 -08:00
Jonah Williams
64b82f50ad
[flutter_tools][web] serve dummy service_worker and manifest file in run mode (#50115) 2020-02-04 14:19:26 -08:00
Jonah Williams
c2353b2911
[flutter_tools] Migrate xcode_backend.sh to flutter assemble (#49842) 2020-02-04 14:19:08 -08:00
Jenn Magder
d00a39cbdd
Remove dead code IMobileDevice.isWorking (#50084) 2020-02-04 14:18:20 -08:00
Jenn Magder
6e605f3fdc
Run "build ios-framework" processes async (#49657) 2020-02-04 14:17:53 -08:00
Mehmet Fidanboylu
0c5ae7d656
Use the FlutterVersion defined in context (#50040) 2020-02-03 20:43:02 -08:00
Jonah Williams
50eeda2495
[flutter_tools] fix frontend server generated entrypoint (#50036) 2020-02-03 20:38:03 -08:00
Zachary Anderson
ef62d53222
[flutter_tools] Fix crash on null Android apiVersion (#50029) 2020-02-03 14:48:02 -08:00
Jonah Williams
b24bca1383
[flutter_tools] add missing period to end of filter (#50038) 2020-02-03 14:33:08 -08:00
Zachary Anderson
390ed1cd81
[flutter_tools] Move homeDirPath to FileSystemUtils (#49909) 2020-02-03 14:33:03 -08:00
Zachary Anderson
2c51efef29
[flutter_tools] Make Config context-free (#49834) 2020-01-31 12:51:20 -08:00
Prerak Mann
688948b778
switching channel prompts to run flutter upgrade (#49511) 2020-01-31 09:33:29 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Greg Spencer
6ee8b6546b
Revert "Always use new plugin schema for plugin template (#48258)" (#49827)
This reverts commit 9d4a35b because it appears to break

the gradle_non_android_plugin_test.
2020-01-30 12:46:12 -08:00
stuartmorgan
9d4a35ba8b
Always use new plugin schema for plugin template (#48258)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-01-30 11:30:31 -08:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free (#49740) 2020-01-29 17:51:31 -08:00
Jenn Magder
02dc0ab37f
Remove unnecessary BuildableIOSApp from "build ios-framework" (#49659) 2020-01-29 14:27:43 -08:00
Jenn Magder
d85ea51384
Move iMobileDevice to globals (#49724) 2020-01-29 13:51:16 -08:00
Jonah Williams
cb3b7ab487
[flutter_tools] simplify symbol logic for iOS (#49628) 2020-01-29 13:43:23 -08:00
Terry Lucas
1b4d321b34
Fix Flutter tool to use correct adb parameter and collect Realtime value. (#49701)
* Fix parameter to adb to be _package.id instead of package._launchActivity.
2020-01-29 10:01:17 -08:00
Jonah Williams
22fc215260
[flutter_tools] hide assembly gen_snapshot warning (#49662) 2020-01-29 09:06:33 -08:00