Commit Graph

1668 Commits

Author SHA1 Message Date
Jason Simmons
8a84437989
Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (#131371)
Dart SDK 3.2.x requires a new version of the dart_internal package.
2023-07-27 17:33:07 +00:00
Sam Rawlins
aab5747fc4
Ignore unused parameters in snippet code (#131068)
Add `unused_element_parameter` to the codes ignored while analyzing snippets.

Fixes https://github.com/flutter/flutter/issues/131067
2023-07-26 00:07:07 +00:00
Polina Cherkasova
30c005f7f4
Upgrade to newer leak_tracker. (#131085) 2023-07-21 14:26:42 -07:00
stuartmorgan
273441eef2
Use downgraded analyze for flutter/packages (#130878)
Add the `--downgrade` flag to the flutter/packages analyze test, so that it won't get the latest version of dependencies, avoiding out-of-band failures in flutter/flutter due to package publishing events.

Fixes https://github.com/flutter/flutter/issues/129633
2023-07-21 00:14:02 +00:00
flutter-pub-roller-bot
edcaa335d1
Roll pub packages (#130821)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-18 21:55:17 +00:00
Greg Spencer
8b768de18f
Add lint check to make sure samples are linked and have tests (#130523)
## Description

This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.

It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459).

Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.

## Related Issues

- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459

## Tests

- Added test for the checker.
2023-07-18 15:26:09 +00:00
Michael Goderbauer
6f09064e78
Stand-alone widget tree with multiple render trees to enable multi-view rendering (#125003)
This change enables Flutter to generate multiple Scenes to be rendered into separate FlutterViews from a single widget tree. Each Scene is described by a separate render tree, which are all associated with the single widget tree.

This PR implements the framework-side mechanisms to describe the content to be rendered into multiple views. Separate engine-side changes are necessary to provide these views to the framework and to draw the framework-generated Scene into them.

## Summary of changes

The details of this change are described in [flutter.dev/go/multiple-views](https://flutter.dev/go/multiple-views). Below is a high-level summary organized by layers.

### Rendering layer changes

* The `RendererBinding` no longer owns a single `renderView`. In fact, it doesn't OWN any `RenderView`s at all anymore. Instead, it offers an API (`addRenderView`/`removeRenderView`) to add and remove `RenderView`s that then will be MANAGED by the binding. The `RenderView` itself is now owned by a higher-level abstraction (e.g. the `RawView` Element of the widgets layer, see below), who is also in charge of adding it to the binding. When added, the binding will interact with the `RenderView` to produce a frame (e.g. by calling `compositeFrame` on it) and to perform hit tests for incoming pointer events. Multiple `RenderView`s can be added to the binding (typically one per `FlutterView`) to produce multiple Scenes.
* Instead of owning a single `pipelineOwner`, the `RendererBinding` now owns the root of the `PipelineOwner` tree (exposed as `rootPipelineOwner` on the binding). Each `PipelineOwner` in that tree (except for the root) typically manages its own render tree typically rooted in one of the `RenderView`s mentioned in the previous bullet. During frame production, the binding will instruct each `PipelineOwner` of that tree to flush layout, paint, semantics etc. A higher-level abstraction (e.g. the widgets layer, see below) is in charge of adding `PipelineOwner`s to this tree.
* Backwards compatibility: The old `renderView` and `pipelineOwner` properties of the `RendererBinding` are retained, but marked as deprecated. Care has been taken to keep their original behavior for the deprecation period, i.e. if you just call `runApp`, the render tree bootstrapped by this call is rooted in the deprecated `RendererBinding.renderView` and managed by the deprecated `RendererBinding.pipelineOwner`.

### Widgets layer changes

* The `WidgetsBinding` no longer attaches the widget tree to an existing render tree. Instead, it bootstraps a stand-alone widget tree that is not backed by a render tree. For this, `RenderObjectToWidgetAdapter` has been replaced by `RootWidget`.
* Multiple render trees can be bootstrapped and attached to the widget tree with the help of the `View` widget, which internally is backed by a `RawView` widget. Configured with a `FlutterView` to render into, the `RawView` creates a new `PipelineOwner` and a new `RenderView` for the new render tree. It adds the new `RenderView` to the `RendererBinding` and its `PipelineOwner` to the pipeline owner tree.
* The `View` widget can only appear in certain well-defined locations in the widget tree since it bootstraps a new render tree and does not insert a `RenderObject` into an ancestor. However, almost all Elements expect that their children insert `RenderObject`s, otherwise they will not function properly. To produce a good error message when the `View` widget is used in an illegal location, the `debugMustInsertRenderObjectIntoSlot` method has been added to Element, where a child can ask whether a given slot must insert a RenderObject into its ancestor or not. In practice, the `View` widget can be used as a child of the `RootWidget`, inside the `view` slot of the `ViewAnchor` (see below) and inside a `ViewCollection` (see below). In those locations, the `View` widget may be wrapped in other non-RenderObjectWidgets (e.g. InheritedWidgets).
* The new `ViewAnchor` can be used to create a side-view inside a parent `View`. The `child` of the `ViewAnchor` widget renders into the parent `View` as usual, but the `view` slot can take on another `View` widget, which has access to all inherited widgets above the `ViewAnchor`. Metaphorically speaking, the view is anchored to the location of the `ViewAnchor` in the widget tree.
* The new `ViewCollection` widget allows for multiple sibling views as it takes a list of `View`s as children. It can be used in all the places that accept a `View` widget.

## Google3

As of July 5, 2023 this change passed a TAP global presubmit (TGP) in google3: tap/OCL:544707016:BASE:545809771:1688597935864:e43dd651

## Note to reviewers

This change is big (sorry). I suggest focusing the initial review on the changes inside of `packages/flutter` first. The majority of the changes describe above are implemented in (listed in suggested review order):

* `rendering/binding.dart`
* `widgets/binding.dart`
* `widgets/view.dart`
* `widgets/framework.dart`

All other changes included in the PR are basically the fallout of what's implemented in those files. Also note that a lot of the lines added in this PR are documentation and tests.

I am also very happy to walk reviewers through the code in person or via video call, if that is helpful.

I appreciate any feedback.

## Feedback to address before submitting ("TODO")
2023-07-17 16:14:08 +00:00
Polina Cherkasova
5870159ed7
Upgrade leak_tracker. (#130507) 2023-07-13 18:40:50 +00:00
Alexander Aprelev
3b8f6c4020
Upgrade framework pub dependencies, roll engine with rolled dart sdk (#130163)
Manual roll is needed because incoming dart sdk requires updated version
vm_snapshot_analysis (>=0.7.4).


5ae09b8b4f...7c83ea3e85

```
7c83ea3e85 Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (#43457)" (#43472)
9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (#43471)
```

Remove implementation of SuitePlatform from the test as well. Remove use
of fake cwd from SuitePlatform as it can't be properly faked.
2023-07-07 13:55:35 -07:00
Flutter GitHub Bot
ba636881eb
Roll pub packages (#129380)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-06-28 14:07:50 -07:00
pdblasi-google
321abcbe4f
Adds dart_fix support to integration_test (#129579)
* Adds fix for `IntegrationTestWidgetsFlutterBinding.runTest(timeout)` to support first round of deprecations for `flutter_test`

Resolves #124346
2023-06-27 18:01:06 +00:00
Yegor
07772a3d23
[framework,web] add FlutterTimeline and semantics benchmarks that use it (#128366)
## FlutterTimeline

Add a new class `FlutterTimeline` that's a drop-in replacement for `Timeline` from `dart:developer`. In addition to forwarding invocations of `startSync`, `finishSync`, `timeSync`, and `instantSync` to `dart:developer`, provides the following extra methods that make is easy to collect timings for code blocks on a frame-by-frame basis:

* `debugCollect()` - aggregates timings since the last reset, or since the app launched.
* `debugReset()` - forgets all data collected since the previous reset, or since the app launched. This allows clearing data from previous frames so timings can be attributed to the current frame.
* `now` - this was enhanced so that it works on the web by calling `window.performance.now` (in `Timeline` this is a noop in Dart web compilers).
* `collectionEnabled` - a field that controls whether `FlutterTimeline` stores timings in memory. By default this is disabled to avoid unexpected overhead (although the class is designed for minimal and predictable overhead). Specific benchmarks can enable collection to report to Skia Perf.

## Semantics benchmarks

Add `BenchMaterial3Semantics` that benchmarks the cost of semantics when constructing a screen full of Material 3 widgets from nothing. It is expected that semantics will have non-trivial cost in this case, but we should strive to keep it much lower than the rendering cost. This is the case already. This benchmark shows that the cost of semantics is <10%.

Add `BenchMaterial3ScrollSemantics` that benchmarks the cost of scrolling a previously constructed screen full of Material 3 widgets. The expectation should be that semantics will have trivial cost, since we're just shifting some widgets around. As of today, the numbers are not great, with semantics taking >50% of frame time, which is what prompted this PR in the first place. As we optimize this, we want to see this number improve.
2023-06-21 21:37:02 +00:00
William Hesse
6ae22ef4e9
Fix detection that tests are running on monorepo bots (#129173)
Automatic CI testing runs on monorepo bots that tests the heads
of the Dart SDK, Flutter engine, and Flutter framework together.
These tests previously ran on bots called HHH (triple-headed),
and the logic for detecting this used the machine name of the test machine.

Extend that detection logic to cover the test machine hostnames that
run monorepo testing, that start with either 'dart-tests-' or 'luci-dart-'.

None of the machines used to run Flutter release builds have names
like this, even though they are in an internal Dart luci project.

Bug: b/231927187
2023-06-20 17:03:49 +00:00
Mouad Debbar
a162d7546a
flutter update-packages --force-upgrade (#128908)
- Bumps `vm_service` from `11.6.0` to `11.7.1`
- Bumps `web` from `0.1.3-beta` to `0.1.4-beta` and adds it everywhere.
- Moves `js` from `dependencies` to `dev_dependencies`
2023-06-15 18:17:09 +00:00
Mouad Debbar
95be76ab7e
[web] Migrate framework away from dart:html and package:js (#128580)
Use `package:web` and `dart:js_interop` instead.

Part of https://github.com/flutter/flutter/issues/127030
2023-06-14 17:43:39 +00:00
Polina Cherkasova
05d1cde0dd
Address leak tracker breaking changes. (#128623) 2023-06-12 11:11:35 -04:00
LongCatIsLooong
d4733a3fd4
Reduce _DoubleClampVisitor false positives (#128539)
I'm getting a few false positives in https://github.com/flutter/flutter/pull/128522/checks from the `num.clamp` checker since I introduced a class with a `clamp` method.
2023-06-08 22:42:35 +00:00
Jackson Gardner
7c15a26eab
Reland "Migrate benchmarks to package:web" (#128266)
This attempts to reland https://github.com/flutter/flutter/pull/126848

This was reverted because it made some unexpected changes to our perf measurements. After landing https://github.com/flutter/flutter/pull/127900, we have much less noise in our benchmarks, so I'd like to reland this and see if there is still a significant measurement difference.
2023-06-08 22:25:40 +00:00
Janice Collins
29c858adc7
Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (#128442)
This updates dartdoc to 6.3.0.  Release notes are available, here:

https://github.com/dart-lang/dartdoc/releases/tag/v6.3.0

Most important for Flutter are the reduction in the size of generated HTML files (dart-lang/dartdoc#3384) and a new dartdoc directive to hide constant implementations from indicated classes (dart-lang/dartdoc#3398), which fixes the longstanding issue (dart-lang/dartdoc#2657).

I've also added the api documentation zip to `.gitignore` and the `{@hideConstantImplementations}` dartdoc directive to the motivating example.  A screenshot:

![Screenshot 2023-06-07 at 9 54 58 AM](https://github.com/flutter/flutter/assets/14116827/1ad9c1f0-b224-462f-a8e3-706d9858f0d8)

I assert that this change to icons.dart should be test-exempt as existing tests cover whether or not dartdoc directives are recognized or are leaking into HTML, and the impact of adding the directive was tested in dart-lang/dartdoc#3398.
2023-06-08 20:14:23 +00:00
Christopher Fujino
0763d61f56
[flutter_tools] manually roll pub deps (#127447)
Fixes https://github.com/flutter/flutter/issues/127226
2023-05-30 23:34:52 +00:00
Phil Quitslund
5bf6318688
Update collection-fors to prefer final (as per updated prefer_final_in_for_each) (#127511)
The newly updated lint will soon flag for-each in collections.

See discussion: https://github.com/dart-lang/linter/pull/4383

/cc @goderbauer
2023-05-26 23:34:36 +00:00
Greg Spencer
5c0eb2d967
Bump Snippet version (#127688)
## Description

Bumps the version for snippets to the latest version.

## Related Issues
 - https://github.com/flutter/flutter/issues/127320

## Tests
 - No test changes needed.
2023-05-26 19:20:59 +00:00
Brandon DeRosier
982e00527c
Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (#127514)
Rolls engine to head with
[fixes](https://github.com/flutter/flutter/pull/127505) corresponding to
the [latest Dart roll](https://github.com/flutter/engine/pull/42286).
2023-05-24 14:35:23 -07:00
Sigurd Meldgaard
788ceb34a3
Fix style issues (#122586)
Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.
2023-05-16 23:56:21 +00:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint (#126647) 2023-05-16 16:14:23 +00:00
Polina Cherkasova
ea5eddb5a9
Upgrade leak_tracker to 5.0.0 (#126367)
Fixes https://github.com/flutter/flutter/issues/126259

Updated pubspec:
345f0bffbf/packages/flutter/pubspec.yaml
2023-05-16 04:39:26 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements (#126320) 2023-05-15 11:07:30 +02:00
Jason Simmons
6e9c0db206
Manual roll Flutter Engine from ef5c349f04d8 to c784d6d4137d (#126680)
ef5c349f04...c784d6d413

2023-05-12
[skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org)
Roll Dart SDK from 7ad028c26344 to 4028c7d8b87c (8 revisions)
(https://github.com/flutter/engine/pull/41967)

Requires some update for changes to the Dart analyzer

fixes https://github.com/flutter/flutter/issues/126683
2023-05-12 10:41:54 -07:00
Pierre-Louis
65dfb555c0
Update packages (#126140)
In particular, update pin for `material_color_utilities` to `0.5.0`.
2023-05-08 09:51:28 +02:00
Jenn Magder
1861ac470a
Migrate Xcode projects last version checks to Xcode 14.3 (#125827)
1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
2. Update iOS and macOS templates to same.
3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested.  I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
4. Run all example/integration test project to see migrator work.
5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.

Fixes https://github.com/flutter/flutter/issues/125817
See https://github.com/flutter/flutter/pull/90304 for Xcode 13 example.
2023-05-02 00:06:33 +00:00
Flutter GitHub Bot
73a343f191
Roll pub packages (#125698)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 19:30:06 +00:00
Flutter GitHub Bot
888b208d62
Roll pub packages (#125447)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 17:31:45 +00:00
Janice Collins
fb36bba366
Update dartdoc to v6.2.2. (#125650)
This PR updates the dartdoc version to v6.2.2.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2

The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers.  See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402.   This will also be a cherry-pick candidate for 3.1 if it can land in time.

- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].
2023-04-27 22:30:06 +00:00
Flutter GitHub Bot
d85e2fb810
Roll pub packages (#125225)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 18:28:10 +00:00
Flutter GitHub Bot
a573d1aeee
Roll pub packages (#125050)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 17:36:10 +00:00
Flutter GitHub Bot
d300b86e80
Roll pub packages (#124709)
Roll pub packages
2023-04-13 20:54:52 +00:00
pdblasi-google
6839b3cbd6
Adds dart_fix support to flutter_test (#124347)
Adds `dart_fix` support to `flutter_test`
2023-04-11 21:09:07 +00:00
Flutter GitHub Bot
cc4b455521
Roll pub packages (#124364)
Roll pub packages
2023-04-07 17:19:24 +00:00
Ian Hickson
806c1f8186
Deprecate these old APIs (#116793)
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Christopher Fujino
b2c65acd5a
[flutter_tools] Remove --no-sound-null-safety #4 (#124039)
Re-land of https://github.com/flutter/flutter/pull/123297 without any of
the commits at the end attempting to fix customer-testing.

Fixes https://github.com/flutter/flutter/issues/118810
2023-04-04 15:25:27 -07:00
godofredoc
50f7910e80
Do not use colors in output if running from CI. (#122645)
Do not use colors in output if running from CI.
2023-04-04 18:41:47 +00:00
Flutter GitHub Bot
0046a25e39
Roll pub packages (#123899)
Roll pub packages
2023-04-03 16:56:56 +00:00
Casey Hillers
6fe54f8811
Revert "[flutter_tools] Remove --no-sound-null-safety #3" (#123969)
Revert "[flutter_tools] Remove --no-sound-null-safety #3"
2023-04-03 00:19:22 +00:00
Danny Tuppeny
a5fc8b2bd4
Roll pub packages (#123854)
Roll pub packages
2023-03-31 16:41:18 +00:00
Danny Tuppeny
d163620f1f
Prevent bots/analyze.dart crashing on circular dependencies (#123802)
Prevent bots/analyze.dart crashing on circular dependencies
2023-03-30 21:01:06 +00:00
Michael Goderbauer
42f61b32c5
Check cc files (#123704)
Check cc files
2023-03-29 18:40:58 +00:00
Christopher Fujino
820ec70a8d
[flutter_tools] Remove --no-sound-null-safety #3 (#123297)
[flutter_tools] Remove --no-sound-null-safety #3
2023-03-29 17:56:23 +00:00
Janice Collins
726b7202a0
Update dartdoc to 6.2.1. (#123420)
Update dartdoc to 6.2.1.
2023-03-24 19:50:57 +00:00
Harry Terkelsen
40bfb701dd
Add smoke test for gstatic resources (#123270) 2023-03-24 11:32:47 -07:00
Harry Terkelsen
4e58370cbf
Use Web resources CDN in service_worker_test by default (#123360) 2023-03-23 17:00:20 -07:00
Flutter GitHub Bot
7b7af9f34c
roll packages (#123339)
Roll pub packages
2023-03-23 19:03:57 +00:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag (#123031)" (#123280)
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
2023-03-22 22:53:49 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks (#123259)
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Michael Goderbauer
3f87e808f8
Update dartdoc to 6.2.0 (#123193)
Update dartdoc to 6.2.0
2023-03-22 17:06:25 +00:00
Michael Goderbauer
25e38a2a87
Bump lower Dart SDK constraints to 3.0 & add class modifiers (#122546)
Bump lower Dart SDK constraints to 3.0 & add class modifiers
2023-03-21 20:21:58 +00:00
Christopher Fujino
6b7c60d69a
manual pub roll (#123071)
manual pub roll
2023-03-21 01:08:51 +00:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909)" (#123031)
[flutter_tools] Remove sound null safety flag #2
2023-03-20 22:32:07 +00:00
Ian Hickson
db5711bfad
remove obsolete todo in doubleClamp lint (#122745)
remove obsolete todo in doubleClamp lint
2023-03-17 20:55:51 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909)
This reverts commit 7c3088cf22.
2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag (#120936)
[flutter_tools] Remove sound null safety flag
2023-03-17 17:48:35 +00:00
Sigurd Meldgaard
1fd84f88e9
Always use user-level pub cache (#121802)
Use the pub cache resolved by pub itself.
To add packages to the flutter.zip download they are packaged as tar.gz and added to the pub-cache on first run by using  `pub cache preload`.
2023-03-13 08:38:17 +01:00
Yegor
91dea4d1a6
[web] delete unhelpful image loading e2e test (#122059)
[web] delete unhelpful image loading e2e test
2023-03-07 00:11:46 +00:00
Flutter GitHub Bot
0d9a0207ad
roll packages (#121746)
Roll pub packages
2023-03-03 01:38:03 +00:00
Flutter GitHub Bot
d48aef0e27
roll packages (#121675)
Roll pub packages
2023-03-01 19:02:30 +00:00
keyonghan
f028f97e8c
update doc (#113778)
Update recipes doc with correct parameters
2023-03-01 01:21:56 +00:00
Flutter GitHub Bot
61a03f7907
roll packages (#121611)
Roll pub packages
2023-02-28 17:44:15 +00:00
Nabeel Parkar
e5a382ec92
Migrate activation issue template to Github form issues (#119916)
Migrate activation issue template to Github form issues
2023-02-28 08:08:01 +00:00
Flutter GitHub Bot
2c3fa08253
roll packages (#121556)
Roll pub packages
2023-02-28 00:11:26 +00:00
Flutter GitHub Bot
5d36cb77fb
roll packages (#121358) 2023-02-23 20:20:25 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Flutter GitHub Bot
8080becadf
roll packages (#120951) 2023-02-23 19:21:53 +00:00
Ricardo Amador
d816e72f07
Do not swallow the error from the licenses acceptance (#121243) 2023-02-22 08:55:08 -08:00
stuartmorgan
c564007f94
Switch analysis to flutter/packages (#120908)
In preparation for the merge of flutter/plugins into flutter/packaegs,
update the cross-repo analysis to flutter/packages rather than
flutter/plugins.

The flutter_plugins.version file is left intentionally for now to avoid
issues with the roller; it will be removed when the roller has been
updated to roll the other repository.
2023-02-21 14:26:08 -05:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) (#120842)
* lerp documentation

* Remove Note, Note That from repo

* Improve BorderSide documentation.

* apply review comments
2023-02-17 22:27:33 +00:00
Flutter GitHub Bot
206c6ae992
roll packages (#120922) 2023-02-16 23:53:16 +00:00
Flutter GitHub Bot
b9b4d3e43e
roll packages (#120628) 2023-02-14 17:33:48 +00:00
Flutter GitHub Bot
d63c54c9c2
roll packages (#120493) 2023-02-10 23:11:53 +00:00
Greg Price
98b3e48ed4
Fix hang on successful dev/bots/analyze.dart (#117660)
Fixes #117659

It turns out this was due to the output-suppression timer introduced
recently as part of cleaning up the output (#109206); on success, the
script would wait 10 minutes for the timeout to expire.  This didn't
affect CI because this feature doesn't apply in CI (as detected by
lack of color on stdout.)

Fix the issue by cleaning up the timer on success in the same way
as on failure.

While here, clean up the final summary messages slightly,
and also cut the trailing space that printProgress was leaving
on each line.
2023-02-08 00:04:23 +00:00
Christopher Fujino
1089588863
un-pin package:intl (#119900) 2023-02-07 12:10:18 -08:00
Flutter GitHub Bot
cfdc35859e
roll packages (#119865) 2023-02-02 23:59:49 +00:00
Christopher Fujino
d820aec786
Manual pub roll with dwds fix (#119575)
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Jesús S Guerrero
d63987f71d
Parser machine logs (#118707)
* remove file reporter optional

* decouple stack trace from metric collections

* update tests; add collect metrics option

* add failed tests property

* add test for multiple stack failed

* change path on result

* create factory method

* throw exception when test file failed to generate

* remove catch of file exception

* handle when no stacktrace on file reporter
2023-02-02 20:04:06 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. (#119587) 2023-02-01 23:57:54 +00:00
Flutter GitHub Bot
df8ad3d2cb
roll packages (#119370) 2023-01-30 17:34:10 +00:00
Danny Tuppeny
0b57596712
Run "flutter update-packages --force-upgrade" (#119340) 2023-01-27 17:20:18 +00:00
yaakovschectman
455e6aca50
Test integration test apps' runner files against current template app (#118646)
* Create template file test

* Add to .ci.yaml

* Add to TESTOWNERS

* Organize test script

* Push license to top of file

* Equals sign

* Utilize path.join

* Expand error message

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Fix missing newline string

* Move template file test to analyze.dart

* Fix newline

* Var name

* Fix extension length

* Use ignore-list for filenames

* Update dev/bots/analyze.dart

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Indentation

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-01-24 17:00:22 -05:00
Christopher Fujino
64b4c69bcc
roll pub deps and remove archive, crypto, typed_data from allow-list (#119018)
* roll pub deps and remove archive, crypto, typed_data from allow-list

* un-comment code
2023-01-24 01:55:06 +00:00
Michael Goderbauer
c757df3bfa
Remove unnecessary null checks in dev/bots (#118846) 2023-01-21 01:39:19 +00:00
David Landeros
c5ceff11dd
[flutter_tools] Ensure service worker starts caching assets since first load (#116833)
* [Flutter_tools] Ensure service worker starts caching assets since the first launch

* [flutter_tools] add comment to give some context on self.clients.claim()

* [flutter_tools] add comment to give some context on self.clients.claim()
2023-01-19 21:52:52 +00:00
Danny Tuppeny
06909ccfa4
Update packages + fix tests for javascript mime change (#118617)
Update test expectations from application/javascript -> text/javascript

`package:mime` now uses `text/javascript` and not `application/javascript`.

See https://github.com/dart-lang/mime/pull/76.
See https://datatracker.ietf.org/doc/html/rfc9239.

> This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is `text/javascript`; all others are considered historical and obsolete aliases of `text/javascript`.
2023-01-19 09:54:40 -05:00
Jonah Williams
1d2e62b764
remove unsound mode web test (#118256) 2023-01-10 19:03:27 +00:00
Flutter GitHub Bot
341ae18f6e
roll packages (#118001) 2023-01-04 22:49:16 +00:00
Flutter GitHub Bot
fe1271f898
roll packages (#117940) 2023-01-04 21:18:30 +00:00
Kenzie Davisson
725c1415df
Fix screenshot testing for flutter web integration_test (#117114)
* Fix screenshot testing for flutter web integration_test

* update packages

* fix method signature and todo

* Run tests on CI

* fix type

* remove silences

* Add docs

* fix comment

* fix whitespace

* review comments
2022-12-22 21:34:04 +00:00
alanwutang11
1970bc919b
cacheWidth cacheHeight support for canvaskit on web (#117423)
* cacheWidth cacheHeight support for web canvaskit

* comments

* clarifying comment for loadTestImageProvider class

Co-authored-by: alanwutang11 <alpwu@google.com>
2022-12-21 21:06:06 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Michael Goderbauer
fdd2d7d64a
Sync analysis_options.yaml & cleanups (#117327) 2022-12-20 14:15:39 -08:00
Flutter GitHub Bot
4591f057fb
roll packages (#117357) 2022-12-20 22:04:23 +00:00
Zachary Anderson
c64dcbefa6
Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)
This reverts commit 61fb6ea2d5.
2022-12-20 09:04:05 -08:00
Siva
61fb6ea2d5
Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372) 2022-12-20 08:31:22 -08:00
Michael Goderbauer
1adc27503f
Bump min SDK to 2.19.0-0 (#117345)
* Bump min SDK to 2.19.0-0

* fix
2022-12-20 00:46:14 +00:00
alanwutang11
c0dddacb81
Fix is canvas kit bool (#116944)
* isCanvasKit implement and test

* isCanvasKit implement and test

* ++

* forgot license

* make isCanvasKit a getter

* addressed comments

* forgot to change names of integration test files

* typo

* simplified tests

* comments
2022-12-17 23:33:32 -08:00
Drew Roen
0604a0e1e6
Add a recursive flag to the zip command - currently it is zipping nothing (#117227) 2022-12-16 21:15:20 +00:00
Alexander Markov
c63d797f94
Upgrade dependencies (#117007) 2022-12-14 13:13:05 -08:00
Greg Spencer
96597c25e6
Bump Dartdoc version to 6.1.5 (#117014) 2022-12-13 22:28:01 +00:00
Christopher Fujino
7a743c8816
[flutter_tools] Pin and roll pub (#116745)
* pin path_provider_android

* make path_provider_android non-transitive

* roll
2022-12-12 21:02:07 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. (#116061) 2022-12-11 22:43:22 +00:00
Jason Simmons
b4304dadc5
Update the Dart language version in the pubspec generated by the dartdoc script (#116789) 2022-12-09 11:38:20 -08:00
Siva
48cfe2eb00
Opt dashing_postprocess.dart out of null safety until we figure out why (#116786)
it complains about some library being unsound.
2022-12-09 10:53:39 -08:00
Parker Lougheed
eefbe85c8b
Bump dartdoc to 6.1.4 (#116758) 2022-12-09 04:32:07 +00:00
Siva
7c8e171320
Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 (#116635)
* Roll Flutter Engine from 67254d6e4b03 to 8d83b98c55b3

* Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (#38105)

* Bump SDK versions.

* Bump Dart SDK version constraints

* Update shrine package to 2.0.1 (null safe version)

* Fix more tests.

* Include patches from Jason for min android sdk version

* Fix analyzer warning
2022-12-08 18:03:51 -08:00
Parker Lougheed
76f03359b1
Update dartdoc to 6.1.3 (#116474)
No longer generates weird constructor-like calls interspersed.

Fixes https://github.com/dart-lang/dartdoc/issues/3201
2022-12-06 21:10:10 +00:00
godofredoc
cd87e094e9
Allow creating packages for master/main. (#116557)
This is to enable testing of the packaging scripts on master/main
branches.

Bug: https://github.com/flutter/flutter/issues/115489
2022-12-06 19:46:07 +00:00
godofredoc
c3e5612362
Zip api docs using the repo under test script. (#116437)
This is to move more logic to the repo under test and remove them from
recipes.

Bug: https://github.com/flutter/flutter/issues/115489
2022-12-02 22:46:07 +00:00
Zachary Anderson
7c0f882a92
Revert "[flutter_tools] Pin path_provider_android and roll pub packages (#116377)" (#116424)
This reverts commit ce94230281.
2022-12-02 08:30:14 -08:00
Christopher Fujino
ce94230281
[flutter_tools] Pin path_provider_android and roll pub packages (#116377)
* pin path_provider_android

* remove constraint that only explicit dependencies can be pinned

* roll packages
2022-12-02 03:13:07 +00:00
godofredoc
61376de9b8
Generate local metadata even when not publishing. (#116087)
* Generate local metadata even when not publishing.

For SLSA compliance we need to separate the fetch, compile and upload
steps of release artifacts. Translating this to the packaging workflows
the fetch step will checkout the prepare_package script at main ToT, the
compile step generate the bundle archives and the recipes will upload
the artifact bundles as part of the upload stage.

This change adds functionality to generate both the release bundle and
the updated metadata file in a way that both files can be uploaded as
part of the upload stage.

Bug: https://github.com/flutter/flutter/issues/115487

* Address comments.

* Update tests.
2022-11-29 04:14:24 +00:00
Christopher Fujino
dfdec8984f
[flutter_tools] Remove package:image (#115848)
* remove ciyaml targets

* remove screenshot_test and package:image

* update-packages

* remove TESTOWNERS entries
2022-11-22 21:49:57 +00:00
Christopher Fujino
459391708e
[flutter_tools] Pin package:archive and manual roll (#115662)
* add package:archive to pins

* roll
2022-11-18 19:28:10 +00:00
Devon Carew
0344407614
Rev package:pub_semver to the latest version (#115570)
* rev package:pub_semver to the latest version

* revert update_packages.dart changes
2022-11-17 18:29:37 +00:00
Jim Graham
92f10ed712
match error statements without relying on volatile human-readable descriptions (#114922)
* match error statements without relying on volatile human readable descriptions

* simplify String list map call
2022-11-09 01:57:52 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
godofredoc
0186b1496b
Fix the path where footer is written. (#114469)
The footer file was being written in dev/bot instead of dev/docs.

Bug: https://github.com/flutter/flutter/issues/113805
2022-11-03 18:15:07 +00:00
Flutter GitHub Bot
ef1236e038
Roll pub packages (#114189) 2022-10-28 19:15:08 +00:00
Jesús S Guerrero
0fe29f5857
Raise an exception when invalid subshard name (#113222) 2022-10-25 17:41:44 +00:00
Flutter GitHub Bot
1ebe53c209
Roll pub packages (#113799) 2022-10-21 16:38:18 +00:00
David Iglesias
883469229e
[web] Use TrustedTypes in flutter.js and other tools (#112969) 2022-10-21 16:03:51 +00:00
pdblasi-google
782baecc50
Resolve 113705: Separated longer running tests from runMisc to prevent flakiness from timeouts (#113784) 2022-10-21 16:02:14 +00:00
Flutter GitHub Bot
37af038303
Roll pub packages (#113574) 2022-10-20 21:39:12 +00:00
Kevin Moore
38ef9410b4
dev/bots/prepare_packages: cleanup (#113717) 2022-10-19 19:13:12 +00:00
Casey Hillers
97e018d8b3
[docs] Refresh dev/bots/README.md (#113464) 2022-10-19 17:36:02 +00:00
Flutter GitHub Bot
d20129b64a
Roll pub packages (#113331) 2022-10-17 22:03:08 +00:00
Casey Hillers
f26dd3730d
[packaging] Run git gc to minimize .git disk footprint (#113467) 2022-10-17 15:43:31 +00:00
Casey Hillers
bc70ae0f57
[packaging] Remove dev references (#113462) 2022-10-17 13:45:19 +00:00
Flutter GitHub Bot
a454c6d03b
Roll pub packages (#112986) 2022-10-06 21:18:08 +00:00
Jesús S Guerrero
8fd46ceeac
Collect metrics - load balancing tests (#108752) 2022-09-30 19:53:35 +00:00
Kevin Moore
38a5571e91
Rev dartdoc to 6.1.2 (#112664) 2022-09-29 20:55:30 +00:00
joshualitt
c66049fcef
Reland "Migrate package/flutter to JS static interop. (#111315)" (#112418) 2022-09-29 08:36:51 -07:00
Jesús S Guerrero
45584b2528
Web subsharding (#112505) 2022-09-28 19:23:35 +00:00
Flutter GitHub Bot
2adee31ce8
Roll pub packages (#112408) 2022-09-26 21:21:58 +00:00
godofredoc
8fbd87065a
Add a script to post-process docs. (#112228) 2022-09-23 18:19:19 +00:00
Casey Hillers
4aa27d844e
Revert "Migrate package/flutter to JS static interop. (#111315)" (#112247) 2022-09-23 04:00:22 +00:00
Flutter GitHub Bot
a24b50ba8f
Roll pub packages (#112225) 2022-09-22 21:18:22 +00:00
Flutter GitHub Bot
f16fe11ecf
Roll pub packages (#112021) 2022-09-22 20:23:42 +00:00
Flutter GitHub Bot
d5946021e5
Roll pub packages (#112004) 2022-09-20 22:07:57 +00:00
joshualitt
6906493a94
Migrate package/flutter to JS static interop. (#111315) 2022-09-19 10:28:37 -07:00
Viren Khatri
e2ab3e581e
fixed inconsistent file names for *_chip.dart files and added a test (#111364) 2022-09-17 03:17:06 +00:00
Dan Field
d905fbab0d
Rev dartdoc to 6.1.1 (#111767) 2022-09-16 20:35:49 +00:00
Flutter GitHub Bot
9ba35816ca
Roll pub packages (#111423) 2022-09-12 23:03:50 +00:00
Jonah Williams
cd83477457
[framework] work around to load self packages from packages/ (#111350) 2022-09-12 18:30:00 +00:00
Christopher Fujino
2e299e1934
[flutter_tools] Pin url_launcher_android and update packages (#111309) 2022-09-09 23:57:03 +00:00
Sigurd Meldgaard
d80e994a62
Reland: Show output from pub get in flutter pub get (#110851) 2022-09-08 15:13:23 +02:00
Elliott Brooks (she/her)
57e42f0223
Manually update DWDS version to v.16.0.0 (#110822) 2022-09-02 19:17:48 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces (#110758) 2022-09-02 04:00:58 +00:00
Zachary Anderson
0e195e9d46
Revert "Show output from pub get in flutter pub get (#106300)" (#110478)
This reverts commit 3802eb627e.
2022-08-29 08:02:50 -07:00
Sigurd Meldgaard
3802eb627e
Show output from pub get in flutter pub get (#106300) 2022-08-29 07:37:19 +00:00
Yegor
6e57ed6088
[web] fix hot restart in entrypoint generated by flutter create (#110229) 2022-08-25 20:30:00 +00:00
Christopher Fujino
db51e5d944
[flutter_tools] unpin path_provider_android and roll (#110216) 2022-08-25 19:42:21 +00:00
Alexander Aprelev
bfdc9a6cfa
Introduce stubbed exclusive parameter to File.create-overridden method (#109646)
* Introduce stubbed `exclusive` parameter to `File.create`-overridden method.

This is to soften landing of a breaking change https://github.com/dart-lang/sdk/issues/49647
2022-08-17 13:26:08 -07:00
Ian Hickson
97901da149
Cleaner test.dart output. (#109206) 2022-08-14 08:53:54 +00:00
Christopher Fujino
b79c216845
[flutter_tools] Pin path_provider_android (#109429) 2022-08-12 01:18:41 +00:00
Christopher Fujino
675f67d611
Revert "Roll pub packages (#109408)" (#109424)
This reverts commit da036da69f.
2022-08-11 16:29:05 -07:00
Flutter GitHub Bot
da036da69f
Roll pub packages (#109408) 2022-08-11 20:53:11 +00:00
Greg Spencer
e3b42e5e2f
Revert "Roll pub packages (#109348)" (#109363)
Committing to green the build.
2022-08-10 19:15:18 -07:00
Flutter GitHub Bot
5a06e2bd5f
Roll pub packages (#109348) 2022-08-10 22:40:38 +00:00
Ian Hickson
7ded3d91da
API documentation cleanup (#108500) 2022-08-10 22:03:20 +00:00
Ian Hickson
03aa059c3c
Do not abort at first error when tests fail. (#108936) 2022-08-05 16:18:54 -07:00
Pierre-Louis
de8a2fa6a7
Update packages (#109054)
In particular, to get `material_color_utilities` `0.2.0`.
2022-08-05 15:21:03 -04:00
Flutter GitHub Bot
7270c48bd7
Roll pub packages (#108919) 2022-08-03 21:30:05 +00:00
David Iglesias
04f7ea8459
[web] Add onEntrypointLoaded to FlutterLoader. (#108776) 2022-08-03 20:58:06 +00:00
Flutter GitHub Bot
d9ce9be0e2
Roll pub packages (#108582) 2022-07-29 19:07:04 +00:00
Michael Goderbauer
10a7c9ba22
Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
Greg Spencer
07de84f014
Add StarBorder and StarBorder.polygon, with example. (#108489) 2022-07-28 00:01:05 +00:00
Flutter GitHub Bot
f82178e2d2
Roll pub packages (#108325) 2022-07-27 17:22:07 +00:00
Michael Goderbauer
8a7b35933c
flutter update-packages --force-upgrade + analyzer fix (#108198) 2022-07-25 10:10:31 -07:00
Yegor
e505529344
[web] define $flutterDriverResult variable early in driver test initalization (#107337) 2022-07-23 00:48:06 +00:00
Flutter GitHub Bot
94572b5d69
Roll pub packages (#107984) 2022-07-22 23:28:06 +00:00
Alexandre Ardhuin
ccd33631e3
enable combinators_ordering (#107847) 2022-07-18 22:04:07 +00:00
Alexandre Ardhuin
93a74ca9f2
remove unused members in executable libs (#107464) 2022-07-12 21:41:08 +00:00
Flutter GitHub Bot
255fa2d152
Roll pub packages (#107258) 2022-07-07 21:58:06 +00:00
Flutter GitHub Bot
b748d1fb1a
Roll pub packages (#107185) 2022-07-07 17:46:07 +00:00
Michael Goderbauer
49a52ae8d1
Bump dartdoc to 6.0.0 (#107194) 2022-07-06 23:24:08 +00:00
Christopher Fujino
19ac08dcd7
manual pub package roll; remove test_api pin, unblock bumping dwds (#106887) 2022-07-06 17:28:07 +00:00
stuartmorgan
6c6ae06381
Add Windows to the platform_channels example (#106754) 2022-06-30 14:54:07 +00:00
Christopher Fujino
aac5e95ae5
[flutter_tools] refactor packages_autoroller.dart script (#106580) 2022-06-27 14:09:10 -07:00
Christopher Fujino
a30012b275
Add update packages roller (#100982) 2022-06-22 17:04:07 -07:00
Jonah Williams
1572773729
Update package:archive and pin test_api (#106157) 2022-06-16 21:23:08 -07:00
David Iglesias
b1b1ee9ca6
[web] Fix JS crash when FF blocks service workers. (#106072) 2022-06-17 02:22:07 +00:00
Christopher Fujino
6671503789
add an ignore to analyze snippet code (#106079) 2022-06-16 01:36:08 +00:00
Jonah Williams
92034482f9
[flutter_tool] partial null safety migration of tool source code (#105798) 2022-06-15 20:02:07 +00:00
Darren Austin
d9be807192
Updated the analyze.dart deprecation check to only look for beta branch versions. (#105290) 2022-06-06 21:16:49 -07:00
Elliott Brooks (she/her)
67a18250b1
Update packages with update-packages (#105325) 2022-06-06 10:49:39 -07:00
Danny Tuppeny
c5b5abe1d2
Update dependencies with 'flutter update-packages --force-upgrade' (#105009) 2022-06-01 11:33:11 -07:00
Anna Gringauze
5cd979e441
Retry getting tabs in chrome launcher on ConnectionException (#104218) 2022-05-26 15:20:11 -07:00
Dacian Florea
680bc17cde
[web] [fix] Cache resource data only if the fetching succeed (#103816) 2022-05-24 16:23:06 -07:00
Casey Hillers
a79233cbba
[packaging] Move chromium mirror to flutter mirror (#104222) 2022-05-20 22:03:06 -07:00
Michael Goderbauer
28d817e708
Bump dartdoc to 5.1.2 (#104097) 2022-05-18 17:57:13 -07:00
gaaclarke
64a0c19652
switched to a double variant of clamp to avoid boxing (#103559) 2022-05-18 13:26:08 -07:00
Chris Bracken
27c6cdb416
Roll dependendencies (#103771)
Roll dependendencies

This rolls depdendencies to latest using
flutter update-packages --force-upgrade

This change includes three code changes:

* Removes charcode from the dependencies allowlist since it no longer
  appears in the transitive closure of dependencies of the flutter,
  flutter_test, flutter_driver, flutter_localizations, and
  integration_test packages.

* Uses Resolver.create instead of the deprecated Resolver constructor.
  The default Resolver constructor has been deprecated in favour of the
  static Resolver.create() factory function, which unfortunately happens
  to be async. Propagated the async-ness up the chain.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

* Eliminates the use of the deprecated packagesPath parameter to
  HitMap.parseJson. This parameter was deprecated and replaced with
  packagePath in https://github.com/dart-lang/coverage/pull/370 which
  was part of the overall deprecation of the .packages file in Dart
  itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
  being that end-user code shouldn't need to know about implementation
  details such as whether dependency information is stored in a
  .packages file or a package_info.json file, but rather use the
  package_config package to obtain the package metadata and perform
  other functions such as resolving its dependencies to filesystem
  paths. packagesPath was replaced by packagePath, which takes the path
  to the package directory itself. Internally, package:coverage then
  uses package_config to do the rest of the package/script URI
  resolution to filesystem paths.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

This is a pre-update prior to updating flutter_template_images in
https://github.com/flutter/flutter/pull/103739

Issue: https://github.com/flutter/flutter/issues/103371
Issue: https://github.com/flutter/flutter/issues/103775
Issue: https://github.com/flutter/flutter/issues/103830

When re-applying the partially-reverted changes to code coverage,
we'll need to patch host_entrypoint.dart internally to await the Future
that we'll be returning rather than a non-async value.
2022-05-14 16:34:10 -07:00
Chris Bracken
110c0a7f80
[ci] Add pointer to template image assets wiki (#103787)
Many of our flutter_tools templates include image assets such as
application icons. Adding these will trigger an analysis error from our
CI tooling.

This adds a pointer to the wiki describing the procedure for adding or
updating image assets in the templates:
https://github.com/flutter/flutter/wiki/Managing-template-image-assets

Uncovered while working on https://github.com/flutter/flutter/issues/103371
2022-05-14 10:28:59 -07:00
Michael Goderbauer
0a5a641f8f
Bump snippets tool to 0.3.0 (#103751) 2022-05-13 14:49:26 -07:00
Michael Goderbauer
8bec125aaf
Avoid analyzing API example code twice, clean-up (#103548) 2022-05-11 21:27:45 -07:00
David Iglesias
1af8cc1183
[tools][web] Make Plugin Registrant file ephemeral. (#102185) 2022-05-11 17:54:11 -07:00
Jonah Williams
c1b909e3fc
add image load benchmark (#103459) 2022-05-10 22:49:08 -07:00
Christopher Fujino
e8c01a8aa8
[flutter_tools] pub roll (#103220)
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2022-05-10 10:26:54 -07:00
Greg Spencer
6504f2896c
Adds menuBarMenuLabel, and removes unneeded key localizations (#102100)
When I added localizations for shortcut keys, I added some that actually can't be shortcut keys, so I'm removing them again. These are mostly Japanese-specific keys that don't even appear on modern keyboards for the most part.

Also, added menuBarMenuLabel for an accessibility label for menu bar menus.

I modified the code for the localization generation scripts to add a --remove-undefined flag that will remove any localizations that don't appear in the canonical locale.
2022-05-09 09:25:52 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() (#103226) 2022-05-06 16:04:13 -07:00
Zachary Anderson
577919dbfe
Don't hardcode ink sparkle spir-v (#102674) 2022-05-04 09:28:45 -07:00
Phil Quitslund
80849adee1
[dev, bots, examples] rename local functions with _s (#102703) 2022-04-28 10:44:06 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Christopher Fujino
41b73894bc
Test framework for executable files (#101853) 2022-04-13 22:44:07 -07:00
Christopher Fujino
fd5356ff60
[flutter_tools] shard out two integration tests we want to run on macOS arm64 (#101769) 2022-04-13 12:09:11 -07:00
Michael Goderbauer
fe6d09a9ef
Bump Dartdoc to 5.0.1 (#101783) 2022-04-13 09:31:19 -07:00
David Iglesias
bee95b6984
[flutter.js] Wait for reg.update, then activate sw (if not active yet). (#101464) 2022-04-11 19:04:08 -07:00
Michael Goderbauer
fa48aed7b2
Bump dwds to 13.1.0 (#101730) 2022-04-11 18:29:14 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
Anna Gringauze
74944d528f
Run update-packages (#101450)
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
2022-04-07 17:07:05 -07:00
Jenn Magder
68471bbb74
Remove --enable-web and --enable-windows-desktop from tests (#101208) 2022-04-07 15:57:09 -07:00
Jenn Magder
bc0ec85717
Only run test harness tests once instead of every shard (#101218) 2022-04-04 17:27:18 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters (#100516) 2022-03-29 12:52:42 -07:00
Christopher Fujino
ef8e3578c1
[flutter_tools] update pub packages (#100726) 2022-03-25 16:45:09 -07:00
Michael Goderbauer
8560d914eb
Upgrade to flutter_lints 2.0 (#99881) 2022-03-22 11:00:23 -07:00
godofredoc
875c552c54
Allow different versions of the architecture. (#100345)
If there was a release entry for the same platform and hash the new
entries were filtered out even if the architecture was different.
2022-03-17 21:24:16 -07:00
Greg Spencer
3f7ca7e576
Increase the timeout for running the snippets script during sample analysis (#100093)
Engine roll is blocked because the analysis script has been timing out trying to run the snippets tool, but only on Cirrus bots. This changes the timeout to 5 minutes from 30 seconds.
2022-03-14 16:45:30 -07:00
nicolasvac
201a64c98f
Fix flutter web app not respecting assets path when in non-root folder (#96774) 2022-03-10 15:50:16 -08:00
Ben Konyi
1880066dd3
Update dependencies (#99874) 2022-03-10 14:13:59 -07:00
Christopher Fujino
09c7eb1b88
fix type error in service_worker_test.dart (#99524) 2022-03-04 11:56:17 -08:00
Jason Simmons
504e669200
Update an analyzer test to support changes to error message text in the latest Dart SDK (#99281)
See https://github.com/flutter/flutter/issues/99248
2022-02-28 10:16:40 -08:00
Jenn Magder
d1265ad308
Run update-packages (#99038) 2022-02-25 12:26:16 -08:00
Jonah Williams
0a9a43b99a
Use flutter pub instead of dart pub (#99159) 2022-02-25 11:31:23 -08:00
Jonah Williams
83a88058d6
use dart pub deps to analyze consumer dependencies (#99079) 2022-02-24 19:26:27 -08:00
Greg Spencer
c7643cf54e
Fix samples so that they present properly in the docs (#97224) 2022-02-24 18:51:22 -08:00
Jenn Magder
0eae276e68
Remove cli_utils from allow-list (#99037) 2022-02-23 18:54:23 -08:00
Ben Konyi
50c4720913
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc (#98513) 2022-02-18 12:32:08 -08:00
Christopher Fujino
87fe3fe031
rename two unit tests that were not actually being run on CI (#98299) 2022-02-14 17:40:13 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Harry Terkelsen
03f1d37935
Add a benchmark for a scrolling list of Links (#94638) 2022-02-03 14:38:58 -08:00
Daco Harkes
54f674c23a
Migrate bots/test.dart from pub run to dart run (#97575) 2022-02-02 14:40:15 -08:00
Zachary Anderson
219bcd329e
Include Dart SDK arch in package info (#97278) 2022-02-02 09:02:02 -08:00
Pierre-Louis
a22cf5d6b9
Update packages (#97592)
* update packages

* implement

* remove trailing spaces

* Revert "remove trailing spaces"

This reverts commit d3bffbef57.

* Revert "implement"

This reverts commit 6b6172a827.
2022-02-02 09:16:05 +01:00
stuartmorgan
22c63a11a8
Add a note about depot_tools to the led step (#96830) 2022-01-24 13:15:22 -08:00
Dan Field
ffba5c425c
Print a more helpful error if DDS is enabled when running integration_test and enableTimeline is called (#92509) 2022-01-19 17:50:18 -08:00
Jonah Williams
e25e1f9037
[framework] dont null assert in _debugVerifyIllFatedPopulation (#96551) 2022-01-14 13:50:29 -08:00
Emmanuel Garcia
f01556ab75
Bump Android dependencies that rely on Jcenter (#96558)
* Bump video_player in flutter gallery

* Update packages

* Update dependencies

* Bump device_info

* Update dev/devicelab/bin/tasks/build_ios_framework_module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Remove deprecated device_info from ios-frameworks test

Co-authored-by: Jenn Magder <magder@google.com>
2022-01-12 20:13:32 -08:00
Ian Hickson
2835c3f116
Consider the FLUTTER_TOOL_ARGS as part of the compilation stamp (#94951) 2022-01-10 15:20:05 -08:00
Jenn Magder
3e6e996f9e
Run update-packages --force-upgrade (#96325) 2022-01-10 13:55:16 -08:00
Greg Spencer
e76ad85e01
Output Dart SDK version in published metadata (#96302) 2022-01-07 16:30:14 -08:00
Greg Spencer
3750beacb4
Update platform shims in dev/manual_tests (#94616)
Updates the platform shims in dev/manual_tests so that Windows and Linux can be built. I had to update the Windows shims, because I was unable to build a Windows app there.

Also updates the analyze.dart script to report all license issues simultaneously instead of just dying after the first failure.

The only substantive code changes are in dev/bots/analyze.dart and dev/bots/test/analyze_test.dart
2022-01-07 12:16:24 -08:00
Darren Austin
78f53bed51
Script to generate widget theme data defaults from the Material token database. (#95370) 2022-01-06 11:15:20 -08:00
Paul Berry
f3a389c40f
Respect --dart-sdk parameter when running analyze.dart tests. (#95174) 2021-12-15 13:39:16 -08:00
Dan Field
bf60291493
Improve sync*/async* opt outs (#95286) 2021-12-14 19:00:52 -08:00
Rami
1a3dc1b32a
Update color scheme seed generation to use color utils package (#95175)
* Update color scheme seed generation to use color utils package
2021-12-14 13:53:36 -08:00
Jonah Williams
fda4094767
[framework] dont allocate forgotten children set in profile/release mode (#94911) 2021-12-14 10:51:30 -08:00
Dan Field
ab0a335973
Ban sync*/async* from user facing code (#95050) 2021-12-12 13:05:03 -08:00
Ian Hickson
cd239599e7
Attempt to mitigate flakiness around devtools (#94879) 2021-12-10 14:54:17 -08:00
Ian Hickson
840e109e07
Improve tracing (#93086) 2021-12-10 10:09:24 -08:00
sigmundch
896c63eaed
[test] log stack trace on errors, to improve diagnostics on #89243 (#94885) 2021-12-09 11:54:16 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Michael Thomsen
bb906b6b4f
Roll packages to pick up new platform package (#94603) 2021-12-06 10:34:56 +01:00
Darren Austin
418cd95661
Added material_color_utilities as a dependency for flutter package. (#94377) 2021-12-01 14:19:04 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Kevin Moore
d1cd614338
dev: Drop domain verification file (#94124) 2021-11-23 16:03:02 -08:00
Ian Hickson
bde9f11831
Add a test to verify that we only link to real issue templates (#93528) 2021-11-19 13:13:05 -08:00
sigmundch
f51d3d7e0c
[Web] Detect when running under Dart HHH Web and skip tests under investigation (#93692) 2021-11-18 22:33:04 -08:00
gaaclarke
f23e515861
Fatten up multiple_flutters memory footprint (#93350)
Increased the memory size of multiple_flutters to help identify regressions in performance

This is not a regression and will affect benchmark's readings.
2021-11-12 11:11:44 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output (#92031) 2021-11-10 16:13:04 -08:00
Zachary Anderson
366648ae90
Revert "Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535)" (#93323)
This reverts commit bfe9c59831.
2021-11-09 08:44:56 -08:00
Greg Spencer
bfe9c59831
Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535) 2021-11-08 21:28:02 -08:00
Yegor
5a123f9710
[web] exclude bitrotten context_menu_action_test.dart from CanvasKit shard (#93268) 2021-11-08 11:21:58 -08:00
Jacob MacDonald
a4fa2affe9
Update packages (#92924) 2021-11-05 12:03:03 -07:00
Greg Spencer
5883a6628d
Differentiate between TalkBack versions for semantics tests. (#92602)
Makes the android_semantics_testing test not fail for newer versions of Talkback.

Also, since the test now depends on pub_semver, upgraded the pubspec files.

The only substantive changes in the PR are in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
2021-10-29 16:38:09 -07:00
Casey Hillers
9d263866e4
[release_dashboard] Remove project (#92516) 2021-10-28 09:13:04 -07:00
Janice Collins
b98ed1b39d
Update dartdoc to 4.1.0. (#92446) 2021-10-26 09:03:02 -07:00
Yegor
ad7727a21c
[web] enable CanvasKit tests using a local bundle fetched from CIPD (#92134) 2021-10-21 11:13:18 -07:00
Zachary Anderson
b412f6fff8
Revert "Update outdated runners in the benchmarks folder (#91126)" (#92106)
This reverts commit 31e3364771.
2021-10-19 10:35:15 -07:00
Greg Spencer
31e3364771
Update outdated runners in the benchmarks folder (#91126)
This change updates the platform runners in the benchmarks subdir.

I've attempted to replace the entire group with new code as if the project were recreated with flutter create so that they don't become a Frankenstein of minor changes to make it work again, but just plain old generated code that can be replaced and updated in place.
2021-10-19 08:27:29 -07:00
Ian Hickson
299d484903
Enable more lints (#91642) 2021-10-14 22:03:03 -07:00
Danny Tuppeny
f8f96a4f80
Run "flutter update-packages --force-upgrade" to get latest DDS (#91736) 2021-10-13 10:58:04 -07:00
Ian Hickson
bb5cbdc635
Enable depend_on_referenced_packages lint (#91653) 2021-10-12 11:28:02 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Clement Skau
64841f6309
Adds analyze_sample_code exit for when pub fails (#91024) 2021-10-05 10:28:04 -07:00
Janice Collins
35fe52cb86
Update dartdoc to 4.0.0 (#91252) 2021-10-04 14:08:04 -07:00
Greg Spencer
983cbb273b
Add example test, update example READMEs (#91130) 2021-10-04 13:53:02 -07:00
Greg Spencer
7b8a3c1bcd
Force building of snippets package executable. (#91110)
This fixes an issue with the Dart Head-Head-Head CI bot, where it was seeing failures because of concurrent execution of the snippets tool.

It adds a single run of the snippets tool right after activation to force the compiling of the package executable, which is what has trouble with concurrent invocation.

This is a temporary measure until dart pub global run is fixed.
2021-10-04 12:17:27 -07:00
Greg Spencer
fd9ce27748
Clean up examples, remove section markers and --template args (#91133)
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.

I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.

I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
2021-10-04 12:16:17 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Christopher Fujino
7fbfb1fad9
update consumer dependencies signature (#91116) 2021-10-01 13:32:47 -07:00
Ian Hickson
4315cdcf76
Some test cleanup for flutter_tools. (#90227) 2021-10-01 10:38:02 -07:00
Christopher Fujino
afd84ad425
flutter update-packages (#90994) 2021-09-30 11:38:02 -07:00
Kenzie (Schmoll) Davisson
5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Daco Harkes
2e663b2472
[bots] Print more on --verbose analyze_sample_code (#90880) 2021-09-28 11:08:05 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Daco Harkes
67fdf937c3
[bots] verbose logs when analyzing samples (#90447) 2021-09-27 12:38:07 -07:00
Christopher Fujino
69ae50310b
[flutter_conductor] implement UI scaffold (#90621) 2021-09-24 15:30:09 -07:00
Janice Collins
2d909fcc5b
Update dartdoc to v3.1.0. (#90415) 2021-09-24 14:03:07 -07:00
Jason Simmons
518bea67fd
Update the analysis options for sample code to ignore unnecessary_imports (#90391)
See https://github.com/flutter/flutter/issues/74381
2021-09-20 09:44:58 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00