Commit Graph

7723 Commits

Author SHA1 Message Date
Siva
b0b2c0077a
Turn support for sync-async on in Flutter. (#16543)
* Turn support for sync-async on in Flutter. With this feature
execution of async functions starts immediately instead of it
being delayed by one microtask tick.

* Address review comments.

* Adjust some stack trace expectations which are slightly different with
--sync-async turned on.
2018-04-16 08:44:38 -07:00
Greg Spencer
6c049ec286
Rename AnimatedChildSwitcher to AnimatedSwitcher (#16551)
We don't really like the name AnimatedChildSwitcher, and we think that AnimatedSwitcher might be better (since the Child part is redundant). We also considered AnimatedChild, AnimatedTransition and AnimatedReplacement (among others).

Nothing in here besides a rename.
2018-04-15 19:24:49 -07:00
Alexander Aprelev
ea30c95dc9
Report RpcException error thrown by _reloadSource vmservice rpc. (#16417)
* Don't return null, just rethrow RpcException error when vmservice responds with error.
2018-04-13 17:02:14 -07:00
Hans Muller
fb0ab99d6f
Remove Number.tryParse() straggler (#16570) 2018-04-13 11:15:33 -07:00
Hans Muller
e7154bee1a
Remove the rest of the uses of Number.tryParse() (#16568) 2018-04-13 09:39:01 -07:00
Ian Hickson
1c3f6a851f
Fix formatting of Flex error message (#16498) 2018-04-12 21:16:39 -07:00
Hans Muller
0260642fc5
Revert some uses of Number.tryParse() (#16546)
Revert some uses of Number.tryParse(), ignore deprecation warnings for Number.parse()
2018-04-12 19:16:44 -07:00
Konstantin Scheglov
2c183f235f
Build once in FlutterTesterDevice. (#16457) 2018-04-12 19:01:55 -07:00
Alexander Aprelev
e0cd42e4ad Roll engine to 76cb311d9c33720dcd19274228b39ecdbad8d9af (with rolled dart) (#16518)
* Handle error count reported by frontend.

Extend compilation result from single string to a structure(string filename and integer error count).

* Use ?.

* Include engine roll with dart sdk roll.

* parse(onError) -> tryParse

* Make '?? throw' more readable and avoid issue with analyzer

* Fix test so it mocks compiler output including errors count
2018-04-12 16:28:01 -07:00
Greg Spencer
c73b8a7cf6
Fix a bug in the AnimatedChildSwitcher, add builders. (#16250)
This fixes a rendering problem in the AnimatedChildSwitcher where it would add a new "previous" child each time it rebuilt, and if you did it fast enough, all of them would disappear from the page.

It also expands the API for AnimatedChildSwitcher to allow you to specify your own transition and/or layout builder for the transition.

Fixes #16226
2018-04-12 16:17:26 -07:00
Greg Spencer
7a78741920
Revert "Changing the slider thumb size." (#16541)
This reverts commit 6494ab23f6.
2018-04-12 16:11:43 -07:00
Devon Carew
a561722b2b
fix a test flake on appveyor (#16479)
* fix a test flake on appveyor

* only catch FileSystemExceptions
2018-04-12 15:07:51 -07:00
Siva
dbddcf26b5
Turn off unused changes report during hot reload (#16520)
* A new UI is being designed to make the unused reload messaging clearer,
the UI will use the coverage data to highlight lines in the UI that were not executed during a reload.

In lieu of that we are turning off the unused reload messages experiment.

There were some issues in Dart2 also with this functionality
- source fingerprinting is not implemented in Dart2
- some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out.
2018-04-12 14:24:10 -07:00
Greg Spencer
5129d8ffa6
Rename Rail to Track, per UX guideline (#16519) 2018-04-12 12:32:30 -07:00
Greg Spencer
4dbbf67887
Adding ChipTheme, ChipThemeData, and some more tests. (#16447)
This converts the chips to use a ChipThemeData to get most of their customization values from (if not overridden by specific arguments to the chip constructors), and to have the base ThemeData contain one of these. It also adds the ChipTheme widget that will allow overriding the theme for a particular subtree in the widget hierarchy.

Added tests for both, and just more tests in general for the Chips.
2018-04-12 11:13:42 -07:00
Greg Spencer
c31706f996
Changing the slider thumb size. (#16515)
The spec changed the size of the slider thumb, so this just effects that change.
2018-04-12 10:22:41 -07:00
Chris Bracken
337d6df73d
Pass verbose flag to Xcode subcommands (#16483)
When flutter builds are run with --verbose, pass the flag through to
flutter sub-commands run via xcode_backend.sh.
2018-04-12 09:30:50 -07:00
Sarah Zakarias
4443e4d4cf
Cleanup FLX related code (#16416) 2018-04-12 10:12:26 +02:00
Mikkel Nygaard Ravn
1ba4336494
Require Cocoapods 1.5.0 (#16443) 2018-04-12 06:23:14 +02:00
Alexander Aprelev
da9e1a4aca
Introduce fingerprint check for preview-dart-2 build flx. (#16484)
* Introduce fingerprint check for preview-dart-2 build flx.

* Don't count outputs into fingerpint. Refactor compilation code.
2018-04-11 20:50:25 -07:00
Chris Bracken
b4d57553c8
Simplify script snapshotting code (#16478)
Inlines the very small amount of work being done in _build() into
buildScriptSnapshot(). Eliminates a duplicate (and un-awaited) call to
_writeFingerprint.
2018-04-11 16:53:32 -07:00
Devon Carew
071485258f
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)" (#16482)
This reverts commit 2f41ea546f.
2018-04-11 16:49:38 -07:00
Devon Carew
2f41ea546f
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-04-11 14:50:36 -07:00
Alexander Aprelev
4c221231c9
Sync .packages file as a normal input file. (#16467)
* Sync .packages file as regular file.

Currently .packages file is treated specially as DevFSStringContent to accommodate package-file rewrite when it is sent to the device for dart1 compilation. In dart2 we need to treat .packages as regular file because from frontend perspective it's just a normal input file.
2018-04-11 14:48:14 -07:00
Xiao Yu
3923ccf655 Revert 9749bea7b9. Accidentally pushed to flutter instead of fork repo for PR.
This reverts commit 9749bea7b9.
2018-04-11 13:54:06 -07:00
Xiao Yu
9749bea7b9 Remove the initial xcodebuild clean step which seems unnecessary 2018-04-11 13:52:04 -07:00
Michael Goderbauer
49a3adc1ac
AutomaticKeepAlive now keeps alive (#16445)
Fixes https://github.com/flutter/flutter/issues/16346.

See https://github.com/flutter/flutter/issues/16346#issuecomment-380255095 for detailed explanation of what was going wrong before this fix.
2018-04-11 10:31:47 -07:00
Konstantin Scheglov
cf500bf6cd
Integration test for FlutterTesterDevice. (#16424) 2018-04-11 08:52:17 -07:00
Alexander Aprelev
a2951a9a1f Roll engine to ed303c628fe4b322529f8cf01ecb38135a2bab73 (dart roll)
Changes since last roll:
```
ed303c628 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (#4966)
8cd272733 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)" (#4965)
9199b40f2 Revert "Support multiple shells in a single process. (#4932)" (#4964)
6baff4c82 Support multiple shells in a single process. (#4932)
31c5bb427 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)
c8e4c6984 Avoid copying the contents of large platform message responses (#4947)
5ff527295 Update to use new vulkan GrBackendRenderTarget ctor. (#4962)
0c8993a1a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (#4963)
132ebdda8 Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)" (#4961)
11882ab9e Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)
```

Add consts
2018-04-10 20:17:06 -07:00
Ian Hickson
497b9deb2a
Some cleanup of Chips that I found while learning the code. (#16249) 2018-04-10 16:43:57 -07:00
Todd Volkert
f408bb06f9
Update dependencies (#16442) 2018-04-10 14:27:53 -07:00
Jason Simmons
c3ce892c9e
Add support for locale-specific text styles (#16430)
See https://github.com/flutter/flutter/issues/12630 and
https://github.com/flutter/flutter/issues/16408
2018-04-10 13:41:51 -07:00
Greg Spencer
c43134a71c
Fixes a problem with the height of the chip label (#16420)
There was a bug in the size calculation for the height of the chip label, where it would force the label to be larger than it wanted to be, causing text to not be vertically centered.
2018-04-10 12:02:52 -07:00
Jonah Williams
fbfaffe1db
Do not add run spacing if there are no run metrics (#16290)
* do not add run spacing if there are no run metrics
2018-04-10 09:38:00 -07:00
Konstantin Scheglov
38970f5f75
Add a new Device backed by flutter_tester. (#16405) 2018-04-10 09:37:16 -07:00
Alexandre Ardhuin
498f1fcc23
fix missing function call (#16382) 2018-04-10 09:17:40 +02:00
Chris Bracken
4576f56624
Run iOS gen_snapshot as x86_64 arch (#16323)
We are about to begin building gen_snapshot as a multi-arch binary,
which when run as x86_64 will generate arm64 AOT output, and when run as
i386 will generate armv7 AOT output.

Currently, gen_snapshot is an x86_64 binary, so this change is
effectively preventative in nature, and is a no-op with the current
snapshotter.
2018-04-09 19:12:05 -07:00
Alexander Markov
3499fa23e3 Roll engine to eea6197a24256fe588e18127f56c733bc42b6a8d (before Dart roll)
* Update text_style_test
2018-04-09 18:52:23 -07:00
Ian Hickson
44fbf7463b
Minor code cleanup (#16237) 2018-04-09 16:33:47 -07:00
Victor Choueiri
da4e06bbca Update template .gitignore rules (#15382)
* Update template .gitignore rules

* Remove old packages rule

* Remove IDE folders from gitignore templates

* Prefer ios.tmpl/.gitignore
2018-04-09 15:02:24 -07:00
Roberto Scaramuzzi
cdc68a73e6 Update text_form_field.dart (#15843)
* Update text_form_field.dart

* Update text_form_field_test.dart

* Update text_form_field_test.dart

* Update text_form_field_test.dart
2018-04-09 13:43:43 -07:00
Sam Rawlins
2329cb7ec8 Bump mockito to 3.0.0-alpha+3 (#16306)
* Bump mockito to 3.0.0-alpha+3

* Type annotation
2018-04-09 12:43:31 -07:00
Jacob Richman
660408edd6
Switch to the new Matrix4.tryInvert method to avoid throwing and catching (#15771) exceptions while performing hit testing. 2018-04-09 10:32:22 -07:00
Todd Volkert
d9a3ced9db
Check whether we can run sdkmanager in AndroidWorkflow.licensesAccepted (#16343)
Fixes https://github.com/flutter/flutter/issues/16332
2018-04-09 08:57:11 -07:00
Konstantin Scheglov
d121cbc80d
Make IntelliJPlugins tests use MemoryFileSystem. (#16341) 2018-04-08 09:46:11 -07:00
xster
bdc06194fb
Prompt a solution message when flutter tools network fail in China (#16244) 2018-04-06 18:44:05 -07:00
Zachary Anderson
d6d874474b
[fuchsia] Fixes for Fuchsia hot reload (#16317) 2018-04-06 13:23:16 -07:00
Jonah Williams
037a4aef16
Un(less)conditionally schedule first callback frame when creating ticker (#16261)
* always schedule first frame when creating ticker, regardless of phase or frame
2018-04-06 13:09:07 -07:00
Todd Volkert
06ed3622a3
Roll engine to d2b69fec751d6d11f62019c863b2cba4ce575bfe (#16307) 2018-04-06 10:09:16 -07:00
David Shuckerow
cb3df70da6
Spelling (#16210) 2018-04-06 10:00:06 -07:00